effective_test_bot 0.5.10 → 0.5.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d50c75e5319b53cbe8c1e2961a84e9869d33618f
-  data.tar.gz: 54f357016f40060d93dbda71279950c48949f1a4
+  metadata.gz: e716315d415bfb20ba64a443552660e343a2de2e
+  data.tar.gz: 42ffbf4212b65bcd964affd294ca9fb5d8eb37ae
 SHA512:
-  metadata.gz: 5dbbb1b750b858eeec2e2a44e28ba0b64865200e7d2712d65ba97fc656dc634f56c46166034580755b39bf7c556e7eb1ddc07c3367abd95046549f126d71c249
-  data.tar.gz: 41ae170c048e453be9192bf90a307ea5b55e972341d968800775a5db3bcbd604449efe14504ea44678c5e05096c41d3b31869f3d503802d1dac7f53c2aeb1ab6
+  metadata.gz: 15909967a589dbfde8b12a5e7f7075d8433bb4c92833e603438835f8961f96bd3b09889e565aa1eda32cc56fff65bdfe98ae708cbdd8f22306d03d22fb9a7a1d
+  data.tar.gz: f269d0c2095a982c2a4549dfa212b7669f010d61e0611aa6ab3c172b63ce6cc1ee85c427cc6e2238ca9de4af97700d8a78a87e5e08d846b6ee817e8474a42630

data/README.md

@@ -107,6 +107,7 @@ The following assertions are added for use in any integration test:
 - `assert_assigns_errors` use after an intentionally invalid form submit to make sure your assigned rails object has errors, or a specific error.
 - `assert_no_assigns_errors` should be used after any form submit to make sure your assigned rails object has no errors.  Prints out any errors if they exist.
 - `assert_current_path(path)` asserts the current page path.
+- `assert_email(action)` asserts an email with the given action name was sent. Also supports `assert_email(to: email)` type syntax with to, from, subject, body.
 - `assert_flash`, optionally with the desired `:success`, `:error` key and/or message, makes sure the flash is set.
 - `assert_jquery_ujs_disable_with` makes sure all `input[type=submit]` elements on the page have the `data-disable-with` property set.
 - `assert_no_exceptions` checks for any exceptions in the last page request and gives a stacktrace if there was.

data/app/helpers/effective_test_bot_mailer_helper.rb

@@ -0,0 +1,8 @@
+module EffectiveTestBotMailerHelper
+  # This is included to ActionMailer::Base an after_filter
+  # And allows the assert_email assertion to work
+  def assign_test_bot_mailer_info
+    message.instance_variable_set(:@mailer_class, self.class)
+    message.instance_variable_set(:@mailer_action, action_name)
+  end
+end

data/lib/effective_test_bot/engine.rb

@@ -51,9 +51,23 @@ module EffectiveTestBot
       end
     end
 
+    initializer 'effective_test_bot.email_logger' do |app|
+      if Rails.env.test?
+        ActiveSupport.on_load :action_mailer do
+          ActionMailer::Base.send :include, ::EffectiveTestBotMailerHelper
+
+          if ActionMailer::Base.respond_to?(:after_action)
+            ActionMailer::Base.send :after_action, :assign_test_bot_mailer_info
+          else
+            ActionMailer::Base.send :after_filter, :assign_test_bot_mailer_info
+          end
+        end
+      end
+    end
+
     initializer 'effective_test_bot.assign_assign_headers' do
-      ActiveSupport.on_load :action_controller do
-        if Rails.env.test?
+      if Rails.env.test?
+        ActiveSupport.on_load :action_controller do
           ActionController::Base.send :include, ::EffectiveTestBotControllerHelper
 
           if ActionController::Base.respond_to?(:before_action)

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.5.10'.freeze
+  VERSION = '0.5.11'.freeze
 end

data/lib/generators/effective_test_bot/install_generator.rb

@@ -13,22 +13,6 @@ module EffectiveTestBot
         run 'bundle exec rails generate minitest:install'
       end
 
-      def explain_overwrite
-        puts '[effective_test_bot] Successfully installed/detected: minitest'
-        puts ""
-        puts 'Starting effective_test_bot specific installation tasks:'
-        puts ""
-        puts "You will be prompted to overwrite the default minitest configuration"
-        puts "files with those packaged inside the effective_test_bot gem."
-        puts ""
-        puts "If you have very specific existing minitest configuration,"
-        puts "you should ensure it's under version control so you can revert if needed"
-        puts ""
-        puts "Otherwise, press 'Y' to all the following prompts to automatically configure"
-        puts "minitest-rails and capybara-webkit based effective_test_bot test coverage"
-        puts ""
-      end
-
       def copy_initializer
         template "effective_test_bot.rb", "config/initializers/effective_test_bot.rb"
       end

data/lib/generators/templates/test_helper.rb

@@ -49,9 +49,10 @@ Capybara::Webkit.configure { |config| config.allow_unknown_urls }
 
 Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new
 
-# These two lines are needed as of minitest-reporters 1.1.2
+# These three lines are needed as of minitest-reporters 1.1.2
 Rails.backtrace_cleaner.remove_silencers!
 Rails.backtrace_cleaner.add_silencer { |line| line =~ /minitest/ }
+Rails.backtrace_cleaner.add_silencer { |line| line =~ /effective_test_bot/ }
 
 ###############################################
 ### Effective Test Bot specific stuff below ###

data/test/support/effective_test_bot_assertions.rb

@@ -161,4 +161,37 @@ module EffectiveTestBotAssertions
     assert errors.present?, message || "(assigns_errors) Expected @#{key}.errors to be present"
   end
 
+  # assert_email :new_user_sign_up
+  # assert_email :new_user_sign_up, to: 'newuser@example.com'
+  # assert_email from: 'admin@example.com'
+  def assert_email(action = nil, to: nil, from: nil, subject: nil, body: nil, message: nil)
+
+    if (action || to || from || subject || body).nil?
+      assert ActionMailer::Base.deliveries.present?, message || "(assert_email) Expected email to have been delivered"
+      return
+    end
+
+    ActionMailer::Base.deliveries.each do |message|
+      matches = true
+
+      matches &&= (message.instance_variable_get(:@mailer_action) == action.to_s) if action
+      matches &&= (Array(message.to).include?(to)) if to
+      matches &&= (Array(message.from).include?(from)) if from
+      matches &&= (message.subject == subject) if subject
+      matches &&= (message.body == body) if body
+
+      return if matches
+    end
+
+    expected = [
+      ("action: #{action}" if action),
+      ("to: #{to}" if to),
+      ("from: {from}" if from),
+      ("subject: #{subject}" if subject),
+      ("body: #{body}" if body),
+    ].compact.to_sentence
+
+    assert false, message || "(assert_email) Expected email with #{expected} to have been delivered"
+  end
+
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -253,7 +253,7 @@ module EffectiveTestBotFormFiller
     elsif fill_value.present?
       fill_values = Array(fill_value)  # Allow an array of fill values to be passed
       (fill_values.include?(field['value']) || fill_values.include?(field.find(:xpath, '..').text))
-    elsif field['required'].present?
+    elsif field['required'].nil? == false
       true
     elsif field['value'] == 'true'
       true
@@ -333,11 +333,30 @@ module EffectiveTestBotFormFiller
   def upload_effective_asset(field, file)
     uid = field['id']
 
-    begin
-      field.set(file)
-    rescue Capybara::Webkit::ClickFailed
-      puts "file upload failed to click #{uid}"
-      return
+    # In some apps, capybara can field.set(file) and it will will just work
+    # Sometimes we need to fallback to javascript to get a file uploaded
+    unless ((field.set(file) || true) rescue false)
+      files = Array(file)
+      uid = field['id']
+
+      js = "fileList = Array();"
+
+      files.each_with_index do |file, i|
+        # Generate a fake input selector
+        page.execute_script("if($('#effectiveAssetsPlaceholder#{i}').length == 0) {effectiveAssetsPlaceholder#{i} = window.$('<input/>').attr({id: 'effectiveAssetsPlaceholder#{i}', type: 'file'}).appendTo('body'); }")
+
+        # Attach file to the fake input selector through Capybara
+        page.document.attach_file("effectiveAssetsPlaceholder#{i}", files[i])
+
+        # Build up the fake js event
+        js = "#{js} fileList.push(effectiveAssetsPlaceholder#{i}.get(0).files[0]);"
+      end
+
+      # Trigger the fake drop event
+      page.execute_script("#{js} e = $.Event('drop'); e.originalEvent = {dataTransfer : { files : fileList } }; $('#s3_#{uid}').trigger(e);")
+
+      # Remove the file inputs we created
+      page.execute_script("$('input[id^=effectiveAssetsPlaceholder]').remove();")
     end
 
     # Wait till the Uploader bar goes away

data/test/support/effective_test_bot_login_helper.rb

@@ -13,6 +13,7 @@ module EffectiveTestBotLoginHelper
       login_as(User.find_by_email!(user))
     elsif user.kind_of?(User)
       raise 'user must be persisted' unless user.persisted?
+      user.reload
       login_as(user)
     elsif user == false
       true # Do nothing
@@ -39,11 +40,11 @@ module EffectiveTestBotLoginHelper
     end
   end
 
-  def sign_up(email = Faker::Internet.email, password = Faker::Internet.password)
+  def sign_up(email: Faker::Internet.email, password: Faker::Internet.password, **options)
     visit new_user_registration_path
 
     within('form#new_user') do
-      fill_form(email: email, password: password, password_confirmation: password)
+      fill_form({email: email, password: password, password_confirmation: password}.merge(options))
       submit_novalidate_form
     end
 

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -4,6 +4,12 @@ module EffectiveTestBotScreenshotsHelper
   include Magick
 
   # Creates a screenshot based on the current test and the order in this test.
+  def debug_test_bot_screenshot
+    filepath = "#{current_test_temp_path}/#{current_test_screenshot_id}.png"
+    page.save_screenshot(filepath)
+    puts filepath
+  end
+
   def save_test_bot_screenshot
     return unless EffectiveTestBot.screenshots?
     page.save_screenshot("#{current_test_temp_path}/#{current_test_screenshot_id}.png")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.5.10
+  version: 0.5.11
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-23 00:00:00.000000000 Z
+date: 2016-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -246,6 +246,7 @@ files:
 - README.md
 - Rakefile
 - app/helpers/effective_test_bot_controller_helper.rb
+- app/helpers/effective_test_bot_mailer_helper.rb
 - lib/effective_test_bot.rb
 - lib/effective_test_bot/engine.rb
 - lib/effective_test_bot/middleware.rb
@@ -299,7 +300,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: A shared library of rails model & capybara-based feature tests that should