effective_test_bot 0.4.5 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6ab5a8dbd613806a632a7d26883287d92b076ad0
-  data.tar.gz: 282a10e85908184563c4b2b344ee2fc007dbf41a
+  metadata.gz: 0b7f79228e53f919d49e05e1c4664c154e8852f1
+  data.tar.gz: 23d86e7bffe2f127072aa2a27254e2420305526d
 SHA512:
-  metadata.gz: 13b966c0c1b0b1222f1d44df755a029a4217781b4eacfa57334882bc9d3ab51b021b8e2b572a9087be3612549fdcda9c3c3c6801a39fd869ef4e97e68d6ab2a3
-  data.tar.gz: 92e89261d74ec87d44177c121c80952a993595b486ba27cf0f9784f8a1647c2cd531e6f61a4801d61a3ef2a4be0a9c93b87f85eb183be8c526439f03dfb0f0be
+  metadata.gz: 001cada50f2fe9ad01c38607d7a42ac40176cb69dc09897e5874c50819c9e28ef51bdda5759455db13e722219dec2a13db1f6ee4d8dd75cdf5ef36c98ac49496
+  data.tar.gz: e0639c6e7c1a233ac3e98dab49290814cffe7d8668173d683bc2a64c04ecb63264377510ad92bd3c630de6c72b75958ad123286b4ef7fecf8127bb972d6013c2

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.4.5'.freeze
+  VERSION = '0.4.6'.freeze
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -33,6 +33,7 @@ module EffectiveTestBotFormFiller
       tab.click()
       synchronize!
       save_test_bot_screenshot
+      @shared_max_fields = nil # Reset value_for_input_numeric_field() history
 
       within('div' + tab['href']) { fill_form_fields(fills) }
     end
@@ -116,6 +117,8 @@ module EffectiveTestBotFormFiller
         else
           Faker::Date.backward(365).strftime('%Y-%m-%d %H:%m')
         end
+      elsif classes.include?('numeric')
+        value_for_input_numeric_field(field, "input.numeric[name$='[#{attribute}]']")
       elsif classes.include?('email') || attribute.include?('email')
         Faker::Internet.email
       elsif classes.include?('price') # effective_form_inputs price
@@ -156,10 +159,7 @@ module EffectiveTestBotFormFiller
 
       field.all('option:enabled').select { |option| option.value.present? }.sample.try(:text) || '' # Don't select an empty option
     when 'input_number'
-      min = (Float(field['min']) rescue 1)
-      max = (Float(field['max']) rescue 1000)
-      number = Random.new.rand(min..max)
-      number.kind_of?(Float) ? number.round(2) : number
+      value_for_input_numeric_field(field, "input[type='number'][name$='[#{attribute}]']")
     when 'input_email'
       Faker::Internet.email
     when 'input_password'
@@ -181,6 +181,35 @@ module EffectiveTestBotFormFiller
     end
   end
 
+  def value_for_input_numeric_field(field, selector)
+    min = (Float(field['min']) rescue 0)
+    max = (Float(field['max']) rescue 1000)
+    number = Random.new.rand(min..max)
+    number = (number.kind_of?(Float) ? number.round(2) : number)
+
+    return number if field['max'].blank?
+
+    shared_max_fields = all(selector)
+    return number if shared_max_fields.length <= 1
+
+    # So there's definitely 2+ fields that share the same max, named the same
+    # We want the total value of all these fields to add upto the max single max value
+    @shared_max_fields ||= {}
+    @shared_max_fields[selector] ||= max
+
+    available = @shared_max_fields[selector]
+
+    amount = if max.kind_of?(Float)
+      (((max * 1000.0) / shared_max_fields.length.to_f).ceil() / 1000.0).round(2)
+    else
+      (max / shared_max_fields.length.to_f).ceil
+    end
+    amount = [[amount, min].max, available].min
+
+    @shared_max_fields[selector] = (available - amount)
+    amount
+  end
+
   # The field here is going to be the %input{:type => file}. Files can be one or more pathnames
   # http://stackoverflow.com/questions/5188240/using-selenium-to-imitate-dragging-a-file-onto-an-upload-element/11203629#11203629
   def upload_effective_asset(field, files)

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -7,7 +7,7 @@ module EffectiveTestBotScreenshotsHelper
   def save_test_bot_screenshot
     return unless EffectiveTestBot.screenshots? && defined?(current_test)
 
-    full_path = current_test_temp_path + '/' + "#{current_test_screenshot_id}.png"
+    full_path = current_test_temp_path + "/#{current_test_screenshot_id}.png"
     page.save_screenshot(full_path)
   end
 
@@ -101,11 +101,11 @@ module EffectiveTestBotScreenshotsHelper
   # current_test_failure_path: destination for .gifs of failing tests
 
   def current_test_temp_path
-    @_current_test_temp_path ||= File.join(Rails.root, 'tmp', 'test_bot', current_test || 'none')
+    @_current_test_temp_path ||= "#{Rails.root}/tmp/test_bot/#{current_test || 'none'}"
   end
 
   def current_test_failure_path
-    File.join(Rails.root, 'tmp', 'test_bot')
+    "#{Rails.root}/tmp/test_bot"
   end
 
   def current_test_failure_filename
@@ -115,11 +115,11 @@ module EffectiveTestBotScreenshotsHelper
 
   # Where the tour animated gif ends up
   def current_test_tour_path
-    File.join(Rails.root, 'test', 'tours')
+    "#{Rails.root}/test/tours"
   end
 
   def current_test_tour_filename
-    current_test + '.gif'
+    "#{current_test}.gif"
   end
 
   private

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.6
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-12 00:00:00.000000000 Z
+date: 2015-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails