effective_test_bot 0.4.3 → 0.4.4

data/test/test_botable/base_test.rb

@@ -5,12 +5,12 @@ module BaseTest
   protected
 
   def assert_page_normal(message = nil)
-    unless test_bot_skip?(:normal)
-      assert_no_exceptions unless test_bot_skip?(:exceptions)
-      assert_page_status unless test_bot_skip?(:page_status)
-      assert_page_title unless test_bot_skip?(:page_title)
-      assert_no_js_errors unless test_bot_skip?(:no_js_errors)
-    end
+    return if test_bot_skip?(:normal)
+
+    assert_no_exceptions unless test_bot_skip?(:exceptions)
+    assert_page_status unless test_bot_skip?(:page_status)
+    assert_no_js_errors unless test_bot_skip?(:no_js_errors)
+    assert_page_title unless test_bot_skip?(:page_title)
   end
 
   private
@@ -37,10 +37,12 @@ module BaseTest
   end
 
   def create_resource!
-    visit(new_resource_path)
+    without_screenshots do
+      visit(new_resource_path)
 
-    within("form#new_#{resource_name}") do
-      fill_form(resource_attributes) and submit_form
+      within("form#new_#{resource_name}") do
+        fill_form(resource_attributes) and submit_novalidate_form
+      end
     end
 
     resource_class.last

data/test/test_botable/crud_test.rb

@@ -6,6 +6,7 @@ module CrudTest
 
   def test_bot_new_test
     sign_in(user) and visit(new_resource_path)
+    save_test_bot_screenshot
 
     assert_page_normal
     assert_assigns(resource_name) # unskippable
@@ -17,22 +18,25 @@ module CrudTest
     within(form_selector) do
       assert_selector 'input[type=submit]', 'Expected submit button to be present'
     end
+
   end
 
   def test_bot_create_valid_test
     sign_in(user) and visit(new_resource_path)
+    save_test_bot_screenshot
 
     before = { count: resource_class.count, path: page.current_path }
 
     within("form#new_#{resource_name}") do
       fill_form(resource_attributes)
-      test_bot_skip?(:unpermitted_params) ? submit_form : with_raised_unpermitted_params_exceptions { submit_form }
+      submit_form
     end
 
+    save_test_bot_screenshot
+
     after = { count: resource_class.count, path: page.current_path }
 
     assert_page_normal
-    assert_no_unpermitted_params unless test_bot_skip?(:unpermitted_params)
 
     refute_equal before[:count], after[:count], "Expected fill_form to create a #{resource_class} object"
     refute_equal(before[:path], after[:path], "(path) Expected unique before and after paths") unless test_bot_skip?(:path)
@@ -49,20 +53,23 @@ module CrudTest
     before = { count: resource_class.count }
 
     within("form#new_#{resource_name}") do
-      clear_form
+      without_screenshots { clear_form }
       submit_novalidate_form
     end
 
+    save_test_bot_screenshot
+
     after = { count: resource_class.count }
 
     assert_page_normal
 
     assert_equal before[:count], after[:count], "Expected #{resource_class}.count to be unchanged"
-    assert_flash(:danger) unless test_bot_skip?(:flash)
 
     assert_assigns(resource_name) unless test_bot_skip?(:assigns)
     assert_assigns_errors(resource_name) unless test_bot_skip?(:assigns_errors)
 
+    assert_flash(:danger) unless test_bot_skip?(:flash)
+
     assert_equal(resources_path, page.current_path, "(path) Expected current_path to match resource #create path #{resources_path}") unless test_bot_skip?(:path)
   end
 
@@ -70,6 +77,7 @@ module CrudTest
     sign_in(user) and (resource = find_or_create_resource!)
 
     visit(edit_resource_path(resource))
+    save_test_bot_screenshot
 
     assert_page_normal
     assert_assigns(resource_name) unless test_bot_skip?(:assigns)
@@ -87,34 +95,40 @@ module CrudTest
     sign_in(user) and (resource = find_or_create_resource!)
 
     visit(edit_resource_path(resource))
+    save_test_bot_screenshot
 
     before = { count: resource_class.count, updated_at: (resource.updated_at rescue nil) }
 
     within("form#edit_#{resource_name}_#{resource.id}") do
       fill_form(resource_attributes)
-      test_bot_skip?(:unpermitted_params) ? submit_form : with_raised_unpermitted_params_exceptions { submit_form }
+      submit_form
     end
+
+    save_test_bot_screenshot
+
     resource = resource_class.find(resource.id)
 
     after = { count: resource_class.count, updated_at: (resource.updated_at rescue nil) }
 
     assert_page_normal
 
-    assert_equal before[:count], after[:count], "Expected #{resource_class}.count to be unchanged"
-    refute_equal(before[:updated_at], after[:updated_at], "(updated_at_changed) Expected @#{resource_name}.updated_at to have changed") if (resource.respond_to?(:updated_at) && !test_bot_skip?(:updated_at_changed))
+    assert_no_assigns_errors(resource_name) unless test_bot_skip?(:no_assigns_errors)
+
+    assert_equal before[:count], after[:count], "Expected #{resource_class}.count to be unchanged" unless test_bot_skip?(:count)
+    refute_equal(before[:updated_at], after[:updated_at], "(updated_at) Expected @#{resource_name}.updated_at to have changed") if (resource.respond_to?(:updated_at) && !test_bot_skip?(:updated_at))
 
     assert_flash(:success) unless test_bot_skip?(:flash)
 
     # In a rails controller, if i redirect to resources_path it may not assign the instance variable
     # Wheras if I redirect to edit_resource_path I must ensure that the instance variable is set
     assert_assigns(resource_name) if (after[:path] == edit_resource_path(resource) && !test_bot_skip?(:assigns))
-    assert_no_assigns_errors(resource_name) unless test_bot_skip?(:no_assigns_errors)
   end
 
   def test_bot_update_invalid_test
     sign_in(user) and (resource = find_or_create_resource!)
 
     visit(edit_resource_path(resource))
+    save_test_bot_screenshot
 
     before = { count: resource_class.count, updated_at: (resource.updated_at rescue nil) }
 
@@ -122,19 +136,21 @@ module CrudTest
       clear_form
       submit_novalidate_form
     end
+
+    save_test_bot_screenshot
+
     resource = resource_class.find(resource.id)
 
     after = { count: resource_class.count, updated_at: (resource.updated_at rescue nil) }
 
     assert_page_normal
-
     assert_equal before[:count], after[:count], "Expected: #{resource_class}.count to be unchanged"
-    assert_equal(before[:updated_at], after[:updated_at], "Expected @#{resource_name}.updated_at to be unchanged") if resource.respond_to?(:updated_at)
-
-    assert_flash(:danger) unless test_bot_skip?(:flash)
 
     assert_assigns(resource_name) unless test_bot_skip?(:assigns)
     assert_assigns_errors(resource_name) unless test_bot_skip?(:assigns_errors)
+    assert_equal(before[:updated_at], after[:updated_at], "(updated_at) Expected @#{resource_name}.updated_at to be unchanged") if (resource.respond_to?(:updated_at) && !test_bot_skip?(:updated_at))
+
+    assert_flash(:danger) unless test_bot_skip?(:flash)
 
     assert_equal(resource_path(resource), page.current_path, "(path) Expected current_path to match resource #update path") unless test_bot_skip?(:path)
   end
@@ -143,6 +159,7 @@ module CrudTest
     sign_in(user) and (resource = (find_or_create_resource! rescue nil))
 
     visit resources_path
+    save_test_bot_screenshot
 
     assert_page_normal
 
@@ -156,6 +173,7 @@ module CrudTest
     sign_in(user) and (resource = find_or_create_resource!)
 
     visit resource_path(resource)
+    save_test_bot_screenshot
 
     assert_page_normal
     assert_assigns(resource_name) unless test_bot_skip?(:assigns)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-01 00:00:00.000000000 Z
+date: 2015-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -178,6 +178,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rmagick
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
@@ -220,8 +234,10 @@ files:
 - test/concerns/test_botable/wizard_dsl.rb
 - test/support/effective_assets_upload_file._test
 - test/support/effective_test_bot_assertions.rb
+- test/support/effective_test_bot_form_filler.rb
 - test/support/effective_test_bot_form_helper.rb
 - test/support/effective_test_bot_login_helper.rb
+- test/support/effective_test_bot_screenshots_helper.rb
 - test/support/effective_test_bot_test_helper.rb
 - test/test_bot/integration/application_test.rb
 - test/test_bot/integration/environment_test.rb