effective_test_bot 0.4.1 → 0.4.2

data/test/test_bot/models/user_test.rb

@@ -5,6 +5,8 @@ if defined?(Devise) && defined?(User)
     class UserTest < ActiveSupport::TestCase
       let(:user) { User.new() }
 
+      # These are mostly here as an example of using shoulda
+      # I don't find that I use the gem, but I see it's value
       should validate_presence_of(:email)
       should validate_presence_of(:password)
       should validate_presence_of(:encrypted_password)

data/test/test_botable/base_test.rb

@@ -0,0 +1,62 @@
+# All the methods in this file should not be called from the outside world
+# See the DSL files in concerns/test_botable/ for how to call these tests
+
+module BaseTest
+  protected
+
+  def assert_page_normal(message = nil)
+    unless test_bot_skip?(:normal)
+      assert_page_status unless test_bot_skip?(:page_status)
+      assert_page_title unless test_bot_skip?(:page_title)
+      assert_no_js_errors unless test_bot_skip?(:no_js_errors)
+    end
+  end
+
+  private
+
+  # I want to use this same method for the current_test rake test:bot skip functionality
+  # As well as the individual assertion skips
+
+  # Only class level dsl methods will have a current_test assigned
+  # if you use the action_test_ instance methods, current_test is nil, and test skips won't apply
+  # Any global assertion skips will tho
+  def test_bot_skip?(assertion = nil)
+    # Skip the whole test
+    # this will put SKIP into the minitest output
+    skip if (defined?(current_test) && EffectiveTestBot.skip?(current_test))
+
+    # Check if the individual assertion should be skipped
+    EffectiveTestBot.skip?((current_test if defined?(current_test)), assertion)
+  end
+
+  def find_or_create_resource!
+    existing = resource_class.last
+    (existing.present? && !existing.kind_of?(User)) ? existing : create_resource!
+  end
+
+  def create_resource!
+    visit(new_resource_path)
+
+    within("form#new_#{resource_name}") do
+      fill_form(resource_attributes) and submit_form
+    end
+
+    resource_class.last
+  end
+
+  def resources_path # index, create
+    polymorphic_path([*controller_namespace, resource_class])
+  end
+
+  def resource_path(resource) # show, update, destroy
+    polymorphic_path([*controller_namespace, resource])
+  end
+
+  def new_resource_path # new
+    new_polymorphic_path([*controller_namespace, resource])
+  end
+
+  def edit_resource_path(resource) # edit
+    edit_polymorphic_path([*controller_namespace, resource])
+  end
+end

data/test/test_botable/crud_test.rb

@@ -1,11 +1,15 @@
+# All the methods in this file should not be called from the outside world
+# See the DSL files in concerns/test_botable/ for how to call these tests
+
 module CrudTest
-  def new
+  protected
+
+  def test_bot_new_test
+    test_bot_skip?
     sign_in(user) and visit(new_resource_path)
 
-    assert_page_status
-    assert_page_title
-    assert_no_js_errors
-    assert_assigns(resource_name)
+    assert_page_normal
+    assert_assigns(resource_name) # unskippable
 
     # Make sure there's a form with a submit button
     form_selector = "form#new_#{resource_name}"
@@ -16,31 +20,35 @@ module CrudTest
     end
   end
 
-  def create_valid
+  def test_bot_create_valid_test
+    test_bot_skip?
     sign_in(user) and visit(new_resource_path)
 
     before = { count: resource_class.count, path: page.current_path }
 
     within("form#new_#{resource_name}") do
       fill_form(resource_attributes)
-      skip?(:unpermitted_params) == true ? submit_form : with_raised_unpermitted_params_exceptions { submit_form }
+      test_bot_skip?(:unpermitted_params) ? submit_form : with_raised_unpermitted_params_exceptions { submit_form }
     end
 
     after = { count: resource_class.count, path: page.current_path }
 
-    assert_no_unpermitted_params '[create_valid: :unpermitted_params] Expected no unpermitted params' unless skip?(:unpermitted_params)
+    assert_page_normal
+    assert_no_unpermitted_params unless test_bot_skip?(:unpermitted_params)
 
     refute_equal before[:count], after[:count], "Expected fill_form to create a #{resource_class} object"
-    refute_equal(before[:path], after[:path], "[create_valid: :path] Expected unique before and after paths") unless skip?(:path)
+    refute_equal(before[:path], after[:path], "(path) Expected unique before and after paths") unless test_bot_skip?(:path)
 
     # In a rails controller, if I redirect to resources_path it may not assign the instance variable
     # Wheras if I redirect to edit_resource_path I must ensure that the instance variable is set
-    assert_assigns(resource_name) if after[:path].include?('/edit/')
-    assert_equal(nil, assigns[resource_name]['errors'], "Expected @#{resource_name}['errors'] to be blank") if assigns[resource_name].present?
+    assert_assigns(resource_name) if (after[:path].include?('/edit/') && !test_bot_skip?(:assigns))
+    assert_no_assigns_errors(resource_name) unless test_bot_skip?(:no_assigns_errors)
   end
 
-  def create_invalid
+  def test_bot_create_invalid_test
+    test_bot_skip?
     sign_in(user) and visit(new_resource_path)
+
     before = { count: resource_class.count }
 
     within("form#new_#{resource_name}") do
@@ -50,36 +58,37 @@ module CrudTest
 
     after = { count: resource_class.count }
 
-    assert_equal before[:count], after[:count], "Expected: #{resource_class}.count to be unchanged"
-    assert_page_title :any, 'Expected page title to be present after failed validation'
+    assert_equal before[:count], after[:count], "Expected #{resource_class}.count to be unchanged"
+    assert_page_title(:any, '(page_title) Expected page title to be present after failed validation') unless test_bot_skip?(:page_title)
 
-    assert_flash :danger
-    assert_assigns resource_name
-    refute_equal nil, assigns[resource_name]['errors'], "Expected @#{resource_name}['errors'] to be present"
+    assert_no_js_errors unless test_bot_skip?(:no_js_errors)
+    assert_flash(:danger) unless test_bot_skip?(:flash)
+    assert_assigns(resource_name) unless test_bot_skip?(:assigns)
+    assert_assigns_errors(resource_name) unless test_bot_skip?(:assigns_errors)
 
-    assert_equal(resources_path, page.current_path, "[create_invalid: :path] Expected current_path to match resource #create path") unless skip?(:path)
+    assert_equal(resources_path, page.current_path, "(path) Expected current_path to match resource #create path #{resources_path}") unless test_bot_skip?(:path)
   end
 
-  def edit
+  def test_bot_edit_test
+    test_bot_skip?
     sign_in(user) and (resource = find_or_create_resource!)
 
     visit(edit_resource_path(resource))
 
-    assert_page_status
-    assert_page_title
-    assert_no_js_errors
-    assert_assigns resource_name
+    assert_page_normal
+    assert_assigns(resource_name) unless test_bot_skip?(:assigns)
 
     # Make sure there's a form with a submit button
     form_selector = "form#edit_#{resource_name}_#{resource.id}"
 
     assert_selector form_selector, "Expected form with selector #{form_selector}"
     within(form_selector) do
-      assert_selector 'input[type=submit]', 'Expected submit button to be present'
+      assert_selector 'input[type=submit]', 'Expected input[type=submit] to be present'
     end
   end
 
-  def update_valid
+  def test_bot_update_valid_test
+    test_bot_skip?
     sign_in(user) and (resource = find_or_create_resource!)
 
     visit(edit_resource_path(resource))
@@ -88,26 +97,28 @@ module CrudTest
 
     within("form#edit_#{resource_name}_#{resource.id}") do
       fill_form(resource_attributes)
-      skip?(:unpermitted_params) == true ? submit_form : with_raised_unpermitted_params_exceptions { submit_form }
+      test_bot_skip?(:unpermitted_params) ? submit_form : with_raised_unpermitted_params_exceptions { submit_form }
     end
     resource = resource_class.find(resource.id)
 
     after = { count: resource_class.count, updated_at: (resource.updated_at rescue nil) }
 
-    assert_no_unpermitted_params '[update_valid: :unpermitted_params] Expected no unpermitted params' unless skip?(:unpermitted_params)
+    assert_no_js_errors unless test_bot_skip?(:no_js_errors)
+    assert_no_unpermitted_params unless test_bot_skip?(:unpermitted_params)
 
     assert_equal before[:count], after[:count], "Expected #{resource_class}.count to be unchanged"
-    refute_equal(before[:updated_at], after[:updated_at], "Expected @#{resource_name}.updated_at to have changed") if resource.respond_to?(:updated_at)
+    refute_equal(before[:updated_at], after[:updated_at], "(updated_at_changed) Expected @#{resource_name}.updated_at to have changed") if (resource.respond_to?(:updated_at) && !test_bot_skip?(:updated_at_changed))
 
-    assert_flash :success
+    assert_flash(:success) unless test_bot_skip?(:flash)
 
     # In a rails controller, if i redirect to resources_path it may not assign the instance variable
     # Wheras if I redirect to edit_resource_path I must ensure that the instance variable is set
-    assert_assigns(resource_name) if after[:path] == edit_resource_path(resource)
-    assert_equal(nil, assigns[resource_name]['errors'], "Expected @#{resource_name}['errors'] to be blank") if assigns[resource_name].present?
+    assert_assigns(resource_name) if (after[:path] == edit_resource_path(resource) && !test_bot_skip?(:assigns))
+    assert_no_assigns_errors(resource_name) unless test_bot_skip?(:no_assigns_errors)
   end
 
-  def update_invalid
+  def test_bot_update_invalid_test
+    test_bot_skip?
     sign_in(user) and (resource = find_or_create_resource!)
 
     visit(edit_resource_path(resource))
@@ -122,40 +133,44 @@ module CrudTest
 
     after = { count: resource_class.count, updated_at: (resource.updated_at rescue nil) }
 
+    assert_no_js_errors unless test_bot_skip?(:no_js_errors)
     assert_equal before[:count], after[:count], "Expected: #{resource_class}.count to be unchanged"
     assert_equal(before[:updated_at], after[:updated_at], "Expected @#{resource_name}.updated_at to be unchanged") if resource.respond_to?(:updated_at)
-    assert_page_title :any, 'Expected page title to be present after failed validation'
+    assert_page_title(:any, '(page_title) Expected page title to be present after failed validation') unless test_bot_skip?(:page_title)
 
-    assert_flash :danger
-    assert_assigns resource_name
-    refute_equal(nil, assigns[resource_name]['errors'], "Expected @#{resource_name}['errors'] to be present") if assigns[resource_name].present?
+    assert_flash(:danger) unless test_bot_skip?(:flash)
+    assert_assigns(resource_name) unless test_bot_skip?(:assigns)
+    assert_assigns_errors(resource_name) unless test_bot_skip?(:assigns_errors)
 
-    assert_equal(resource_path(resource), page.current_path, "[update_invalid: :path] Expected current_path to match resource #update path") unless skip?(:path)
+    assert_equal(resource_path(resource), page.current_path, "(path) Expected current_path to match resource #update path") unless test_bot_skip?(:path)
   end
 
-  def index
-    sign_in(user) and (resource = find_or_create_resource!)
+  def test_bot_index_test
+    test_bot_skip?
+    sign_in(user) and (resource = (find_or_create_resource! rescue nil))
 
     visit resources_path
 
-    assert_page_status
-    assert_page_title
-    assert_no_js_errors
-    assert((assigns['datatable'].present? || assigns[resource_name.pluralize].present?), "[index: :assigns] Expected @#{resource_name.pluralize} or @datatable to be present") unless skip?(:assigns)
+    assert_page_normal
+
+    assert(
+      (assigns['datatable'].present? || assigns[resource_name.pluralize].present?),
+      "(assigns) Expected @#{resource_name.pluralize} or @datatable to be present"
+    ) unless test_bot_skip?(:assigns)
   end
 
-  def show
-    sign_in(user) and (resource = create_resource!)
+  def test_bot_show_test
+    test_bot_skip?
+    sign_in(user) and (resource = find_or_create_resource!)
 
     visit resource_path(resource)
 
-    assert_page_status
-    assert_page_title
-    assert_no_js_errors
-    assert_assigns resource_name
+    assert_page_normal
+    assert_assigns(resource_name) unless test_bot_skip?(:assigns)
   end
 
-  def destroy
+  def test_bot_destroy_test
+    test_bot_skip?
     sign_in(user) and (resource = find_or_create_resource!)
 
     before = { count: resource_class.count, archived: (resource.archived rescue nil) }
@@ -164,51 +179,12 @@ module CrudTest
 
     after = { count: resource_class.count, archived: (resource_class.find(resource.id).archived rescue nil) }
 
-    assert_flash :success
+    assert_flash(:success) unless test_bot_skip?(:flash)
 
     if resource.respond_to?(:archived)
-      assert after[:archived] == true, "Expected #{resource_class}.archived? to be true"
+      assert_equal(true, after[:archived], "Expected #{resource_class}.archived? to be true")
     else
-      refute_equal before[:count], after[:count], "Expected: #{resource_class}.count to decrement by 1"
+      assert_equal before[:count]-1, after[:count], "Expected: #{resource_class}.count to decrement by 1"
     end
   end
-
-  protected
-
-  def skip?(test)
-    skips.include?(test)
-  end
-
-  def find_or_create_resource!
-    existing = resource_class.last
-    (existing.present? && !existing.kind_of?(User)) ? existing : create_resource!
-  end
-
-  def create_resource!
-    visit(new_resource_path)
-
-    within("form#new_#{resource_name}") do
-      fill_form(resource_attributes) and submit_form
-    end
-
-    resource_class.last
-  end
-
-  private
-
-  def resources_path # index, create
-    polymorphic_path([*controller_namespace, resource_class])
-  end
-
-  def resource_path(resource) # show, update, destroy
-    polymorphic_path([*controller_namespace, resource])
-  end
-
-  def new_resource_path # new
-    new_polymorphic_path([*controller_namespace, resource])
-  end
-
-  def edit_resource_path(resource) # edit
-    edit_polymorphic_path([*controller_namespace, resource])
-  end
 end

data/test/test_botable/member_test.rb

@@ -0,0 +1,20 @@
+# All the methods in this file should not be called from the outside world
+# See the DSL files in concerns/test_botable/ for how to call these tests
+
+module MemberTest
+  protected
+
+  def test_bot_member_test
+    test_bot_skip?
+    sign_in(user) and (resource = find_or_create_resource!)
+
+    path = url_for(controller: controller, action: action, id: resource.id, only_path: true)
+
+    visit(path)
+
+    assert_page_normal
+    assert_flash unless test_bot_skip?(:flash)
+    assert_assigns(resource_name) unless (was_redirect?(path) || test_bot_skip?(:assigns))
+  end
+
+end

data/test/test_botable/page_test.rb

@@ -0,0 +1,23 @@
+# All the methods in this file should not be called from the outside world
+# See the DSL files in concerns/test_botable/ for how to call these tests
+
+module PageTest
+  protected
+
+  def test_bot_page_test
+    test_bot_skip?
+
+    sign_in(user)
+
+    if page_path.kind_of?(Symbol)
+      visit(public_send(page_path))
+    else
+      visit(page_path)
+    end
+
+    assert_page_normal
+
+    #page.save_screenshot("#{page_path.to_s.parameterize}.png")
+  end
+
+end

data/test/test_botable/redirect_test.rb

@@ -0,0 +1,18 @@
+# All the methods in this file should not be called from the outside world
+# See the DSL files in concerns/test_botable/ for how to call these tests
+
+module RedirectTest
+  protected
+
+  def test_bot_redirect_test
+    test_bot_skip?
+
+    sign_in(user) and visit(from_path)
+
+    assert_redirect(from_path, to_path)
+    assert_page_normal
+
+    #page.save_screenshot("#{from_path.parameterize}.png")
+  end
+
+end

data/test/test_botable/wizard_test.rb

@@ -0,0 +1,31 @@
+# All the methods in this file should not be called from the outside world
+# See the DSL files in concerns/test_botable/ for how to call these tests
+
+module WizardTest
+  protected
+
+  def test_bot_wizard_test
+    test_bot_skip?
+
+    sign_in(user) and visit(from_path)
+
+    0.upto(50) do |index|   # Can only test wizards 51 steps long
+      assert_page_normal
+
+      if defined?(within_form)
+        within(within_form) do
+          fill_form
+          submit_form
+        end
+      else
+        fill_form
+        submit_form
+      end
+
+      break if page.current_path == to_path
+    end
+
+    assert_current_path to_path
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-07 00:00:00.000000000 Z
+date: 2015-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -211,17 +211,27 @@ files:
 - lib/generators/templates/effective_test_bot.rb
 - lib/generators/templates/test_helper.rb
 - lib/tasks/effective_test_bot_tasks.rake
-- test/concerns/test_botable/crud_test.rb
+- test/concerns/test_botable/base_dsl.rb
+- test/concerns/test_botable/crud_dsl.rb
+- test/concerns/test_botable/member_dsl.rb
+- test/concerns/test_botable/page_dsl.rb
+- test/concerns/test_botable/redirect_dsl.rb
+- test/concerns/test_botable/wizard_dsl.rb
 - test/support/effective_assets_upload_file._test
 - test/support/effective_test_bot_assertions.rb
 - test/support/effective_test_bot_form_helper.rb
 - test/support/effective_test_bot_login_helper.rb
 - test/support/effective_test_bot_test_helper.rb
+- test/test_bot/integration/application_test.rb
 - test/test_bot/integration/devise_test.rb
-- test/test_bot/integration/home_page_test.rb
 - test/test_bot/integration/minitest_test.rb
 - test/test_bot/models/user_test.rb
+- test/test_botable/base_test.rb
 - test/test_botable/crud_test.rb
+- test/test_botable/member_test.rb
+- test/test_botable/page_test.rb
+- test/test_botable/redirect_test.rb
+- test/test_botable/wizard_test.rb
 homepage: https://github.com/code-and-effect/effective_test_bot
 licenses:
 - MIT