effective_storage 0.4.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4f1b5a4ba6185fdd5c81e33afacd6dfb6ec8dc2e5c24fa07fb05be840d196740
-  data.tar.gz: e82b0d3bea47958aabd007a0a444088b92124421149357dd9998e1f0c30c4346
+  metadata.gz: 9230c3cd21cf195cdf1b24f42bf4221c8a7a2619a78b2ba3cc4ef7d132906e4d
+  data.tar.gz: 7121042e8928e76541e60f595f93461ed767563e62d5e3f2251dda5f9b6239da
 SHA512:
-  metadata.gz: aebccce481ef3f36dac0a1f1855e957abca8f6d30465f3bb214875210a98aa24fd1ea7df14b5de80c727d503fb69ef2a226e81f23b7b7381ea88165ccdf85df3
-  data.tar.gz: af51fe35aeed80cd5409aa39c3048b6e4128ad80429d383e2639d8b3afa19500ba05ee2647e6ff93c46fdca6d4af3700cfcc914d81aa3f1136afcf27e873d6ad
+  metadata.gz: 8798dd36a2b61b525416d8eb27a4c4d291d8380df42690c088f17ec76ddd1ebef5e995a0a97293fa105a19b00bb44b12cb325073345a975a245aeaf25dfcd3b2
+  data.tar.gz: ab3c5af1ae73962ada0a37cfdb2edda28a81ff8bd3b081b62e5e90eb5a1ee4335eda7247c34af16982ca79adf4fdff11e0a7eb27150d98a47e8d1f2bce8dea40

data/app/models/concerns/active_storage_authorization.rb

@@ -35,7 +35,6 @@ module ActiveStorageAuthorization
   # Send an ExceptionNotification email with the unauthorized details
   # This is not visible to users
   def unauthorized_active_storage_request(exception)
-    return if request.referer.to_s.include?('.test:')
 
     if defined?(ExceptionNotifier)
       data = { 'current_user_id': current_user&.id || 'none' }.merge(@blob&.attributes || {})
@@ -79,6 +78,8 @@ module ActiveStorageAuthorization
     record = attachment.record if attachment
     resource = record.record if record.respond_to?(:record)
 
+    return if skip_notification?(record || resource || @blob)
+
     error = [
       "unauthorized active storage request for #{@blob.filename}",
       ("on #{record.class.name} #{record.id}" if record.present?),
@@ -91,6 +92,14 @@ module ActiveStorageAuthorization
     raise Effective::UnauthorizedStorageException.new(error + '. ' + resolution)
   end
 
+  def skip_notification?(resource)
+    return true if EffectiveStorage.skip_notification?
+    return true if EffectiveStorage.skip_notifications.include?(resource.class.name)
+    return true if request.referer.to_s.include?('.test:')
+
+    false
+  end
+
   # This is a file that was drag & drop or inserted into the article editor
   # I think this might only happen with article editor edit screens
   def authorize_content_download?(blob)

data/config/effective_storage.rb

@@ -9,4 +9,9 @@ EffectiveStorage.setup do |config|
 
   # Do not delete ActiveStorage::Blobs
   config.never_delete = true
+
+  # Skip Notifications for unauthorized active storage requests
+  # config.skip_notification = true
+  # config.skip_notification = ['Effective::Classified']
+
 end

data/lib/effective_storage/version.rb

@@ -1,3 +1,3 @@
 module EffectiveStorage
-  VERSION = '0.4.1'.freeze
+  VERSION = '0.4.3'.freeze
 end

data/lib/effective_storage.rb

@@ -6,7 +6,7 @@ require 'effective_storage/version'
 module EffectiveStorage
 
   def self.config_keys
-    [:layout, :authorize_active_storage, :never_delete]
+    [:layout, :authorize_active_storage, :never_delete, :skip_notification]
   end
 
   include EffectiveGem
@@ -19,4 +19,12 @@ module EffectiveStorage
     never_delete == true
   end
 
+  def self.skip_notification?
+    skip_notification == true
+  end
+
+  def self.skip_notifications
+    Array(skip_notification)
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_storage
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.3
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-20 00:00:00.000000000 Z
+date: 2023-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: haml-rails
+  name: haml
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -170,7 +170,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Authorize and browse Active Storage attachments