effective_storage 0.4.0 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d31c97986b5166e4bd1fa34d329ea5a6b8f7c355a9ab952f010100ba8ed33f63
-  data.tar.gz: e88cce63f52489de5fed02e3c5119f4ff17cb5ca07fba05472b15d5cfcfdd814
+  metadata.gz: 0e845ec308c0f8172341a2a427b3f3d87dfae2bf970484cf35ffd57659cf0359
+  data.tar.gz: c36875b2f938f2bacad35031edc878998fb1000385ae63e91396f2906a3c81c9
 SHA512:
-  metadata.gz: 405aa9bb4a51b937c3c551af74327774078418ed01e96b13340806c0dca6dc6fc1bd9824147d3472f65aec8bdc8db49d9dfe5903215e87ee17f3958aefa3f518
-  data.tar.gz: d6058d78e87602fdfbb7639e0e66628c691edd6c22c1823c6697343a8ede5359d09da98c3daa729f146c2e608cc1bf66045cad9785c228d01e1b69ce4b60d55f
+  metadata.gz: '079f895f60a5bb4c4288f7c3d77b99f27822f44956f529baf98a7ec8982aaeecfa80addebdfb9363e61847974a30cd293a38b095d52c169a6c97e0544ed88f94'
+  data.tar.gz: b90dba9ec5b38775667539bbdd6bf84a0fcd4435f62e4da043fbc2263382bec0cce6cf1d808bc5e92145670d7cfde4e47a6999d676516550f235bf7dd0537cff

data/app/models/concerns/active_storage_authorization.rb

@@ -35,7 +35,6 @@ module ActiveStorageAuthorization
   # Send an ExceptionNotification email with the unauthorized details
   # This is not visible to users
   def unauthorized_active_storage_request(exception)
-    return if request.referer.to_s.include?('.test:')
 
     if defined?(ExceptionNotifier)
       data = { 'current_user_id': current_user&.id || 'none' }.merge(@blob&.attributes || {})
@@ -79,6 +78,8 @@ module ActiveStorageAuthorization
     record = attachment.record if attachment
     resource = record.record if record.respond_to?(:record)
 
+    return if skip_notification?(record || resource || @blob)
+
     error = [
       "unauthorized active storage request for #{@blob.filename}",
       ("on #{record.class.name} #{record.id}" if record.present?),
@@ -91,6 +92,14 @@ module ActiveStorageAuthorization
     raise Effective::UnauthorizedStorageException.new(error + '. ' + resolution)
   end
 
+  def skip_notification?(resource)
+    return true if EffectiveStorage.skip_notification?
+    return true if EffectiveStorage.skip_notifications.include?(resource.class.name)
+    return true if request.referer.to_s.include?('.test:')
+
+    false
+  end
+
   # This is a file that was drag & drop or inserted into the article editor
   # I think this might only happen with article editor edit screens
   def authorize_content_download?(blob)

data/app/models/concerns/active_storage_blob_extension.rb

@@ -9,6 +9,8 @@ module ActiveStorageBlobExtension
     scope :deep, -> { includes(:active_storage_extensions, attachments: [record: :record]) }
 
     scope :attached, -> { joins(:attachments) }
+    scope :unattached, -> { where.not(id: attached) }
+
   end
 
   module ClassMethods

data/config/effective_storage.rb

@@ -9,4 +9,9 @@ EffectiveStorage.setup do |config|
 
   # Do not delete ActiveStorage::Blobs
   config.never_delete = true
+
+  # Skip Notifications for unauthorized active storage requests
+  # config.skip_notification = true
+  # config.skip_notification = ['Effective::Classified']
+
 end

data/lib/effective_storage/version.rb

@@ -1,3 +1,3 @@
 module EffectiveStorage
-  VERSION = '0.4.0'.freeze
+  VERSION = '0.4.2'.freeze
 end

data/lib/effective_storage.rb

@@ -6,7 +6,7 @@ require 'effective_storage/version'
 module EffectiveStorage
 
   def self.config_keys
-    [:layout, :authorize_active_storage, :never_delete]
+    [:layout, :authorize_active_storage, :never_delete, :skip_notification]
   end
 
   include EffectiveGem
@@ -19,4 +19,12 @@ module EffectiveStorage
     never_delete == true
   end
 
+  def self.skip_notification?
+    skip_notification == true
+  end
+
+  def self.skip_notifications
+    Array(skip_notification)
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_storage
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.2
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-20 00:00:00.000000000 Z
+date: 2023-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails