effective_storage 0.3.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ddb75c58fe70421e642837cd9af4f53f90d8c4b01d56489d95410b293da9509d
-  data.tar.gz: 01dfc8e5af3dc6ce51181989c4d3a30b75295dd384c616ef14dc994f03ca9490
+  metadata.gz: e4d882d7dc41b30bee6a440cffcbcc0008dc697fc5ace3455ff2f427910325d1
+  data.tar.gz: a6a536963a71e23feeb0106193a7d731372f3190cf48632aa5cb70388636df31
 SHA512:
-  metadata.gz: 9f11e509b1a5a92c007a87178f8bb53b9f6d1a5563fe1d7f14e04b8db13d39c1757197050a79bc6807be703d7257d10424f92d4d1a5f4493f984dd949094f40f
-  data.tar.gz: 6eae6952c076bab26ab2a67ffe403d4eb51d0aa9242dcff992fb5473580982fdefff44fa36bc635b52d98f9b8866752e53f9d296037bb9a2136487d6acff94ca
+  metadata.gz: fc59eaafef6892fb1b3826e7ad0ee0f5aacf175f553cdae2eb8bc15a2631a72ea4681f2ef6b7c594f5497007df06f7acfd91c9f76480b4d49e96811b1a637781
+  data.tar.gz: 12d4c064a19a72670545e52f61c986c80455c90ae4852af9c3e272aea56a4331d7e7e0065e9cdfeff860f25f1e12f282b180815dd1145e1af33e66d7e2c863a4

data/app/models/concerns/active_storage_authorization.rb

@@ -67,8 +67,8 @@ module ActiveStorageAuthorization
     # If we are authorized on any attached record, permit the download
     return true if @blob.attachments.any? { |attachment| authorized_attachment_download?(attachment) }
 
-    # Otherwise raise a 403 Forbidden and block the download
-    head(:forbidden, 'X-Robots-Tag': 'noindex')
+    # Otherwise raise a 404 Not Found and block the download
+    head(:not_found)
 
     # Raise an exception to log unauthorized request
     raise_exception()
@@ -113,7 +113,8 @@ module ActiveStorageAuthorization
   # This is a has_one_attached or has_many_attached record
   # Or an ActionText::RichText object, that belongs_to a record
   def authorized_attachment_download?(attachment)
-    return false if attachment.record.blank?
+    # DO NOT USE .blank? or .present? here. They return incorrect values.
+    return false if attachment.record.nil?
 
     # Associated Record
     record = attachment.record

data/lib/effective_storage/version.rb

@@ -1,3 +1,3 @@
 module EffectiveStorage
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.3.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_storage
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-06 00:00:00.000000000 Z
+date: 2023-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails