effective_resources 1.8.5 → 1.8.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 29481500627bdb2e83a1f66d58dde1c9d74aecc2e8902b2bb2afa82b0a70ad46
-  data.tar.gz: e46866b50672f2e2fa928caa226d663eb630f292d3a2b10c3de026cf323b3d67
+  metadata.gz: dc3c685dc56b79f0af482b0cf0d67e0dacafd6b9dc1e032cceb5d688b44752d6
+  data.tar.gz: e5b9f21ab57e68f9fbc601d6a41cc40358f47f92850e80c756e75f7c52d13383
 SHA512:
-  metadata.gz: fd7cfc021a37f0e1b4381b7d9a6b3ff1515c9368ff3b4fbc072573ebdc89a6e0df0b59f01fa1392fafe00d1993ff1115cdabd1081315172dc84db711786cc36f
-  data.tar.gz: b352c4e02f16afae95201ad937ec14a746a73c116a6a9149052a3c239c9160229f9932ffbfb9a5e66a8c25782f38a29146e5b1f5b0bb4df1616c4a5201cc0da4
+  metadata.gz: 044ee953eb0e281c9f85c95934a2824a80d73a2779e4799e716374e7f1fe932255339bd56efc918333a9886eaef0baa0c4400a43db1060ddd40ee2c2f988d7d5
+  data.tar.gz: 6d337535d4e2c37da1f8d5bbeb5c6dd95621bb3789b873fcf94364fd21fd5750a7a31c0c5e6d6be28d560525c6b5a7c1de9d8a56b6abdf710e2cc771c71a35c5

data/app/controllers/concerns/effective/crud_controller.rb

@@ -11,7 +11,6 @@ module Effective
     include Effective::CrudController::Submits
 
     included do
-      define_actions_from_routes
       define_callbacks :resource_render, :resource_before_save, :resource_after_save, :resource_after_commit, :resource_error
       layout -> { resource_layout }
     end
@@ -19,22 +18,11 @@ module Effective
     module ClassMethods
       include Effective::CrudController::Dsl
 
-      # This is used to define_actions_from_routes and for the buttons/submits/ons
+      # This is used for the buttons/submits/ons
       # It doesn't really work with the resource_scope correctly but the routes are important here
       def effective_resource
         @_effective_resource ||= Effective::Resource.new(controller_path)
       end
-
-      # Automatically respond to any action defined via the routes file
-      def define_actions_from_routes
-        (effective_resource.member_actions - effective_resource.crud_actions).each do |action|
-          define_method(action) { member_action(action) }
-        end
-
-        (effective_resource.collection_actions - effective_resource.crud_actions).each do |action|
-          define_method(action) { collection_action(action) }
-        end
-      end
     end
 
     def resource # @thing
@@ -53,22 +41,41 @@ module Effective
       send(:instance_variable_set, "@#{resource_plural_name}", instance)
     end
 
-    def effective_resource
+    def effective_resource(safe: false)
       @_effective_resource ||= begin
         relation = instance_exec(&resource_scope_relation) if respond_to?(:resource_scope_relation)
 
-        if respond_to?(:resource_scope_relation) && !relation.kind_of?(ActiveRecord::Relation)
-          raise('resource_scope must return an ActiveRecord::Relation')
+        if respond_to?(:resource_scope_relation)
+          unless relation.kind_of?(ActiveRecord::Relation) || (relation.kind_of?(Class) && relation.ancestors.include?(ActiveModel::Model))
+            raise('resource_scope must return an ActiveRecord::Relation or class including ActiveModel::Model')
+          end
         end
 
         resource = Effective::Resource.new(controller_path, relation: relation)
 
         unless resource.relation.kind_of?(ActiveRecord::Relation) || resource.active_model?
-          raise("unable to build resource_scope for #{resource.klass || 'unknown klass'}. Please name your controller to match an existing model, or manually define a resource_scope.")
+          raise("unable to build resource_scope for #{resource.klass || 'unknown klass'}. Please name your controller to match an existing model, or manually define a resource_scope.") unless safe
+        else
+          resource
         end
+      end
+    end
+
+    def action_missing(action, *args, &block)
+      effective_resource = self.effective_resource(safe: true)
+      return super if effective_resource.blank?
+
+      action = action.to_sym
 
-        resource
+      if effective_resource.member_actions.include?(action)
+        return member_action(action)
       end
+
+      if effective_resource.collection_actions.include?(action)
+        return collection_action(action)
+      end
+
+      super
     end
 
     private

data/app/controllers/concerns/effective/crud_controller/paths.rb

@@ -2,7 +2,7 @@ module Effective
   module CrudController
     module Paths
 
-      def resource_redirect_path(action = nil)
+      def resource_redirect_path(resource, action)
         submit = commit_action(action)
         redirect = submit[:redirect].respond_to?(:call) ? instance_exec(&submit[:redirect]) : submit[:redirect]
 
@@ -39,13 +39,29 @@ module Effective
         # Otherwise consider the action
         commit_default_redirect = case action
         when :create
-          [resource_show_path, resource_edit_path, resource_index_path]
+          [
+            (resource_show_path if EffectiveResources.authorized?(self, :show, resource)),
+            (resource_edit_path if EffectiveResources.authorized?(self, :edit, resource)),
+            (resource_index_path if EffectiveResources.authorized?(self, :index, resource.class))
+          ]
         when :update
-          [resource_edit_path, resource_show_path, resource_index_path]
+          [
+            (resource_edit_path if EffectiveResources.authorized?(self, :edit, resource)),
+            (resource_show_path if EffectiveResources.authorized?(self, :show, resource)),
+            (resource_index_path if EffectiveResources.authorized?(self, :index, resource.class))
+          ]
         when :destroy
-          [referer_redirect_path, resource_index_path]
+          [
+            referer_redirect_path,
+            (resource_index_path if EffectiveResources.authorized?(self, :index, resource.class))
+          ]
         else
-          [referer_redirect_path, resource_edit_path, resource_show_path, resource_index_path]
+          [
+            referer_redirect_path,
+            (resource_edit_path if EffectiveResources.authorized?(self, :edit, resource)),
+            (resource_show_path if EffectiveResources.authorized?(self, :show, resource)),
+            (resource_index_path if EffectiveResources.authorized?(self, :index, resource.class))
+          ]
         end.compact.first
 
         return commit_default_redirect if commit_default_redirect.present?

data/app/controllers/concerns/effective/crud_controller/respond.rb

@@ -10,12 +10,12 @@ module Effective
           respond_to do |format|
             format.html do
               flash[:success] ||= resource_flash(:success, resource, action)
-              redirect_to(resource_redirect_path(action))
+              redirect_to(resource_redirect_path(resource, action))
             end
 
             format.js do
               flash[:success] ||= resource_flash(:success, resource, action)
-              redirect_to(resource_redirect_path(action))
+              redirect_to(resource_redirect_path(resource, action))
             end
           end
         elsif template_present?(action)
@@ -35,7 +35,7 @@ module Effective
           respond_to do |format|
             format.html do
               flash[:success] ||= resource_flash(:success, resource, action)
-              redirect_to(resource_redirect_path(action))
+              redirect_to(resource_redirect_path(resource, action))
             end
 
             format.js do
@@ -61,7 +61,7 @@ module Effective
           when :destroy
             format.html do
               redirect_flash
-              redirect_to(resource_redirect_path(action))
+              redirect_to(resource_redirect_path(resource, action))
             end
           else
             if template_present?(action)
@@ -73,7 +73,7 @@ module Effective
             else
               format.html do
                 redirect_flash
-                redirect_to(resource_redirect_path(action))
+                redirect_to(resource_redirect_path(resource, action))
               end
             end
           end

data/app/controllers/concerns/effective/flash_messages.rb

@@ -8,8 +8,10 @@ module Effective
     def flash_success(resource, action = nil, name: nil)
       raise 'expected an ActiveRecord resource' unless (name || resource.class.respond_to?(:model_name))
 
-      name ||= begin
-        resource.destroyed? ? resource.class.model_name.to_s.downcase.split('::').last : resource.to_s.presence
+      name ||= if resource.respond_to?(:destroyed?) && resource.destroyed?
+        resource.class.model_name.to_s.downcase.split('::').last
+      else
+        resource.to_s.presence
       end
 
       "Successfully #{action_verb(action)} #{name || 'resource'}".html_safe
@@ -24,8 +26,10 @@ module Effective
 
       messages = flash_errors(resource, e: e)
 
-      name ||= begin
-        resource.destroyed? ? resource.class.model_name.to_s.downcase.split('::').last : resource.to_s.presence
+      name ||= if resource.respond_to?(:destroyed?) && resource.destroyed?
+        resource.class.model_name.to_s.downcase.split('::').last
+      else
+        resource.to_s.presence
       end
 
       ["Unable to #{action}", (" #{name}" if name), (": #{messages}" if messages)].compact.join.html_safe

data/app/controllers/concerns/effective/wizard_controller/save.rb

@@ -7,7 +7,7 @@ module Effective
         action ||= resource.respond_to?("#{step}!") ? step : :save
 
         if save_resource(resource, action)
-          flash[:success] = options.delete(:success) || resource_flash(:success, resource, action)
+          flash[:success] ||= options.delete(:success) || resource_flash(:success, resource, action)
 
           @skip_to ||= next_step
           @redirect_to ||= resource_wizard_path(resource, @skip_to) if was_new_record

data/app/helpers/effective_resources_helper.rb

@@ -148,6 +148,7 @@ module EffectiveResourcesHelper
     effective_resource = (atts.delete(:effective_resource) || find_effective_resource)
 
     action = atts.delete(:action)
+    safe = atts.delete(:safe)
     atts = { :namespace => (effective_resource.namespace.to_sym if effective_resource.namespace), effective_resource.name.to_sym => resource }.compact.merge(atts)
 
     if lookup_context.template_exists?("form_#{action}", controller._prefixes, :partial)
@@ -168,7 +169,10 @@ module EffectiveResourcesHelper
       end
     end
 
-    render('form', atts) # Will raise the regular error
+    # Will raise the regular error
+    return ''.html_safe if safe
+
+    render('form', atts)
   end
 
   # Similar to render_resource_form
@@ -182,6 +186,7 @@ module EffectiveResourcesHelper
     effective_resource = (atts.delete(:effective_resource) || find_effective_resource)
 
     action = atts.delete(:action)
+    safe = atts.delete(:safe)
     atts = { :namespace => (effective_resource.namespace.to_sym if effective_resource.namespace), effective_resource.name.to_sym => resource }.compact.merge(atts)
 
     if lookup_context.template_exists?(effective_resource.name, controller._prefixes, :partial)
@@ -194,7 +199,10 @@ module EffectiveResourcesHelper
       end
     end
 
-    render(resource, atts)  # Will raise the regular error
+    # Will raise the regular error
+    return ''.html_safe if safe
+
+    render(resource, atts)
   end
   alias_method :render_resource, :render_resource_partial
 

data/app/views/application/member_action.js.erb

@@ -1,7 +1,7 @@
 <% resource = (@_effective_resource || Effective::Resource.new(controller_path)) %>
 <% @resource = instance_variable_get('@' + resource.name) if resource.name %>
 
-EffectiveForm.remote_form_payload = "<%= j render_resource_form(@resource, action: action) %>";
+EffectiveForm.remote_form_payload = "<%= j render_resource_form(@resource, action: action, safe: true) %>";
 EffectiveForm.remote_form_commit = "<%= params[:commit] %>";
 EffectiveForm.remote_form_flash = <%= raw flash.to_json %>;
 

data/lib/effective_resources/effective_gem.rb

@@ -7,7 +7,7 @@ module EffectiveGem
     raise("expected self.config_keys method") unless respond_to?(:config_keys)
 
     config_keys.each do |key|
-      self.class.define_method(key) { config()[key] }
+      self.singleton_class.define_method(key) { config()[key] }
     end
   end
 

data/lib/effective_resources/version.rb

@@ -1,3 +1,3 @@
 module EffectiveResources
-  VERSION = '1.8.5'.freeze
+  VERSION = '1.8.10'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_resources
 version: !ruby/object:Gem::Version
-  version: 1.8.5
+  version: 1.8.10
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-08 00:00:00.000000000 Z
+date: 2021-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails