effective_resources 1.3.15 → 1.3.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c9401a04b558eb6438c84b7a4fefe259d37fc3deecf022aa95729a18fdc24511
-  data.tar.gz: 137da931f63327136a49d05ad14de51cd1b70f7d0878dc530978f9778d79da7e
+  metadata.gz: d7e03695900381e818f1b43f1cffa5880c3c8cc51e95a4ca7d7f5a634b1d3439
+  data.tar.gz: 298f386f1def244429b50643da2b12c8981b8c792714205f17c656c31b1cf9ec
 SHA512:
-  metadata.gz: 4da7d55ebb3f63dff8f64a549cd6fc90331dcbf7e41b37c19dcf780390efd10e62f15db71175514e30344d60d448d3b9943bcfb165769ecfc4eb7d98c1976c08
-  data.tar.gz: 1301f38268a74ae5a159c0a63fa8af7f5b4ace3a157d10a45ebcf46abcec25eb0709519354a28394e2355b0507ba47c5ef5ffc7c22ce4062c70044a55151c040
+  metadata.gz: d684ebb7078363cf3dbfd06dcb0e49fa75c47f72d979809d0783f71a0d922d0f5e765ad3451703d5aff6f1559c3ea39affe5c44abcda3e3a37173d4ca57b4ed4
+  data.tar.gz: 68bb600221adc7747afd558d67f5a75c401163ab08ac606df7f31e73a61f8a5101c6b3d82becb059dc007fc0d25bdb65b2a23768faee138eb2f2a5712b3ce1f7

data/app/models/concerns/acts_as_statused.rb

@@ -120,52 +120,34 @@ module ActsAsStatused
 
     # Create an received scope and approved? method for each status
     acts_as_statused_options[:statuses].each do |sym|
-      unless respond_to?("#{sym}?")
-        define_method("#{sym}?") { status == sym.to_s }
-      end
+      define_method("#{sym}?") { status == sym.to_s }
+      define_method("was_#{sym}?") { send("#{sym}_at").present? }
 
-      unless respond_to?("#{sym}_at")
+      unless has_attribute?("#{sym}_at")
         define_method("#{sym}_at") { status_steps["#{sym}_at".to_sym] }
-      end
-
-      unless respond_to?("#{sym}_at=")
         define_method("#{sym}_at=") { |value| status_steps["#{sym}_at".to_sym] = value }
       end
 
-      unless respond_to?("#{sym}_by")
+      unless has_attribute?("#{sym}_by_id")
         define_method("#{sym}_by") { acts_as_statused_by_user(sym) }
-      end
-
-      unless respond_to?("#{sym}_by_id")
         define_method("#{sym}_by_id") { status_steps["#{sym}_by".to_sym] }
-      end
-
-      unless respond_to?("#{sym}_by_id=")
         define_method("#{sym}_by_id=") { |value| status_steps["#{sym}_by".to_sym] = value }
       end
 
-      unless respond_to?("was_#{sym}?")
-        define_method("was_#{sym}?") { send("#{sym}_at").present? }
-      end
-
       # approved!
-      unless respond_to?("#{sym}!")
-        define_method("#{sym}!") do |atts = {}|
-          raise 'expected a Hash of passed attributes' unless atts.kind_of?(Hash)
-          update!(atts.merge(status: sym))
-        end
+      define_method("#{sym}!") do |atts = {}|
+        raise 'expected a Hash of passed attributes' unless atts.kind_of?(Hash)
+        update!(atts.merge(status: sym))
       end
 
       # unapproved!
-      unless respond_to?("un#{sym}!")
-        define_method("un#{sym}!") do
-          self.status = nil if (status == sym.to_s)
+      define_method("un#{sym}!") do
+        self.status = nil if (status == sym.to_s)
 
-          status_steps.delete("#{sym}_at".to_sym)
-          status_steps.delete("#{sym}_by".to_sym)
+        status_steps.delete("#{sym}_at".to_sym)
+        status_steps.delete("#{sym}_by".to_sym)
 
-          true
-        end
+        true
       end
 
       scope(sym, -> { where(status: sym.to_s) })

data/lib/effective_resources/version.rb

@@ -1,3 +1,3 @@
 module EffectiveResources
-  VERSION = '1.3.15'.freeze
+  VERSION = '1.3.16'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_resources
 version: !ruby/object:Gem::Version
-  version: 1.3.15
+  version: 1.3.16
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-13 00:00:00.000000000 Z
+date: 2019-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails