effective_resources 1.10.0 → 1.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0bc703e350cb8ca2e07dd5d9f0413f88bd15e98bab5d113e2696397e00af0732
-  data.tar.gz: d40aa7078d8ce692b7c5c7991b5c5ed2c06de95b0bf3602c5253b2b19affe6e6
+  metadata.gz: 3db298e3e7c154dc1aa2dbec87f22bcd2fe0c20b9ab565bea13a8305f6ba04f3
+  data.tar.gz: 6b79e28b6b7f8f7335313d769725e16f9f6deb799bdfa29fb0b1de6c5b459b3c
 SHA512:
-  metadata.gz: 1f5a322f0390678c9fc5834003621d73a42ab538cb3c904d942b68d44a57acb81cd5ad4601b722f8f8795e64930074ad4281a8f26baea4d798edc0b182eaa48b
-  data.tar.gz: efcd8d06e4889a5adce7a747eb207a0abfb920ae4f46981fd4de82ddeace22eb9ff2364fe1482c99ccff71d94d0d3393e986fd10fd2c6aa74059459ac583f06a
+  metadata.gz: 82f53749182dc5a0f9b86c92171c0dc36eebf49fbeb874789a466143354fe28143c4d83e8caefae4b4e42f7157608ec58400f5ce4322b3609616ccf115d2235c
+  data.tar.gz: c388f8c66074503b1d04874419b71a5d5054ececd383d33a45087f0a17f65007fbd3f9aeb7c457c5d61ac3c36d1931a6b734756ea55ef807bd54c827e5143884

data/app/controllers/concerns/effective/wizard_controller/before_actions.rb

@@ -35,6 +35,20 @@ module Effective
 
       # setup_wizard from Wicked called now
 
+      # Allow only 1 in-progress wizard at a time
+      def redirect_if_existing
+        return if step == 'wicked_finish'
+        return if resource.blank?
+        return if resource.try(:done?)
+        return unless resource_scope.respond_to?(:in_progress)
+
+        existing = resource_scope.in_progress.where.not(id: resource).first
+        return unless existing.present?
+
+        flash[:success] = "You have been redirected to your in-progress wizard"
+        redirect_to resource_wizard_path(existing, existing.next_step)
+      end
+
       # before_action :enforce_can_visit_step, only: [:show, :update]
       # Make sure I have permission for this step
       def enforce_can_visit_step
@@ -76,6 +90,10 @@ module Effective
         resource.ready!
       end
 
+      def clear_flash_success
+        @_delete_flash_success = true
+      end
+
     end
   end
 end

data/app/controllers/concerns/effective/wizard_controller/permitted_params.rb

@@ -0,0 +1,19 @@
+module Effective
+  module WizardController
+    module PermittedParams
+      BLACKLIST = [
+        :created_at, :updated_at,
+        :token, :slug, :price,
+        :logged_change_ids, :orders, :purchased_order_id,
+        :status, :status_steps, :wizard_steps,
+        :submitted_at, :completed_at, :reviewed_at, :approved_at, :declined_at, :purchased_at,
+        :declined_reason
+      ]
+
+      def resource_permitted_params
+        permitted_name = params.key?(effective_resource.name) ? effective_resource.name : effective_resource.resource_name
+        params.require(permitted_name).except(BLACKLIST).permit!
+      end
+    end
+  end
+end

data/app/controllers/concerns/effective/wizard_controller.rb

@@ -7,9 +7,14 @@ module Effective
 
     include Effective::WizardController::Actions
     include Effective::WizardController::BeforeActions
+    include Effective::WizardController::PermittedParams
     include Effective::WizardController::Save
     include Effective::WizardController::WickedOverrides
 
+    module ClassMethods
+      def effective_wizard_controller?; true; end
+    end
+
     included do
       raise("please install gem 'wicked' to use Effective::WizardController") unless defined?(Wicked)
 
@@ -19,10 +24,14 @@ module Effective
         before_action :assign_resource
         before_action :authorize_resource
         before_action :assign_required_steps
+
         before_action :setup_wizard # Wicked
 
         before_action :enforce_can_visit_step
 
+        before_action :redirect_if_existing, only: [:show, :new]
+        before_action :clear_flash_success, only: [:update]
+
         before_action :assign_current_step
         before_action :assign_page_title
 
@@ -38,6 +47,12 @@ module Effective
         flash[:danger] = "Unknown step. You have been moved to the #{resource_wizard_steps.first} step."
         redirect_to wizard_path(resource_wizard_steps.first)
       end
+
+      # effective_resources on save callback
+      after_action do
+        flash.clear if @_delete_flash_success
+      end
+
     end
 
     def find_wizard_resource

data/app/helpers/effective_resources_helper.rb

@@ -244,4 +244,8 @@ module EffectiveResourcesHelper
     simple_format(sanitize(value.to_s, tags: @format_resource_tags, attributes: @format_resource_atts), {}, sanitize: false)
   end
 
+  def edit_effective_wizard?
+    controller.class.try(:effective_wizard_controller?) && defined?(resource) && resource.draft?
+  end
+
 end

data/app/models/concerns/acts_as_wizard.rb

@@ -59,6 +59,12 @@ module ActsAsWizard
       wizard_step_keys()
     end
 
+    # For use in the summary partials. Does not include summary.
+    def render_steps
+      blacklist = [:start, :billing, :checkout, :submitted, :summary]
+      (required_steps - blacklist).select { |step| has_completed_step?(step) }
+    end
+
     def wizard_step_title(step)
       self.class.const_get(:WIZARD_STEPS).fetch(step)
     end
@@ -134,6 +140,11 @@ module ActsAsWizard
 
   module ClassMethods
     def acts_as_wizard?; true; end
+
+    def all_wizard_steps
+      const_get(:WIZARD_STEPS).keys
+    end
+
   end
 
 end

data/app/models/effective/after_commit.rb

@@ -28,8 +28,10 @@ module Effective
     def self.register_callback(connection:, name:, callback:)
       raise ArgumentError, "#{name} expected a block" unless callback
 
-      raise("#{name} is useless outside transaction") unless connection.transaction_open?
-      raise("#{name} is useless outside transaction") unless connection.current_transaction.joinable?
+      in_transaction = (connection.transaction_open? && connection.current_transaction.joinable?)
+
+      # Execute immediately when outside transaction
+      return callback.call unless in_transaction
 
       after_commit = Effective::AfterCommit.new("#{name}": callback)
       connection.add_transaction_record(after_commit)

data/config/effective_resources.rb

@@ -38,7 +38,7 @@ EffectiveResources.setup do |config|
   # config.parent_mailer = '::ApplicationMailer'
 
   # Default deliver method
-  # config.deliver_method = :deliver_now
+  # config.deliver_method = :deliver_later
 
   # Default layout
   # config.mailer_layout = 'effective_mailer_layout'

data/lib/effective_resources/version.rb

@@ -1,3 +1,3 @@
 module EffectiveResources
-  VERSION = '1.10.0'.freeze
+  VERSION = '1.12.1'.freeze
 end

data/lib/effective_resources.rb

@@ -36,7 +36,10 @@ module EffectiveResources
 
   # Email
   def self.deliver_method
-    config[:deliver_method] || :deliver_now
+    return config[:deliver_method] if config[:deliver_method].present?
+
+    rails = Rails.application.config
+    (rails.respond_to?(:active_job) && rails.active_job.queue_adapter) ? :deliver_later : :deliver_now
   end
 
   def self.mailer_layout
@@ -106,10 +109,6 @@ module EffectiveResources
     end
   end
 
-  def self.deliver_method
-    config = Rails.application.config
-    (config.respond_to?(:active_job) && config.active_job.queue_adapter) ? :deliver_later : :deliver_now
-  end
 
   def self.advance_date(date, business_days: 1, holidays: [:ca, :observed])
     raise('business_days must be an integer <= 365') unless business_days.kind_of?(Integer) && business_days <= 365

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_resources
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.12.1
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-24 00:00:00.000000000 Z
+date: 2022-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -145,6 +145,7 @@ files:
 - app/controllers/concerns/effective/wizard_controller.rb
 - app/controllers/concerns/effective/wizard_controller/actions.rb
 - app/controllers/concerns/effective/wizard_controller/before_actions.rb
+- app/controllers/concerns/effective/wizard_controller/permitted_params.rb
 - app/controllers/concerns/effective/wizard_controller/save.rb
 - app/controllers/concerns/effective/wizard_controller/wicked_overrides.rb
 - app/helpers/effective_acts_as_email_form_helper.rb