effective_qb_online 0.9.9 → 0.9.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9c2123d98959752c1fc3282eaed56393c472270627852362f18f481df53effb
-  data.tar.gz: 5337ce9494f3677d72d3d8b5fb95ed43612d3a1580631cc6954d0f0dbac20f83
+  metadata.gz: 78e60bd08d0c81f3aee5084c32b6276cb0c01f4e5ca7fee043451003f84e0745
+  data.tar.gz: e6e5d58197ffb083cf351f0cd4931729769a716f47d5751fbfa0a4c02134adcc
 SHA512:
-  metadata.gz: ba8008ddd33147f3cf9f793a9f8a2477ed231ba91588cbaa47246ce571b91107eff55298d4a1eef5fb28144279ee011d35c7b5fe5b0ca1680cb1eaa6a3714f26
-  data.tar.gz: 3ab35742a9bd30d10248a8a8efeaf4511c42bc9a1390283f6a5387a69ec76e95e3faeb39673e97b31065d336a5c6e8d5229597dcbfc529d13afe610661aecbc7
+  metadata.gz: 5d58050f4a1c942479d9b6ab5494de290e9e3111d0c7b46837aa321b53dbc61c032000bfef27cc32ac917e7618acfaaef18d23433a22cb4611c5a9d27817bb6d
+  data.tar.gz: 3685f8ac6b49b091dcbfd000e8aebcf8191ee7883cae82095b69013db939f5b3de2380d7aabc3c5cf5757207590c4cadfb2f224e1a112ba04f5fad2c7ac86587

data/app/models/effective/qb_receipt.rb

@@ -66,6 +66,12 @@ module Effective
         sales_receipt = Effective::QbSalesReceipt.build_from_receipt!(self, api: api)
         sales_receipt = api.create_sales_receipt(sales_receipt: sales_receipt)
 
+        # The SalesReceipt now exists in QuickBooks. Persist its id immediately so a
+        # later failure (e.g. the total sanity checks below) doesn't orphan it. Without
+        # this, a re-sync would try to create it again and QuickBooks rejects the
+        # reused DocNumber with a Duplicate Document Number Error.
+        update_column(:sales_receipt_id, sales_receipt.id)
+
         # Sanity check
         if EffectiveOrders.try(:credit_card_surcharge_qb_item_name).present? && !EffectiveOrders.try(:fee_saver?)
           if (expected = api.price_to_amount(order.total)) != sales_receipt.total

data/app/models/effective/qb_sales_receipt.rb

@@ -38,8 +38,11 @@ module Effective
       end
 
       receipt.qb_receipt_items.each do |receipt_item|
+        # The purchasable may have been deleted. When it's missing we can't auto-match
+        # the QuickBooks item from its qb_item_id/qb_item_name, so we fall back to the
+        # QbReceiptItem's item_id (mapped manually in the admin). The SalesReceipt line
+        # items are built from the OrderItem, so a missing purchasable is not fatal.
         purchasable = receipt_item.order_item.purchasable
-        raise("Expected a purchasable for Effective::OrderItem #{receipt_item.order_item.id}") unless purchasable.present?
 
         # Either of these could match
         purchasable_id_name = [
@@ -59,7 +62,7 @@ module Effective
 
         if item.blank?
           purchasable_id_name = [purchasable.try(:qb_item_id), purchasable.try(:qb_item_name)].compact
-          raise("Unknown Item #{purchasable_id_name.join(' or ')} from #{purchasable} (#{purchasable.class.name} ##{purchasable.id})")
+          raise("Unknown Item #{purchasable_id_name.join(' or ')} from #{purchasable} (#{purchasable.class.name} ##{purchasable&.id})")
         end
 
         receipt_item.update!(item_id: item.id)
@@ -162,13 +165,14 @@ module Effective
     end
 
     # Order item names may contain HTML (e.g. an EventRegistrant's "Member" badge).
-    # QuickBooks line item descriptions are plain text, so strip the markup while keeping
-    # the badge text. Convert line breaks to spaces first so adjacent text doesn't run together.
+    # QuickBooks line item descriptions are plain text, so strip the markup while keeping the badge text.
+    # <br> and &nbsp; carry spacing, so they become spaces rather than being dropped or passed through.
+    # The sanitizer re-encodes as it strips, so unescape after or a title with an & syncs as &amp;
     def self.strip_html(value)
       return value if value.blank?
 
-      text = value.to_s.gsub(/<br\s*\/?>/i, ' ')
-      ActionView::Base.full_sanitizer.sanitize(text).squish
+      text = ActionView::Base.full_sanitizer.sanitize(value.to_s.gsub(/<br\s*\/?>/i, ' '))
+      CGI.unescapeHTML(text.gsub('&nbsp;', ' ')).squish
     end
 
   end

data/lib/effective_qb_online/version.rb

@@ -1,3 +1,3 @@
 module EffectiveQbOnline
-  VERSION = '0.9.9'.freeze
+  VERSION = '0.9.11'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_qb_online
 version: !ruby/object:Gem::Version
-  version: 0.9.9
+  version: 0.9.11
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-06-18 00:00:00.000000000 Z
+date: 2026-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails