effective_qb_online 0.9.7 → 0.9.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a76e27c7de7949bc0eda143d1f54b01a24f9242df10ded427287d952758451a
-  data.tar.gz: bbd314c5c7a59814c67386a44f2e097ae71cf46759736ce2e2b3652ff0f34a7b
+  metadata.gz: e9c2123d98959752c1fc3282eaed56393c472270627852362f18f481df53effb
+  data.tar.gz: 5337ce9494f3677d72d3d8b5fb95ed43612d3a1580631cc6954d0f0dbac20f83
 SHA512:
-  metadata.gz: 108bfb5e515c03ea0fa47c0718298504718fb3d0ee63d448131fc0fdc32ddc6517facd9eb382fa8e1d3471096c54e4c0845a376ad43eb2b1d6f05f48cc49fd59
-  data.tar.gz: 43653ac4f849fe09de8bb7b06b23b458d76f514423a3f92f14fce53727f382871613afe6d85c8c534dc7c8b2138710698a3d61454b01a94fb25a13558e6d3135
+  metadata.gz: ba8008ddd33147f3cf9f793a9f8a2477ed231ba91588cbaa47246ce571b91107eff55298d4a1eef5fb28144279ee011d35c7b5fe5b0ca1680cb1eaa6a3714f26
+  data.tar.gz: 3ab35742a9bd30d10248a8a8efeaf4511c42bc9a1390283f6a5387a69ec76e95e3faeb39673e97b31065d336a5c6e8d5229597dcbfc529d13afe610661aecbc7

data/app/models/effective/qb_api.rb

@@ -79,6 +79,11 @@ module Effective
         .group_by(&:last)
     end
 
+    # Array of strings
+    def item_names
+      items_collection.values.flatten(1).map(&:first).map(&:to_s).reject(&:blank?).uniq.sort
+    end
+
     def item_html(item)
       details = [
         ("##{item.id}"),

data/app/models/effective/qb_receipt.rb

@@ -88,7 +88,7 @@ module Effective
         assign_attributes(result: 'completed successfully', sales_receipt_id: sales_receipt.id)
         complete!
       rescue => e
-        result = [e.message, ("(intuit_tid: #{e.intuit_tid})" if e.try(:intuit_tid).present?), e.backtrace.first(15)].compact.flatten.join("\n\n")
+        result = [e.message, ("(intuit_tid: #{e.intuit_tid})" if e.try(:intuit_tid).present?)].compact.join("\n\n")
         assign_attributes(result: result)
         error!
       end

data/app/models/effective/qb_receipt_item.rb

@@ -19,7 +19,7 @@ module Effective
     end
 
     def order_item_qb_name
-      item_id || order_item.purchasable.try(:qb_item_id) || order_item.purchasable.try(:qb_item_name)
+      item_id.presence || order_item.purchasable.try(:qb_item_id) || order_item.purchasable.try(:qb_item_name)
     end
 
   end

data/app/models/effective/qb_sales_receipt.rb

@@ -100,7 +100,7 @@ module Effective
 
       receipt.qb_receipt_items.each do |receipt_item|
         order_item = receipt_item.order_item
-        line_item = Quickbooks::Model::Line.new(amount: api.price_to_amount(order_item.subtotal), description: order_item.name)
+        line_item = Quickbooks::Model::Line.new(amount: api.price_to_amount(order_item.subtotal), description: strip_html(order_item.name))
 
         line_item.sales_item! do |line|
           line.item_id = receipt_item.item_id
@@ -161,5 +161,15 @@ module Effective
       value.to_s.downcase.strip
     end
 
+    # Order item names may contain HTML (e.g. an EventRegistrant's "Member" badge).
+    # QuickBooks line item descriptions are plain text, so strip the markup while keeping
+    # the badge text. Convert line breaks to spaces first so adjacent text doesn't run together.
+    def self.strip_html(value)
+      return value if value.blank?
+
+      text = value.to_s.gsub(/<br\s*\/?>/i, ' ')
+      ActionView::Base.full_sanitizer.sanitize(text).squish
+    end
+
   end
 end

data/app/views/admin/qb_receipts/_form.html.haml

@@ -28,7 +28,7 @@
         = f.fields_for :qb_receipt_items do |fi|
           %tr
             %td= fi.object.order_item_id
-            %td= fi.object.order_item
+            %td= fi.object.order_item.to_s.html_safe
             %td
               - if fi.object.item_id.present?
                 - existing = items.find { |(name, id)| id == fi.object.item_id }&.first

data/app/views/effective/qb_online_mailer/sync_error.html.haml

@@ -12,7 +12,7 @@
   = @order.billing_name
 %p
   - @order.order_items.each do |oi|
-    = "#{oi.name} (#{oi.try(:qb_item_name)})"
+    = oi.to_s.html_safe
     %br
 
 %p

data/lib/effective_qb_online/version.rb

@@ -1,3 +1,3 @@
 module EffectiveQbOnline
-  VERSION = '0.9.7'.freeze
+  VERSION = '0.9.9'.freeze
 end

data/lib/effective_qb_online.rb

@@ -61,4 +61,28 @@ module EffectiveQbOnline
     qb_receipt.skip!
   end
 
+  # Syncs the QuickBooks Online item names down into Effective::ItemName
+  def self.sync_item_names!
+    client = api()
+    raise 'expected a connected QuickBooks Online realm' if client.blank?
+
+    qb_item_names = client.item_names
+    raise 'QuickBooks Online returned no items' if qb_item_names.blank?
+
+    qb_item_names.each do |name|
+      item_name = Effective::ItemName.where(name: name).first_or_initialize
+
+      if item_name.new_record?
+        item_name.save!
+      elsif item_name.archived?
+        item_name.unarchive!
+      end
+    end
+
+    Effective::ItemName.unarchived.where.not(name: qb_item_names).find_each do |item_name|
+      item_name.archive!
+    end
+
+    true
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_qb_online
 version: !ruby/object:Gem::Version
-  version: 0.9.7
+  version: 0.9.9
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-03-13 00:00:00.000000000 Z
+date: 2026-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails