effective_qb_online 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d0a57f6214297b86608b3cddc41885a14093371ccf8246471177e83adca31c93
-  data.tar.gz: e5035d9267de8cf24a5ce0431a051e41621797b2c9ffbbdebade41f07b324d1a
+  metadata.gz: 57216dcf3ae7c167d41dad7c56b0f6f625b428646efccfe7d3c03149377276f3
+  data.tar.gz: 8a6174d2268d4301a432a52b1dac6ff0fce077f7e3eb830b42899a17a5d810e8
 SHA512:
-  metadata.gz: d69dbad553ff14cd2e1cc75e32b25f39f0b900afafc8197a4efd43ddc718eb2df7e6df455b93aca8d44ff964654eacdc77195f2324a8b0882f1a72aa49b116e5
-  data.tar.gz: c855c58edfb05b3b1bd767b9a92fa40f9f281e1c98ba3c484e33d74bb2f6175f208954fdd66d61dd3e414b539ca0c586c2a3540a5243e886a674921eb7470bcb
+  metadata.gz: dd06c85052e13213874e0e70d6830b35b2e3f6c34f670eb289e0d2ac0ab712b24b47fd1f9eee199d61c6c1e8250d5f3c74ac676204cc2bf1856d65e5b70db945
+  data.tar.gz: e6d6c68c7354f14b8bd951d6f203e6a4e1f2ab9901f1f58b790004da95a2ec95bbff6de9f89c3666c0e6a16c19b2a6d0c8223ff32ff1dff582a1d4aedd2664a1

data/app/models/effective/qb_api.rb

@@ -97,36 +97,30 @@ module Effective
       payment_methods.sort_by(&:name).map { |payment_method| [payment_method.name, payment_method.id] }
     end
 
-    def find_or_create_customer(user:)
-      find_customer(user: user) || create_customer(user: user)
+    def find_or_create_customer(order:)
+      find_customer(order: order) || create_customer(order: order)
     end
 
-    def find_customer(user:)
-      raise('expected a user that responds to email') unless user.respond_to?(:email)
+    def find_customer(order:)
+      raise('expected an Effective::Order') unless order.kind_of?(Effective::Order)
 
       with_service('Customer') do |service|
         # Find by email
-        customer = service.find_by(:PrimaryEmailAddr, user.email)&.first
-
-        # Find by given name and family name
-        customer ||= if user.respond_to?(:first_name) && user.respond_to?(:last_name)
-          service.query("SELECT * FROM Customer WHERE GivenName LIKE '#{scrub(user.first_name, sql: true)}' AND FamilyName LIKE '#{scrub(user.last_name, sql: true)}'")&.first
-        end
+        customer = service.find_by(:PrimaryEmailAddr, order.email)&.first
 
         # Find by display name
-        customer || service.find_by(:display_name, scrub(user.to_s))&.first
+        customer || service.find_by(:display_name, scrub(order.billing_name))&.first
       end
     end
 
-    def create_customer(user:)
-      raise('expected a user that responds to email') unless user.respond_to?(:email)
+    # https://developer.intuit.com/app/developer/qbo/docs/api/accounting/all-entities/customer#create-a-customer
+    def create_customer(order:)
+      raise('expected an Effective::Order') unless order.kind_of?(Effective::Order)
 
       with_service('Customer') do |service|
         customer = Quickbooks::Model::Customer.new(
-          primary_email_address: Quickbooks::Model::EmailAddress.new(user.email),
-          display_name: scrub(user.to_s),
-          given_name: scrub(user.try(:first_name)),
-          family_name: scrub(user.try(:last_name))
+          primary_email_address: Quickbooks::Model::EmailAddress.new(order.email),
+          display_name: scrub(order.billing_name)
         )
 
         service.create(customer)

data/app/models/effective/qb_sales_receipt.rb

@@ -68,7 +68,7 @@ module Effective
 
       # Find or build customer
       if receipt.customer_id.blank?
-        customer = api.find_or_create_customer(user: user)
+        customer = api.find_or_create_customer(order: order)
         receipt.update!(customer_id: customer.id)
       end
 

data/lib/effective_qb_online/version.rb

@@ -1,3 +1,3 @@
 module EffectiveQbOnline
-  VERSION = '0.4.0'.freeze
+  VERSION = '0.5.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_qb_online
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-24 00:00:00.000000000 Z
+date: 2023-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails