effective_qb_online 0.3.6 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af4c52461f0378d8b68ce63a75523a729b94ff217279a2e5c3f4f38f842bc470
-  data.tar.gz: 9188a00558f0c1eb254f91c7a95e69f9aacdff13d61617cd7e8eb8767f679b0f
+  metadata.gz: 57216dcf3ae7c167d41dad7c56b0f6f625b428646efccfe7d3c03149377276f3
+  data.tar.gz: 8a6174d2268d4301a432a52b1dac6ff0fce077f7e3eb830b42899a17a5d810e8
 SHA512:
-  metadata.gz: 1dfb6a10786272862f188f6b15d5dc864cb3d5e7b2582818b6629f0d9d86aa416046cbb4cd07b4bc526c4e38aae4641adede2d01289d7dca21290da551ff17e5
-  data.tar.gz: bd9bedd6b1dfb1c10de29e37cc6ce122eb6b2d499de34def2c0796eac6d01cef63c71c4082cb3b9616b1df626fdac1169186cf82ef1eb30e3a245232baae6c95
+  metadata.gz: dd06c85052e13213874e0e70d6830b35b2e3f6c34f670eb289e0d2ac0ab712b24b47fd1f9eee199d61c6c1e8250d5f3c74ac676204cc2bf1856d65e5b70db945
+  data.tar.gz: e6d6c68c7354f14b8bd951d6f203e6a4e1f2ab9901f1f58b790004da95a2ec95bbff6de9f89c3666c0e6a16c19b2a6d0c8223ff32ff1dff582a1d4aedd2664a1

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2022 Code and Effect Inc.
+Copyright 2023 Code and Effect Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/app/models/effective/qb_api.rb

@@ -97,36 +97,30 @@ module Effective
       payment_methods.sort_by(&:name).map { |payment_method| [payment_method.name, payment_method.id] }
     end
 
-    def find_or_create_customer(user:)
-      find_customer(user: user) || create_customer(user: user)
+    def find_or_create_customer(order:)
+      find_customer(order: order) || create_customer(order: order)
     end
 
-    def find_customer(user:)
-      raise('expected a user that responds to email') unless user.respond_to?(:email)
+    def find_customer(order:)
+      raise('expected an Effective::Order') unless order.kind_of?(Effective::Order)
 
       with_service('Customer') do |service|
         # Find by email
-        customer = service.find_by(:PrimaryEmailAddr, user.email)&.first
-
-        # Find by given name and family name
-        customer ||= if user.respond_to?(:first_name) && user.respond_to?(:last_name)
-          service.query("SELECT * FROM Customer WHERE GivenName LIKE '#{scrub(user.first_name, sql: true)}' AND FamilyName LIKE '#{scrub(user.last_name, sql: true)}'")&.first
-        end
+        customer = service.find_by(:PrimaryEmailAddr, order.email)&.first
 
         # Find by display name
-        customer || service.find_by(:display_name, scrub(user.to_s))&.first
+        customer || service.find_by(:display_name, scrub(order.billing_name))&.first
       end
     end
 
-    def create_customer(user:)
-      raise('expected a user that responds to email') unless user.respond_to?(:email)
+    # https://developer.intuit.com/app/developer/qbo/docs/api/accounting/all-entities/customer#create-a-customer
+    def create_customer(order:)
+      raise('expected an Effective::Order') unless order.kind_of?(Effective::Order)
 
       with_service('Customer') do |service|
         customer = Quickbooks::Model::Customer.new(
-          primary_email_address: Quickbooks::Model::EmailAddress.new(user.email),
-          display_name: scrub(user.to_s),
-          given_name: scrub(user.try(:first_name)),
-          family_name: scrub(user.try(:last_name))
+          primary_email_address: Quickbooks::Model::EmailAddress.new(order.email),
+          display_name: scrub(order.billing_name)
         )
 
         service.create(customer)

data/app/models/effective/qb_sales_receipt.rb

@@ -68,7 +68,7 @@ module Effective
 
       # Find or build customer
       if receipt.customer_id.blank?
-        customer = api.find_or_create_customer(user: user)
+        customer = api.find_or_create_customer(order: order)
         receipt.update!(customer_id: customer.id)
       end
 

data/config/effective_qb_online.rb

@@ -1,8 +1,4 @@
 EffectiveQbOnline.setup do |config|
-  config.qb_realms_table_name = :qb_realms
-  config.qb_receipts_table_name = :qb_receipts
-  config.qb_receipt_items_table_name = :qb_receipt_items
-
   # Layout Settings
   # Configure the Layout per controller, or all at once
   # config.layout = { application: 'application', admin: 'admin' }

data/db/migrate/{01_create_effective_qb_online.rb.erb → 101_create_effective_qb_online.rb}

@@ -1,6 +1,6 @@
-class CreateEffectiveQbOnline < ActiveRecord::Migration[6.1]
+class CreateEffectiveQbOnline < ActiveRecord::Migration[6.0]
   def change
-    create_table <%= @qb_realms_table_name %> do |t|
+    create_table :qb_realms do |t|
       t.string :realm_id
 
       t.integer :deposit_to_account_id
@@ -15,7 +15,7 @@ class CreateEffectiveQbOnline < ActiveRecord::Migration[6.1]
       t.timestamps
     end
 
-    create_table <%= @qb_receipts_table_name %> do |t|
+    create_table :qb_receipts do |t|
       t.integer :order_id
       t.integer :customer_id
 
@@ -27,9 +27,9 @@ class CreateEffectiveQbOnline < ActiveRecord::Migration[6.1]
       t.timestamps
     end
 
-    add_index <%= @qb_receipts_table_name %>, :order_id
+    add_index :qb_receipts, :order_id
 
-    create_table <%= @qb_receipt_items_name %> do |t|
+    create_table :qb_receipt_items_name do |t|
       t.integer :qb_receipt_id
       t.integer :order_item_id
 

data/lib/effective_qb_online/version.rb

@@ -1,3 +1,3 @@
 module EffectiveQbOnline
-  VERSION = '0.3.6'.freeze
+  VERSION = '0.5.0'.freeze
 end

data/lib/generators/effective_qb_online/install_generator.rb

@@ -20,11 +20,7 @@ module EffectiveQbOnline
       end
 
       def create_migration_file
-        @qb_realms_table_name  = ':' + EffectiveQbOnline.qb_realms_table_name.to_s
-        @qb_receipts_table_name  = ':' + EffectiveQbOnline.qb_receipts_table_name.to_s
-        @qb_receipt_items_table_name  = ':' + EffectiveQbOnline.qb_receipt_items_table_name.to_s
-
-        migration_template ('../' * 3) + 'db/migrate/01_create_effective_qb_online.rb.erb', 'db/migrate/create_effective_qb_online.rb'
+        migration_template ('../' * 3) + 'db/migrate/101_create_effective_qb_online.rb', 'db/migrate/create_effective_qb_online.rb'
       end
 
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_qb_online
 version: !ruby/object:Gem::Version
-  version: 0.3.6
+  version: 0.5.0
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-23 00:00:00.000000000 Z
+date: 2023-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -137,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: haml-rails
+  name: haml
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -231,7 +231,7 @@ files:
 - app/views/admin/qb_receipts/new.html.haml
 - config/effective_qb_online.rb
 - config/routes.rb
-- db/migrate/01_create_effective_qb_online.rb.erb
+- db/migrate/101_create_effective_qb_online.rb
 - db/seeds.rb
 - lib/effective_qb_online.rb
 - lib/effective_qb_online/engine.rb
@@ -258,7 +258,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Create QuickBooks Online SalesReceipts for purchased effective orders