effective_products 0.3.7 → 0.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b339a0aac52ca7f1cb0723ea8807061a5bfe58a593b735cb7fd3963fbb3b365
-  data.tar.gz: 11bb3d70210a7cd213440f95f758cc9219de554d1610fbea2393124150a5d48b
+  metadata.gz: 8126cdc9fd87848c7da280fb0e2ecc23cd4c83beb1f5efbb07aa2b0d7ebdbb1f
+  data.tar.gz: 71481f64c82b4a422bfc7b348e286cf8099c50adf6b897774e3a4ea76890f43e
 SHA512:
-  metadata.gz: 4b6b20349a62da271c83a550ef954134b5e7b5f4ba38e2fc4cdbe79f2553c577470968b294cf39f9894c5e20ed2e0a07ddff8dc06da3265010d9f2258ebb185e
-  data.tar.gz: 26b65e114b40e52abcb62d7153c6f95b3bcc7c8dfc52259a8227353f0a4af8c51947ff50d11741525d41b773c75dfbcf91767d0be0829f741f03e82070fb2260
+  metadata.gz: b4c894fff91b9dc09933d3ed0d461c7698f33f5f8f45ed964ec07d622a7a78bf42650cc9a283522984f7a6e1df7bb705ea3a4fed4310ada9c6828128c688e753
+  data.tar.gz: 36ebdab52e77a293f8f5905a6cb1b0a531442bdb5f7303d57937c452d09a0fd650663c6a5042f19f50271a8c816312391a9b5ae124ebf3696b4da08d7c28fb03

data/app/models/effective/stamp.rb

@@ -72,15 +72,15 @@ module Effective
     validates :shipping_address, presence: true, unless: -> { category == 'Digital-only' }
 
     validate(if: -> { name.present? && name_confirmation.present? }) do
-      self.errors.add(:name_confirmation, "doesn't match name") unless name == name_confirmation
+      errors.add(:name_confirmation, "doesn't match name") unless name == name_confirmation
     end
 
     validate(if: -> { category.present? }) do
-      self.errors.add(:category, "is not included") unless EffectiveProducts.stamp_categories.include?(category)
+      errors.add(:category, "is not included") unless EffectiveProducts.stamp_categories.include?(category)
     end
 
     validate(if: -> { admin_action }) do
-      self.errors.add(:owner_id, "must have a membership") unless owner && owner.try(:membership).present?
+      errors.add(:owner_id, "must have a membership") unless owner && owner.try(:membership).present?
     end
 
     def to_s
@@ -114,19 +114,25 @@ module Effective
 
     # This is the Admin Save and Mark Paid action
     def mark_paid!
-      update!(admin_action: true) # Make sure we have an owner with a membership
-      raise('expected an user with a membership category') unless owner && owner.try(:membership).present?
+      assign_attributes(admin_action: true)
 
-      category = owner.membership.categories.first
+      category = owner&.membership&.categories&.first
 
-      assign_attributes(
-        price: category.stamp_fee,
-        tax_exempt: category.stamp_fee_tax_exempt,
-        qb_item_name: category.stamp_fee_qb_item_name
-      )
+      if category.present?
+        assign_attributes(
+          price: category.stamp_fee,
+          tax_exempt: category.stamp_fee_tax_exempt,
+          qb_item_name: category.stamp_fee_qb_item_name
+        )
+      end
 
-      submitted!
-      Effective::Order.new(items: self, user: owner).mark_as_purchased!
+      submitted! # Will fail with invalid owner membership anyway
+
+      if category.present?
+        Effective::Order.new(items: self, user: owner).mark_as_purchased!
+      end
+
+      true
     end
 
   end

data/app/views/effective/stamps/_fields.html.haml

@@ -5,11 +5,7 @@
 = f.text_field :name_confirmation, hint: 'must match name'
 
 - collection = local_assigns[:parent].try(:stamp_categories) || EffectiveProducts.stamp_categories
-
-- if collection.length == 1
-  = f.hidden_field :category, value: collection.first
-- else
-  = f.select :category, collection
+= f.select :category, collection
 
 %h4 Shipping address
 = effective_address_fields(f, :shipping)

data/lib/effective_products/version.rb

@@ -1,3 +1,3 @@
 module EffectiveProducts
-  VERSION = '0.3.7'.freeze
+  VERSION = '0.3.8'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_products
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.3.8
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-15 00:00:00.000000000 Z
+date: 2024-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails