effective_posts 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7fa99747e0baf6c175224b5d3ce645964ac5592137857a6cb28ae6d17687146
-  data.tar.gz: 277fa3f03c1411d810f0dc09663f4deb6bb2be2c1a890cbf7cc88bc9d6b0bd9e
+  metadata.gz: 8aa5788677bbc314a5bf40d373e1d8fcd3ec888fcff06ceb309dc28b027304db
+  data.tar.gz: bc87d5b89781c026ee5db81ee123aeefbf5de29e8bd65c102e282c362b38ae2b
 SHA512:
-  metadata.gz: efce23b1c3b45e66acbe5d5b055e114a7baa09add399a29a4a76074c2be854b46565deb2dfc3e9bd3f9559b6e6ec8c51a0fcb66f184c278f8edd8fed10578d18
-  data.tar.gz: 2422db33dc37d6d3f39b3b206c7ea77cf0238a3c9194b44c7b4335058e870e1082449027bab23b71e46177c36e62d697a704359e3fecf7891c7921eef2a000fa
+  metadata.gz: 175315b793aa0e096a29a20b66e568c93812ae804156e4c2bd169fa28ad20084041e0058f238fea7c063f87093d7f2e74330a2a15a10e47712470649ee7546b0
+  data.tar.gz: 2dc2137a2e10ec1c63e0cfbcfb63c92ee8b045568f8acb2ac991b7888eba0b4242ed7f9188f1c76cbd1b67ea4c423ada138798c02c85d47af7448bbf9eb98b07

data/README.md

@@ -85,54 +85,7 @@ The per_page for posts may be configured via the `/app/config/initializers/effec
 
 ## Authorization
 
-All authorization checks are handled via the config.authorization_method found in the `app/config/initializers/effective_posts.rb` file.
-
-It is intended for flow through to CanCan or Pundit, but neither of those gems are required.
-
-This method is called by all controller actions with the appropriate action and resource
-
-Action will be one of [:index, :show, :new, :create, :edit, :update, :destroy]
-
-Resource will the appropriate Effective::Post object or class
-
-The authorization method is defined in the initializer file:
-
-```ruby
-# As a Proc (with CanCan)
-config.authorization_method = Proc.new { |controller, action, resource| authorize!(action, resource) }
-```
-
-```ruby
-# As a Custom Method
-config.authorization_method = :my_authorization_method
-```
-
-and then in your application_controller.rb:
-
-```ruby
-def my_authorization_method(action, resource)
-  current_user.is?(:admin) || EffectivePunditPolicy.new(current_user, resource).send('#{action}?')
-end
-```
-
-or disabled entirely:
-
-```ruby
-config.authorization_method = false
-```
-
-If the method or proc returns false (user is not authorized) an Effective::AccessDenied exception will be raised
-
-You can rescue from this exception by adding the following to your application_controller.rb:
-
-```ruby
-rescue_from Effective::AccessDenied do |exception|
-  respond_to do |format|
-    format.html { render 'static_pages/access_denied', :status => 403 }
-    format.any { render :text => 'Access Denied', :status => 403 }
-  end
-end
-```
+All authorization checks are handled via the effective_resources gem found in the `config/initializers/effective_resources.rb` file.
 
 ### Permissions
 
@@ -155,7 +108,6 @@ There are some obvious additional features that have yet to be implemented:
 - Some kind of helper for displaying a sidebar for the categories
 - Post archives and date filtering
 
-
 ## License
 
 MIT License.  Copyright [Code and Effect Inc.](http://www.codeandeffect.com/)

data/app/helpers/effective_posts_helper.rb

@@ -61,8 +61,8 @@ module EffectivePostsHelper
   def post_meta(post, date: true, datetime: false, category: true, author: true)
     [
       'Published',
-      ("on #{post.published_at.strftime('%B %d, %Y')}" if date),
-      ("on #{post.published_at.strftime('%B %d, %Y at %l:%M %p')}" if datetime),
+      ("on #{post.published_at.strftime('%B %d, %Y')}" if date && post.published_at),
+      ("on #{post.published_at.strftime('%B %d, %Y at %l:%M %p')}" if datetime && post.published_at),
       ("to #{link_to_post_category(post.category)}" if category && Array(EffectivePosts.categories).length > 1),
       ("by #{post.user.to_s.presence || 'Unknown'}" if author && EffectivePosts.post_meta_author && post.user.present?)
     ].compact.join(' ').html_safe

data/app/models/effective/post.rb

@@ -47,7 +47,7 @@ module Effective
     validates :title, presence: true, length: { maximum: 255 }
     validates :description, presence: true, length: { maximum: 150 }
     validates :category, presence: true
-    validates :published_at, presence: true
+    validates :published_at, presence: true, unless: -> { draft? }
 
     validates :start_at, presence: true, if: -> { category == 'events' }
 
@@ -107,7 +107,7 @@ module Effective
     end
 
     def send_post_submitted_to_admin!
-      deliver_method = EffectivePosts.mailer[:deliver_method] || raise('expected an EffectivePosts.deliver_method')
+      deliver_method = EffectivePosts.mailer[:deliver_method] || EffectiveResources.deliver_method
       Effective::PostsMailer.post_submitted_to_admin(to_param).send(deliver_method)
     end
 

data/config/routes.rb

@@ -1,38 +1,35 @@
 EffectivePosts::Engine.routes.draw do
   namespace :admin do
     resources :posts, except: [:show] do
-      if EffectivePosts.submissions_enabled && EffectivePosts.submissions_require_approval
-        post :approve, on: :member
-      end
+      post :approve, on: :member
     end
-
-    match 'posts/excerpts', to: 'posts#excerpts', via: :get
   end
 
   scope module: 'effective' do
-    categories = Array(EffectivePosts.categories).map { |cat| cat.to_s unless cat == 'posts'}.compact
-    onlies = ([:index, :show] unless EffectivePosts.submissions_enabled)
+    # Post Routes
+    resources :posts
 
-    if EffectivePosts.use_blog_routes
-      categories.each do |category|
-        match "blog/category/#{category}", to: 'posts#index', via: :get, defaults: { category: category }
-      end
+    # Blog Routes
+    match 'blog/category/:category', to: 'posts#index', via: :get, constraints: lambda { |req|
+      EffectivePosts.use_blog_routes && EffectivePosts.categories.include?(req.params['category'].to_sym)
+    }
 
-      resources :posts, only: onlies, path: 'blog'
-    elsif EffectivePosts.use_category_routes
-      categories.each do |category|
-        match category, to: 'posts#index', via: :get, defaults: { category: category }
-        match "#{category}/:id", to: 'posts#show', via: :get, defaults: { category: category }
-      end
+    resources :posts, only: [:index, :show], path: 'blog', constraints: lambda { |req|
+      EffectivePosts.use_blog_routes
+    }
 
-      resources :posts, only: onlies
-    else
-      resources :posts, only: onlies
-    end
+    # Category routes
+    match ':category', to: 'posts#index', via: :get, constraints: lambda { |req|
+      EffectivePosts.use_category_routes && EffectivePosts.categories.include?(req.params['category'].to_sym)
+    }
+
+    match ":category/:id", to: 'posts#show', via: :get, constraints: lambda { |req|
+      EffectivePosts.use_category_routes && EffectivePosts.categories.include?(req.params['category'].to_sym)
+    }
   end
 
 end
 
 Rails.application.routes.draw do
-  mount EffectivePosts::Engine => '/', :as => 'effective_posts'
+  mount EffectivePosts::Engine => '/', as: 'effective_posts'
 end

data/lib/effective_posts.rb

@@ -1,4 +1,3 @@
-require 'effective_datatables'
 require 'effective_resources'
 require 'effective_posts/engine'
 require 'effective_posts/version'

data/lib/effective_posts/version.rb

@@ -1,3 +1,3 @@
 module EffectivePosts
-  VERSION = '2.0.1'.freeze
+  VERSION = '2.0.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_posts
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-23 00:00:00.000000000 Z
+date: 2021-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails