effective_pages 3.8.4 → 3.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab2014d3e00b7e610f9e4bbb783dc853d5eeb5a5c51215266d37c42d6435d453
-  data.tar.gz: 59c5957db1af495169511e34bd2b77b9da60574d16d8fabcde374738429c55eb
+  metadata.gz: de13a6ce9afb0cee9e8401e076c3416a159f9a64f4a5fb7cf70c890de442263f
+  data.tar.gz: dfa2b67769948a6e25c5c20e3b1520260f494d0722165cfd5a78eeff1aeb3ce8
 SHA512:
-  metadata.gz: 71d6ef9905b0426c44b791e6422b6784e395bd776d3a346fee1609931769b5e9e2f2b5f63b5240e643d763394d6624ebf8089f5d59bb45d7f25f85071a1c74a7
-  data.tar.gz: 8d07252b5ba59072c8f078f394260da1ab6bd5b874f1ec9543f247c66528760b729a22c7cab542b66dbee7a402f64db929fc08ebf5baebfbe15deb1caa8f2eaa
+  metadata.gz: 11295b2af4904ad5469948123e4e910302fa4e3d7c29a79b55bd4500b7456f458e31f5f389c587725a7d534a21c4e138daff27b525fae74d874c8344948cd1d7
+  data.tar.gz: 5e2bbcef490e3b25c6ba565fd64fab7ee4a7091377fef64ca664a4be1edfa54d64b0810c2b5005a7e33e63c04e54ff65f2955c5e705f5ec9e03bb39ff513c654

data/README.md

@@ -6,6 +6,33 @@ Create content pages ontop of one or more templates -- just regular Rails views
 
 Use this gem to create a fully-functional CMS that provides full or restricted editing for your end users.
 
+## Upgrading to 3.9.0
+
+Add a migration
+
+```
+class UpgradeEffectivePagesThreeNine < ActiveRecord::Migration[7.0]
+  def change
+    # Add a counter cache
+    add_column :pages, :menu_children_count, :integer, default: 0
+  end
+end
+```
+
+Run a one time script
+
+```
+# rake upgrade_effective_pages_to_three_nine
+task upgrade_effective_pages_to_three_nine: :environment do
+  puts "Starting effective pages 3.9.0 upgrade"
+
+  Effective::Page.where(menu_children_count: 0).find_each do |page|
+    Effective::Page.reset_counters(page.slug, :menu_children)
+  end
+
+  puts 'All done'
+end
+```
 
 ## effective_pages 3.0
 

data/app/datatables/effective_pages_menu_datatable.rb

@@ -14,6 +14,8 @@ class EffectivePagesMenuDatatable < Effective::Datatable
     col :menu_url, label: 'Redirect Url'
     col :menu_position, label: 'Position', visible: false
 
+    col :menu_children_count, label: 'Children Count', visible: false
+
     # We only support depth 2 and 3.
     col :menu_children, label: 'Children' do |page|
       page.menu_children.group_by { |child| child.menu_group.presence }.values.flatten.map do |child|

data/app/helpers/effective_menus_helper.rb

@@ -28,8 +28,6 @@ module EffectiveMenusHelper
       (
         [content_tag(:li, link_to(root, root_path, title: root), class: 'breadcrumb-item')] +
         parents.map do |page|
-          page.try(:strict_loading!, false)
-
           next if page.menu_root_with_children? # Don't show root pages because they have no content
 
           url = (page.menu_url.presence || effective_pages.page_path(page))
@@ -62,7 +60,7 @@ module EffectiveMenusHelper
   def admin_menu_parent_collection(page = nil)
     raise('expected a page') if page.present? && !page.kind_of?(Effective::Page)
 
-    pages = Effective::Page.deep.menuable.root_level.where.not(id: page)
+    pages = Effective::Page.deep_menuable.menuable.root_level.where.not(id: page)
 
     if EffectivePages.max_menu_depth == 2
       # You can only select root level pages

data/app/models/effective/page.rb

@@ -14,7 +14,7 @@ module Effective
     belongs_to :page_banner, optional: true
 
     # These parent / children are for the menu as well
-    belongs_to :menu_parent, class_name: 'Effective::Page', optional: true
+    belongs_to :menu_parent, class_name: 'Effective::Page', optional: true, touch: true, counter_cache: :menu_children_count
 
     has_many :menu_children, -> { Effective::Page.menuable }, class_name: 'Effective::Page',
       foreign_key: :menu_parent_id, inverse_of: :menu_parent
@@ -47,6 +47,8 @@ module Effective
       menu_url          :string         # Redirect to this url instead of the page url
       menu_position     :integer        # Position in the menu
 
+      menu_children_count :integer      # Counter cache
+
       # Banners
       banner            :boolean        # Should we display a banner?
       banner_random     :boolean        # Display a random banner
@@ -59,11 +61,14 @@ module Effective
     end
 
     scope :deep, -> { 
-      base = includes(:page_banner, :tags, :rich_texts, :menu_parent, menu_children: [:menu_parent, :menu_children]) 
+      base = includes(:page_banner, :tags, :rich_texts) 
+      base = base.deep_menuable
       base = base.includes(:pg_search_document) if defined?(PgSearch)
       base
     }
 
+    scope :deep_menuable, -> { includes(:menu_parent, menu_children: [:menu_parent, :menu_children]) }
+
     scope :draft, -> { where(draft: true) }
     scope :published, -> { where(draft: false) }
     scope :sorted, -> { order(:title) }
@@ -186,13 +191,21 @@ module Effective
     end
 
     def menu_parent?
-      menu? && menu_children.to_a.present?
+      menu? && menu_children_present?
     end
 
     def menu_child?
       menu? && menu_parent_id.present?
     end
 
+    def menu_children_present?
+      menu_children_count > 0
+    end
+
+    def menu_children_blank?
+      menu_children_count <= 0
+    end
+
   end
 
 end

data/app/views/effective/pages/_menu.html.haml

@@ -7,14 +7,11 @@
   - next if (page.authenticate_user || page.roles.present?) && current_user.blank?
   - next if page.roles.present? && (current_user.roles & page.roles).blank?
 
-  - menu_children = page.menu_children
-
-  - if menu_children.blank?
+  - if page.menu_children_blank?
     = nav_link_to(page.menu_to_s, (page.menu_url.presence || effective_pages.page_path(page)))
-
-  - if menu_children.present?
+  - else
     = nav_dropdown(page.menu_to_s, groups: true) do
-      - menu_children.group_by { |menu| menu.menu_group.presence }.each do |menu_group, pages|
+      - page.menu_children.group_by { |menu| menu.menu_group.presence }.each do |menu_group, pages|
         = nav_dropdown_group(menu_group || '') do
           - pages.each do |page|
             - next unless EffectiveResources.authorized?(self, :show, page)

data/app/views/effective/pages/_page_menu.html.haml

@@ -1,15 +1,15 @@
 - raise('expected a page') unless page.present?
 
-- children = page.menu_children
+- children = []
 
-- if page.menu_children.present?
+- if page.menu_children_present?
+  - children = page.menu_children
   = nav_link_to(page.menu_to_s, (page.menu_url.presence || effective_pages.page_path(page)))
 
 - # if this is a third depth page, show the parent and siblings
-- if page.menu_children.blank? && page.menu_parent.try(:menu_parent_id).present?
-  - page.menu_parent.try(:strict_loading!, false)
-
-  - if page.menu_parent.menu_children.present?
+- if page.menu_children_blank? && page.menu_parent.try(:menu_parent_id).present?
+  - if page.menu_parent.menu_children_present?
+    - page.menu_parent.try(:strict_loading!, false)
     - children = page.menu_parent.menu_children
     = nav_link_to(page.menu_parent.menu_to_s, (page.menu_parent.menu_url.presence || effective_pages.page_path(page.menu_parent)))
 

data/db/migrate/101_create_effective_pages.rb

@@ -27,6 +27,8 @@ class CreateEffectivePages < ActiveRecord::Migration[6.0]
       t.string :menu_url
       t.integer :menu_position
 
+      t.integer :menu_children_count, default: 0
+
       t.boolean :banner, default: false
       t.boolean :banner_random, default: false
 

data/lib/effective_pages/version.rb

@@ -1,3 +1,3 @@
 module EffectivePages
-  VERSION = '3.8.4'.freeze
+  VERSION = '3.9.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: effective_pages
 version: !ruby/object:Gem::Version
-  version: 3.8.4
+  version: 3.9.0
 platform: ruby
 authors:
 - Code and Effect