effective_orders 6.29.0 → 6.29.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d996e08b837f4c718389356de10e99bb96f9e4c700610dfc52e4f0073ff6ca93
-  data.tar.gz: 504220bd762a516da3a315e67ffd7c768aea2ce39e3d83971b952d05e2bcb86f
+  metadata.gz: d2ed83ebfbf108715d418f71ba4e4328f921e7c25bf1089bf14088273423e10a
+  data.tar.gz: 1d425c694ceb2941600bf6645e78375eb094dd9ca243f20c50f5385c6ead6d83
 SHA512:
-  metadata.gz: 7adf267def1cc4485468a2adc96b0d41260f9f7202f77969486e406095ed87f84cbaa8599284c7944d25ddc7aab28e2160a47bfd97e95cfcd9a4604300223913
-  data.tar.gz: 929ac92776551b457655800a81bd5ec684a3bac710284fddc2827cfdd7c50be84e6c0a2380758d9badfb50a7da0170072edc560c419ceb825983db7cd4a5b28a
+  metadata.gz: 939643e123d27170b05fa68b00d3e5a90f774bbe4ea46ffc38fa76d080e123f315d36360ad947146d993b9a790c1fd3fcd7e7ed987a31ba5e10e7bf1941144f1
+  data.tar.gz: d0ba5224ba9c2e787df3c1197f5e25082418fbdf1037260c09c724530b3ad32cfc5666b21de515bc99714b846d2311771fc23dcec9a5bcd24b6191a16f634f3d

data/app/models/effective/helcim_api.rb

@@ -26,10 +26,14 @@ module Effective
       get('/connection-test')
     end
 
-    def get_transaction(id)
+    def get_card_transaction(id)
       get("/card-transactions/#{id}")
     end
 
+    def get_ach_transaction(id)
+      get("/ach/transactions/#{id}").try(:dig, 'transaction')
+    end
+
     # Make the Preload Request
     # https://devdocs.helcim.com/reference/checkout-init
     def initialize_request(order)
@@ -110,6 +114,7 @@ module Effective
     end
 
     # Decode the base64 encoded JSON object that was given from the form into a Hash
+    # For a card transaction
     # {"transactionId"=>"38142732",
     # "dateCreated"=>"2025-08-15 10:10:32",
     # "cardBatchId"=>"4656307",
@@ -126,9 +131,24 @@ module Effective
     # "customerCode"=>"CST1022",
     # "invoiceNumber"=>"#30",
     # "warning"=>""}
+    #
+    # For an ACH transaction
+    # {"transactionId"=>"12345",
+    # "batchId"=>"168333,
+    # "dateCreated"=>"2025-10-10 11:48:47",
+    # "statusAuth"=>"APPROVED",
+    # "statusClearing"=>"OPENED",
+    # "type"=>"WITHDRAWAL",
+    # "amount"=>"1.05",
+    # "currency"=>"CAD",
+    # "approvalCode"=>"1232435435",
+    # "bankAccountNumber"=>"4333434",
+    # "bankToken"=>"3748uzocio7348",
+    # "invoiceNumber"=>"#26-1760118464",
+    # "customerCode"=>"CST0000"}
+
     def decode_payment_payload(payload)
       return if payload.blank?
-
       raise('expected a string') unless payload.kind_of?(String)
 
       payment = (JSON.parse(Base64.decode64(payload)) rescue nil)
@@ -145,7 +165,7 @@ module Effective
       raise('expected a payment Hash') unless payment.kind_of?(Hash)
 
       return true if (payment['status'] == 'APPROVED' && payment['type'] == 'purchase') # CC
-      return true if (payment['bankToken'].present? && payment['type'] == 'WITHDRAWAL') # ACH
+      return true if (payment['bankAccountId'].present? && payment['responseMessage'].to_s.downcase == 'approved') # ACH
 
       false
     end
@@ -157,11 +177,15 @@ module Effective
       transaction_id = payment_payload['transactionId']
       raise('expected a payment_payload with a transactionId') unless transaction_id.present?
 
-      payment = get_transaction(transaction_id)
-      raise('expected an existing card-transaction payment') unless payment.kind_of?(Hash)
+      payment = if payment_payload['cardBatchId'].present? && payment_payload['type'].to_s.downcase == 'purchase'
+        get_card_transaction(transaction_id)
+      elsif payment_payload['batchId'].present? && payment_payload['type'].to_s.downcase == 'withdrawal'
+        get_ach_transaction(transaction_id)
+      end
+
+      raise("expected an existing card-transaction or ach-transaction payment with params #{payment_payload}") unless payment.kind_of?(Hash)
 
-      # Compare the payment (trusted truth) and the payment_payload (untrusted)
-      if payment['transactionId'].to_s != payment_payload['transactionId'].to_s
+      unless (payment['transactionId'].to_s == payment_payload['transactionId'].to_s) || (payment['id'].to_s == payment_payload['transactionId'].to_s)
         raise('expected the payment and payment_payload to have the same transactionId')
       end
 
@@ -190,7 +214,7 @@ module Effective
 
     def verify_payment!(order, payment)
       # Validate order ids
-      unless payment['invoiceNumber'].to_s.start_with?('#' + order.to_param)
+      if payment['invoiceNumber'].present? && !payment['invoiceNumber'].start_with?('#' + order.to_param)
         raise("expected card-transaction invoiceNumber to be the same as the order to_param")
       end
 
@@ -205,12 +229,12 @@ module Effective
     # Takes a payment_intent and returns the card info we can store
     def card_info(payment)
       # Return the authorization params merged with the card info
-      last4 = payment['cardNumber'].to_s.last(4)
-      card = payment['cardType'].to_s.downcase
+      last4 = (payment['cardNumber'] || payment['bankAccountL4L4']).to_s.last(4)
 
-      card = 'ACH' if card.blank? && payment['bankToken'].present?
+      card = payment['cardType'].to_s.downcase
+      card = 'ACH' if card.blank? && payment['bankAccountId'].present?
 
-      active_card = "**** **** **** #{last4} #{card}" if last4.present?
+      active_card = "**** **** **** #{last4} #{card}".strip if last4.present?
 
       { 'active_card' => active_card, 'card' => card }.compact
     end

data/app/models/effective/order.rb

@@ -1046,7 +1046,7 @@ module Effective
         when 'm', 'mc', 'master', 'mastercard' then 'MasterCard'
         when 'a', 'ax', 'american', 'americanexpress' then 'American Express'
         when 'd', 'discover' then 'Discover'
-        when 'ach' then 'ACH Payment'
+        when 'ach' then 'ACH'
         else payment_card.to_s
       end
 

data/app/views/effective/orders/_order_footer.html.haml

@@ -1,3 +1,2 @@
 .effective-orders-footer
-  .mb-4.text-center
-    %p If you have any questions, please contact us or call right away.
+  -# Intentionally left blank

data/lib/effective_orders/version.rb

@@ -1,3 +1,3 @@
 module EffectiveOrders
-  VERSION = '6.29.0'.freeze
+  VERSION = '6.29.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_orders
 version: !ruby/object:Gem::Version
-  version: 6.29.0
+  version: 6.29.1
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-09 00:00:00.000000000 Z
+date: 2025-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails