effective_orders 4.6.1 → 4.6.2

data/config/routes.rb

@@ -1,5 +1,5 @@
 EffectiveOrders::Engine.routes.draw do
-  scope module: 'effective' do
+  scope :module => 'effective' do
     resources :orders, except: [:destroy] do
       member do
         get :purchased
@@ -7,32 +7,33 @@ EffectiveOrders::Engine.routes.draw do
         get :declined
         get :send_buyer_receipt
 
-        post :free
-        post :mark_as_paid
-        post :cheque
-        post :phone
-        post :pretend
-        post :refund
-        post :stripe
+        post :free if EffectiveOrders.free?
+        post :mark_as_paid if EffectiveOrders.mark_as_paid?
+        post :cheque if EffectiveOrders.cheque?
+        post :phone if EffectiveOrders.phone?
+        post :pretend if EffectiveOrders.pretend?
+        post :refund if EffectiveOrders.refund?
+        post :stripe if EffectiveOrders.stripe?
       end
 
       collection do
         post :bulk_send_buyer_receipt
 
-        post :moneris_postback
-        post :paypal_postback
+        post :moneris_postback if EffectiveOrders.moneris?
+        post :paypal_postback if EffectiveOrders.paypal?
       end
     end
 
     post 'orders/:id', to: 'orders#update'
 
-    # Subscriptions
-    match 'subscribe', to: 'subscripter#update', via: :post, as: :subscripter
-    match 'customer/settings', to: 'customers#edit', as: :customer_settings, via: [:get]
-    match 'customer/settings', to: 'customers#update', via: [:patch, :put, :post]
-    match 'webhooks/stripe', to: 'webhooks#stripe', via: [:get, :post, :put]
+    if EffectiveOrders.subscriptions?
+      match 'subscribe', to: 'subscripter#update', via: :post, as: :subscripter
+
+      match 'customer/settings', to: 'customers#edit', as: :customer_settings, via: [:get]
+      match 'customer/settings', to: 'customers#update', via: [:patch, :put, :post]
+      match 'webhooks/stripe', to: 'webhooks#stripe', via: [:get, :post, :put]
+    end
 
-    # Carts
     match 'cart', to: 'carts#show', as: 'cart', via: :get
     match 'cart', to: 'carts#destroy', via: :delete
 

data/db/migrate/01_create_effective_orders.rb.erb

@@ -2,7 +2,6 @@ class CreateEffectiveOrders < ActiveRecord::Migration[4.2]
   def self.up
     create_table <%= @orders_table_name %> do |t|
       t.integer   :user_id
-      t.string    :user_type
 
       t.integer   :parent_id
       t.string    :parent_type
@@ -54,8 +53,6 @@ class CreateEffectiveOrders < ActiveRecord::Migration[4.2]
 
     create_table <%= @carts_table_name %> do |t|
       t.integer   :user_id
-      t.string    :user_type
-
       t.integer   :cart_items_count, :default => 0
       t.timestamps
     end
@@ -79,7 +76,6 @@ class CreateEffectiveOrders < ActiveRecord::Migration[4.2]
 
     create_table <%= @customers_table_name %> do |t|
       t.integer   :user_id
-      t.string    :user_type
 
       t.string    :stripe_customer_id
       t.string    :payment_method_id

data/lib/effective_orders.rb

@@ -1,47 +1,94 @@
 require 'effective_addresses'
-require 'effective_resources'
 require 'effective_orders/engine'
 require 'effective_orders/version'
 
 module EffectiveOrders
-  # Order states
-  PENDING = 'pending'        # New orders are created in a pending state
-  CONFIRMED = 'confirmed'    # Once the order has passed checkout step 1
-  DEFERRED = 'deferred'      # Deferred providers. Cheque or Phone was selected.
-  PURCHASED = 'purchased'    # Purchased by provider
-  DECLINED = 'declined'      # Declined by provider
+  PENDING = 'pending'.freeze        # New orders are created in a pending state
+  CONFIRMED = 'confirmed'.freeze    # Once the order has passed checkout step 1
+  DEFERRED = 'deferred'.freeze      # Deferred providers. Cheque or Phone was selected.
+  PURCHASED = 'purchased'.freeze    # Purchased by provider
+  DECLINED = 'declined'.freeze      # Declined by provider
+
   STATES = { PENDING => PENDING, CONFIRMED => CONFIRMED, DEFERRED => DEFERRED, PURCHASED => PURCHASED, DECLINED => DECLINED }
 
   # Subscription statuses (as per stripe)
-  ACTIVE = 'active'
-  PAST_DUE = 'past_due'
-  TRIALING = 'trialing'
-  CANCELED = 'canceled'
+  ACTIVE = 'active'.freeze
+  PAST_DUE = 'past_due'.freeze
+  TRIALING = 'trialing'.freeze
+  CANCELED = 'canceled'.freeze
 
   STATUSES = { ACTIVE => ACTIVE, PAST_DUE => PAST_DUE, CANCELED => CANCELED, TRIALING => TRIALING }
 
-  def self.config_keys
-    [
-      :orders_table_name, :order_items_table_name, :carts_table_name, :cart_items_table_name,
-      :customers_table_name, :subscriptions_table_name, :products_table_name,
-      :layout, :mailer_class_name, :mailer,
-      :orders_collection_scope, :order_tax_rate_method,
-      :obfuscate_order_ids, :use_effective_qb_sync,
-      :billing_address, :shipping_address, :use_address_full_name,
-      :collect_note, :collect_note_required, :collect_note_message,
-      :terms_and_conditions, :terms_and_conditions_label, :minimum_charge,
-
-      # Features
-      :free_enabled, :mark_as_paid_enabled, :pretend_enabled, :pretend_message,
-      # Payment processors. false or Hash
-      :cheque, :moneris, :paypal, :phone, :refund, :stripe, :subscriptions, :trial
-    ]
+  # The following are all valid config keys
+  mattr_accessor :orders_table_name
+  mattr_accessor :order_items_table_name
+  mattr_accessor :carts_table_name
+  mattr_accessor :cart_items_table_name
+  mattr_accessor :customers_table_name
+  mattr_accessor :subscriptions_table_name
+  mattr_accessor :products_table_name
+
+  mattr_accessor :authorization_method
+
+  mattr_accessor :layout
+  mattr_accessor :mailer
+
+  mattr_accessor :orders_collection_scope
+  mattr_accessor :order_tax_rate_method
+
+  mattr_accessor :obfuscate_order_ids
+  mattr_accessor :billing_address
+  mattr_accessor :shipping_address
+  mattr_accessor :use_address_full_name
+
+  mattr_accessor :collect_note
+  mattr_accessor :collect_note_required
+  mattr_accessor :collect_note_message
+
+  mattr_accessor :terms_and_conditions
+  mattr_accessor :terms_and_conditions_label
+
+  mattr_accessor :minimum_charge
+
+  # Features
+  mattr_accessor :free_enabled
+  mattr_accessor :mark_as_paid_enabled
+  mattr_accessor :pretend_enabled
+  mattr_accessor :pretend_message
+
+  # Payment processors. false or Hash
+  mattr_accessor :cheque
+  mattr_accessor :moneris
+  mattr_accessor :paypal
+  mattr_accessor :phone
+  mattr_accessor :refund
+  mattr_accessor :stripe
+  mattr_accessor :subscriptions  # Stripe subscriptions
+  mattr_accessor :trial          # Trial mode
+
+  def self.setup
+    yield self
+  end
+
+  def self.authorized?(controller, action, resource)
+    @_exceptions ||= [Effective::AccessDenied, (CanCan::AccessDenied if defined?(CanCan)), (Pundit::NotAuthorizedError if defined?(Pundit))].compact
+
+    return !!authorization_method unless authorization_method.respond_to?(:call)
+    controller = controller.controller if controller.respond_to?(:controller)
+
+    begin
+      !!(controller || self).instance_exec((controller || self), action, resource, &authorization_method)
+    rescue *@_exceptions
+      false
+    end
   end
 
-  include EffectiveGem
+  def self.authorize!(controller, action, resource)
+    raise Effective::AccessDenied.new('Access Denied', action, resource) unless authorized?(controller, action, resource)
+  end
 
   def self.permitted_params
-    @permitted_params ||= [
+    [
       :cc, :note, :terms_and_conditions, :confirmed_checkout,
       billing_address: EffectiveAddresses.permitted_params,
       shipping_address: EffectiveAddresses.permitted_params,
@@ -122,11 +169,6 @@ module EffectiveOrders
     [('cheque' if cheque?), ('phone' if phone?)].compact
   end
 
-  def self.mailer_klass
-    name = mailer_class_name.presence || 'Effective::OrdersMailer'
-    name.safe_constantize || raise("unable to constantize mailer class. check config.mailer_class_name")
-  end
-
   def self.can_skip_checkout_step1?
     return false if require_billing_address
     return false if require_shipping_address

data/lib/effective_orders/engine.rb

@@ -16,6 +16,13 @@ module EffectiveOrders
       eval File.read("#{config.root}/config/effective_orders.rb")
     end
 
+    # Set up mail delivering config option
+    initializer 'effective_orders.mailer', after: :load_config_initializers do |app|
+      EffectiveOrders.mailer[:deliver_method] ||= (
+        (Rails.application.config.respond_to?(:active_job) && Rails.application.config.active_job.queue_adapter) ? :deliver_later : :deliver_now
+      )
+    end
+
     initializer "effective_orders.append_precompiled_assets" do |app|
       Rails.application.config.assets.precompile += ['effective_orders/*']
     end

data/lib/effective_orders/version.rb

@@ -1,3 +1,3 @@
 module EffectiveOrders
-  VERSION = '4.6.1'.freeze
+  VERSION = '4.6.2'.freeze
 end

data/lib/generators/templates/effective_orders_mailer_preview.rb

@@ -4,55 +4,55 @@
 
 class EffectiveOrdersMailerPreview < ActionMailer::Preview
   def order_receipt_to_admin
-    EffectiveOrders.mailer_klass.order_receipt_to_admin(build_preview_order)
+    Effective::OrdersMailer.order_receipt_to_admin(build_preview_order)
   end
 
   def order_receipt_to_buyer
-    EffectiveOrders.mailer_klass.order_receipt_to_buyer(build_preview_order)
+    Effective::OrdersMailer.order_receipt_to_buyer(build_preview_order)
   end
 
   def payment_request_to_buyer
-    EffectiveOrders.mailer_klass.payment_request_to_buyer(build_preview_order)
+    Effective::OrdersMailer.payment_request_to_buyer(build_preview_order)
   end
 
   def pending_order_invoice_to_buyer
-    EffectiveOrders.mailer_klass.pending_order_invoice_to_buyer(build_preview_order)
+    Effective::OrdersMailer.pending_order_invoice_to_buyer(build_preview_order)
   end
 
   def subscription_payment_succeeded
-    EffectiveOrders.mailer_klass.subscription_payment_succeeded(preview_customer)
+    Effective::OrdersMailer.subscription_payment_succeeded(preview_customer)
   end
 
   def subscription_payment_failed
-    EffectiveOrders.mailer_klass.subscription_payment_failed(preview_customer)
+    Effective::OrdersMailer.subscription_payment_failed(preview_customer)
   end
 
   def subscription_created
-    EffectiveOrders.mailer_klass.subscription_created(preview_customer)
+    Effective::OrdersMailer.subscription_created(preview_customer)
   end
 
   def subscription_updated
-    EffectiveOrders.mailer_klass.subscription_updated(preview_customer)
+    Effective::OrdersMailer.subscription_updated(preview_customer)
   end
 
   def subscription_canceled
-    EffectiveOrders.mailer_klass.subscription_canceled(preview_customer)
+    Effective::OrdersMailer.subscription_canceled(preview_customer)
   end
 
   def subscription_trialing
-    EffectiveOrders.mailer_klass.subscription_trialing(preview_subscribable)
+    Effective::OrdersMailer.subscription_trialing(preview_subscribable)
   end
 
   def subscription_trial_expired
-    EffectiveOrders.mailer_klass.subscription_trial_expired(preview_subscribable)
+    Effective::OrdersMailer.subscription_trial_expired(preview_subscribable)
   end
 
   def subscription_event_to_admin
-    EffectiveOrders.mailer_klass.subscription_event_to_admin(:subscription_updated, preview_customer)
+    Effective::OrdersMailer.subscription_event_to_admin(:subscription_updated, preview_customer)
   end
 
   def order_error
-    EffectiveOrders.mailer_klass.order_error(order: build_preview_order, error: 'Something did not work out')
+    Effective::OrdersMailer.order_error(order: build_preview_order, error: 'Something did not work out')
   end
 
   protected

data/lib/tasks/effective_orders_tasks.rake

@@ -44,7 +44,7 @@ namespace :effective_orders do
         klass.trialing.find_each do |subscribable|
           if subscribable.trialing_until == today
             puts "sending trial expired to #{subscribable}"
-            EffectiveOrders.mailer_klass.subscription_trial_expired(subscribable).deliver_now
+            Effective::OrdersMailer.subscription_trial_expired(subscribable).deliver_now
           end
 
           next if subscribable.trial_past_due? # We already notified them
@@ -53,7 +53,7 @@ namespace :effective_orders do
 
           reminders.each do |remind_at|
             next unless today == (date + remind_at)
-            EffectiveOrders.mailer_klass.subscription_trialing(subscribable).deliver_now
+            Effective::OrdersMailer.subscription_trialing(subscribable).deliver_now
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: effective_orders
 version: !ruby/object:Gem::Version
-  version: 4.6.1
+  version: 4.6.2
 platform: ruby
 authors:
 - Code and Effect
@@ -156,6 +156,7 @@ files:
 - app/models/concerns/acts_as_purchasable.rb
 - app/models/concerns/acts_as_subscribable.rb
 - app/models/concerns/acts_as_subscribable_buyer.rb
+- app/models/effective/access_denied.rb
 - app/models/effective/cart.rb
 - app/models/effective/cart_item.rb
 - app/models/effective/customer.rb