effective_orders 4.4.5 → 4.4.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79f24e4a1d65aa32251934ecf34dcd229409bdea00516337cf3311108f4d068f
-  data.tar.gz: 70caa88a3e3ee44a0aa0e9e58803cf91675180456a1f8ccca08880c72421e256
+  metadata.gz: c92ae430fbce8f9ee7692d921653fffda8419a6d76eb2a4b43f3efcc932b7902
+  data.tar.gz: 9ce838e457cb9a3d365641b1d6d975f55fa118eed1df7be6d8071044a845fc38
 SHA512:
-  metadata.gz: e613f86ceedef7721b804381180f620302f8f1769393a1e77bcd0a2879995f9dfed0f9b7e0fbf2cc60384e1547f666671445e6be055e540d0cd35c241684f423
-  data.tar.gz: 116b05fc90541da625812c0d47e6e90730087346b0d35f6e4762817d95de4e61c28a640f93b55ab247943fb08d6a40634eb87dc987bd41db2ecb717b68fcf038
+  metadata.gz: 4f2999ad4d947a2f3623d4dfa82aa6f9a31daabef750715bc2d4671dae7f64e3dee7076e26dd6e678b4e1ecc394ea96f4a37f241fc258eea53f533e7040a1216
+  data.tar.gz: 825f4065b65081552b68d6228c5c7d72e96d60cc6967e1789485df31366aa9f6ce5e09c2508604e697180ef7ccd7b9c5e5b75bc94ee9c954cb7dce091c885a5d

data/app/assets/javascripts/effective_orders/providers/stripe.js.coffee

@@ -0,0 +1,77 @@
+this.StripeForm ||= class StripeForm
+  constructor: ->
+    @form = null
+    @paymentIntent = null
+
+    @data = null
+    @stripe = null
+    @card = null
+
+  initialize: ->
+    @form = $('form[data-stripe-form]').first()
+    return false unless @form.length > 0
+
+    @paymentIntent = @form.find("input[name$='[payment_intent_id]']").first()
+    @data = @form.data('stripe-form')
+    @stripe = Stripe(@data.key)
+    @card = @stripe.elements().create('card', @style())
+
+    @mount()
+
+  style: ->
+    style: {
+      base: { color: '#32325d', fontSize: '16px', },
+      invalid: { color: '#dc3545', iconColor: '#dc3545' }
+    }
+
+  mount: ->
+    @card.mount('#stripe-card-element')
+
+    @card.addEventListener('change', (error) ->
+      $('#stripe-card-errors').text(if error.message then error.message else '')
+    )
+
+    @form.on('click', '[type=submit]', (event) => @submit(event))
+
+  submit: (event) ->
+    event.preventDefault()
+
+    payment = if @shouldUseNewCard() then @useNewCard() else @useExistingCard()
+
+    $.active = $.active + 1
+
+    payment.then((result) =>
+      if result.error
+        @errorPayment(result.error)
+      else if result.paymentIntent.status == 'succeeded'
+        @submitPayment(result.paymentIntent)
+    ).then((result) =>
+      $.active = $.active - 1
+    )
+
+  shouldUseNewCard: ->
+    @form.get(0).checkValidity() &&
+    @paymentIntent.val().length == 0 &&
+    (@data.token_required || @form.children('.collapse.show').length > 0)
+
+  useNewCard: ->
+    @stripe.confirmCardPayment(@data.client_secret, {
+      payment_method: {
+        card: @card,
+        billing_details: { email: @data.email }
+      },
+      setup_future_usage: 'off_session'
+    })
+
+  useExistingCard: ->
+    @stripe.confirmCardPayment(@data.client_secret, { payment_method: @data.payment_method })
+
+  submitPayment: (payment) ->
+    @paymentIntent.val(payment['id'])
+    @form.submit()
+
+  errorPayment: (error) ->
+    $('#stripe-card-errors').text(error.message)
+    EffectiveForm.invalidate(@form);
+
+$ -> (new StripeForm()).initialize()

data/app/models/concerns/acts_as_purchasable.rb

@@ -1,19 +1,19 @@
 module ActsAsPurchasable
   extend ActiveSupport::Concern
 
-  module ActiveRecord
+  module Base
     def acts_as_purchasable(*options)
       @acts_as_purchasable = options || []
 
-      if table_exists?
-        instance = new()
-        raise 'must respond_to price' unless instance.respond_to?(:price)
-        raise 'must respond_to purchased_order_id' unless instance.respond_to?(:purchased_order_id)
+      # if table_exists?
+      #   instance = new()
+      #   raise 'must respond_to price' unless instance.respond_to?(:price)
+      #   raise 'must respond_to purchased_order_id' unless instance.respond_to?(:purchased_order_id)
 
-        if defined?(EffectiveQbSync)
-          raise 'must respond to qb_item_name' unless instance.respond_to?(:qb_item_name)
-        end
-      end
+      #   if defined?(EffectiveQbSync)
+      #     raise 'must respond to qb_item_name' unless instance.respond_to?(:qb_item_name)
+      #   end
+      # end
 
       include ::ActsAsPurchasable
     end

data/app/models/concerns/acts_as_subscribable.rb

@@ -3,13 +3,15 @@ module ActsAsSubscribable
 
   mattr_accessor :descendants
 
-  module ActiveRecord
+  module Base
     def acts_as_subscribable(*options)
       @acts_as_subscribable = options || []
 
-      instance = new()
-      raise 'must respond to trialing_until' unless instance.respond_to?(:trialing_until)
-      raise 'must respond to subscription_status' unless instance.respond_to?(:subscription_status)
+      # if table_exists?
+      #   instance = new()
+      #   raise 'must respond to trialing_until' unless instance.respond_to?(:trialing_until) || !EffectiveOrders.trial?
+      #   raise 'must respond to subscription_status' unless instance.respond_to?(:subscription_status)
+      # end
 
       include ::ActsAsSubscribable
       (ActsAsSubscribable.descendants ||= []) << self
@@ -20,7 +22,7 @@ module ActsAsSubscribable
     has_one :subscription, as: :subscribable, class_name: 'Effective::Subscription', inverse_of: :subscribable
     has_one :customer, through: :subscription, class_name: 'Effective::Customer'
 
-    before_validation(if: -> { trialing_until.blank? && EffectiveOrders.trial? }) do
+    before_validation(if: -> { EffectiveOrders.trial? && trialing_until.blank? }) do
       self.trialing_until = (Time.zone.now + EffectiveOrders.trial.fetch(:length)).beginning_of_day
     end
 
@@ -28,7 +30,10 @@ module ActsAsSubscribable
       raise :abort unless (subscripter.destroy! rescue false)
     end
 
-    validates :trialing_until, presence: true, if: -> { EffectiveOrders.trial? }
+    if EffectiveOrders.trial?
+      validates :trialing_until, presence: true
+    end
+
     validates :subscription_status, inclusion: { allow_nil: true, in: EffectiveOrders::STATUSES.keys }
 
     scope :trialing, -> { where(subscription_status: nil).where('trialing_until > ?', Time.zone.now) }

data/app/models/concerns/acts_as_subscribable_buyer.rb

@@ -1,7 +1,7 @@
 module ActsAsSubscribableBuyer
   extend ActiveSupport::Concern
 
-  module ActiveRecord
+  module Base
     def acts_as_subscribable_buyer(*options)
       include ::ActsAsSubscribableBuyer
     end

data/app/models/effective/customer.rb

@@ -51,6 +51,13 @@ module Effective
       end
     end
 
+    def invoices
+      @invoices ||= if stripe_customer_id.present?
+        Rails.logger.info "[STRIPE] list invoices: #{stripe_customer_id}"
+        ::Stripe::Invoice.list(customer: stripe_customer_id) rescue nil
+      end
+    end
+
     def upcoming_invoice
       @upcoming_invoice ||= if stripe_customer_id.present?
         Rails.logger.info "[STRIPE] get upcoming invoice: #{stripe_customer_id}"

data/app/models/effective/order.rb

@@ -337,13 +337,14 @@ module Effective
 
       assign_attributes(
         state: EffectiveOrders::PURCHASED,
-        purchased_at: Time.zone.now,
         payment: payment_to_h(payment),
         payment_provider: provider,
         payment_card: (card.presence || 'none'),
         skip_buyer_validations: skip_buyer_validations
       )
 
+      self.purchased_at ||= Time.zone.now
+
       Effective::Order.transaction do
         begin
           run_purchasable_callbacks(:before_purchase)
@@ -504,7 +505,7 @@ module Effective
     end
 
     def update_purchasables_purchased_order!
-      order_items.each { |oi| oi.purchasable.update_column(:purchased_order_id, self.id) }
+      order_items.each { |oi| oi.purchasable&.update_column(:purchased_order_id, self.id) }
     end
 
     def run_purchasable_callbacks(name)

data/app/models/effective/subscription.rb

@@ -56,6 +56,10 @@ module Effective
 
     validates :status, inclusion: { in: EffectiveOrders::STATUSES.keys }
 
+    before_validation do
+      self.name ||= EffectiveOrders.stripe_plans.find { |plan| plan[:id] == stripe_plan_id }&[:name] || 'Subscribed Plan'
+    end
+
     def to_s
       name || 'New Subscription'
     end

data/app/views/effective/customers/_customer.html.haml

@@ -15,7 +15,7 @@
               %td= sub.quantity
               %td= sub.interval
 
-- if customer.stripe_customer.invoices.present?
+- if customer.invoices.present?
   .card.my-4
     .card-header Invoices
     .card-body
@@ -26,7 +26,7 @@
             %th Invoice
             %th Total
         %tbody
-          - customer.stripe_customer.invoices.each do |invoice|
+          - customer.invoices.each do |invoice|
             - date_method = [(:date if invoice.respond_to?(:date)), (:period_start if invoice.respond_to?(:period_start)), :created].compact.first
             %tr
               %td= link_to Time.zone.at(invoice.public_send(date_method)).strftime('%F'), invoice.invoice_pdf

data/lib/effective_orders.rb

@@ -183,7 +183,7 @@ module EffectiveOrders
       Rails.logger.info '[STRIPE] index plans'
 
       plans = begin
-        Stripe::Plan.all
+        Stripe::Plan.respond_to?(:all) ? Stripe::Plan.all : Stripe::Plan.list
       rescue => e
         raise e if Rails.env.production?
         Rails.logger.info "[STRIPE ERROR]: #{e.message}"
@@ -192,15 +192,18 @@ module EffectiveOrders
       end
 
       plans = plans.map do |plan|
+        description = ("$#{'%0.2f' % (plan.amount / 100.0)}" + ' ' + plan.currency.upcase + '/' +  plan.interval.to_s)
+
         {
           id: plan.id,
           product_id: plan.product,
-          name: plan.nickname,
+          name: plan.nickname || description,
+          description: description,
           amount: plan.amount,
           currency: plan.currency,
-          description: ("$#{'%0.2f' % (plan.amount / 100.0)}" + ' ' + plan.currency.upcase + '/' +  plan.interval.to_s),
           interval: plan.interval,
-          interval_count: plan.interval_count
+          interval_count: plan.interval_count,
+          trial_period_days: plan.trial_period_days
         }
       end.sort do |x, y|
         val ||= (x[:interval] <=> y[:interval])

data/lib/effective_orders/engine.rb

@@ -5,9 +5,9 @@ module EffectiveOrders
     # Include acts_as_addressable concern and allow any ActiveRecord object to call it
     initializer 'effective_orders.active_record' do |app|
       ActiveSupport.on_load :active_record do
-        ActiveRecord::Base.extend(ActsAsPurchasable::ActiveRecord)
-        ActiveRecord::Base.extend(ActsAsSubscribable::ActiveRecord)
-        ActiveRecord::Base.extend(ActsAsSubscribableBuyer::ActiveRecord)
+        ActiveRecord::Base.extend(ActsAsPurchasable::Base)
+        ActiveRecord::Base.extend(ActsAsSubscribable::Base)
+        ActiveRecord::Base.extend(ActsAsSubscribableBuyer::Base)
       end
     end
 

data/lib/effective_orders/version.rb

@@ -1,3 +1,3 @@
 module EffectiveOrders
-  VERSION = '4.4.5'.freeze
+  VERSION = '4.4.10'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_orders
 version: !ruby/object:Gem::Version
-  version: 4.4.5
+  version: 4.4.10
 platform: ruby
 authors:
 - Code and Effect
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-17 00:00:00.000000000 Z
+date: 2020-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -121,7 +121,7 @@ files:
 - app/assets/images/effective_orders/stripe.png
 - app/assets/javascripts/effective_orders.js
 - app/assets/javascripts/effective_orders/customers.js.coffee
-- app/assets/javascripts/effective_orders/providers/stripe.js
+- app/assets/javascripts/effective_orders/providers/stripe.js.coffee
 - app/assets/javascripts/effective_orders/subscriptions.js.coffee
 - app/assets/stylesheets/effective_orders.scss
 - app/assets/stylesheets/effective_orders/_cart.scss
@@ -253,7 +253,7 @@ homepage: https://github.com/code-and-effect/effective_orders
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -268,8 +268,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Quickly build an online store with carts, orders, automatic email receipts
   and payment collection via Stripe, StripeConnect, PayPal and Moneris.

data/app/assets/javascripts/effective_orders/providers/stripe.js

@@ -1,97 +0,0 @@
-class StripeForm {
-  initialize() {
-    let $form = $('form[data-stripe-form]').first();
-    if ($form.length == 0) { return false; }
-
-    this.$form = $form;
-    this.$paymentIntentId = this.$form.find("input[name$='[payment_intent_id]']").first();
-
-    this.data = $form.data('stripe-form');
-    this.stripe = Stripe(this.data.key);
-    this.card = this.stripe.elements().create("card", { style: this.style() });
-
-    this.mount();
-  }
-
-  mount() {
-    this.card.mount("#stripe-card-element");
-
-    this.card.addEventListener('change', function ({ error }) {
-      if (error) {
-        $('#stripe-card-errors').text(error.message);
-      } else {
-        $('#stripe-card-errors').text('');
-      }
-    });
-
-    this.$form.on('click', '[type=submit]', (event) => { this.submit(event) });
-  }
-
-  shouldUseNewCard() {
-    let $newCardForm = this.$form.children('.collapse.show')
-
-    return (
-      this.$form.get(0).checkValidity() &&
-      (this.data.token_required || $newCardForm.length > 0) &&
-      this.$paymentIntentId.val().length == 0
-    )
-  }
-
-  submit(event) {
-    event.preventDefault();
-
-    let payment = this.shouldUseNewCard() ? this.useNewCard() : this.useExistingCard();
-
-    payment.then((result) => {
-      if (result.error) {
-        this.errorPayment(result.error)
-      } else if (result.paymentIntent.status == 'succeeded') {
-        this.submitPayment(result.paymentIntent);
-      }
-    });
-  }
-
-  useExistingCard() {
-    return this.stripe.confirmCardPayment(this.data.client_secret, {
-      payment_method: this.data.payment_method
-    });
-  }
-
-  useNewCard() {
-    return this.stripe.confirmCardPayment(this.data.client_secret, {
-      payment_method: {
-        card: this.card,
-        billing_details: {
-          email: this.data.email
-        }
-      },
-      setup_future_usage: 'off_session'
-    });
-  }
-
-  errorPayment(error) {
-    $('#stripe-card-errors').text(error.message);
-    EffectiveForm.invalidate(this.$form);
-  }
-
-  submitPayment(payment) {
-    this.$paymentIntentId.val('' + payment['id']);
-    this.$form.submit();
-  }
-
-  style() {
-    return {
-      base: {
-        color: "#32325d",
-        fontSize: "16px",
-      },
-      invalid: {
-        color: "#dc3545",
-        iconColor: "#dc3545"
-      }
-    };
-  }
-
-}
-
-$(document).ready(function () { new StripeForm().initialize(); });