effective_orders 2.1.6 → 2.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f067a482a08a63b26a23649c3ff1cbeabdf5a3c9
-  data.tar.gz: b1c1adc7ce23f8196a072155261e3a9139761d0f
+  metadata.gz: 241819ceeb137196d59b1383c99ff092e65e1fa7
+  data.tar.gz: d79d5f2798e61e92ab25f686f1db9624d2706dec
 SHA512:
-  metadata.gz: 253b5d1cb1877f869558aceaf15be0230f896bddc419821d3bb322a00aff98f576db9103ad8829fe08706a1dca1d2aa03d39398a558b4cad9999a7ec97dce2e7
-  data.tar.gz: 2f0d3b522ad5c12632f9d6263459b13a26e2064a1ae838aa9a41dac3fc183a6998207f3937c1dabf6a08c7d47f0010c19cf4b20b828a4fe4a358c6232622efa1
+  metadata.gz: c74dcef00e1d2506b7a425582b3b51eaee276c007861e90ea5a275b78d1e40ff089332c7c084bf4cb63aaf9126b1004f146a68f2dfa3a24e00ba7c345f37f115
+  data.tar.gz: 1087399127980e9089fb2f1dd41d5d01eb2a850ac4f96e6074b82540b7f8ea4214aca1b0404ecba099cd6de13367c5a6bc192af83052cfd37d47d1c21615bae8

data/README.md

@@ -793,12 +793,14 @@ Order totals ending in .05 will be Declined
 
 And there's a whole bunch more.  Please refer to:
 
-https://www.google.ca/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CB8QFjAA&url=https%3A%2F%2Fcartthrob.com%2F%3FACT%3D50%26fid%3D25%26aid%3D704_jvVKOeo1a8d3aSYeT3R4%26board_id%3D1&ei=_p1OVOysEpK_sQTZ8oDgCg&usg=AFQjCNHJGH_hEm4kUJAzkvKrzTqEpFnrgA&sig2=XJdE6PZoOY9habWH_B4uWA&bvm=bv.77880786,d.cWc&cad=rja
+https://www.collinsharper.com/downloadable/download/sample/sample_id/5/
 
 2. Moneris will not process a duplicate order ID
 
 Once Order id=1 has been purchased/declined, you will be unable to purchase an order with id=1 ever again.
 
+effective_orders works around this by appending a timestamp to the order ID.
+
 
 ## Paying via Stripe
 

data/app/controllers/effective/providers/app_checkout.rb

@@ -4,13 +4,13 @@ module Effective
       extend ActiveSupport::Concern
 
       included do
-        if defined?(CanCan)
-          skip_authorization_check only: [:app_checkout]
-        end
       end
 
       def app_checkout
         @order = Order.find(params[:id])
+
+        (EffectiveOrders.authorized?(self, :update, @order) rescue false)
+
         checkout = EffectiveOrders.app_checkout[:service].call(order: @order)
         if checkout.success?
           order_purchased(details: payment_details(checkout), provider: 'app_checkout', card: 'none')

data/app/controllers/effective/providers/ccbill.rb

@@ -5,16 +5,14 @@ module Effective
 
       included do
         skip_before_filter :verify_authenticity_token, only: [:ccbill_postback]
-
-        if defined?(CanCan)
-          skip_authorization_check only: [:ccbill_postback]
-        end
       end
 
       def ccbill_postback
         postback = Effective::Providers::CcbillPostback.new(params)
         @order ||= Effective::Order.find(postback.order_id)
 
+        (EffectiveOrders.authorized?(self, :update, @order) rescue false)
+
         if @order.present? && postback.verified?
           if @order.purchased?
             order_purchased(details: postback.order_details, provider: 'ccbill')

data/app/controllers/effective/providers/moneris.rb

@@ -10,7 +10,7 @@ module Effective
       def moneris_postback
         @order ||= Effective::Order.find(params[:response_order_id])
 
-        EffectiveOrders.authorized?(self, :update, @order)
+        (EffectiveOrders.authorized?(self, :update, @order) rescue false)
 
         # Delete the Purchased and Declined Redirect URLs
         purchased_redirect_url = params.delete(:rvar_purchased_redirect_url)

data/app/controllers/effective/providers/paypal.rb

@@ -5,15 +5,13 @@ module Effective
 
       included do
         skip_before_filter :verify_authenticity_token, :only => [:paypal_postback]
-
-        if defined?(CanCan)
-          skip_authorization_check only: [:paypal_postback]
-        end
       end
 
       def paypal_postback
         @order ||= Effective::Order.where(id: (params[:invoice].to_i rescue 0)).first
 
+        (EffectiveOrders.authorized?(self, :update, @order) rescue false)
+
         if @order.present?
           if @order.purchased?
             order_purchased(details: params, provider: 'paypal', card: params[:payment_type])

data/app/helpers/effective_orders_helper.rb

@@ -1,10 +1,12 @@
 module EffectiveOrdersHelper
-  def price_to_currency(price)
+  def price_to_currency(price, options = {})
     raise 'price_to_currency expects an Integer representing the number of cents in a price' unless price.kind_of?(Integer)
-    number_to_currency(price / 100.0)
+    options[:precision] ||= 2
+    number_to_currency(price / 100.0, options)
   end
 
-  def tax_rate_to_percentage(tax_rate)
+  def tax_rate_to_percentage(tax_rate, options = {})
+    options[:strip_insignificant_zeros] = true if options[:strip_insignificant_zeros].nil?
     number_to_percentage(tax_rate, strip_insignificant_zeros: true)
   end
 

data/app/views/effective/orders/moneris/_form.html.haml

@@ -13,7 +13,7 @@
   = hidden_field_tag(:email, order.user.try(:email))
   = hidden_field_tag(:cust_id, order.user.to_param)
 
-  = hidden_field_tag(:order_id, [order.to_param, order.billing_name.try(:parameterize).presence].compact.join('-'))
+  = hidden_field_tag(:order_id, [order.to_param, order.billing_name.try(:parameterize).presence, Time.zone.now.to_i].compact.join('-'))
   = hidden_field_tag(:gst, '%.2f' % (order.tax / 100.0))
   = hidden_field_tag(:charge_total, '%.2f' % (order.total / 100.0))
 

data/lib/effective_orders/version.rb

@@ -1,3 +1,3 @@
 module EffectiveOrders
-  VERSION = '2.1.6'.freeze
+  VERSION = '2.1.7'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_orders
 version: !ruby/object:Gem::Version
-  version: 2.1.6
+  version: 2.1.7
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-15 00:00:00.000000000 Z
+date: 2016-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails