effective_orders 1.8.1 → 2.0.0

data/spec/controllers/ccbill_orders_controller_spec.rb

@@ -0,0 +1,103 @@
+require 'spec_helper'
+
+# We're testing the effective/providers/ccbill.rb file, which is included into the OrdersController at runtime
+
+describe Effective::OrdersController, type: :controller do
+  routes { EffectiveOrders::Engine.routes }
+
+  let(:order) { FactoryGirl.create(:order) }
+
+  let(:ccbill_params) do
+    {
+      "customer_fname"=>"Nathan",
+      "customer_lname"=>"Feaver",
+      "email"=>"nathan@agilestyle.com",
+      "username"=>"",
+      "password"=>"[FILTERED]",
+      "productDesc"=>"Cool Stuff",
+      "price"=>"#{ccbill_formatted_price(order.total)} for 365 days",
+      "subscription_id"=>"0216026202000000347",
+      "denialId"=>"",
+      "clientAccnum"=>"999999",
+      "clientSubacc"=>"0000",
+      "address1"=>"123 Easy St",
+      "city"=>"Edmonton",
+      "state"=>"AB",
+      "country"=>"CA",
+      "phone_number"=>"",
+      "zipcode"=>"A1B 2C3",
+      "start_date"=>"2016-01-26 13:55:44",
+      "referer"=>"",
+      "ccbill_referer"=>"",
+      "affiliate"=>"",
+      "reservationId"=>"",
+      "referringUrl"=>"http://localhost:3000/orders/833-7014-992",
+      "reasonForDecline"=>"",
+      "reasonForDeclineCode"=>"",
+      "formName"=>"211cc",
+      "cardType"=>"VISA",
+      "responseDigest"=>"43492c3db3f97944bab31a0f15d486cb",
+      "commit"=>"Checkout with CCBill",
+      "authenticity_token"=>"96wvM13VjhtNwgCyRZfO03Gn4x2ntgl7GBSn3U51OdwlGLxe2YYNdCHETtGjm8WwikQfRF79/aHF2zmldwsFCA==",
+      "order_id"=>order.to_param,
+      "utf8"=>"✓",
+      "typeId"=>"0",
+      "initialPrice"=>"10.5",
+      "initialPeriod"=>"365",
+      "recurringPrice"=>"0",
+      "recurringPeriod"=>"0",
+      "rebills"=>"0",
+      "initialFormattedPrice"=>ccbill_formatted_price(order.total),
+      "recurringFormattedPrice"=>"$0.00",
+      "ip_address"=>"00.00.000.00"
+    }
+  end
+
+  let(:ccbill_declined_params) do
+    ccbill_params.merge(
+      "denialId"=>"",
+      "reasonForDecline"=>"Transaction Denied by Bank",
+      "reasonForDeclineCode"=>"24",
+    )
+  end
+
+  def ccbill_formatted_price(price)
+    price_in_dollars = price.to_s.insert(-3, '.')
+    "$#{price_in_dollars}"
+  end
+
+  describe 'ccbill_postback' do
+    before do
+      sign_in order.user
+      allow_any_instance_of(Effective::Providers::CcbillPostback).to receive(:verified?).and_return(true)
+    end
+
+    describe 'invalid parameters' do
+      it 'raises RecordNotFound when passed an unknown order id' do
+        expect {
+          post :ccbill_postback, ccbill_params.tap { |x| x[:order_id] = 999 }
+        }.to raise_error(ActiveRecord::RecordNotFound)
+      end
+    end
+
+    describe 'declined purchase params' do
+      it 'marks an order declined when params[:result] indicate decline'  do
+        expect(subject).to receive(:order_declined).and_call_original
+
+        post :ccbill_postback, ccbill_declined_params
+
+        expect(assigns(:order)).to be_declined
+      end
+    end
+
+    describe 'approved purchase' do
+      it 'marks the order as purchased' do
+        expect(subject).to receive(:order_purchased).and_call_original
+
+        post :ccbill_postback, ccbill_params
+
+        expect(assigns(:order)).to be_purchased
+      end
+    end
+  end
+end

data/spec/controllers/moneris_orders_controller_spec.rb

@@ -8,23 +8,23 @@ describe Effective::OrdersController, type: :controller do
   let(:order) { FactoryGirl.create(:order) }
   let(:moneris_params) do
     {
-      :response_order_id => "#{order.to_param}",
-      :date_stamp => '2014-10-27',
-      :time_stamp => '17:42:31',
-      :bank_transaction_id =>'660110910011137660',
-      :charge_total => "#{'%.2f' % order.total}",
-      :bank_approval_code => '497365',
-      :response_code => '027',
-      :iso_code => '01',
-      :message => 'APPROVED           *                    =',
-      :trans_name => 'purchase',
-      :cardholder => 'Matt',
-      :f4l4 => '4242***4242',
-      :card =>'V',
-      :expiry_date => '1904',
-      :result => '1',
-      :rvar_authenticity_token => 'nJQf5RKL9SES4uiQIaj4aMNNdIQayEeauOL44iSppD4=',
-      :transactionKey => 'C3kYLXwyMDDFD1ArgxiHFph3wIy1Jx'
+      response_order_id: "#{order.to_param}",
+      date_stamp: '2014-10-27',
+      time_stamp: '17:42:31',
+      bank_transaction_id:'660110910011137660',
+      charge_total: "#{'%.2f' % order.total}",
+      bank_approval_code: '497365',
+      response_code: '027',
+      iso_code: '01',
+      message: 'APPROVED           *                    =',
+      trans_name: 'purchase',
+      cardholder: 'Matt',
+      f4l4: '4242***4242',
+      card:'V',
+      expiry_date: '1904',
+      result: '1',
+      rvar_authenticity_token: 'nJQf5RKL9SES4uiQIaj4aMNNdIQayEeauOL44iSppD4=',
+      transactionKey: 'C3kYLXwyMDDFD1ArgxiHFph3wIy1Jx'
     }
   end
 
@@ -72,7 +72,7 @@ describe Effective::OrdersController, type: :controller do
 
     describe 'transaction verification step' do
       it 'marks the order as purchased when response code is valid' do
-        allow(subject).to receive(:parse_moneris_response).and_return({:response_code => 1}) # success
+        allow(subject).to receive(:parse_moneris_response).and_return({response_code: 1}) # success
 
         post :moneris_postback, moneris_params
 
@@ -81,7 +81,7 @@ describe Effective::OrdersController, type: :controller do
       end
 
       it 'marks order declined when response_code = null' do
-        allow(subject).to receive(:parse_moneris_response).and_return({:response_code => 'null'}) # failure
+        allow(subject).to receive(:parse_moneris_response).and_return({response_code: 'null'}) # failure
 
         post :moneris_postback, moneris_params
 
@@ -101,14 +101,14 @@ describe Effective::OrdersController, type: :controller do
       end
 
       it 'marks order declined when response_code = 0' do
-        allow(subject).to receive(:parse_moneris_response).and_return({:response_code => 0}) # failure
+        allow(subject).to receive(:parse_moneris_response).and_return({response_code: 0}) # failure
         post :moneris_postback, moneris_params
         response.should redirect_to "/orders/#{order.to_param}/declined"
         assigns(:order).purchased?.should eq false
       end
 
       it 'marks order declined when response_code = 50' do
-        allow(subject).to receive(:parse_moneris_response).and_return({:response_code => 50}) # failure
+        allow(subject).to receive(:parse_moneris_response).and_return({response_code: 50}) # failure
         post :moneris_postback, moneris_params
         response.should redirect_to "/orders/#{order.to_param}/declined"
         assigns(:order).purchased?.should eq false
@@ -117,13 +117,13 @@ describe Effective::OrdersController, type: :controller do
 
     describe 'redirect urls' do
       it 'redirects to the purchased_redirect_url on purchase' do
-        allow(subject).to receive(:parse_moneris_response).and_return({:response_code => 1}) # success
+        allow(subject).to receive(:parse_moneris_response).and_return({response_code: 1}) # success
         post :moneris_postback, moneris_params.tap { |x| x[:rvar_purchased_redirect_url] = '/something' }
         response.should redirect_to '/something'
       end
 
       it 'redirects to the declined_redirect_url on decline' do
-        allow(subject).to receive(:parse_moneris_response).and_return({:response_code => 'null'}) # failure
+        allow(subject).to receive(:parse_moneris_response).and_return({response_code: 'null'}) # failure
         post :moneris_postback, moneris_params.tap { |x| x[:rvar_declined_redirect_url] = '/something' }
         response.should redirect_to '/something'
       end

data/spec/controllers/orders_controller_spec.rb

@@ -17,9 +17,9 @@ describe Effective::OrdersController, type: :controller do
 
   let(:valid_order_attributes) do
     {
-      :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => false,
-        :shipping_address => shipping_atts, :save_shipping_address => false,
+      effective_order: {
+        billing_address: billing_atts, save_billing_address: false,
+        shipping_address: shipping_atts, save_shipping_address: false,
       }
     }
   end
@@ -90,11 +90,11 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'assign appropriate User fields' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => false,
-        :shipping_address => shipping_atts, :save_shipping_address => false,
-        :shipping_address_same_as_billing => false,
-        :user_attributes => {:first_name => 'First', :last_name => 'Last', :email => 'email@somwhere.com'}
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: false,
+        shipping_address: shipping_atts, save_shipping_address: false,
+        shipping_address_same_as_billing: false,
+        user_attributes: {first_name: 'First', last_name: 'Last', email: 'email@somwhere.com'}
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq true
@@ -105,10 +105,10 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'assign addresses to the order and not the user' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => false,
-        :shipping_address => shipping_atts, :save_shipping_address => false,
-        :shipping_address_same_as_billing => false
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: false,
+        shipping_address: shipping_atts, save_shipping_address: false,
+        shipping_address_same_as_billing: false
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq true
@@ -121,10 +121,10 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'assign addresses to the order and the user' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => true,
-        :shipping_address => shipping_atts, :save_shipping_address => true,
-        :shipping_address_same_as_billing => false
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: true,
+        shipping_address: shipping_atts, save_shipping_address: true,
+        shipping_address_same_as_billing: false
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq true
@@ -139,10 +139,10 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'does not assign the billing_address to user if save_billing_address is false' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => false,
-        :shipping_address => shipping_atts, :save_shipping_address => true,
-        :shipping_address_same_as_billing => false
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: false,
+        shipping_address: shipping_atts, save_shipping_address: true,
+        shipping_address_same_as_billing: false
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq true
@@ -157,10 +157,10 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'does not assign the shipping_address to user if save_shipping_address is false' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => true,
-        :shipping_address => shipping_atts, :save_shipping_address => false,
-        :shipping_address_same_as_billing => false
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: true,
+        shipping_address: shipping_atts, save_shipping_address: false,
+        shipping_address_same_as_billing: false
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq true
@@ -175,10 +175,10 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'assign billing address to the order shipping_address when shipping_address_same_as_billing' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => true,
-        :shipping_address => shipping_atts, :save_shipping_address => true,
-        :shipping_address_same_as_billing => true
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: true,
+        shipping_address: shipping_atts, save_shipping_address: true,
+        shipping_address_same_as_billing: true
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq true
@@ -193,9 +193,9 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'assign billing address to the order shipping_address when shipping_address_same_as_billing and no shipping provided' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => true,
-        :shipping_address_same_as_billing => true
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: true,
+        shipping_address_same_as_billing: true
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq true
@@ -210,10 +210,10 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'assign billing address to the order shipping_address but not the user when shipping_address_same_as_billing provided' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => false,
-        :save_shipping_address => false,
-        :shipping_address_same_as_billing => true
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: false,
+        save_shipping_address: false,
+        shipping_address_same_as_billing: true
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq true
@@ -228,61 +228,61 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'is invalid when passed an invalid address' do
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => true,
-        :shipping_address => shipping_atts.tap { |x| x[:address1] = nil }, :save_shipping_address => true,
-        :shipping_address_same_as_billing => false
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: true,
+        shipping_address: shipping_atts.tap { |x| x[:address1] = nil }, save_shipping_address: true,
+        shipping_address_same_as_billing: false
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq false
       assigns(:order).errors[:shipping_address].present?.should eq true
 
-      response.should render_template(:new)
+      response.should render_template(:checkout_step1)
     end
 
     it 'is invalid when passed an invalid order_item' do
       Effective::OrderItem.any_instance.stub(:valid?).and_return(false)
 
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => true,
-        :shipping_address => shipping_atts, :save_shipping_address => true,
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: true,
+        shipping_address: shipping_atts, save_shipping_address: true,
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq false
-      response.should render_template(:new)
+      response.should render_template(:checkout_step1)
     end
 
     it 'is invalid when passed an invalid user' do
       User.any_instance.stub(:valid?).and_return(false)
 
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => true,
-        :shipping_address => shipping_atts, :save_shipping_address => true,
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: true,
+        shipping_address: shipping_atts, save_shipping_address: true,
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq false
-      response.should render_template(:new)
+      response.should render_template(:checkout_step1)
     end
 
     it 'is invalid when passed an invalid purchasable' do
       Product.any_instance.stub(:valid?).and_return(false)
 
-      post :create, :effective_order => {
-        :billing_address => billing_atts, :save_billing_address => true,
-        :shipping_address => shipping_atts, :save_shipping_address => true,
+      post :create, effective_order: {
+        billing_address: billing_atts, save_billing_address: true,
+        shipping_address: shipping_atts, save_shipping_address: true,
       }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq false
-      response.should render_template(:new)
+      response.should render_template(:checkout_step1)
     end
 
     it 'prevents the order from proceeding when missing a required address' do
-      post :create, :effective_order => { :billing_address => billing_atts, :save_billing_address => true, :shipping_address_same_as_billing => false }
+      post :create, effective_order: { billing_address: billing_atts, save_billing_address: true, shipping_address_same_as_billing: false }
 
       (assigns(:order).valid? && assigns(:order).persisted?).should eq false
       assigns(:order).errors[:shipping_address].present?.should eq true
 
-      response.should render_template(:new)
+      response.should render_template(:checkout_step1)
     end
   end
 
@@ -339,21 +339,20 @@ describe Effective::OrdersController, type: :controller do
   describe '#order_purchased (with a free order)' do
     before(:each) do
       sign_in cart.user
-      cart.cart_items.each { |cart_item| cart_item.purchasable.update_attributes(:price => 0.0) }
+      cart.cart_items.each { |cart_item| cart_item.purchasable.update_attributes(price: 0.0) }
     end
 
     it 'creates a purchased order' do
       post :create, valid_order_attributes
       assigns(:order).purchased?.should eq true
-      assigns(:order).payment[:details].should eq 'automatic purchase of free order.'
+      assigns(:order).payment[:details].should eq 'automatic purchase of free order'
     end
 
     it 'destroys the current user cart' do
       post :create, valid_order_attributes
 
       expect { Effective::Cart.find(cart.id) }.to raise_error(ActiveRecord::RecordNotFound)
-      ci_ids = assigns(:cart).cart_items.collect(&:id)
-      expect(Effective::CartItem.where(:id => ci_ids).count).to be 0
+      Effective::Cart.count.should eq 0
     end
 
     it 'redirects to the purchased page' do
@@ -363,28 +362,81 @@ describe Effective::OrdersController, type: :controller do
   end
 
   describe '#show' do
+    context 'when finding order' do
+      before { sign_in purchased_order.user }
 
-    it 'finds the order by obfuscated ID' do
-      sign_in purchased_order.user
-      get :show, :id => purchased_order.to_param
-      assigns(:order).id.should eq purchased_order.id
-    end
+      it 'should find the order by obfuscated ID' do
+        get :show, id: purchased_order.to_param
 
-    it 'does not find an order by regular ID' do
-      sign_in purchased_order.user
-      expect { get :show, :id => purchased_order.id }.to raise_error(ActiveRecord::RecordNotFound)
-    end
+        expect(assigns(:order).id).to eq purchased_order.id
+      end
 
-    it 'renders the show template for a purchased order' do
-      sign_in purchased_order.user
-      get :show, :id => purchased_order.to_param
-      response.should render_template(:show)
+      it 'should not find an order by regular ID' do
+        expect { get :show, id: purchased_order.id }.to raise_error(ActiveRecord::RecordNotFound)
+      end
     end
 
-    it 'renders the checkout template for a non-purchased order' do
-      sign_in order.user
-      get :show, :id => order.to_param
-      response.should render_template(:checkout)
+    context 'when rendering template' do
+      let(:user) { FactoryGirl.create(:user) }
+
+      before { sign_in user }
+
+      context 'when not purchased order' do
+        let(:order) { FactoryGirl.create(:order, user: user) }
+
+        it 'should render checkout page successfully' do
+          get :show, id: order.to_param
+
+          expect(response).to be_successful
+          expect(response).to render_template :checkout_step2
+          expect(assigns(:order)).to eq order
+          expect(assigns(:page_title)).to eq 'Checkout'
+        end
+
+        it 'should render checkout page successfully' do
+          get :edit, id: order.to_param
+
+          expect(response).to be_successful
+          expect(response).to render_template :checkout_step1
+          expect(assigns(:order)).to eq order
+          expect(assigns(:page_title)).to eq 'Checkout'
+        end
+      end
+
+      context 'when pending order' do
+        let(:order) { FactoryGirl.create(:pending_order, user: user) }
+
+        it 'should render checkout page successfully' do
+          get :show, id: order.to_param
+
+          expect(response).to be_successful
+          expect(response).to render_template :checkout_step2
+          expect(assigns(:order)).to eq order
+          expect(assigns(:page_title)).to eq 'Checkout'
+        end
+
+        it 'should render checkout page successfully' do
+          get :edit, id: order.to_param
+
+          expect(response).to be_successful
+          expect(response).to render_template :checkout_step1
+          expect(assigns(:order)).to eq order
+          expect(assigns(:page_title)).to eq 'Checkout'
+        end
+      end
+
+      context 'when purchased order' do
+        let(:order) { FactoryGirl.create(:purchased_order, user: user) }
+
+        it 'should render order show page successfully' do
+          get :show, id: order.to_param
+
+          expect(response).to be_successful
+          expect(response).to render_template :show
+          expect(assigns(:order)).to eq order
+          expect(assigns(:page_title)).to eq 'Receipt'
+        end
+      end
     end
   end
 
@@ -394,12 +446,12 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'finds the order by obfuscated ID' do
-      get :purchased, :id => purchased_order.to_param
+      get :purchased, id: purchased_order.to_param
       assigns(:order).id.should eq purchased_order.id
     end
 
     it 'does not find an order by regular ID' do
-      expect { get :purchased, :id => purchased_order.id }.to raise_error(ActiveRecord::RecordNotFound)
+      expect { get :purchased, id: purchased_order.id }.to raise_error(ActiveRecord::RecordNotFound)
     end
   end
 
@@ -409,13 +461,49 @@ describe Effective::OrdersController, type: :controller do
     end
 
     it 'finds the order by obfuscated ID' do
-      get :declined, :id => purchased_order.to_param
+      get :declined, id: purchased_order.to_param
       assigns(:order).id.should eq purchased_order.id
     end
 
     it 'does not find an order by regular ID' do
-      expect { get :declined, :id => purchased_order.id }.to raise_error(ActiveRecord::RecordNotFound)
+      expect { get :declined, id: purchased_order.id }.to raise_error(ActiveRecord::RecordNotFound)
     end
   end
 
+  describe 'POST #pay_by_cheque' do
+    let(:user) { FactoryGirl.create(:user) }
+    let(:order) { FactoryGirl.create(:order, user: user) }
+    let!(:cart) { FactoryGirl.create(:cart_with_items, user: user) }
+
+    before { sign_in user }
+
+    context 'when success' do
+      it 'should update order state, empty cart and redirect to order show page with success message' do
+        Effective::OrdersMailer.deliveries.clear
+
+        post :pay_by_cheque, id: order.to_param
+
+        expect(assigns(:order).pending?).to be_truthy
+        expect(Effective::Cart.first).to be_nil
+        flash[:success].present?.should eq true
+        response.should render_template(:pay_by_cheque)
+        Effective::OrdersMailer.deliveries.length.should eq 1
+      end
+    end
+
+    context 'when failed' do
+      before { Effective::Order.any_instance.stub(:save).and_return(false) }
+
+      it 'should not empty cart and redirect to order show page with danger message' do
+        Effective::OrdersMailer.deliveries.clear
+        post :pay_by_cheque, id: order.to_param
+
+        expect(response).to be_redirect
+        expect(response).to redirect_to EffectiveOrders::Engine.routes.url_helpers.order_path(order)
+        expect(Effective::Cart.first.empty?).to be_falsey
+        flash[:danger].present?.should eq true
+        Effective::OrdersMailer.deliveries.length.should eq 0
+      end
+    end
+  end
 end