effective_orders 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb1d6669051ee4a4c2caf28dccbac451bdd3221b
-  data.tar.gz: 6ad503455f871663204142a019802e58e0761139
+  metadata.gz: 880e18d649a95f87eba2e87fd7fc941849fd08be
+  data.tar.gz: 8c8fc70f4bc7f85a2c63bddcf50cbee72ac64396
 SHA512:
-  metadata.gz: 384f81697a59dce11cd020734531dc460d4d2e6fbb771687d13179375ad166d7f4c01d9a21b819018e2d91ddf760e605f1c1e022645a72e9bbfa7f92b212f63d
-  data.tar.gz: 49ed6f3e16ca6745070ac459f181f20c89767b3dd7a472a2424aec5415f91724237c589ac667e853010e58458cc545015771e04f0c1242db8bb80a84c8fea4fe
+  metadata.gz: c950647d5032d3ef4f95751f822f22377a4c1e78e1d0037fb3b76c6cc5791b768c206aec0fd936b52d5ed7f841d95eb36c6b279886abec958a6b15b00f3395c5
+  data.tar.gz: 5b761e368af7fd83c8cd272b568aea5dac030b30920e483907c11c9733c803833382bd2603f6289448fed782696f6f01da491b04b9e745a3b35b494102a34903

data/README.md

@@ -852,9 +852,86 @@ Register an additional Webhook, to accept Stripe subscription creation events fr
 root_url/webhooks/stripe
 
 
-### PayPal
+## Paying Via PayPal
 
-TODO
+Use the following to set up a PayPal sandbox store.
+
+### PayPal Account
+
+Start by creating a PayPal Account. [Sign up or login](http://paypal.com/). You'll need a business account for use in production but a personal account is fine for creating sandbox apps.
+
+_During sign up of a personal account, you may go to the next step in these directions when PayPal asks you to link a credit card or bank with your account._
+
+_During sign up of a business account, you may go to the next step in these directions when PayPal asks "How do you want to set up PayPal on your website?"._
+
+Confirm your email address using the email sent to you by PayPal.
+
+
+### Configuring Your App With a PayPal Sandbox
+
+PayPal uses a series of public and private certificates and keys to communicate with third party applications.
+
+You need to generate your application's private key (so that it is private!). To generate these, we'll use OpenSSL. If you're on Mac/Linux, you can run these commands inside `#{Rails.root}/config/paypalcerts/development/`:
+
+```
+openssl genrsa -out app_key.pem 1024
+openssl req -new -key app_key.pem -x509 -days 999 -out app_cert.pem
+```
+
+The app_key.pem file is your private key and the app_cert.pem is the public certificate. We require one more certificate, the PayPal public certificate. This certificate will come from your sandbox seller account.
+
+To login to the sandbox seller account:
+
+1. Visit the [PayPal developer portal](https://developer.paypal.com/) and click on "Sandbox" -> "Accounts".
+   It might take some time for the two default sandbox accounts to show up here if you just created your account (~10 minutes).
+2. Click on the facilitator account accordion, then click 'Profile'.
+3. Change the password of the facilitator account to whatever you want and copy the facilitator account email address.
+4. Go to the [PayPal sandbox site](https://www.sandbox.paypal.com/).
+5. Sign in using the facilitator account credentials
+
+**If the seller account is from Canada, you can follow these directions:**
+
+1. Click "Profile". Then click "Encrypted Payment Settings" under the "Selling Preferences" column.
+2. Download the PayPal public certicate in the middle of the page and save it as `#{Rails.root}/config/paypalcerts/development/paypal_cert.pem`.
+3. Upload the public certificate that you generated earlier, `app_cert.pem`, at the bottom of the page.
+4. Copy the new `Cert ID` of the new public certificiate and add it to the effective_orders initializer with other PayPal settings as the `:cert_id`.
+
+While you're logged in to the seller account, you should disable non-encrypted instant payment notifications (IPNs):
+
+1. Click on "Profile".
+2. Click on "Website Payment Preferences" under the "Selling Preferences" column.
+3. Under "Encrypted Website Payments", turn "Block Non-encrypted Website Payment" to "On"
+
+**If the seller account is from elsewhere, please contribute what you find. =)**
+
+Make sure all of the certificates/keys are available in the proper config directory (i.e. `#{Rails.root}/config/paypalcerts/development/paypal_cert.pem`)
+or set up environment variables to hold the full text or file location.
+
+Finally, finish adding config values in the effective_orders initializer. Set `config.paypal_enabled = true` and fill out the `config.paypal` settings:
+
+* seller_email - email that you logged into the sandbox site with above
+* secret - can be any string (see below)
+* cert_id - provided by PayPal after uploading your public `app_cert.pem`
+* paypal_url - https://www.sandbox.paypal.com/cgi-bin/webscr for sandbox or https://www.paypal.com/cgi-bin/webscr for real payments
+* currency - [choose your preference](https://developer.paypal.com/docs/integration/direct/rest-api-payment-country-currency-support/)
+* paypal_cert - PayPal's public certificate for your app, downloaded from PayPal earlier (this can be a string with `\n` in it or a path to the file)
+* app_cert - Your generated public certificate (this can be a string with `\n` in it or a path to the file)
+* app_key - Your generated private key (this can be a string with `\n` in it or a path to the file)
+
+The secret can be any string. Here's a good way to come up with a secret:
+
+```irb
+ & irb
+ > require 'securerandom'
+=> true
+ > SecureRandom.base64
+=> "KWidsksL/KR4LAf2EcRSdQ=="
+```
+
+### Configuring PayPal For Use With Real Payments
+
+This process should be very similar although you'll create and configure a seller account on paypal.com rather than the sandbox site.
+You should generate separate private and public certificates/keys for this and it is advisable to not keep production certificates/keys in version control.
 
 
 ## License

data/app/controllers/effective/orders_controller.rb

@@ -143,7 +143,7 @@ module Effective
     def order_purchased(details = nil, redirect_url = nil, declined_redirect_url = nil)
       begin
         @order.purchase!(details)
-        current_cart.try(:destroy)
+        Cart.where(user_id: @order.user_id).try(:destroy_all) # current_cart won't work for provider post backs here
 
         if EffectiveOrders.mailer[:send_order_receipt_to_buyer]
           flash[:success] = "Payment successful! Please check your email for a receipt."

data/app/helpers/effective_paypal_helper.rb

@@ -1,8 +1,18 @@
 module EffectivePaypalHelper
+  class ConfigReader
+    def self.cert_or_key(config)
+      if File.exist?(EffectiveOrders.paypal[config])
+        File.read(EffectiveOrders.paypal[config]) rescue {}
+      else
+        EffectiveOrders.paypal[config] || {}
+      end
+    end
+  end
+
   # These're constants so they only get read once, not every order request
-  PAYPAL_CERT_PEM = (File.read(EffectiveOrders.paypal[:paypal_cert]) rescue {})
-  APP_CERT_PEM = (File.read(EffectiveOrders.paypal[:app_cert]) rescue {})
-  APP_KEY_PEM = (File.read(EffectiveOrders.paypal[:app_key]) rescue {})
+  PAYPAL_CERT_PEM = ConfigReader.cert_or_key(:paypal_cert)
+  APP_CERT_PEM    = ConfigReader.cert_or_key(:app_cert)
+  APP_KEY_PEM     = ConfigReader.cert_or_key(:app_key)
 
   def paypal_encrypted_payload(order)
     raise ArgumentError.new("unable to read EffectiveOrders PayPal paypal_cert #{EffectiveOrders.paypal[:paypal_cert]}") unless PAYPAL_CERT_PEM.present?

data/app/models/concerns/acts_as_purchasable.rb

@@ -122,11 +122,6 @@ module ActsAsPurchasable
   end
 
   def purchased!(order = nil, order_item = nil)
-    # begin
-    #   self.quantity_purchased = (self.quantity_purchased + 1)
-    # rescue
-    # end
-
     after_purchase(order, order_item) if self.respond_to?(:after_purchase)
     save!
   end

data/lib/effective_orders/version.rb

@@ -1,3 +1,3 @@
 module EffectiveOrders
-  VERSION = '1.7.0'.freeze
+  VERSION = '1.7.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_orders
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-01 00:00:00.000000000 Z
+date: 2015-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails