effective_memberships 0.8.1 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a2ae153f152ca4d2295c8847e7848d10dde99d015c77367606cc1d00feb8743
-  data.tar.gz: f41d582a3c5da8491cfb82ac7129aaa796c3f4fc14ee49e5eff6e2770d725200
+  metadata.gz: f3936f6e8acaea0e3aea19acfb6ab2919eed75cf533997d7d3ceb9423acb67c1
+  data.tar.gz: d23bdf6c67f07b6d0558a4f03e40237b6a93a2a55603e9d534d4a9d63464f182
 SHA512:
-  metadata.gz: 218f5706b65bfc70fa9cd458678fb24cfa106751f91c98a636e304dc66494879789e95bcccfebf79eb993dd7797b56b72cf640de69013ded6b117e2ca6fb0f64
-  data.tar.gz: 2fcba0dab68d21ce5653e9d9e227895e227d887c3fbc80c2533be72cd190b1ad6a8a02b7b7041692957cd4edca505d24533fcb8653c82c3ace37623122d4498a
+  metadata.gz: 9245f8060285f526b024a616fe0125460fe59567140fd106c6f657f1504b9e5385157ef24f3e3ca5f1ca27ac78280929ee9ea87021ef1ad202bfd03d39d1d526
+  data.tar.gz: 76586e73e7f04ff55343be3012169d5afb6b8fe3265279b46aab16c9f32f6798b7582282fe63bef73cc37278376538ac004b3a21691b4a0da932270786e22664

data/app/models/concerns/effective_memberships_directory.rb

@@ -29,7 +29,8 @@ module EffectiveMembershipsDirectory
 
   # Base collection to search. Can be configured per tenant.
   def collection
-    Effective::Membership.directory
+    # Example::User.members.membership_in_good_standing.all
+    raise('to be implemented by app membership_directory')
   end
 
   # Search Users and Organizations for only these fields. Passed into search_any. Return nil for all.
@@ -50,14 +51,14 @@ module EffectiveMembershipsDirectory
   # Assigns the entire collection() if there are no search terms
   # Otherwise validate the search terms
   def search!
-    @memberships = build_collection()
-    @memberships = @memberships.none if present? && !valid?
-    @memberships
+    @membership_owners = build_collection()
+    @membership_owners = @membership_owners.none if present? && !valid?
+    @membership_owners
   end
 
   # The unpaginated results of the search
-  def memberships
-    @memberships || collection
+  def membership_owners
+    @membership_owners || collection
   end
 
   # The paginated results
@@ -65,54 +66,38 @@ module EffectiveMembershipsDirectory
     page = (page || 1).to_i
     offset = [(page - 1), 0].max * per_page
 
-    memberships().limit(per_page).offset(offset)
+    membership_owners.limit(per_page).offset(offset)
   end
 
   protected
 
   def build_collection
-    memberships = collection()
-    raise('expected an ActiveRecord collection') unless memberships.kind_of?(ActiveRecord::Relation)
+    owners = collection()
+    raise('expected an ActiveRecord collection') unless owners.kind_of?(ActiveRecord::Relation)
+    raise('expected a collection of membership_owners') unless owners.klass.respond_to?(:effective_memberships_owner?)
 
     # Filter by term
     if term.present?
-      memberships = search_owners(memberships, term, search_any_columns)
+      owners = Effective::Resource.new(owners).search_any(term, columns: search_any_columns)
     end
 
     # Filter by first name
     if first_name.present?
-      memberships = search_owners(memberships, first_name, :first_name)
+      owners = Effective::Resource.new(owners).search_any(first_name, columns: :first_name)
     end
 
     # Filter by last name
     if last_name.present?
-      memberships = search_owners(memberships, last_name, :last_name)
+      owners = Effective::Resource.new(owners).search_any(last_name, columns: :last_name)
     end
 
     # Filter by category
     if category.present?
       cat = EffectiveMemberships.Category.where(id: category)
-      memberships = memberships.with_category(cat) if cat.present?
+      owners = owners.members_with_category(cat) if cat.present?
     end
 
-    memberships
-  end
-
-  def search_owners(collection, term, columns = nil)
-    results = collection.none()
-
-    owner_klasses.each do |klass|
-      search = Effective::Resource.new(klass).search_any(term, columns: columns)
-      searched = collection.where(owner_type: klass.name, owner_id: search.select('id'))
-
-      results = results.or(searched)
-    end
-
-    collection.merge(results)
-  end
-
-  def owner_klasses
-    @owner_klasses ||= Effective::Membership.owner_klasses
+    owners
   end
 
 end

data/app/models/effective/membership.rb

@@ -73,8 +73,6 @@ module Effective
     scope :not_in_good_standing, -> { with_status(EffectiveMemberships.Registrar.not_in_good_standing_status) }
     scope :in_good_standing, -> { without_status(EffectiveMemberships.Registrar.not_in_good_standing_status) }
 
-    scope :directory, -> { deep.in_good_standing.order(:id) }
-
     before_validation do
       self.registration_on ||= joined_on
     end

data/app/views/effective/applicants/equivalences.html.haml

@@ -6,12 +6,15 @@
       %p You must include #{resource.min_applicant_equivalences} or more equivalent memberships.
 
     - if resource.min_applicant_equivalences == 0
-      %p Equivalent memberships are not required. Click the Remove button to skip adding memberships.
+      %p Equivalent memberships are not required.
+
+    - if resource.applicant_equivalences.blank?
+      %p Click Add Another to add an equivalent membership.
 
     = effective_form_with(model: resource, url: wizard_path(step), method: :put) do |f|
       = f.hidden_field :id
 
-      = f.has_many(:applicant_equivalences, cards: true) do |aef|
+      = f.has_many(:applicant_equivalences, cards: true, build: false) do |aef|
         %h4.mb-4 Equivalent Membership
 
         = aef.text_field :name

data/app/views/effective/membership_directory/_membership_directory.html.haml

@@ -8,9 +8,10 @@
 
   - results.in_groups_of(3).each do |group|
     .row.mt-4
-      - group.each do |membership|
-        - next unless membership
-        .col-md= render('effective/membership_directory/membership', membership: membership)
+      - group.each do |owner|
+        - next unless owner
+        .col-md
+          = render('effective/membership_directory/membership_owner', membership: owner.membership, owner: owner)
 
   %nav.d-flex.justify-content-center
     = bootstrap_paginate(results, per_page: membership_directory.per_page)

data/app/views/effective/membership_directory/{_membership.html.haml → _membership_owner.html.haml}

@@ -1,4 +1,4 @@
 = card do
-  %h6= membership.owner
+  %h6= owner
   %p= membership.categories.to_sentence
   %p= membership.statuses.to_sentence

data/lib/effective_memberships/version.rb

@@ -1,3 +1,3 @@
 module EffectiveMemberships
-  VERSION = '0.8.1'
+  VERSION = '0.8.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_memberships
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.3
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-24 00:00:00.000000000 Z
+date: 2022-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -481,8 +481,8 @@ files:
 - app/views/effective/membership_cards/index.html.haml
 - app/views/effective/membership_directory/_form.html.haml
 - app/views/effective/membership_directory/_layout.html.haml
-- app/views/effective/membership_directory/_membership.html.haml
 - app/views/effective/membership_directory/_membership_directory.html.haml
+- app/views/effective/membership_directory/_membership_owner.html.haml
 - app/views/effective/membership_directory/index.html.haml
 - app/views/effective/memberships/_dashboard.html.haml
 - app/views/effective/memberships/_membership.html.haml