effective_memberships 0.3.10 → 0.3.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c506926f876b0fe6e4559cce6784e0c0ac8f30891dca21183f74dd5ab1fc5ee6
-  data.tar.gz: 980454f32127c3423d33aaaf4136615fac433dbede09f718ae7ebfb1c0cc3b39
+  metadata.gz: 38134acc9619d9ea0404332803f0c17535fee985688ddcc628db39c1cbf9987c
+  data.tar.gz: 781c42e6cdeb6c501aa696c1a13bc9917db90c5090b05a845754b2547b4a9689
 SHA512:
-  metadata.gz: 29813982537ac083f937e2c1d8df597676b51eb26c7512f773f018fd91e0e2a3a389b6095f89ba8e8acdb44086313b2ff3638f926f380490366b8c7148eaaf46
-  data.tar.gz: 436039fe95ff3c095bb755663ec6f51674ffe620957b2f1a0557d598f634eeb651aa317476a887d818cd71bacf5a9708eb34eab2df06a3456201c6b02e1af890
+  metadata.gz: 6ea602b5671e84066f96d77d996c08f6524ff46659ff1ede3b0b730a133c95693aa83b1e4dbf837b06f271c8d01ee73fa9c1c44528a2fd4bb3b3e10123e60888
+  data.tar.gz: dc6909b2b20ef4db2200be6cd8bcbf2bcc2ea5492e2c745ae64b48158b4092b78db8305b43d0ae46f2fa800e41767bbb1faf9ad13a9547b0676b3dd8ff283520

data/app/controllers/admin/applicants_controller.rb

@@ -8,6 +8,20 @@ module Admin
     resource_scope -> { EffectiveMemberships.Applicant.deep.all }
     datatable -> { Admin::EffectiveApplicantsDatatable.new }
 
+    submit :complete, 'Complete Applicant', success: -> {
+      [
+        "Successfully completed #{resource.owner} #{resource}",
+        ("and sent #{resource.owner.email} a notification" unless resource.email_form_skip)
+      ].compact.join(' ')
+    }
+
+    submit :missing, 'Missing Info Applicant', success: -> {
+      [
+        "Successfully marked #{resource.owner} #{resource} as missing info",
+        ("and sent #{resource.owner.email} a notification" unless resource.email_form_skip)
+      ].compact.join(' ')
+    }
+
     submit :approve, 'Approve Applicant', success: -> {
       [
         "Successfully approved #{resource.owner} #{resource}",

data/app/controllers/effective/applicants_controller.rb

@@ -6,5 +6,7 @@ module Effective
 
     resource_scope -> { EffectiveMemberships.Applicant.deep.where(owner: current_user.effective_memberships_owners) }
 
+    submit :resubmit, 'Submit Application'
+
   end
 end

data/app/datatables/admin/effective_applicants_datatable.rb

@@ -11,14 +11,19 @@ module Admin
       order :id
       col :id, visible: false
 
-      col :status
+      col :status, search: effective_memberships_status_collection()
 
       col :created_at, label: 'Created', as: :date, visible: false
       col :updated_at, label: 'Updated', visible: false
 
       col :submitted_at, label: 'Submitted', visible: false, as: :date
       col :completed_at, label: 'Completed', visible: false, as: :date
-      col :reviewed_at, label: 'Reviewed', visible: false, as: :date
+      col :missing_info_at, label: 'Missing Info', visible: false, as: :date
+
+      if EffectiveMemberships.applicant_reviews?
+        col :reviewed_at, label: 'Reviewed', visible: false, as: :date
+      end
+
       col :approved_at, label: 'Approved', visible: false, as: :date
 
       col :owner

data/app/datatables/admin/effective_fees_datatable.rb

@@ -33,7 +33,9 @@ module Admin
 
       col :category, search: { collection: EffectiveMemberships.Category.all, polymorphic: false }
 
-      aggregate :total
+      unless attributes[:total] == false
+        aggregate :total
+      end
 
       if attributes[:applicant_id]
         actions_col(new: false)
@@ -63,11 +65,11 @@ module Admin
     end
 
     def applicant
-      @applicant ||= EffectiveMemberships.Applicant.find(attributes[:applicant_id])
+      @applicant ||= EffectiveMemberships.Applicant.where(id: attributes[:applicant_id]).first!
     end
 
     def fee_payment
-      @fee_payment ||= EffectiveMemberships.FeePayment.find(attributes[:fee_payment_id])
+      @fee_payment ||= EffectiveMemberships.FeePayment.where(id: attributes[:fee_payment_id]).first!
     end
 
   end

data/app/datatables/effective_applicants_datatable.rb

@@ -6,14 +6,20 @@ class EffectiveApplicantsDatatable < Effective::Datatable
     col :id, visible: false
 
     col :category, label: 'Category'
-    col :status
+    col :status, search: effective_memberships_status_collection()
 
     col :created_at, label: 'Created', as: :date
     col :updated_at, label: 'Updated', as: :date, visible: false
+
     col :submitted_at, label: 'Submitted', as: :date
-    col :completed_at, label: 'Completed', as: :date
-    col :reviewed_at, label: 'Reviewed', as: :date
-    col :approved_at, label: 'Approved', visible: false, as: :date
+    col :completed_at, label: 'Completed', as: :date, visible: false
+    col :missing_info_at, label: 'Missing Info', as: :date, visible: false
+
+    if EffectiveMemberships.applicant_reviews?
+      col :reviewed_at, label: 'Reviewed', as: :date
+    end
+
+    col :approved_at, label: 'Approved', as: :date
 
     col :orders
 

data/app/helpers/effective_memberships_helper.rb

@@ -1,2 +1,11 @@
 module EffectiveMembershipsHelper
+
+  def effective_memberships_status_collection
+    EffectiveMemberships.Applicant::STATUSES.map do |status|
+      next if status == :reviewed && !EffectiveMemberships.applicant_reviews?
+
+      [status.to_s.gsub('_', ' '), status]
+    end.compact
+  end
+
 end

data/app/mailers/effective/memberships_mailer.rb

@@ -1,18 +1,29 @@
 module Effective
   class MembershipsMailer < EffectiveMemberships.parent_mailer_class
-    include EffectiveEmailTemplatesMailer
+
+    include EffectiveEmailTemplatesMailer if EffectiveMemberships.use_effective_email_templates
 
     default from: -> { EffectiveMemberships.mailer_sender }
-    layout -> { EffectiveMemberships.mailer_layout || 'effective_memberships_mailer_layout' }
+    layout -> { EffectiveMemberships.mailer_layout }
+
+    def applicant_completed(resource, opts = {})
+      @assigns = assigns_for(resource)
+      mail(to: resource.owner.email, **headers_for(resource, opts))
+    end
+
+    def applicant_missing_info(resource, opts = {})
+      @assigns = assigns_for(resource)
+      mail(to: resource.owner.email, **headers_for(resource, opts))
+    end
 
     def applicant_approved(resource, opts = {})
       @assigns = assigns_for(resource)
-      mail(to: EffectiveMemberships.mailer_admin, **headers_for(resource, opts))
+      mail(to: resource.owner.email, **headers_for(resource, opts))
     end
 
     def applicant_declined(resource, opts = {})
       @assigns = assigns_for(resource)
-      mail(to: EffectiveMemberships.mailer_admin, **headers_for(resource, opts))
+      mail(to: resource.owner.email, **headers_for(resource, opts))
     end
 
     def applicant_reference_notification(resource, opts = {})
@@ -49,11 +60,11 @@ module Effective
 
         url: effective_memberships.applicant_url(applicant),
         admin_url: effective_memberships.edit_admin_applicant_url(applicant),
-      }
 
-      if applicant.declined_reason.present?
-        values.merge!(declined_reason: applicant.declined_reason)
-      end
+        # Optional
+        declined_reason: applicant.declined_reason.presence,
+        missing_info_reason: applicant.missing_info_reason.presence
+      }.compact
 
       { applicant: values }
     end

data/app/models/concerns/effective_memberships_applicant.rb

@@ -32,12 +32,13 @@ module EffectiveMembershipsApplicant
     acts_as_tokened
 
     acts_as_statused(
-      :draft,       # Just Started
-      :submitted,   # Completed wizard. Paid applicant fee.
-      :completed,   # Admin has received all deliverables. The application is complete and ready for review.
-      :reviewed,    # All applicant reviews completed
-      :declined,    # Exit state. Application was declined.
-      :approved     # Exit state. Application was approved.
+      :draft,         # Just Started
+      :submitted,     # Completed wizard. Paid applicant fee.
+      :missing_info,  # Admin has indicated information is missing. The applicant can edit applicant and add info
+      :completed,     # Admin has received all deliverables. The application is complete and ready for review.
+      :reviewed,      # All applicant reviews completed
+      :declined,      # Exit state. Application was declined.
+      :approved       # Exit state. Application was approved.
     )
 
     acts_as_wizard(
@@ -121,18 +122,22 @@ module EffectiveMembershipsApplicant
       declined_at            :datetime
       declined_reason        :text
 
+      # Missing Info
+      missing_info_at        :datetime
+      missing_info_reason    :text
+
       # Applicant Educations
-      applicant_educations_details  :text
+      applicant_educations_details    :text
 
       # Applicant Experiences
-      applicant_experiences_months   :integer
-      applicant_experiences_details  :text
+      applicant_experiences_months    :integer
+      applicant_experiences_details   :text
 
       # Additional Information
-      additional_information         :text
+      additional_information          :text
 
       # Acts as Wizard
-      wizard_steps           :text, permitted: false
+      wizard_steps                    :text, permitted: false
 
       timestamps
     end
@@ -264,9 +269,12 @@ module EffectiveMembershipsApplicant
     # Admin Decline
     validates :declined_reason, presence: true, if: -> { declined? }
 
+    # Admin Missing Info
+    validates :missing_info_reason, presence: true, if: -> { missing_info? }
+
     # These two try completed and try reviewed
-    before_save(if: -> { submitted? }) { complete! }
-    before_save(if: -> { completed? }) { review! }
+    # before_save(if: -> { submitted? }) { complete! }
+    # before_save(if: -> { completed? }) { review! }
 
     # Clear required steps memoization
     after_save { @_required_steps = nil }
@@ -290,6 +298,14 @@ module EffectiveMembershipsApplicant
       end
     end
 
+    def can_visit_step?(step)
+      if missing_info?
+        return [:start, :select, :billing, :checkout].exclude?(step)
+      end
+
+      can_revisit_completed_steps(step)
+    end
+
     # All Fees and Orders
     def submit_fees
       # Find or build submit fee
@@ -374,6 +390,10 @@ module EffectiveMembershipsApplicant
     approved? || declined?
   end
 
+  def status_label
+    (status_was || status).to_s.gsub('_', ' ')
+  end
+
   def summary
     case status_was
     when 'draft'
@@ -388,6 +408,8 @@ module EffectiveMembershipsApplicant
       else
         "This application has been completed and is now ready for an admin to approve or decline it. If approved, prorated fees will be generated."
       end
+    when 'missing_info'
+      "Missing the following information: <ul><li>#{missing_info_reason}</li></ul>"
     when 'reviewed'
       "This application has been reviewed and is now ready for an admin to approve or decline it. If approved, prorated fees will be generated."
     when 'approved'
@@ -489,7 +511,8 @@ module EffectiveMembershipsApplicant
     min_applicant_references > 0
   end
 
-  # When an application is submitted, these must be done to go to completed
+  # When an application is submitted, these must be done to go to completed.
+  # An Admin can override this and just set them to completed.
   def completed_requirements
     {
       'Applicant References' => (!applicant_references_required? || applicant_references.count(&:completed?) >= min_applicant_references)
@@ -497,9 +520,34 @@ module EffectiveMembershipsApplicant
   end
 
   def complete!
-    return false unless submitted? && completed_requirements.values.all?
-    # Could send registrar an email here saying this applicant is ready to review
+    raise('applicant must have been submitted to complete!') unless was_submitted?
+
+    # Let an admin ignore these requirements if need be
+    # return false unless submitted? && completed_requirements.values.all?
+
+    assign_attributes(missing_info_reason: nil)
     completed!
+
+    after_commit { send_email(:applicant_completed) }
+    true
+  end
+
+  def missing!
+    raise('applicant must have been submitted to missing!') unless was_submitted?
+
+    missing_info!
+
+    after_commit { send_email(:applicant_missing_info) }
+    true
+  end
+
+  def resubmit!
+    raise('applicant must have been submitted and missing info to resubmit!') unless was_submitted? && was_missing_info?
+    raise('already submitted') if submitted?
+    raise('expected a purchased order') unless submit_order&.purchased?
+
+    assign_attributes(skip_to_step: :submitted, submitted_at: Time.zone.now)
+    submitted!
   end
 
   # Completed -> Reviewed requirements
@@ -512,6 +560,7 @@ module EffectiveMembershipsApplicant
   end
 
   # When an application is completed, these must be done to go to reviewed
+  # An Admin can override this and just set them to reviewed.
   def reviewed_requirements
     {
       'Applicant Reviews' => (!applicant_reviews_required? || applicant_reviews.count(&:completed?) >= min_applicant_reviews)
@@ -519,8 +568,10 @@ module EffectiveMembershipsApplicant
   end
 
   def review!
-    return false unless completed? && reviewed_requirements.values.all?
-    # Could send registrar an email here saying this applicant is ready to approve
+    raise('applicant must have been submitted to review!') unless was_submitted?
+
+    # Let an admin ignore these requirements if need be
+    # return false unless completed? && reviewed_requirements.values.all?
     reviewed!
   end
 
@@ -532,6 +583,8 @@ module EffectiveMembershipsApplicant
     # Complete the wizard step. Just incase this is run out of order.
     wizard_steps[:checkout] ||= Time.zone.now
     wizard_steps[:submitted] ||= Time.zone.now
+    assign_attributes(missing_info_reason: nil)
+
     approved!
 
     if apply_to_join?

data/app/models/concerns/effective_memberships_owner.rb

@@ -56,7 +56,9 @@ module EffectiveMembershipsOwner
     owners = organizations if self.class.respond_to?(:effective_organizations_user?)
     owners = users if self.class.respond_to?(:effective_organizations_organization?)
 
-    owners = Array(owners).reject { |owner| owner.try(:archived?) }
+    owners = Array(owners)
+      .select { |owner| owner.class.respond_to?(:effective_memberships_owner?) }
+      .reject { |owner| owner.try(:archived?) }
 
     owners.presence || [self]
   end
@@ -73,7 +75,11 @@ module EffectiveMembershipsOwner
 
   def organization_membership_present?(except: nil)
     return false unless self.class.respond_to?(:effective_organizations_user?)
-    organizations.any? { |organization| organization != except && organization.membership_present? }
+
+    organizations
+      .select { |organization| organization.class.respond_to?(:effective_memberships_owner?) }
+      .reject { |organization| organization.try(:archived?) }
+      .any? { |organization| organization != except && organization.membership_present? }
   end
 
   def assign_member_role

data/app/views/admin/applicants/_form.html.haml

@@ -25,13 +25,17 @@
     = tab 'References' do
       .mb-4= render_inline_datatable(Admin::EffectiveApplicantReferencesDatatable.new(applicant: applicant))
 
-  - if applicant.fees.present?
+  - if applicant.fees.present? || applicant.orders.present?
     = tab 'Fees' do
-      .mb-4= render_inline_datatable(Admin::EffectiveFeesDatatable.new(applicant_id: applicant.to_param))
-
-  - if applicant.orders.present?
-    = tab 'Orders' do
-      .mb-4= render_datatable(Admin::EffectiveOrdersDatatable.new(parent_id: applicant.id, parent_type: EffectiveMemberships.Applicant.name, owner_id: applicant.owner_id, user_type: applicant.owner_type))
+      .mb-4
+        %h2 Fees
+        - datatable = Admin::EffectiveFeesDatatable.new(applicant: applicant, total: false)
+        = render_datatable(datatable, simple: true, inline: true)
+
+      .mb-4
+        %h2 Orders
+        - datatable = Admin::EffectiveOrdersDatatable.new(parent: applicant, owner: applicant.owner, user: applicant.owner, total: false)
+        = render_datatable(datatable, simple: true)
 
   - if applicant.owner.applicants.any? { |other| other.was_submitted? && other.id != applicant.id }
     = tab 'Other Applications' do

data/app/views/admin/applicants/_form_approve.html.haml

@@ -1,13 +1,9 @@
 = effective_form_with(model: [:admin, applicant], engine: true) do |f|
-  %p The #{applicant} will be <strong>approved</strong> to the following membership category.
-
-  %h3 Category
-  = f.static_field :category, label: 'Applied for'
+  %p The #{applicant} will be <strong>approved</strong> to the following membership category:
 
   - categories = EffectiveMemberships.Category.all
   = f.select :category_id, categories, label: 'Approve to'
 
-  %h3 Number
   %p
     - if applicant.owner.membership&.number_was.present?
       The member will keep their existing membership number: #{applicant.owner.membership.number}.

data/app/views/admin/applicants/_form_complete.html.haml

@@ -0,0 +1,8 @@
+= effective_form_with(model: [:admin, applicant], engine: true) do |f|
+  %p The #{applicant} will be <strong>completed</strong>. All deliverables have been received and all requirements completed.
+
+  %h3 Email to send
+  %p The following email will be sent:
+  = email_form_fields(f, :applicant_completed)
+
+  = f.submit 'Complete Applicant', border: false, center: true, 'data-confirm': "Complete #{f.object.owner}?"

data/app/views/admin/applicants/_form_missing_info.html.haml

@@ -0,0 +1,11 @@
+= effective_form_with(model: [:admin, applicant], engine: true) do |f|
+  %p This applicant will be marked as <strong>missing information</strong> with the following:
+
+  = f.text_field :missing_info_reason, required: true, label: 'Explanation of missing info'
+
+  %h3 Email to send
+
+  %p The following email will be sent:
+  = email_form_fields(f, :applicant_missing_info)
+
+  = f.submit 'Missing Info Applicant', border: false, center: true, 'data-confirm': "Missing Info #{f.object.owner}?"

data/app/views/admin/applicants/_form_process.html.haml

@@ -1,18 +1,22 @@
 %p
-  %span.badge.badge-secondary= applicant.status
+  %span.badge.badge-secondary= applicant.status_label
   = applicant.summary
 
-= tabs(list: { class: 'nav nav-pills'}) do
+%p Process applicant:
+
+= accordion do
+  - if EffectiveResources.authorized?(self, :complete, applicant)
+    = collapse 'Complete this Applicant' do
+      = render('admin/applicants/form_complete', applicant: applicant)
+
+  - if EffectiveResources.authorized?(self, :missing, applicant)
+    = collapse 'Missing Information' do
+      = render('admin/applicants/form_missing_info', applicant: applicant)
+
   - if EffectiveResources.authorized?(self, :approve, applicant)
-    = tab 'Approve this Applicant' do
-      .card.mt-4
-        .card-body
-          %h5.card-title Approve
-          = render('admin/applicants/form_approve', applicant: applicant)
+    = collapse 'Approve this Applicant' do
+      = render('admin/applicants/form_approve', applicant: applicant)
 
   - if EffectiveResources.authorized?(self, :decline, applicant)
-    = tab 'Decline this Applicant' do
-      .card.mt-4
-        .card-body
-          %h5.card-title Decline
-          = render('admin/applicants/form_decline', applicant: applicant)
+    = collapse 'Decline this Applicant' do
+      = render('admin/applicants/form_decline', applicant: applicant)

data/app/views/admin/applicants/_status.html.haml

@@ -1,5 +1,5 @@
 %p
-  %span.badge.badge-secondary= applicant.status_was
+  %span.badge.badge-secondary= applicant.status_label
   = applicant.summary
 
 %table.table.table-sm.table-striped
@@ -11,6 +11,8 @@
       %th
         - # Next action button
   %tbody
+
+    -# Draft
     %tr
       %td In Progress
       %td= applicant.created_at.strftime('%F')
@@ -21,6 +23,8 @@
         - else
           = '-'
       %td
+
+    - # Submitted
     %tr
       %td Application Submitted
       %td= applicant.submitted_at&.strftime('%F') || '-'
@@ -30,6 +34,8 @@
         - else
           = '-'
       %td
+
+    - # Waiting to Complete
     %tr
       %td Waiting to Complete
       %td= applicant.submitted_at&.strftime('%F') || '-'
@@ -63,71 +69,83 @@
             References Not Required
 
       %td
-        -# - if !applicant.was_approved? && applicant.transcripts_required? && !applicant.transcripts_approved?
-        -#   = link_to 'Process Transcripts', '#transcripts', 'data-click-tab': true, class: 'btn btn-sm btn-primary'
+        - if applicant.submitted?
+          = link_to 'Complete Applicant', '#process', 'data-click-tab': true, class: 'btn btn-sm btn-primary'
 
-        -# - if !applicant.was_approved? && applicant.nwpta_form_required? && !applicant.nwpta_form_received?
-        -#   = link_to 'Receive NWPTA Form', '#nwpta-verification-form', 'data-click-tab': true, class: 'btn btn-sm btn-primary'
+    - # Missing Information
+    %tr
+      %td Missing Information
+      %td= applicant.missing_info_at&.strftime('%F') || '-'
+      %td= applicant.missing_info_reason
+      %td
 
+    - # Completed
     %tr
-      %td Application Complete
+      %td Application Completed
       %td= applicant.completed_at&.strftime('%F') || '-'
       %td
+        - if applicant.completed_at.present?
+          = icon('check', class: 'small-1')
+          Done
       %td
 
-    %tr
-      %td Reviews
-      %td= applicant.reviewed_at&.strftime('%F') || '-'
-      %td
-        - applicant.reviewed_requirements.each do |requirement, completed|
-          - next if requirement.to_s == 'Applicant Reviews'
+    - # Reviewed
+    - if EffectiveMemberships.applicant_reviews?
+      %tr.effective-memberships-applicant-status-reviewed
+        %td Reviews
+        %td= applicant.reviewed_at&.strftime('%F') || '-'
+        %td
+          - applicant.reviewed_requirements.each do |requirement, completed|
+            - next if requirement.to_s == 'Applicant Reviews'
 
-          %p
-            = icon((completed ? 'check' : 'x'), class: 'small-1')
-            = requirement
+            %p
+              = icon((completed ? 'check' : 'x'), class: 'small-1')
+              = requirement
 
-        - if applicant.applicant_reviews_required?
-          %p
-            - if applicant.reviewed_requirements['Applicant Reviews']
+          - if applicant.applicant_reviews_required?
+            %p
+              - if applicant.reviewed_requirements['Applicant Reviews']
+                = icon('check', class: 'small-1')
+
+              = applicant.applicant_reviews.count(&:completed?)
+              = '/'
+              = applicant.min_applicant_reviews
+              Reviews Completed
+          - else
+            %p
               = icon('check', class: 'small-1')
+              Reviews Not Required
 
-            = applicant.applicant_reviews.count(&:completed?)
-            = '/'
-            = applicant.min_applicant_reviews
-            Reviews Completed
-        - else
-          %p
-            = icon('check', class: 'small-1')
-            Reviews Not Required
+        %td
+          - # Button to create reviews here
 
+    %tr
+      %td Waiting to Process
       %td
-        - if applicant.was_reviewed? && !applicant.was_approved?
+        - if EffectiveMemberships.applicant_reviews?
+          = applicant.reviewed_at&.strftime('%F') || '-'
+        - else
+          = applicant.completed_at&.strftime('%F') || '-'
+      %td
+      %td
+        - if applicant.was_submitted? && !(applicant.approved? || applicant.declined?)
           = link_to 'Process Applicant', '#process', 'data-click-tab': true, class: 'btn btn-sm btn-primary'
 
-    - if applicant.declined_at.present?
-      %tr
-        %td Processed
-        %td= applicant.declined_at.strftime('%F')
-        %td
+    %tr
+      %td Processed
+      %td= (applicant.approved_at&.strftime('%F') || applicant.declined_at&.strftime('%F') || '-')
+      %td
+        - if applicant.was_approved? && !applicant.approved?
+          = icon('check', class: 'small-1')
+          Approved
+
+        - elsif applicant.was_declined? || applicant.declined?
           = icon('check', class: 'small-1')
           Declined
           %br
           = applicant.declined_reason
-        %td
 
-    - if applicant.was_approved?
-      %tr
-        %td Processed
-        %td= applicant.approved_at&.strftime('%F')
-        %td
-          - if applicant.was_approved?
-            = icon('check', class: 'small-1')
-            Approved
-          - elsif applicant.declined?
-            = icon('check', class: 'small-1')
-            Declined
-            %br
-            = applicant.declined_reason
-          - else
-            = '-'
-        %td
+        - elsif applicant.approved?
+          = icon('check', class: 'small-1')
+          Approved
+      %td

data/app/views/effective/applicants/_missing_info.html.haml

@@ -0,0 +1,18 @@
+%h3 Missing Information
+%p The following information is missing: #{resource.missing_info_reason}.
+
+%p
+  Please revisit each wizard step and
+  = link_to 'complete all missing information', wizard_path(:demographics)
+  for this application.
+
+%p
+  Once you're ready, click below to re-submit your application with the updated information.
+
+%p
+  = effective_form_with(model: resource, url: wizard_path(step), method: :put) do |f|
+    = f.hidden_field :id
+    = f.save 'Submit Application', 'data-confirm': "Really submit application?"
+
+%p
+  %small * No additional payment required.

data/app/views/effective/applicants/_summary.html.haml

@@ -36,5 +36,5 @@
     %tr
       %th Status
       %td
-        %span.badge.badge-secondary= applicant.status
+        %span.badge.badge-secondary= applicant.status_label
         = applicant.summary

data/app/views/effective/applicants/submitted.html.haml

@@ -5,8 +5,7 @@
   - raise('expected a purchased applicant submit_order') unless resource.submit_order&.purchased?
 
   .alert.alert-success.mb-4
-    This application was submitted on
-    = resource.submit_order.purchased_at.strftime('%F')
+    This application was submitted on #{resource.submitted_at.strftime('%F')}
 
   - unless resource.approved?
     .card
@@ -20,15 +19,18 @@
   .card
     .card-body= render 'effective/applicants/summary', applicant: resource
 
+  - if resource.missing_info?
+    = card do
+      = render 'effective/applicants/missing_info', applicant: resource
+
   - if resource.min_applicant_references.to_i > 0 || resource.applicant_references.present?
-    .card
-      .card-body
-        %h3 Confidential References
-        %p
-          References are automatically sent a reference request.
-          Click 'New' to add an additional reference, or click 'Notify' to resend the reference request.
+    = card do
+      %h3 Confidential References
+      %p
+        References are automatically sent a reference request.
+        Click 'New' to add an additional reference, or click 'Notify' to resend the reference request.
 
-        = render_datatable(EffectiveApplicantReferencesDatatable.new(applicant: resource), inline: true, simple: true)
+      = render_datatable(EffectiveApplicantReferencesDatatable.new(applicant: resource), inline: true, simple: true)
 
   .mb-4
     = collapse('Show application...', card_class: 'my-2') do

data/app/views/effective/applicants/summary.html.haml

@@ -5,4 +5,10 @@
 
   = effective_form_with(model: resource, url: wizard_path(step), method: :put) do |f|
     = f.hidden_field :id
-    = f.submit 'Save and Continue', border: false, left: true
+
+    = f.submit(border: false, left: true) do
+      -# Missing Info
+      - if EffectiveResources.authorized?(self, :resubmit, resource)
+        = f.save 'Submit Application'
+      - else
+        = f.save 'Save and Continue'

data/app/views/effective/memberships_mailer/applicant_completed.liquid

@@ -0,0 +1,15 @@
+---
+subject: 'Your application was marked as completed!'
+from: 'admin@example.com'
+---
+Hello {{ user.name }},
+
+Your application for {{ applicant.to_category }} has been marked completed.
+
+It is ready for review and a final decision to approve or decline.
+
+{{ applicant.url }}
+
+Thank you.
+
+Please contact us for assistance.

data/app/views/effective/memberships_mailer/applicant_missing_info.liquid

@@ -0,0 +1,17 @@
+---
+subject: 'Your application is missing information'
+from: 'admin@example.com'
+---
+Hello {{ user.name }},
+
+Your application for {{ applicant.to_category }} is missing information:
+
+{{ applicant.missing_info_reason }}
+
+Please update your application with this info.
+
+{{ applicant.url }}
+
+Thank you.
+
+Please contact us for assistance.

data/config/effective_memberships.rb

@@ -21,27 +21,25 @@ EffectiveMemberships.setup do |config|
   # The defaults include: Applicant, Prorated, Renewal, Late, Admin
   # config.additional_fee_types = []
 
-  # Mailer Configuration
+  # Applicant Reviews
+  # When true, display the reviewed state and require Category.min_applicant_reviews
+  # When false, hide the reviewed state entirely
+  # config.applicant_reviews = false
+
+  # Mailer Settings
+  # Please see config/initializers/effective_resources.rb for default effective_* gem mailer settings
+  #
   # Configure the class responsible to send e-mails.
   # config.mailer = 'Effective::MembershipsMailer'
-
-  # Configure the parent class responsible to send e-mails.
-  # config.parent_mailer = 'ActionMailer::Base'
-
-  # Default deliver method
-  # config.deliver_method = :deliver_later
-
-  # Default layout
-  # config.mailer_layout = 'effective_memberships_mailer_layout'
-
-  # Default From
-  config.mailer_sender = "no-reply@example.com"
-
-  # Send Admin correspondence To
-  config.mailer_admin = "admin@example.com"
-
-  # Will work with effective_email_templates gem:
-  # - The audit and audit review email content will be preopulated based off the template
-  # - Uses an EmailTemplatesMailer mailer instead of ActionMailer::Base for default parent_mailer
-  config.use_effective_email_templates = false
+  #
+  # Override effective_resource mailer defaults
+  #
+  # config.parent_mailer = nil      # The parent class responsible for sending emails
+  # config.deliver_method = nil     # The deliver method, deliver_later or deliver_now
+  # config.mailer_layout = nil      # Default mailer layout
+  # config.mailer_sender = nil      # Default From value
+  # config.mailer_admin = nil       # Default To value for Admin correspondence
+
+  # Will work with effective_email_templates gem
+  config.use_effective_email_templates = true
 end

data/db/migrate/01_create_effective_memberships.rb.erb

@@ -151,6 +151,10 @@ class CreateEffectiveMemberships < ActiveRecord::Migration[6.0]
       t.datetime :declined_at
       t.text :declined_reason
 
+      # Missing
+      t.datetime :missing_info_at
+      t.text :missing_info_reason
+
       # Applicant Educations
       t.text :applicant_educations_details
 

data/lib/effective_memberships/version.rb

@@ -1,3 +1,3 @@
 module EffectiveMemberships
-  VERSION = '0.3.10'
+  VERSION = '0.3.13'
 end

data/lib/effective_memberships.rb

@@ -8,7 +8,7 @@ module EffectiveMemberships
     [
       :categories_table_name, :applicants_table_name, :applicant_reviews_table_name, :fee_payments_table_name,
       :category_class_name, :applicant_class_name, :applicant_review_class_name, :fee_payment_class_name, :registrar_class_name, :membership_card_class_name,
-      :additional_fee_types,
+      :additional_fee_types, :applicant_reviews,
       :layout,
       :mailer, :parent_mailer, :deliver_method, :mailer_layout, :mailer_sender, :mailer_admin, :use_effective_email_templates
     ]
@@ -36,6 +36,10 @@ module EffectiveMemberships
     membership_card_class_name&.constantize || Effective::MembershipCard
   end
 
+  def self.applicant_reviews?
+    applicant_reviews == true
+  end
+
   # Singleton
   def self.Registrar
     klass = registrar_class_name&.constantize || Effective::Registrar
@@ -46,17 +50,6 @@ module EffectiveMemberships
     mailer&.constantize || Effective::MembershipsMailer
   end
 
-  def self.parent_mailer_class
-    return parent_mailer.constantize if parent_mailer.present?
-
-    if use_effective_email_templates
-      require 'effective_email_templates'
-      Effective::EmailTemplatesMailer
-    else
-      ActionMailer::Base
-    end
-  end
-
   def self.fee_types
     required = ['Applicant', 'Prorated', 'Discount', 'Renewal', 'Late', 'Admin']
     additional = Array(additional_fee_types)
@@ -69,21 +62,4 @@ module EffectiveMemberships
     ['Admin']
   end
 
-  def self.send_email(email, *args)
-    raise('expected args to be an Array') unless args.kind_of?(Array)
-
-    if defined?(Tenant)
-      tenant = Tenant.current || raise('expected a current tenant')
-      args.last.kind_of?(Hash) ? args.last.merge!(tenant: tenant) : args << { tenant: tenant }
-    end
-
-    deliver_method = EffectiveMemberships.deliver_method || EffectiveResources.deliver_method
-
-    begin
-      EffectiveMemberships.mailer_class.send(email, *args).send(deliver_method)
-    rescue => e
-      raise if Rails.env.development? || Rails.env.test?
-    end
-  end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_memberships
 version: !ruby/object:Gem::Version
-  version: 0.3.10
+  version: 0.3.13
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-24 00:00:00.000000000 Z
+date: 2022-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -317,7 +317,9 @@ files:
 - app/views/admin/applicant_references/_applicant_reference.html.haml
 - app/views/admin/applicants/_form.html.haml
 - app/views/admin/applicants/_form_approve.html.haml
+- app/views/admin/applicants/_form_complete.html.haml
 - app/views/admin/applicants/_form_decline.html.haml
+- app/views/admin/applicants/_form_missing_info.html.haml
 - app/views/admin/applicants/_form_process.html.haml
 - app/views/admin/applicants/_status.html.haml
 - app/views/admin/categories/_form.html.haml
@@ -360,6 +362,7 @@ files:
 - app/views/effective/applicants/_experience.html.haml
 - app/views/effective/applicants/_files.html.haml
 - app/views/effective/applicants/_layout.html.haml
+- app/views/effective/applicants/_missing_info.html.haml
 - app/views/effective/applicants/_orders.html.haml
 - app/views/effective/applicants/_references.html.haml
 - app/views/effective/applicants/_select.html.haml
@@ -403,9 +406,10 @@ files:
 - app/views/effective/memberships/_membership.html.haml
 - app/views/effective/memberships_directory/index.html.haml
 - app/views/effective/memberships_mailer/applicant_approved.liquid
+- app/views/effective/memberships_mailer/applicant_completed.liquid
 - app/views/effective/memberships_mailer/applicant_declined.liquid
+- app/views/effective/memberships_mailer/applicant_missing_info.liquid
 - app/views/effective/memberships_mailer/applicant_reference_notification.liquid
-- app/views/layouts/effective_memberships_mailer_layout.html.haml
 - config/effective_memberships.rb
 - config/routes.rb
 - db/migrate/01_create_effective_memberships.rb.erb

data/app/views/layouts/effective_memberships_mailer_layout.html.haml

@@ -1,7 +0,0 @@
-!!!
-%html{style: 'background: #fff;'}
-  %head
-    %meta{:content => 'text/html; charset=UTF-8', 'http-equiv' => 'Content-Type'}
-
-  %body{style: 'background: #fff;'}
-    = yield