effective_memberships 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5349de013b96f392cd5d9965a55fc8348656aed3a20b9c2798538454286368cd
-  data.tar.gz: 1f04f3dfd643b060a48919a00705255590439632fa4afd03925c0b1abe6ab324
+  metadata.gz: 6edc66bd8a9a8c6b9d38fb90cb42c8041efde67d7e2d5b80b14169678e70e9ff
+  data.tar.gz: 928861f7ee7ee4a2e2f1f77f3e8209909948ba7470ad2894267cbe29084e1290
 SHA512:
-  metadata.gz: 1a9056129fa56370cf1dd1b9324b1f2581f81b3952f801f3509e60d68de68da6c65c7cf3a898bfd525d9e4a5ad3b648088e2e5218ead9448288bd67a9daf783e
-  data.tar.gz: 0f75e5e23b53188eb83524190ad4fc7292bddb7af3faf349207074a3bc0b4da660ea41415392933c851843d1c57b1eafa43127fd3c6f9ac2dfeca5f43fe5f303
+  metadata.gz: 9a928f4b12eead76fc74ebd7fe39838829484796b4dd017dbbc35236f9bdd16d0bdcf7cc74526fbb95dee1711c82157c817f084352aa6bcde3ce35c2306e5a59
+  data.tar.gz: b2dca432e504b87d57b88c2e36624cf857f3364c346828d355b58e28188b01a4ff38bdaece31b60cadc976075d9e62f4d7bf0530d260d63ecdd31b051702f014

data/app/models/concerns/effective_memberships_applicant.rb

@@ -312,13 +312,15 @@ module EffectiveMembershipsApplicant
       raise('already submitted') if was_submitted?
       raise('expected a purchased order') unless submit_order&.purchased?
 
+      wizard_steps[:checkout] ||= Time.zone.now
+      wizard_steps[:submitted] = Time.zone.now
+      submitted!
+
       after_commit do
         applicant_references.each { |reference| reference.notify! if reference.submitted? }
       end
 
-      wizard_steps[:checkout] ||= Time.zone.now
-      wizard_steps[:submitted] = Time.zone.now
-      submitted!
+      true
     end
 
   end
@@ -526,9 +528,10 @@ module EffectiveMembershipsApplicant
       raise('unsupported approval applicant_type')
     end
 
-    after_commit { send_email(:applicant_approved) }
-
     save!
+
+    after_commit { send_email(:applicant_approved) }
+    true
   end
 
   # Admin approves an applicant. Registers the owner. Sends an email.
@@ -542,9 +545,10 @@ module EffectiveMembershipsApplicant
     wizard_steps[:submitted] ||= Time.zone.now
     declined!
 
-    after_commit { send_email(:applicant_declined) }
-
     save!
+
+    after_commit { send_email(:applicant_declined) }
+    true
   end
 
   private

data/app/models/concerns/effective_memberships_applicant_review.rb

@@ -109,30 +109,33 @@ module EffectiveMembershipsApplicantReview
     end
 
     def conflict_of_interest!
-      after_commit { send_email(:applicant_review_conflict_of_interest) }
-
       update!(conflict_of_interest: true, recommendation: nil)
       conflicted!
 
       applicant.save!
+
+      after_commit { send_email(:applicant_review_conflict_of_interest) }
+      true
     end
 
     def accept!
-      after_commit { send_email(:applicant_review_completed) }
-
       assign_attributes(recommendation: 'Accept')
       accepted!
 
       applicant.save!
-    end
 
-    def reject!
       after_commit { send_email(:applicant_review_completed) }
+      true
+    end
 
+    def reject!
       assign_attributes(recommendation: 'Reject')
       rejected!
 
       applicant.save!
+
+      after_commit { send_email(:applicant_review_completed) }
+      true
     end
 
     private

data/lib/effective_memberships/version.rb

@@ -1,3 +1,3 @@
 module EffectiveMemberships
-  VERSION = '0.2.5'
+  VERSION = '0.2.6'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: effective_memberships
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - Code and Effect