effective_memberships 0.17.1 → 0.17.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 75a253a5d3a571ffd68882f95735ce2461498cb40900064fd66e60026db9ce67
-  data.tar.gz: 83336209575eb783851494cf7b5edb7c98c3a29bbe4abc2403600581b83a6214
+  metadata.gz: 172faa35356355bd3a8d6f2bd51a4d1ec26cac9b58c617713b972096c32ec42d
+  data.tar.gz: fa370c75fcf09fd03134451dc3ffeefb3bd3b0b9032392fb4e9a17c364f810a0
 SHA512:
-  metadata.gz: 40ae6507569b2b58eb60b54be06033204b3eaadb9476438bf16b4683b5710627674778737b774e5db843c485be3d3df746151b0f2a0e1951efeb03a03f43fbe5
-  data.tar.gz: 264eae8dc5ac8b7666a627ed1706ac37bfbdc7439aa7004d4ac3bb9def1849df957ae198c838bfede8d40b721398a8592154d0a36e2d0e0762a0e4d5de0bf5b6
+  metadata.gz: 1853d32c2a951cc21b34ee224007bed5ca1af849027f3ac398cd99a77c9397e4cc8cce59ba7e26c23ffd4cb006676933a7a208a95b2c55a9f3b48ff0b6218db8
+  data.tar.gz: a5a8f725ca25361aa8424108fc59c4aff507367a895c0f99f94ecdbce30117a6d77049facf8ba255fdacef68a555c5c87172f8c72ca1bc1304f4183fe66362f2

data/app/datatables/admin/effective_applicants_datatable.rb

@@ -36,6 +36,7 @@ module Admin
       col :from_category, search: { collection: EffectiveMemberships.Category.all, polymorphic: false }
       col :from_status, search: { collection: EffectiveMemberships.Status.all, polymorphic: false }
 
+      col :applicant_reviews, visible: false
       col :orders, visible: false
 
       actions_col

data/app/models/concerns/effective_memberships_applicant_review.rb

@@ -102,9 +102,14 @@ module EffectiveMembershipsApplicantReview
 
     def submit!
       submitted!
-      applicant.try_reviewed!
 
-      after_commit { send_email(:applicant_review_submitted) }
+      after_commit do
+        applicant.reload
+        applicant.try_reviewed!
+
+        send_email(:applicant_review_submitted)
+      end
+
       true
     end
 

data/app/models/concerns/effective_memberships_fee_payment.rb

@@ -48,6 +48,7 @@ module EffectiveMembershipsFeePayment
 
     # CPD Step
     attr_accessor :declare_cpd
+    attr_accessor :skip_cpd_validation
 
     # Declarations Step
     attr_accessor :declare_code_of_ethics
@@ -127,11 +128,11 @@ module EffectiveMembershipsFeePayment
     # CPD step
     with_options(if: -> { current_step == :cpd }) do
       validates :declare_cpd, acceptance: true
+    end
 
-      validate do
-        if (cpd_cycles = cpd_uncompleted_cpd_cycles).present?
-          self.errors.add(:base, "Please complete #{cpd_cycles.map(&:to_s).to_sentence} to continue")
-        end
+    validate(if: -> { current_step == :cpd && !skip_cpd_validation }) do
+      if (cpd_cycles = cpd_uncompleted_cpd_cycles).present?
+        self.errors.add(:base, "Please complete #{cpd_cycles.map(&:to_s).to_sentence} to continue")
       end
     end
 
@@ -172,6 +173,11 @@ module EffectiveMembershipsFeePayment
       end
     end
 
+    def can_visit_step?(step)
+      return (step == :submitted) if was_submitted?
+      can_revisit_completed_steps(step)
+    end
+
     # All Fees and Orders
     # Overriding acts_as_purchasable_wizard
     def submit_fees
@@ -246,12 +252,30 @@ module EffectiveMembershipsFeePayment
   end
 
   def cpd_required_cpd_cycles
-    date = submitted_at || Time.zone.now
+    @cpd_required_cpd_cycles ||= begin
+      date = submitted_at || Time.zone.now
+
+      cpd_cycles = [] # Return value
+
+      # The current and previous cycle
+      current = EffectiveCpd.current_cpd_cycle(date: date)
+      previous = EffectiveCpd.previous_cpd_cycle(date: date)
 
-    [
-      (EffectiveCpd.previous_cpd_cycle(date: date) if cpd_requirement.to_s.include?('previous')),
-      (EffectiveCpd.current_cpd_cycle(date: date) if cpd_requirement.to_s.include?('current'))
-    ].compact
+      if current.present? && cpd_requirement.to_s.include?('current')
+        cpd_cycles << current
+      end
+
+      # Only include if they were a member during the previous period
+      if previous.present? && cpd_requirement.to_s.include?('previous')
+        period = EffectiveMemberships.Registrar.period(date: previous.end_at&.advance(months: -1) || current&.start_at&.advance(months: -1) || previous.start_at.advance(months: 1))
+        renewal_date = EffectiveMemberships.Registrar.renewal_fee_date(date: period)
+        membership_history = owner.membership_history_on(renewal_date.advance(days: -1))
+
+        cpd_cycles << previous if membership_history.present? && !membership_history.removed?
+      end
+
+      cpd_cycles
+    end
   end
 
   def cpd_completed_cpd_cycles

data/app/views/effective/applicants/cpd.html.haml

@@ -4,12 +4,12 @@
   = card(et('effective_cpd.name')) do
     = render('cpd_requirements', applicant: resource)
 
-  = card('All ' + cpd_statements_label) do
-    = render('effective/wizard_steps/cpd_statements', resource: resource)
-
   = card('Requirements') do
     = render('effective/wizard_steps/cpd_requirements', resource: resource)
 
+  = card('All ' + cpd_statements_label) do
+    = render('effective/wizard_steps/cpd_statements', resource: resource)
+
   = card do
     = effective_form_with(model: resource, url: wizard_path(step), method: :put) do |f|
       = f.hidden_field :id

data/app/views/effective/fee_payments/_cpd.html.haml

@@ -1,3 +1,3 @@
 = wizard_card(fee_payment) do
-  = render('effective/wizard_steps/cpd_statements', resource: fee_payment)
   = render('effective/wizard_steps/cpd_requirements', resource: fee_payment)
+  = render('effective/wizard_steps/cpd_statements', resource: fee_payment)

data/app/views/effective/fee_payments/cpd.html.haml

@@ -4,12 +4,12 @@
   = card(et('effective_cpd.name')) do
     = render('cpd_requirements', fee_payment: resource)
 
-  = card('All ' + cpd_statements_label) do
-    = render('effective/wizard_steps/cpd_statements', resource: resource)
-
   = card('Requirements') do
     = render('effective/wizard_steps/cpd_requirements', resource: resource)
 
+  = card('All ' + cpd_statements_label) do
+    = render('effective/wizard_steps/cpd_statements', resource: resource)
+
   = card do
     = effective_form_with(model: resource, url: wizard_path(step), method: :put) do |f|
       = f.hidden_field :id
@@ -17,4 +17,7 @@
       - f.object.declare_cpd = true if f.object.has_completed_step?(:cpd)
       = render('effective/wizard_steps/cpd_fields', f: f)
 
+      - if Rails.env.development? || Rails.env.test?
+        = f.check_box :skip_cpd_validation, label: "Yes, skip the :cpd step validation (development and test mode only)"
+
       = f.save 'Save and Continue'

data/lib/effective_memberships/version.rb

@@ -1,3 +1,3 @@
 module EffectiveMemberships
-  VERSION = '0.17.1'
+  VERSION = '0.17.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_memberships
 version: !ruby/object:Gem::Version
-  version: 0.17.1
+  version: 0.17.3
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-02 00:00:00.000000000 Z
+date: 2023-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -574,7 +574,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.8
 signing_key:
 specification_version: 4
 summary: Manage your professional association online. Membership categories, applications