effective_memberships 0.1.19 → 0.1.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a68526d13ceb57edb42353e0e69a53681019c88aaeec05327e497b1d8fccec6
-  data.tar.gz: 17cdff6a9e737bb379e833d90f5ca94b071d30688c2520ec2de1505be88e9d06
+  metadata.gz: 928383b46dabf57a0ee3e4ebed61050c15ddd4d2da01fcc50cec8ead2ded706b
+  data.tar.gz: 2e7b2f5b6e5e75991239f093783ab8a83c6f2b522fa8f5a482c067d04cb122ba
 SHA512:
-  metadata.gz: bd7107f8179634d2c3ff55ed70dcd04ca06aae9b6a01bda8addbf48a0b038b7e64c3dafc03f41abc89ef354e047df9b9b689a1b2429ec6181c1608fe5ef12275
-  data.tar.gz: a5a541ce25fb0930a2cd773b8ba70d23acbc140834549481a663d2800df1f7caf34a42a4363f4af2061e7a7aeba512d06b02dcbd480d6486ca20f914a7918522
+  metadata.gz: 8cd3faa8139e44db7aa485de820bed35f09b9d8cf8b2d56010cd87bf47515f143b9289362978cc305d63a50d8a24b4b8b9dadaabd240fffcc50abb970e8ac7d4
+  data.tar.gz: ba43e01d4180108144333d61d17f22a4297374db0842c6e33bf7044d381b192883d6813532b5717dca8df778293b065e1a0ba7d07a2c867f2c60b03912520e1e

data/app/controllers/effective/applicants_controller.rb

@@ -16,6 +16,7 @@ module Effective
       end
     end
 
+
     after_save do
       flash.now[:success] = ''
     end

data/app/models/concerns/effective_memberships_applicant.rb

@@ -60,6 +60,8 @@ module EffectiveMembershipsApplicant
       submitted: 'Submitted'
     )
 
+    acts_as_purchasable_wizard
+
     log_changes(except: :wizard_steps) if respond_to?(:log_changes)
 
     has_many_attached :applicant_files
@@ -247,12 +249,6 @@ module EffectiveMembershipsApplicant
       validates :declare_truth, acceptance: true
     end
 
-    # Billing Step
-    validate(if: -> { current_step == :billing && owner.present? }) do
-      self.errors.add(:base, "must have a billing address") unless owner.billing_address.present?
-      self.errors.add(:base, "must have an email") unless owner.email.present?
-    end
-
     # Admin Approve
     validate(if: -> { approved_membership_date.present? }) do
       if approved_membership_date.to_date > Time.zone.now.to_date
@@ -288,10 +284,47 @@ module EffectiveMembershipsApplicant
       end
     end
 
-    after_purchase do |_|
-      raise('expected submit_order to be purchased') unless submit_order&.purchased?
-      submit_purchased!
+    # All Fees and Orders
+    def submit_fees
+      fees.select { |fee| fee.applicant_submit_fee? }
+    end
+
+    def submit_order
+      orders.find { |order| order.purchasables.any?(&:applicant_submit_fee?) }
+    end
+
+    def submit_fee_qb_item_name
+      'Applicant'
     end
+
+    def find_or_build_submit_fees
+      return submit_fees if submit_fees.present?
+
+      fees.build(
+        owner: owner,
+        fee_type: 'Applicant',
+        category: category,
+        price: category.applicant_fee,
+        qb_item_name: submit_fee_qb_item_name()
+      )
+
+      submit_fees
+    end
+
+    # Draft -> Submitted requirements
+    def submit!
+      raise('already submitted') if was_submitted?
+      raise('expected a purchased order') unless submit_order&.purchased?
+
+      after_commit do
+        applicant_references.each { |reference| reference.notify! if reference.submitted? }
+      end
+
+      wizard_steps[:checkout] ||= Time.zone.now
+      wizard_steps[:submitted] = Time.zone.now
+      submitted!
+    end
+
   end
 
   # Instance Methods
@@ -330,10 +363,6 @@ module EffectiveMembershipsApplicant
     approved? || declined?
   end
 
-  def can_visit_step?(step)
-    can_revisit_completed_steps(step)
-  end
-
   def summary
     case status_was
     when 'draft'
@@ -435,96 +464,9 @@ module EffectiveMembershipsApplicant
     category&.min_applicant_files.to_i
   end
 
-  # All Fees and Orders
-  def submit_fees
-    fees.select { |fee| fee.applicant_submit_fee? }
-  end
-
-  def submit_order
-    orders.find { |order| order.purchasables.any?(&:applicant_submit_fee?) }
-  end
-
-  def find_or_build_submit_fees
-    return submit_fees if submit_fees.present?
-
-    fees.build(
-      owner: owner,
-      fee_type: 'Applicant',
-      category: category,
-      price: category.applicant_fee
-    )
-
-    submit_fees
-  end
-
-  def find_or_build_submit_order
-    order = submit_order || orders.build(user: owner)
-    fees = submit_fees()
-
-    # Adds fees, but does not overwrite any existing price.
-    fees.each do |fee|
-      order.add(fee) unless order.purchasables.include?(fee)
-    end
-
-    order.purchasables.each do |purchasable|
-      order.remove(purchasable) unless fees.include?(purchasable)
-    end
-
-    # From Billing Step
-    order.billing_address = owner.billing_address if owner.billing_address.present?
-
-    order.save
-
-    order
-  end
-
-  # Should be indempotent.
-  def build_submit_fees_and_order
-    return false if was_submitted?
-
-    fees = find_or_build_submit_fees()
-    raise('already has purchased submit fees') if fees.any? { |fee| fee.purchased? }
-
-    order = find_or_build_submit_order()
-    raise('already has purchased submit order') if order.purchased?
-
-    true
-  end
-
-  # Owner clicks on the Billing step. Next step is Checkout
-  def billing!
-    ready!
-  end
-
-  # Ready to check out
-  def ready!
-    build_submit_fees_and_order
-    save!
-  end
-
-  # Called automatically via after_purchase hook above
-  def submit_purchased!
-    return false if was_submitted?
-
-    wizard_steps[:checkout] = Time.zone.now
-    submit!
-  end
-
-  # Draft -> Submitted requirements
-  def submit!
-    raise('already submitted') if was_submitted?
-    raise('expected a purchased order') unless submit_order&.purchased?
-
-    after_commit do
-      applicant_references.each { |reference| reference.notify! if reference.submitted? }
-    end
-
-    wizard_steps[:checkout] ||= Time.zone.now
-    wizard_steps[:submitted] = Time.zone.now
-    submitted!
-  end
-
-  # Submitted -> Completed requirements
+  # The submit! method used to be here
+  # But it needs to be inside the included do block
+  # So see above. Sorry.
 
   def applicant_references_required?
     min_applicant_references > 0

data/app/models/concerns/effective_memberships_fee_payment.rb

@@ -44,6 +44,8 @@ module EffectiveMembershipsFeePayment
       submitted: 'Submitted'
     )
 
+    acts_as_purchasable_wizard
+
     log_changes(except: :wizard_steps) if respond_to?(:log_changes)
 
     # Declarations Step
@@ -110,12 +112,6 @@ module EffectiveMembershipsFeePayment
       validates :declare_truth, acceptance: true
     end
 
-    # Billing Step
-    validate(if: -> { current_step == :billing && owner.present? }) do
-      self.errors.add(:base, "must have a billing address") unless owner.billing_address.present?
-      self.errors.add(:base, "must have an email") unless owner.email.present?
-    end
-
     # Clear required steps memoization
     after_save { @_required_steps = nil }
 
@@ -135,13 +131,30 @@ module EffectiveMembershipsFeePayment
       end
     end
 
-    after_purchase do |_order|
-      raise('expected submit_order to be purchased') unless submit_order&.purchased?
+    # All Fees and Orders
+    # Overriding acts_as_purchasable_wizard
+    def outstanding_fees
+      owner&.outstanding_fee_payment_fees
+    end
+
+    def submit_fees
+      fees
+    end
+
+    def submit_order
+      orders.first
+    end
+
+    # We take over the owner's outstanding fees.
+    def find_or_build_submit_fees
+      Array(outstanding_fees).each { |fee| fees << fee unless fees.include?(fee) }
+      submit_fees
+    end
 
-      submit_purchased!
-      after_submit_purchased!
+    def after_submit_purchased!
       EffectiveMemberships.Registrar.fee_payment_purchased!(owner)
     end
+
   end
 
   def to_s
@@ -157,14 +170,6 @@ module EffectiveMembershipsFeePayment
     submitted?
   end
 
-  def can_visit_step?(step)
-    can_revisit_completed_steps(step)
-  end
-
-  def outstanding_fees
-    owner&.outstanding_fee_payment_fees
-  end
-
   def select!
     reset!
   end
@@ -200,83 +205,4 @@ module EffectiveMembershipsFeePayment
     owner.representatives.any?(&:marked_for_destruction?)
   end
 
-  # All Fees and Orders
-  def submit_fees
-    fees
-  end
-
-  def submit_order
-    orders.first
-  end
-
-  # We take over the owner's outstanding fees.
-  def find_or_build_submit_fees
-    Array(outstanding_fees).each { |fee| fees << fee unless fees.include?(fee) }
-    submit_fees
-  end
-
-  def find_or_build_submit_order
-    order = submit_order || orders.build(user: owner)
-    fees = submit_fees()
-
-    fees.each do |fee|
-      order.add(fee) unless order.purchasables.include?(fee)
-    end
-
-    order.purchasables.each do |purchasable|
-      order.remove(purchasable) unless fees.include?(purchasable)
-    end
-
-    order.billing_address = owner.billing_address if owner.billing_address.present?
-
-    order.save
-
-    order
-  end
-
-  # Should be indempotent.
-  def build_submit_fees_and_order
-    return false if was_submitted?
-
-    fees = find_or_build_submit_fees()
-    raise('already has purchased submit fees') if fees.any? { |fee| fee.purchased? }
-
-    order = find_or_build_submit_order()
-    raise('already has purchased submit order') if order.purchased?
-
-    true
-  end
-
-  # Owner clicks on the Billing Submit. Next step is Checkout
-  def billing!
-    ready!
-  end
-
-  def ready!
-    build_submit_fees_and_order
-    save!
-  end
-
-  # Called automatically via after_purchase hook above
-  def submit_purchased!
-    return false if was_submitted?
-
-    wizard_steps[:checkout] = Time.zone.now
-    submit!
-  end
-
-  # A hook to extend
-  def after_submit_purchased!
-  end
-
-  # Draft -> Submitted
-  def submit!
-    raise('already submitted') if was_submitted?
-    raise('expected a purchased order') unless submit_order&.purchased?
-
-    wizard_steps[:checkout] ||= Time.zone.now
-    wizard_steps[:submitted] = Time.zone.now
-    submitted!
-  end
-
 end

data/app/models/effective/fee.rb

@@ -107,8 +107,6 @@ module Effective
       EffectiveMemberships.custom_fee_types.include?(fee_type)
     end
 
-    private
-
     def default_period
       EffectiveMemberships.Registrar.current_period
     end
@@ -131,7 +129,7 @@ module Effective
     end
 
     def default_qb_item_name
-      category&.qb_item_name.presence || "#{fee_type} Fee"
+      category&.qb_item_name.presence || "#{fee_type}"
     end
 
     def default_tax_exempt

data/app/views/admin/categories/_form_applicant_fees.html.haml

@@ -6,6 +6,9 @@
   .row
     .col-lg-3= f.price_field :applicant_fee
 
+  .row
+    .col-lg-3= f.text_field :qb_item_name, label: "Quickbooks Item Name"
+
   %p Charged to join, based on the month of approval:
 
   .row

data/lib/effective_memberships/version.rb

@@ -1,3 +1,3 @@
 module EffectiveMemberships
-  VERSION = '0.1.19'
+  VERSION = '0.1.23'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_memberships
 version: !ruby/object:Gem::Version
-  version: 0.1.19
+  version: 0.1.23
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-11 00:00:00.000000000 Z
+date: 2022-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails