effective_email_templates 1.5.1 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1522926c50dd2f6874bc8cb41b906b4c8c2d31b8f0952ae1dc7482b647dc184c
-  data.tar.gz: 3cab7ba180c3eadfeb74e6c6806ed24b46b74408073eb94f04598b23776bdfce
+  metadata.gz: 8d32e71af524fb3658debbf8210a4239b4bbd98f7a806f0a743735e62bc135dc
+  data.tar.gz: f6064f01a1a679b3c4bf1abca99222ab4ba191d4bb0ee16a1ac23ddad644c368
 SHA512:
-  metadata.gz: 93d50932390ea0c38b202196451c58623f433a78d8d131b0568da75a1e44b0029653285934a1d311db7c7a658a2c78c969bbbabf78144e2335d4454ccd0fbfdb
-  data.tar.gz: 9b5fe215d1dd3bb1f2e05d1a5417536eb4a38f3a29c0369e0346562347c308b88a21fe9d96a4c1e6f017d926b01429aed989e9e8f0310d7f4754b4ed7c152675
+  metadata.gz: 360328a697866d2d802d7c882bcfbd9c0be6e148c0b6d98114417088af72b9ea74cc935d275b6396a8be64becd88749536f491b1cfcb0f953e8ab1c739ba276e
+  data.tar.gz: 5cad8e018ad138e6050278c36e39a69a631a06773bc8d87aeee9986a96b56de9ab3f491198634eea514126f30241a0536b2b8ccceb9721f5e6a7da928e7f0b63

data/app/mailers/concerns/effective_email_templates_mailer.rb

@@ -9,21 +9,40 @@ module EffectiveEmailTemplatesMailer
 
     assigns = (@assigns || {})
 
-    # Parse assigns. Special keys for body and subject.
+    # Parse body content if given
     body = assigns.delete(:body) || headers[:body] || headers['body']
     email_template.body = body if body.present?
 
-    # Ignore the subject when passed in via mail method subject: key.
-    subject = assigns.delete(:subject)
+    # Parse subject content if explicitly given
+    # Otherwise the :subject key is a default and should be ignored in favor of the email template subject instead
+    subject = assigns.delete(:subject) || headers[:subject] || headers['subject']
     email_template.subject = subject if subject.present?
 
+    # If the body or subject are nil, they will be populated from the email_template
+
     # Add any _url helpers
     assigns = route_url_assigns(email_template, assigns).merge(assigns)
 
-    # Render from the template, possibly with updated body
+    # Render from the template, possibly with updated body and subject
     rendered = email_template.render(assigns)
 
-    super(rendered.merge(headers.except(:body, :subject, 'body', 'subject')))
+    # Merge any other passed values
+    merged = rendered.merge(headers.except(:body, :subject, 'body', 'subject'))
+
+    # Finalize the subject_for Proc
+    if respond_to?(:subject_for) # EffectiveResourcesMailer
+      if (prefix = EffectiveResources.mailer_subject_prefix_hint).present?
+        subject = subject_for(action_name, merged[:subject], email_template, merged)
+
+        if subject.start_with?("#{prefix}#{prefix}") || subject.start_with?("#{prefix} #{prefix}")
+          subject = subject.sub(prefix, '')
+        end
+
+        merged[:subject] = subject
+      end
+    end
+
+    super(merged)
   end
 
   private

data/app/models/effective/email_template.rb

@@ -23,6 +23,7 @@ module Effective
 
     before_validation do
       self.content_type ||= CONTENT_TYPES.first
+      self.from ||= EffectiveEmailTemplates.mailer_froms.first
     end
 
     validates :body, liquid: true

data/app/views/admin/email_templates/_form.html.haml

@@ -4,11 +4,15 @@
   - if EffectiveEmailTemplates.select_content_type
     = f.select :content_type, Effective::EmailTemplate::CONTENT_TYPES
 
-  = f.select :from, EffectiveEmailTemplates.mailer_froms, hint: 'Please contact us to add additional sender addresses.'
+  = f.select :from, mailer_froms_collection(), hint: 'Please contact us to add additional sender addresses. Please refresh the page if this from address looks weird.'
   = f.text_field :cc
   = f.text_field :bcc
 
-  = f.text_field :subject, hint: 'The subject of your email'
+  - prefix_hint = EffectiveResources.mailer_subject_prefix_hint.to_s.strip.presence
+
+  = f.text_field :subject,
+    hint: (prefix_hint ? "The subject of your email. It will be automatically prefixed with #{prefix_hint}." : 'The subject of your email')
+
   = f.text_area :body, hint: 'The content of your email template', rows: 10
 
   .card

data/lib/effective_email_templates/version.rb

@@ -1,3 +1,3 @@
 module EffectiveEmailTemplates
-  VERSION = '1.5.1'.freeze
+  VERSION = '1.7.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_email_templates
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.7.0
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-25 00:00:00.000000000 Z
+date: 2023-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails