effective_email_templates 0.3.1 → 0.3.3

data/spec/lib/effective_email_templates/template_importer_spec.rb

@@ -2,43 +2,72 @@ require 'spec_helper'
 require 'effective_email_templates/template_importer'
 
 describe EffectiveEmailTemplates::TemplateImporter do
-  before :each do
-      Effective::EmailTemplate.delete_all
-  end
+  before { Effective::EmailTemplate.delete_all }
 
-  describe 'well formatted template files' do
-    it 'imports templates from view files' do
-      expect{ EffectiveEmailTemplates::TemplateImporter.invoke }.to change { Effective::EmailTemplate.count }
-    end
+  describe '.invoke' do
+    context 'without overwriting' do
+      context 'when well formatted template files' do
+        it 'should import templates from view files' do
+          expect { EffectiveEmailTemplates::TemplateImporter.invoke }.to change { Effective::EmailTemplate.count }
+        end
 
-    it 'does not import templates if a template already exists in the database' do
-      expect{ EffectiveEmailTemplates::TemplateImporter.invoke }.to change { Effective::EmailTemplate.count }
-      expect{ EffectiveEmailTemplates::TemplateImporter.invoke }.to_not change { Effective::EmailTemplate.count }
-    end
+        it 'should not import templates if a template already exists in the database' do
+          expect { EffectiveEmailTemplates::TemplateImporter.invoke }.to change { Effective::EmailTemplate.count }
+          expect { EffectiveEmailTemplates::TemplateImporter.invoke }.to_not change { Effective::EmailTemplate.count }
+        end
 
-    it 'does not print errors' do
-      importer = EffectiveEmailTemplates::TemplateImporter.new
-      expect(importer).to_not receive(:print_errors)
-      EffectiveEmailTemplates::TemplateImporter.invoke(importer)
-    end
-  end
+        it 'should not print errors' do
+          importer = EffectiveEmailTemplates::TemplateImporter.new
+          expect(importer).to_not receive(:print_errors)
+          EffectiveEmailTemplates::TemplateImporter.invoke(importer)
+        end
+      end
+
+      context 'when poorly formatted template files' do
+        let(:filepath) { Rails.root.join('app', 'views', 'user_liquid', 'some_template.liquid') }
+
+        before { File.open(filepath, 'w') { |f| f.write("--\n---\nbody") } }
+        after { File.delete(filepath) }
 
-  describe 'poorly formatted template files' do
-    let(:filepath) { Rails.root.join('app', 'views', 'user_liquid', 'some_template.liquid') }
-    before do
-      File.open(filepath, 'w') do |f|
-        f.write("--\n---\nbody")
+        it 'should print errors if there is a problem with a template' do
+          importer = EffectiveEmailTemplates::TemplateImporter.new
+          expect(importer).to receive(:print_errors)
+          EffectiveEmailTemplates::TemplateImporter.invoke(importer)
+        end
       end
     end
 
-    after do
-      File.delete(filepath)
-    end
+    context 'with overwriting' do
+      let!(:existing_template) { FactoryGirl.create(:email_template, body: 'test', slug: 'after_create_user') }
+
+      context 'when well formatted template files' do
+        it 'should update templates from view files' do
+          expect { EffectiveEmailTemplates::TemplateImporter.invoke(overwrite: true) }.to change { existing_template.reload.body }.from('test').to('Hello {{ user_name }}')
+        end
+
+        it 'should not create duplicate templates if a template already exists in the database' do
+          expect { EffectiveEmailTemplates::TemplateImporter.invoke(overwrite: true) }.not_to change { Effective::EmailTemplate.count }
+        end
+
+        it 'should not print errors' do
+          importer = EffectiveEmailTemplates::TemplateImporter.new
+          expect(importer).to_not receive(:print_errors)
+          EffectiveEmailTemplates::TemplateImporter.invoke(importer, overwrite: true)
+        end
+      end
+
+      context 'when poorly formatted template files' do
+        let(:filepath) { Rails.root.join('app', 'views', 'user_liquid', 'some_template.liquid') }
 
-    it 'prints errors if there is a problem with a template' do
-      importer = EffectiveEmailTemplates::TemplateImporter.new
-      expect(importer).to receive(:print_errors)
-      EffectiveEmailTemplates::TemplateImporter.invoke(importer)
+        before { File.open(filepath, 'w') { |f| f.write("--\n---\nbody") } }
+        after { File.delete(filepath) }
+
+        it 'should print errors if there is a problem with a template' do
+          importer = EffectiveEmailTemplates::TemplateImporter.new
+          expect(importer).to receive(:print_errors)
+          EffectiveEmailTemplates::TemplateImporter.invoke(importer, overwrite: true)
+        end
+      end
     end
   end
 end

data/spec/lib/effective_email_templates/template_importer_spec.rb~

@@ -0,0 +1,43 @@
+require 'spec_helper'
+require 'effective_email_templates/template_importer'
+
+describe EffectiveEmailTemplates::TemplateImporter do
+
+  describe 'well formatted template files' do
+    it 'imports templates from view files' do
+      Effective::EmailTemplate.delete_all
+      expect{ EffectiveEmailTemplates::TemplateImporter.invoke }.to change { Effective::EmailTemplate.count }
+    end
+
+    it 'does not import templates if a template already exists in the database' do
+      Effective::EmailTemplate.delete_all
+      expect{ EffectiveEmailTemplates::TemplateImporter.invoke }.to change { Effective::EmailTemplate.count }
+      expect{ EffectiveEmailTemplates::TemplateImporter.invoke }.to_not change { Effective::EmailTemplate.count }
+    end
+
+    it 'does not print errors' do
+      importer = EffectiveEmailTemplates::TemplateImporter.new
+      expect(importer).to_not receive(:print_errors)
+      EffectiveEmailTemplates::TemplateImporter.invoke(importer)
+    end
+  end
+
+  describe 'poorly formatted template files' do
+    let(:filepath) { Rails.root.join('app', 'views', 'user_liquid', 'some_template.liquid') }
+    before do
+      File.open(filepath, 'w') do |f|
+        f.write("--\n---\nbody")
+      end
+    end
+
+    after do
+      File.delete(filepath)
+    end
+
+    it 'prints errors if there is a problem with a template' do
+      importer = EffectiveEmailTemplates::TemplateImporter.new
+      expect(importer).to receive(:print_errors)
+      EffectiveEmailTemplates::TemplateImporter.invoke(importer)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_email_templates
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.3
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-24 00:00:00.000000000 Z
+date: 2015-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -209,7 +209,9 @@ files:
 - lib/effective_email_templates/engine.rb
 - lib/effective_email_templates/liquid_resolver.rb
 - lib/effective_email_templates/template_importer.rb
+- lib/effective_email_templates/template_importer.rb~
 - lib/effective_email_templates/version.rb
+- lib/effective_email_templates/version.rb~
 - lib/generators/effective_email_templates/install_generator.rb
 - lib/generators/templates/README
 - lib/generators/templates/effective_email_templates.rb
@@ -253,18 +255,29 @@ files:
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
+- spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/20141126222940_devise_create_users.rb
 - spec/dummy/db/migrate/20141126222941_create_effective_email_templates.rb
 - spec/dummy/db/schema.rb
+- spec/dummy/db/test.sqlite3
+- spec/dummy/log/development.log
+- spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
+- spec/dummy/tmp/cache/assets/development/sprockets/13fe41fee1fe35b49d145bcc06610705
+- spec/dummy/tmp/cache/assets/development/sprockets/2f5173deea6c795b8fdde723bb4b63af
+- spec/dummy/tmp/cache/assets/development/sprockets/357970feca3ac29060c1e3861e2c0953
+- spec/dummy/tmp/cache/assets/development/sprockets/cffd775d018f68ce5dba1ee0d951a994
+- spec/dummy/tmp/cache/assets/development/sprockets/d771ace226fc8215a3572e0aa35bb0d6
+- spec/dummy/tmp/cache/assets/development/sprockets/f7cbd26ba1d28d48de824f0e94586655
 - spec/effective_email_templates_spec.rb
 - spec/factories/email_template.rb
 - spec/factories/user.rb
 - spec/factory_spec.rb
 - spec/lib/effective_email_templates/template_importer_spec.rb
+- spec/lib/effective_email_templates/template_importer_spec.rb~
 - spec/mailers/liquid_resolved_mailer_spec.rb
 - spec/models/email_template_spec.rb
 - spec/models/user_spec.rb
@@ -290,7 +303,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Effective Email Templates provides an admin access to modify email templates
@@ -332,20 +345,31 @@ test_files:
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
 - spec/dummy/config.ru
+- spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/20141126222940_devise_create_users.rb
 - spec/dummy/db/migrate/20141126222941_create_effective_email_templates.rb
 - spec/dummy/db/schema.rb
+- spec/dummy/db/test.sqlite3
+- spec/dummy/log/development.log
+- spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
+- spec/dummy/tmp/cache/assets/development/sprockets/13fe41fee1fe35b49d145bcc06610705
+- spec/dummy/tmp/cache/assets/development/sprockets/2f5173deea6c795b8fdde723bb4b63af
+- spec/dummy/tmp/cache/assets/development/sprockets/357970feca3ac29060c1e3861e2c0953
+- spec/dummy/tmp/cache/assets/development/sprockets/cffd775d018f68ce5dba1ee0d951a994
+- spec/dummy/tmp/cache/assets/development/sprockets/d771ace226fc8215a3572e0aa35bb0d6
+- spec/dummy/tmp/cache/assets/development/sprockets/f7cbd26ba1d28d48de824f0e94586655
 - spec/effective_email_templates_spec.rb
 - spec/factories/email_template.rb
 - spec/factories/user.rb
 - spec/factory_spec.rb
 - spec/lib/effective_email_templates/template_importer_spec.rb
+- spec/lib/effective_email_templates/template_importer_spec.rb~
 - spec/mailers/liquid_resolved_mailer_spec.rb
 - spec/models/email_template_spec.rb
 - spec/models/user_spec.rb