effective_datatables 4.3.2 → 4.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bce1cbc5306668fcececce76aec875bda8b76f6f
-  data.tar.gz: 81cccd9b962ddcd3d709d33190c54ba76e836a17
+  metadata.gz: 4fe669a7536deb43686a84bb9fc15f93f76eaf84
+  data.tar.gz: 86359d4b303b234f904c51b9bf0eeb846d924c57
 SHA512:
-  metadata.gz: 811e931df4538a941a94abf365014fae0efcd0e40e5a614b9e505ababe7dd8c1c175b8a15d71811dcc76f22d499baf3586ec3ca33b0d8ff384ebd8743eedec0b
-  data.tar.gz: e398e589472f0d5e8c4aa83a73e65018fbdcdad057c36a40eb56c8b54e0d72f61359b3ac51ffd440fd99fde7045d26e4ba695e16c501409eb51bf36144afdbb0
+  metadata.gz: f76787e95bab3aa54d510e9dbb2d69215ec74bc9ef061ecc7eb692fecd98298af9053d3ec5196d39b537aca0f67713833418536563c97e67a4191bed0eca64d9
+  data.tar.gz: 297ccbf127f6e1d4871c13294f67bef61ea2ddddeeafa89244d208b7b016c7517106b2999cca213361630de3c2185e5b7dab0c71678e4e03bb995c121840e0e0

data/app/assets/javascripts/effective_datatables/initialize.js.coffee

@@ -163,6 +163,9 @@ initializeDataTables = ->
     # Let's actually initialize the table now
     table = datatable.dataTable(jQuery.extend(init_options, options))
 
+    # Fix a tabindex issue
+    table.children('tbody').children('tr').children('td[tabindex]').removeAttr('tabindex')
+
     # Apply EffectiveFormInputs to the Show x per page dropdown
     try table.closest('.dataTables_wrapper').find('.dataTables_length select').removeAttr('name').select2(minimumResultsForSearch: 100)
 

data/app/assets/stylesheets/effective_datatables/_overrides.scss

@@ -107,6 +107,13 @@ table.dataTable > thead {
 
       input { max-height: 38px; }
     }
+
+    &.col-bulk_actions {
+      label {
+        cursor: pointer;
+      }
+    }
+
   }
 }
 
@@ -173,6 +180,13 @@ table.dataTable {
   td.col-decimal { text-align: right; }
   td.col-right { text-align: right; }
 
+  td.col-bulk_actions {
+    label {
+      cursor: pointer;
+      vertical-align: top;
+    }
+  }
+
   tfoot {
     .col-price { text-align: right; }
     .col-decimal { text-align: right; }
@@ -184,10 +198,6 @@ table.dataTable {
     text-align: right;
   }
 
-  td.col-bulk_actions {
-    input[type='checkbox'] { margin-left: 1px; margin-right: 1px; }
-  }
-
   td.col-resource_item { word-break: keep-all; }
 
   td {

data/app/helpers/effective_datatables_private_helper.rb

@@ -70,7 +70,7 @@ module EffectiveDatatablesPrivateHelper
       form.select name, collection, options
     when :bulk_actions
       options[:data]['role'] = 'bulk-actions'
-      form.check_box name, options.merge(custom: false)
+      form.check_box name, options.merge(label: ' ')
     end
   end
 

data/app/views/effective/datatables/_bulk_actions_column.html.haml

@@ -1,2 +1,6 @@
 - id = (resource.try(:to_param) || resource.try(:id) || resource.object_id)
-= check_box_tag 'bulk_actions_resources[]', id, false, autocomplete: 'off', id: "datatable_bulk_actions_resource_#{id}", data: { role: 'bulk-action' }
+
+.form-group.custom-control.custom-checkbox
+  %input{value: 0, type: 'hidden'}
+  %input.custom-control-input{name: 'bulk_actions_resources[]', id: "datatable_bulk_actions_resource_#{id}", value: id, type: 'checkbox', autocomplete: 'off', 'data-role': 'bulk-action' }
+  %label.custom-control-label{for: "datatable_bulk_actions_resource_#{id}" }

data/lib/effective_datatables/version.rb

@@ -1,3 +1,3 @@
 module EffectiveDatatables
-  VERSION = '4.3.2'.freeze
+  VERSION = '4.3.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_datatables
 version: !ruby/object:Gem::Version
-  version: 4.3.2
+  version: 4.3.3
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-18 00:00:00.000000000 Z
+date: 2018-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails