effective_committees 0.4.2 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 701cf249e308e4866ec599fce879509d3a032292e29ba9a6775e49e136135cc8
-  data.tar.gz: 119e68d045546f7199ca01fe8c1ecdfc2566bcfe45897f7f59e06d277eb7c887
+  metadata.gz: e2a318a62bd5057b979e35eb0280f7db899f83367a80726e13471444bd80d758
+  data.tar.gz: 01d660c74f301d9a82627cf7d15782db30bac3bee2e717720fd1d54b77bdd3fb
 SHA512:
-  metadata.gz: 214657350e87fd4e21059f001b9caa9aba42fedeb0099456fc5e352f9562ec9f0ef22654df0809afbb32b5fcd0318c02175cea29ff98e0ffc5b9f0fe340ad270
-  data.tar.gz: b36a92d72782adbbb10c6f7458d1de4411a337405d5d8ba347d31f6e6e072e1e9cbb6c9e02f539a8d1fea292adc62b47d1c02ecfb64737689ec8a24aaf9f6703
+  metadata.gz: f07fb6ef7c974f646a35186845541752b522a286657efe3158eb99262244274efc09d610d7799218c0a92931cab86394946dd83f5b1ba91a7b3bad4cea43b40d
+  data.tar.gz: dfa60d6d7d0926ec9ada024243139fce61088251bff4da53b8a69a94b6db46207535f8ab9c785c46f992d1f346b387b96f6b89ced4697d6805199f23263f42d3

data/app/controllers/effective/committee_folders_controller.rb

@@ -3,6 +3,7 @@ module Effective
     before_action(:authenticate_user!) if defined?(Devise)
 
     include Effective::CrudController
+    log_page_views(if: -> { EffectiveCommittees.log_page_views? })
 
     resource_scope -> { Effective::CommitteeFolder.deep }
 

data/app/controllers/effective/committee_members_controller.rb

@@ -3,6 +3,7 @@ module Effective
     before_action(:authenticate_user!) if defined?(Devise)
 
     include Effective::CrudController
+    log_page_views(if: -> { EffectiveCommittees.log_page_views? })
 
     resource_scope -> {
       committees = Effective::Committee.deep.where(id: current_user.committees)

data/app/controllers/effective/committees_controller.rb

@@ -3,18 +3,24 @@ module Effective
     before_action(:authenticate_user!) if defined?(Devise)
 
     include Effective::CrudController
+    log_page_views(if: -> { EffectiveCommittees.log_page_views? })
 
     resource_scope -> { Effective::Committee.all.deep }
+    page_title "More Activity", only: [:activity]
 
     def index
       @committees = resource_scope.for_index
       @page_title = EffectiveResources.et('effective_committees.name')
 
       EffectiveResources.authorize!(self, :index, Effective::Committee)
+      EffectiveResources.authorize!(self, :all_committees, Effective::Committee)
 
       render 'index'
     end
 
+    # activity
+    # my_committees
+
     private
 
     def permitted_params

data/app/datatables/admin/effective_committee_members_datatable.rb

@@ -7,7 +7,7 @@ module Admin
       col :committee
       col :user
 
-      if defined?(EffectiveMemberships)
+      if current_user.class.try(:effective_memberships_owner?)
         col(:member_number, label: 'Member #', sort: false) do |committee_member|
           committee_member.user.try(:membership).try(:number)
         end.search do |collection, term|
@@ -34,7 +34,11 @@ module Admin
         col :roles, search: roles_collection
       end
 
-      actions_col
+      actions_col do |committee_member|
+        if EffectiveResources.authorized?(self, :impersonate, committee_member.user)
+          dropdown_link_to("Impersonate", "/admin/users/#{committee_member.user_id}/impersonate", data: { confirm: "Really impersonate #{committee_member.user}?", method: :post, remote: true })
+        end
+      end
     end
 
     collection do

data/app/datatables/effective_committees_activity_datatable.rb

@@ -0,0 +1,42 @@
+# For the /committees/activity More Activity page
+# Displays all the logged changes for this user's committees
+class EffectiveCommitteesActivityDatatable < Effective::Datatable
+  datatable do
+    order :id, :desc
+
+    col :updated_at, label: 'Date'
+    col :id, visible: false
+
+    col :user, label: 'Changed by', search: :string, sort: false
+    col :changes_to, label: committee_label, search: current_user.committees
+    col :associated, visible: false
+
+    col :message, sort: false do |log|
+      message = (log.message || '').gsub("\n", '<br>')
+      associated_type = log.associated_type.gsub('Effective::', '').gsub('ActiveStorage::', '')
+
+      if log.associated_id == attributes[:changes_to_id] && log.associated_type == attributes[:changes_to_type]
+        message
+      else
+        "#{associated_type} #{log.associated_to_s} - #{message}"
+      end
+
+    end.search do |collection, term, column, sql_column|
+      ilike = effective_resource.ilike
+      collection.where("associated_type #{ilike} ? OR associated_to_s #{ilike} ? OR message #{ilike} ?", "%#{term}%", "%#{term}%", "%#{term}%")
+    end
+
+    col :details, visible: false, sort: false do |log|
+      tableize_hash(log.details)
+    end
+
+    actions_col
+  end
+
+  collection do
+    EffectiveLogging.Log.logged_changes.deep
+      .where(changes_to_type: 'Effective::Committee', changes_to_id: current_user.committees.map(&:id))
+      .where.not(associated_type: 'ActiveStorage::Attachment')
+  end
+
+end

data/app/datatables/effective_committees_datatable.rb

@@ -10,7 +10,7 @@ class EffectiveCommitteesDatatable < Effective::Datatable
     col(:committee_members, label: committee_members_label, visible: false) do |committee|
       committee.committee_members.select(&:active?).sort_by(&:to_s).map do |member|
         content_tag(:div, class: 'col-resource_item') do
-          label = link_to(member.to_s, "/admin/users/#{member.user_id}/edit")
+          label = member.to_s
           badge = badge(member.category) if member.category.present?
 
           [label, badge].compact.join(' ').html_safe

data/app/models/concerns/effective_committees_user.rb

@@ -45,4 +45,28 @@ module EffectiveCommitteesUser
     committee_members.select { |cm| cm.active? && !cm.marked_for_destruction? }.map { |cm| cm.committee }
   end
 
+  # When activity is for sequential uploaded files, group them together like: "12 files were added to Board of Directors - April 2025 Meeting"
+  def committees_recent_activity(limit: 100)
+    logs = EffectiveLogging.Log.logged_changes.deep
+      .where(changes_to_type: 'Effective::Committee', changes_to_id: committees.map(&:id))
+      .order(created_at: :desc)
+
+    # Recent activity should be for folders being created and files being uploaded/replaced
+    logs = logs.select do |log|
+      folder_created = (log.associated_type == 'Effective::CommitteeFolder' && log.message == 'Created')
+      file_changed = (log.associated_type == 'Effective::CommitteeFile' && (log.message == 'Created' || log.details.dig(:changes, 'File').present?))
+      folder_created || file_changed
+    end
+
+    # Returns an Array of Arrays where some are 1 length groups
+    # Others are multiple length groups of file changes to one folder
+    logs = logs.slice_when do |a, b|
+      (a.changes_to_id != b.changes_to_id) || 
+      (a.associated_type != b.associated_type) || 
+      (b.associated_type == "Effective::CommitteeFolder") ||
+      (a.associated.try(:committee_folder_id) != b.associated.try(:committee_folder_id))
+    end
+
+    logs.take(limit)
+  end
 end

data/app/models/effective/committee_file.rb

@@ -15,6 +15,9 @@ module Effective
       title         :string
       notes         :text
 
+      file_id          :integer
+      file_created_at  :datetime
+
       timestamps
     end
 
@@ -23,7 +26,7 @@ module Effective
     end
 
     before_validation(if: -> { file.attached? }) do
-      self.title ||= file.filename.to_s
+      assign_attributes(title: file.filename.to_s, file_id: file.attachment.blob.id, file_created_at: file.attachment.blob.created_at)
     end
 
     scope :deep, -> { with_attached_file.includes(:committee, :committee_folder) }

data/app/views/effective/committee_folders/_committee_folder.html.haml

@@ -1,7 +1,7 @@
 = render('layout') do
   %nav{'aria-label': 'breadcrumb'}
     %ol.breadcrumb
-      - if EffectiveResources.authorized?(self, :index, Effective::Committee)
+      - if EffectiveResources.authorized?(self, :all_committees, Effective::Committee)
         %li.breadcrumb-item= link_to("All #{committees_label}", effective_committees.committees_path)
       - elsif EffectiveResources.authorized?(self, :my_committees, Effective::Committee)
         %li.breadcrumb-item= link_to("My #{committees_label}", effective_committees.my_committees_path)

data/app/views/effective/committee_folders/show.html.haml

@@ -0,0 +1,13 @@
+- resource = (@_effective_resource || Effective::Resource.new(controller_path))
+- @resource = instance_variable_get('@' + resource.name) if resource.name
+
+- if @resource
+  .resource-buttons
+    = render_resource_buttons(@resource, show: false)
+
+  = render_resource_partial(@resource)
+
+.my-4
+
+-# .form-actions
+-#   = link_to 'Continue', return_to_dashboard_path, class: 'btn btn-primary mb-4'

data/app/views/effective/committees/_committee.html.haml

@@ -1,7 +1,7 @@
 = render('layout') do
   %nav{'aria-label': 'breadcrumb'}
     %ol.breadcrumb
-      - if EffectiveResources.authorized?(self, :index, Effective::Committee)
+      - if EffectiveResources.authorized?(self, :all_committees, Effective::Committee)
         %li.breadcrumb-item= link_to("All #{committees_label}", effective_committees.committees_path)
       - elsif EffectiveResources.authorized?(self, :my_committees, Effective::Committee)
         %li.breadcrumb-item= link_to("My #{committees_label}", effective_committees.my_committees_path)

data/app/views/effective/committees/_dashboard.html.haml

@@ -4,7 +4,7 @@
   %p 
     You have access to #{pluralize(current_user.committees.length, committee_label.downcase)}.
 
-    - if EffectiveResources.authorized?(self, :index, Effective::Committee)
+    - if EffectiveResources.authorized?(self, :all_committees, Effective::Committee)
       Please
       = link_to('click here', effective_committees.committees_path)
       to view all #{committees_label.downcase}.

data/app/views/effective/committees/_dashboard_activity.html.haml

@@ -0,0 +1,30 @@
+%h2 #{committees_label} Recent Activity
+
+- if current_user.committees.present?
+  - current_user.committees_recent_activity(limit: 5).each do |logs|
+    - log = logs.first
+
+    - committee = log.changes_to
+    - link_to_committee = link_to(committee, effective_committees.committee_path(committee))
+
+    - committee_folder = log.associated.try(:committee_folder) || log.associated
+    - link_to_committee_folder = link_to(committee_folder, effective_committees.committee_committee_folder_path(committee, committee_folder))
+
+    - link_to_file = link_to(log.associated, url_for(log.associated.try(:file)))
+
+    - if logs.length == 1 && log.associated_type == 'Effective::CommitteeFolder'
+      %p Folder #{link_to_committee_folder} was added to #{link_to_committee}.
+
+    - elsif logs.length == 1 && log.associated_type == 'Effective::CommitteeFile'
+      %p File #{link_to_file} was added to #{link_to_committee} - #{link_to_committee_folder}.
+
+    - elsif logs.length > 1 && logs.all? { |log| log.associated_type == 'Effective::CommitteeFile' }
+      %p #{logs.length} files were added to #{link_to_committee} - #{link_to_committee_folder}.
+
+    - else
+      - raise("Unexpected logs: #{logs.inspect}")
+
+  %p= link_to('View more activity', effective_committees.activity_committees_path)
+
+- else
+  %p There's no activity to display. When there is, we'll show it here.

data/app/views/effective/committees/activity.html.haml

@@ -0,0 +1,19 @@
+- committees = @committees.sorted
+
+= render('layout') do
+  %nav{'aria-label': 'breadcrumb'}
+    %ol.breadcrumb
+      %li.breadcrumb-item= link_to("Home", root_path)
+      %li.breadcrumb-item.active{'aria-current': 'page'}= @page_title
+
+  %h1= @page_title
+
+  - if committees.blank?
+    %p There are no #{committees_label.downcase} to display.
+  - else
+    - datatable = EffectiveResources.best('EffectiveCommitteesActivityDatatable').new(self, namespace: :effective)
+    = render_datatable(datatable, inline: true)
+  .my-4
+
+  .form-actions
+    = link_to 'Continue', return_to_dashboard_path, class: 'btn btn-primary mb-4'

data/app/views/effective/committees/my_committees.html.haml

@@ -3,7 +3,7 @@
 = render('layout') do
   %nav{'aria-label': 'breadcrumb'}
     %ol.breadcrumb
-      - if EffectiveResources.authorized?(self, :index, Effective::Committee)
+      - if EffectiveResources.authorized?(self, :all_committees, Effective::Committee)
         %li.breadcrumb-item= link_to("All #{committees_label}", effective_committees.committees_path)
       - else
         %li.breadcrumb-item= link_to("Home", root_path)

data/app/views/effective/committees/show.html.haml

@@ -0,0 +1,13 @@
+- resource = (@_effective_resource || Effective::Resource.new(controller_path))
+- @resource = instance_variable_get('@' + resource.name) if resource.name
+
+- if @resource
+  .resource-buttons
+    = render_resource_buttons(@resource, show: false)
+
+  = render_resource_partial(@resource)
+
+.my-4
+
+-# .form-actions
+-#   = link_to 'Continue', return_to_dashboard_path, class: 'btn btn-primary mb-4'

data/config/effective_committees.rb

@@ -5,4 +5,7 @@ EffectiveCommittees.setup do |config|
 
   # Committee Members can belong to a committee with a role
   config.use_effective_roles = true
+
+  # Uses EffectiveLogging to log page views for front end committees pages
+  config.log_page_views = false
 end

data/config/routes.rb

@@ -8,10 +8,13 @@ EffectiveCommittees::Engine.routes.draw do
   # Public routes
   scope module: 'effective' do
     resources :committees, only: [:index, :show] do
+      get 'activity', on: :collection
+
       resources :committee_folders, only: [:show]
     end
 
     get 'my-committees', to: 'committees#my_committees'
+    get 'my_committees', to: 'committees#my_committees'
 
     resources :committee_members, except: [:show]
   end

data/db/migrate/101_create_effective_committees.rb

@@ -66,6 +66,9 @@ class CreateEffectiveCommittees < ActiveRecord::Migration[6.0]
 
       t.integer :committee_folder_id
 
+      t.integer :file_id
+      t.datetime :file_created_at
+
       t.string :title
       t.text :notes
 

data/lib/effective_committees/version.rb

@@ -1,3 +1,3 @@
 module EffectiveCommittees
-  VERSION = '0.4.2'.freeze
+  VERSION = '0.5.0'.freeze
 end

data/lib/effective_committees.rb

@@ -9,10 +9,14 @@ module EffectiveCommittees
   def self.config_keys
     [
       :committees_table_name, :committee_members_table_name, :committee_folders_table_name, :committee_files_table_name,
-      :layout, :use_effective_roles
+      :layout, :use_effective_roles, :log_page_views
     ]
   end
 
   include EffectiveGem
 
+  def self.log_page_views?
+    !!log_page_views
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_committees
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.5.0
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-26 00:00:00.000000000 Z
+date: 2025-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -191,6 +191,7 @@ files:
 - app/datatables/admin/effective_committee_members_datatable.rb
 - app/datatables/admin/effective_committees_datatable.rb
 - app/datatables/effective_committee_members_datatable.rb
+- app/datatables/effective_committees_activity_datatable.rb
 - app/datatables/effective_committees_datatable.rb
 - app/helpers/effective_committees_helper.rb
 - app/models/concerns/effective_committees_user.rb
@@ -207,16 +208,20 @@ files:
 - app/views/admin/committees/_form_committee.html.haml
 - app/views/effective/committee_folders/_committee_folder.html.haml
 - app/views/effective/committee_folders/_layout.html.haml
+- app/views/effective/committee_folders/show.html.haml
 - app/views/effective/committee_members/_form.html.haml
 - app/views/effective/committee_members/_user_fields.html.haml
 - app/views/effective/committees/_committee.html.haml
 - app/views/effective/committees/_dashboard.html.haml
+- app/views/effective/committees/_dashboard_activity.html.haml
 - app/views/effective/committees/_fields.html.haml
 - app/views/effective/committees/_form.html.haml
 - app/views/effective/committees/_form_committee.html.haml
 - app/views/effective/committees/_layout.html.haml
+- app/views/effective/committees/activity.html.haml
 - app/views/effective/committees/index.html.haml
 - app/views/effective/committees/my_committees.html.haml
+- app/views/effective/committees/show.html.haml
 - config/effective_committees.rb
 - config/locales/effective_committees.en.yml
 - config/routes.rb