effective_committees 0.1.2 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63a0f1fb0d95dfae23974217952a389877c115b31e9ba3b73b616138ff0ae9b9
-  data.tar.gz: 38c05e3f466ae93f9258dd9394caa177a1fa7c4dd944b776e6866b9ecef2253a
+  metadata.gz: cd2e7e60e604c2c37d662cde5abd1d4823b4400762bed564e734b50c65f16a5f
+  data.tar.gz: 713486d3de4e2aa4412762f243f0f9f352f5c74f7786cddc89e1781ef2b49de6
 SHA512:
-  metadata.gz: 977e23882e20848a4b6aead2a8966e913664cf27ab396fc5ab24f3b85d58d47a9ae770ec368d2eb866ad88786beab86fb6982da6bf2956c805030f840ac8ab61
-  data.tar.gz: 6ab21c11c4bfec46be1347c57c0fca82163e601671a752a85735187c66ed5c66b51dda390e45d3b934098a305a17e319a3fcece909b31a062c41d9c0c9d84577
+  metadata.gz: 4b3e9bd523495fb20bde48fac897b64bffd58f5197ef458008e95a7b6b752b74959dc2b67196c5471d9ceba45e0b5565fb334dd05fe3ddd33a6f60d03083c0bf
+  data.tar.gz: e3c37293212b4fd74121f1ca3fe2aba2a1d776199484cafba8821a0fc40466622f7df8bf9c06375bb4c60a26171e51adbd15562845ec0d2eb9cf3bb312f07423

data/app/datatables/admin/effective_committee_members_datatable.rb

@@ -13,6 +13,13 @@ module Admin
         end
       end
 
+      col :start_on
+      col :end_on
+
+      col :expired do |committee_member|
+        badge('expired') if committee_member.expired?
+      end
+
       if EffectiveCommittees.use_effective_roles
         col :roles, search: roles_collection
       end

data/app/datatables/effective_committee_members_datatable.rb

@@ -11,6 +11,9 @@ class EffectiveCommitteeMembersDatatable < Effective::Datatable
       end
     end
 
+    col :start_on
+    col :end_on
+
     if EffectiveCommittees.use_effective_roles
       col :roles, search: roles_collection
     end

data/app/datatables/effective_committees_datatable.rb

@@ -25,6 +25,7 @@ class EffectiveCommitteesDatatable < Effective::Datatable
   end
 
   collection do
+    # This only displays active committees
     Effective::Committee.deep.where(id: current_user.committees)
   end
 

data/app/models/concerns/effective_committees_user.rb

@@ -34,7 +34,7 @@ module EffectiveCommitteesUser
   end
 
   def committees
-    committee_members.reject(&:marked_for_destruction?).map(&:committee)
+    committee_members.select { |cm| cm.active? && !cm.marked_for_destruction? }.map { |cm| cm.committee }
   end
 
 end

data/app/models/effective/committee_member.rb

@@ -18,6 +18,9 @@ module Effective
     effective_resource do
       roles_mask    :integer
 
+      start_on      :date
+      end_on        :date
+
       timestamps
     end
 
@@ -34,13 +37,13 @@ module Effective
 
     after_commit(if: -> { user_ids.present? }) do
       additional = (user_ids - CommitteeMember.where(committee_id: committee_id, user_id: user_ids).pluck(:user_id))
-      additional = additional.map { |user_id| {committee_id: committee_id, committee_type: committee_type, user_id: user_id, user_type: user_type, roles_mask: roles_mask} }
+      additional = additional.map { |user_id| {committee_id: committee_id, committee_type: committee_type, user_id: user_id, user_type: user_type, roles_mask: roles_mask, start_on: start_on, end_on: end_on} }
       CommitteeMember.insert_all(additional)
     end
 
     after_commit(if: -> { committee_ids.present? }) do
       additional = (committee_ids - CommitteeMember.where(user_id: user_id, committee_id: committee_ids).pluck(:committee_id))
-      additional = additional.map { |committee_id| {committee_id: committee_id, committee_type: committee_type, user_id: user_id, user_type: user_type, roles_mask: roles_mask} }
+      additional = additional.map { |committee_id| {committee_id: committee_id, committee_type: committee_type, user_id: user_id, user_type: user_type, roles_mask: roles_mask, start_on: start_on, end_on: end_on} }
       CommitteeMember.insert_all(additional)
     end
 
@@ -50,10 +53,27 @@ module Effective
     validates :user_id, if: -> { user_id && user_type && committee_id && committee_type },
       uniqueness: { scope: [:committee_id, :committee_type], message: 'already belongs to this committee' }
 
+    validate(if: -> { start_on && end_on }) do
+      self.errors.add(:end_on, 'must be after start date') unless end_on > start_on
+    end
+
     def to_s
       user.to_s
     end
 
+    def active?(date: nil)
+      return true if start_on.blank? && end_on.blank?
+
+      date ||= Time.zone.now
+      date = date.to_date if date.respond_to?(:to_date)
+
+      (start_on..end_on).cover?(date)  # Endless ranges
+    end
+
+    def expired?(date: nil)
+      active?(date: date) == false
+    end
+
     def user_ids
       Array(@user_ids) - [nil, '']
     end

data/app/views/admin/committee_members/_form.html.haml

@@ -10,21 +10,28 @@
   = f.hidden_field :committee_type
   = f.hidden_field :committee_id
 
+  - ajax_url = (@select2_ajax_path || effective_resources.users_admin_select2_ajax_index_path) unless Rails.env.test?
+
   - if f.object.new_record?
     - if inline_datatable? && inline_datatable.attributes[:committee_id].present?
-      = f.select :user_ids, current_user.class.sorted, label: 'Add user(s)', hint: 'Add one or more users'
+      = f.select :user_ids, current_user.class.sorted, label: 'Add user(s)', required: true, ajax_url: ajax_url, hint: 'Add one or more users'
 
     - if inline_datatable? && inline_datatable.attributes[:user_id].present?
       = f.select :committee_ids, committees, label: 'Add committee(s)', hint: 'Add one or more committees'
 
     - unless inline_datatable?
       = f.select :committee_id, committees, label: 'Committee'
-      = f.select :user_ids, current_user.class.sorted, label: 'User(s)', hint: 'Add one or more user at a time'
+
+      = f.select :user_ids, current_user.class.sorted, label: 'User(s)', required: true, ajax_url: ajax_url, hint: 'Add one or more user at a time'
 
   - if f.object.persisted?
     = f.static_field :committee
     = f.static_field :user, label: 'Committee Member'
 
+  .row
+    .col= f.date_field :start_on, hint: 'optional start date'
+    .col= f.date_field :end_on, hint: 'optional end date'
+
   - if EffectiveCommittees.use_effective_roles
     = f.checks :roles, EffectiveRoles.roles_collection(f.object, skip_disabled: true)
 

data/app/views/effective/committee_members/_form.html.haml

@@ -10,6 +10,10 @@
     - unless inline_datatable? && inline_datatable.attributes[:committee_id].present?
       = f.select :committee, { 'Committees' => Effective::Committee.sorted }, polymorphic: true
 
+    .row
+      .col= f.date_field :start_on, hint: 'optional start date'
+      .col= f.date_field :end_on, hint: 'optional end date'
+
     - if EffectiveCommittees.use_effective_roles
       = f.checks :roles, EffectiveRoles.roles_collection(f.object, skip_disabled: true)
 
@@ -26,6 +30,10 @@
     - unless inline_datatable? && inline_datatable.attributes[:user_id].present?
       = f.static_field :user
 
+    .row
+      .col= f.date_field :start_on, hint: 'optional start date'
+      .col= f.date_field :end_on, hint: 'optional end date'
+
     - if EffectiveCommittees.use_effective_roles
       = f.checks :roles, EffectiveRoles.roles_collection(f.object, skip_disabled: true)
 

data/app/views/effective/committees/_committee.html.haml

@@ -18,6 +18,6 @@
       %tr
         %td= link_to(icon('folder') + folder, effective_committees.committee_committee_folder_path(committee, folder))
         %td= pluralize(folder.committee_files.length, 'file')
-        %td= folder.body
+        %td= folder.body.to_s
 
   %p Displaying #{pluralize(committee.committee_folders.length, 'folder')}

data/config/locales/effective_committees.en.yml

@@ -0,0 +1,11 @@
+en:
+  effective_committees:
+    name: 'Effective Committees'
+    acronym: 'Committees'
+
+  activerecord:
+    models:
+      effective/committee: 'Committee'
+      effective/committee_file: 'Committee File'
+      effective/committee_folder: 'Committee Folder'
+      effective/committee_member: 'Committee Member'

data/db/migrate/01_create_effective_committees.rb.erb

@@ -26,6 +26,9 @@ class CreateEffectiveCommittees < ActiveRecord::Migration[6.1]
 
       t.integer :roles_mask
 
+      t.date :start_on
+      t.date :end_on
+
       t.datetime :updated_at
       t.datetime :created_at
     end

data/lib/effective_committees/version.rb

@@ -1,3 +1,3 @@
 module EffectiveCommittees
-  VERSION = '0.1.2'.freeze
+  VERSION = '0.2.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_committees
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.1
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-27 00:00:00.000000000 Z
+date: 2023-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -215,6 +215,7 @@ files:
 - app/views/effective/committees/_form_committee.html.haml
 - app/views/effective/committees/index.html.haml
 - config/effective_committees.rb
+- config/locales/effective_committees.en.yml
 - config/routes.rb
 - db/migrate/01_create_effective_committees.rb.erb
 - db/seeds.rb