effective_addresses 1.9.3 → 1.9.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e41141e340c412a2e083dfb79792a86f102484fe61734eebf85963ba17c287c8
-  data.tar.gz: f0f60629f50f7f20e3e8ba6976e6ba9554b18ed6bb38870a4653ab1ad33b9c17
+  metadata.gz: 662a91519afc8f6bd35398c6ef980a41d318e09b49a15da12d7572a0921d1736
+  data.tar.gz: c12ffecd410c02828d1d30a61198aa78e94e03d96019537930206198bf76a8ab
 SHA512:
-  metadata.gz: 934bf8000a28eb370e5f444d6f70610ea7b63f5c0d71c0e1da9f1ed0d83265b697b424489b732d2469e3a23edde57c603d11b2daf2aec9a4688635239e45ee4d
-  data.tar.gz: 170e98c482c1d99e3907864773762f487f0b61b0e5fc8399ffcac6c11f4d03655b547450d0c7a8ae856b97a7b13469bbe83f7a602ad8304b9ae32397f9f82179
+  metadata.gz: fb2dd3933ce5bfd663f4f99ad2bbf2bf2efce136a872c1b443e9ff9f96a922348b23d986260e50b05160153cc7e22911e8bb3fc8a975094949b3967c872d46e0
+  data.tar.gz: 1d7bc37461b4633084d2f0aa1b45a404f17b253a569a7f16e89b913c62ebd0645debe7cc413ede607109e4c34168e8f53d01291346da0016caa48205ac7305cc

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2018 Code and Effect Inc.
+Copyright 2021 Code and Effect Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -89,7 +89,7 @@ or
 
 ```ruby
 class User
-  acts_as_addressable :billing => {:presence => true, :use_full_name => false}
+  acts_as_addressable :billing => {:presence => true}
 end
 ```
 
@@ -110,11 +110,7 @@ This means when a User is created, it will not be valid unless a billing_address
 
 Sometimes you want to collect a `full_name` field with your addresses, such as in the case of a mailing address; other times, it's an unnecessary field.
 
-When you specify the config option `config.use_full_name = true` all `acts_as_addressable` defined addresses will use `use_full_name => true` by default.
-
-This can be overridden on a per-address basis when declared in the model.
-
-When `use_full_name == true`, any calls to `effective_address_fields` form helper will display the full_name input, and the model will `validate_presence_of :full_name`.
+When you specify the config option `config.use_full_name = true` all, any calls to `effective_address_fields` form helper will display the full_name input, and the model will `validate_presence_of :full_name`.
 
 
 ### Address Validations

data/app/helpers/effective_addresses_helper.rb

@@ -1,16 +1,15 @@
-module EffectiveAddressesHelper
-  @@use_geocoder = defined?(Geocoder)
+# frozen_string_literal: true
 
+module EffectiveAddressesHelper
   def effective_address_fields(form, method = 'billing', options = {})
     method = (method.to_s.include?('_address') ? method.to_s : "#{method}_address")
 
     required = (form.object._validators[method.to_sym].any? { |v| v.kind_of?(ActiveRecord::Validations::PresenceValidator) && (v.options[:if].blank? || (v.options[:if].respond_to?(:call) ? f.object.instance_exec(&v.options[:if]) : v.options[:if])) } rescue true)
-    use_full_name = form.object._validators[method.to_sym].any? { |v| v.kind_of?(EffectiveAddressFullNamePresenceValidator) }
 
     address = form.object.send(method) || form.object.addresses.build(category: method.to_s.gsub('_address', ''))
     effective_address_pre_select(address) if address.new_record?
 
-    opts = { required: required, use_full_name: use_full_name, field_order: [:full_name, :address1, :address2, :city, :country_code, :state_code, :postal_code] }.merge(options).merge({:f => form, :address => address, :method => method})
+    opts = { required: required, field_order: [:full_name, :address1, :address2, :city, :country_code, :state_code, :postal_code] }.merge(options).merge({:f => form, :address => address, :method => method})
 
     case form.class.name
     when 'Effective::FormBuilder'
@@ -28,7 +27,7 @@ module EffectiveAddressesHelper
     if EffectiveAddresses.pre_selected_country.present?
       address.country = EffectiveAddresses.pre_selected_country
       address.state = EffectiveAddresses.pre_selected_state if EffectiveAddresses.pre_selected_state.present?
-    elsif @@use_geocoder && request.location.present?
+    elsif defined?(Geocoder) && request.location.present?
       location = request.location
       address.country = location.country_code
       address.state = location.state_code

data/app/models/concerns/acts_as_addressable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # ActsAsAddressable
 
 module ActsAsAddressable
@@ -23,7 +25,7 @@ module ActsAsAddressable
     end
 
     # Categories can be either:
-    # {'billing'=>{:singular=>true, :use_full_name=>false}, 'shipping'=>{:singular=>true, :use_full_name=>false}}
+    # {'billing'=>{:singular=>true}, 'shipping'=>{:singular=>true}}
     # or
     # {'billing' => true, 'shipping' => true}
     # or
@@ -46,11 +48,13 @@ module ActsAsAddressable
 
       case options
       when Hash
-        validates "#{category}_address", presence: options.fetch(:presence, false)
-        validates "#{category}_address", effective_address_full_name_presence: options.fetch(:use_full_name, EffectiveAddresses.use_full_name)
-      when TrueClass, FalseClass
-        validates "#{category}_address", presence: (options == true)
-        validates "#{category}_address", effective_address_full_name_presence: EffectiveAddresses.use_full_name
+        validates("#{category}_address", presence: true) if options[:presence]
+        validates("#{category}_address", effective_address_full_name_presence: true) if options[:use_full_name]
+      when TrueClass
+        validates "#{category}_address", presence: true
+        validates "#{category}_address", effective_address_full_name_presence: true, if: -> { EffectiveAddresses.use_full_name }
+      when FalseClass
+        # Nothing to do
       else
         raise 'Unexpected options. Expected a Hash or Boolean'
       end
@@ -133,4 +137,3 @@ module ActsAsAddressable
   end
 
 end
-

data/app/models/effective/address.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Effective
   class Address < ActiveRecord::Base
     self.table_name = EffectiveAddresses.addresses_table_name.to_s
@@ -8,27 +10,22 @@ module Effective
 
     belongs_to :addressable, polymorphic: true, touch: true
 
-    if defined?(EffectiveResources)
-      effective_resource do
-        category          :string
-
-        full_name         :string
-        address1          :string
-        address2          :string
+    effective_resource do
+      category          :string
 
-        if EffectiveAddresses.use_address3
-          address3          :string
-        end
+      full_name         :string
+      address1          :string
+      address2          :string
+      address3          :string
 
-        city              :string
-        state_code        :string
-        country_code      :string
-        postal_code       :string
+      city              :string
+      state_code        :string
+      country_code      :string
+      postal_code       :string
 
-        shipping_address_same_as_billing permitted: true
+      shipping_address_same_as_billing permitted: true
 
-        timestamps
-      end
+      timestamps
     end
 
     validates :category, :address1, :city, :country_code, :postal_code, presence: true, if: Proc.new { |address| address.present? }

data/app/views/effective/addresses/_form_with.html.haml

@@ -8,7 +8,7 @@
   - if ((f.object.errors.include?(method) && !f.object.errors.include?(:addresses)) rescue false)
     = f.errors method
 
-  - if use_full_name || fa.object.errors.include?(:full_name)
+  - if EffectiveAddresses.use_full_name || fa.object.errors.include?(:full_name)
     = fa.text_field :full_name,
       required: required,
       disabled: same_as_billing,
@@ -26,7 +26,7 @@
     disabled: same_as_billing,
     wrapper: wrapper_options
 
-  - if fa.object.respond_to?(:address3) && EffectiveAddresses.use_address3
+  - if EffectiveAddresses.use_address3
     = fa.text_field :address3,
       label: false,
       required: false,

data/app/views/effective/addresses/_formtastic.html.haml

@@ -9,7 +9,7 @@
 
     - case field
       - when :full_name
-        - if use_full_name || fa.object.errors.include?(:full_name)
+        - if EffectiveAddresses.use_full_name || fa.object.errors.include?(:full_name)
           = fa.input :full_name, :required => true, :label => 'Full name', :placeholder => 'Full name'
 
       - when :address1

data/app/views/effective/addresses/_simple_form.html.haml

@@ -10,7 +10,7 @@
 
     - case field
       - when :full_name
-        - if use_full_name || fa.object.errors.include?(:full_name)
+        - if EffectiveAddresses.use_full_name || fa.object.errors.include?(:full_name)
           = fa.input :full_name,
             required: required,
             disabled: shipping_address_same_as_billing,
@@ -81,4 +81,3 @@
       label: 'Shipping address is same as billing address',
       required: false,
       input_html: { checked: shipping_address_same_as_billing }
-

data/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 EffectiveAddresses::Engine.routes.draw do
   scope :module => 'effective' do
     match 'addresses/subregions/:country_code', to: 'addresses#subregions', as: 'address_subregions', via: :get

data/db/migrate/01_create_effective_addresses.rb.erb

@@ -7,9 +7,7 @@ class CreateEffectiveAddresses < ActiveRecord::Migration[4.2]
       t.string :full_name
       t.string :address1
       t.string :address2
-
-      # Uncomment this if you want 3 address fields
-      # t.string :address3
+      t.string :address3
 
       t.string :city
       t.string :state_code

data/lib/effective_addresses/version.rb

@@ -1,3 +1,3 @@
 module EffectiveAddresses
-  VERSION = '1.9.3'.freeze
+  VERSION = '1.9.7'.freeze
 end

data/lib/effective_addresses.rb

@@ -1,26 +1,31 @@
 require 'carmen'
+require 'effective_resources'
 require 'effective_addresses/engine'
 require 'effective_addresses/version'
 
 module EffectiveAddresses
 
-  # The following are all valid config keys
-  mattr_accessor :country_codes
-  mattr_accessor :country_codes_priority
-  mattr_accessor :addresses_table_name
-  mattr_accessor :use_full_name
-  mattr_accessor :use_address3
-  mattr_accessor :simple_form_options
-  mattr_accessor :validate_postal_code_format
-  mattr_accessor :pre_selected_country
-  mattr_accessor :pre_selected_state
-
-  def self.setup
-    yield self
+  def self.config_keys
+    [
+      :addresses_table_name,
+      :country_codes,
+      :country_codes_priority,
+      :use_full_name,
+      :use_address3,
+      :simple_form_options,
+      :validate_postal_code_format,
+      :pre_selected_country,
+      :pre_selected_state
+    ]
   end
 
+  include EffectiveGem
+
   def self.permitted_params
-    [:address1, :address2, :address3, :city, :country_code, :state_code, :postal_code, :full_name, :shipping_address_same_as_billing]
+    [
+      :address1, :address2, :address3, :city, :country_code, :state_code, :postal_code,
+      :full_name, :shipping_address_same_as_billing
+    ]
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_addresses
 version: !ruby/object:Gem::Version
-  version: 1.9.3
+  version: 1.9.7
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-03 00:00:00.000000000 Z
+date: 2021-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
+- !ruby/object:Gem::Dependency
+  name: effective_resources
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: carmen
   requirement: !ruby/object:Gem::Requirement