eeny-meeny 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 34311644231b710c6ce1e10c5fb6f4410bd4ed5d
-  data.tar.gz: fa951cdb99821c5cd8d0c032d0048875b210193f
+  metadata.gz: 3d6f1ff00ff903e788dcf59c336dce5748f18852
+  data.tar.gz: 153b807882e56f14e0865d3b9648e2b3aea747f4
 SHA512:
-  metadata.gz: 46a37bb2552e814042c625c3e864073ac4133f295eec99e8a646b4331182060299981b3e8248e7bda8f3c5c2c629ae276a49f0ca9c4290700c22fc840ee0f508
-  data.tar.gz: 03653ee7e0e9eee45bfe2f0efe87e92df72bf7a74d6546dfae2947330eba02e8dd218bb0f070b55967081b7f00be3dd501596b92af8328b65d3c9d150cb5b6f3
+  metadata.gz: 977ead352b9f734e1ac1af86f0c6c5649ff68f8e1accac7efe159b6bd1a17a26bf397efbcce7b6c1b47c14650a24944fc87ab7956094ce105147351fcd03f5f1
+  data.tar.gz: 02e9d69b318010e3fab99e947699d78b053245a1089b871f615a0e05c3ec7f26d58aa1b4a9c37ab72339de7ed7567f51a59e6d93ad29d7c064a355aef83d0b86

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+### 2.1.0 (2016-10-02)
+
+Features:
+
+    - Trigger experiment variations with query parameters
+    - Trigger smoke tests with query parameters
+
+Bugfixes:
+
+    - Fixed error that caused 'participates_in?' to throw error when the given experiment_id did not exist.
+
+Other Changes:
+
+    - Reduced size of experiment cookies. Now only the picked variation_id is stored in the cookie itself.
+
 ### 2.0.0 (2016-09-11)
 
 Features:

data/README.md

@@ -24,6 +24,7 @@ The following configurations are available:
 * `cookies` Defaults to `{ http_only: true, path: '/', same_site: :strict }`. Sets the eeny-meeny cookie attributes. The valid attributes are listed in the section below.
 * `secure`  Defaults to `true`. Determines if eeny-meeny cookies should be encrypted or not.
 * `secret`  Sets the secret used for encrypting experiment cookies.
+* `query_parameters` Defaults to `{ experiment: true, smoke_test: true }`. Controls whether experiments variations and smoke tests can be triggered through query parameters.
 * `experiments` Defaults to `{}`. It is easiest to load this from a `.yml` file with `YAML.load_file(File.join('config','experiments.yml'))`. The YAML file should have a structure matching the following example:
 
 ```
@@ -36,13 +37,11 @@ The following configurations are available:
     :a:
       :name: Variation A
       :weight: 0.8
-      :options:
-        :message: A rocks, B sucks
+      :custom_attribute: A rocks, B sucks
     :b:
       :name: Variation B
       :weight: 0.2
-      :options:
-        :message: B is an all-star!
+      :custom_attribute: B is an all-star!
 ```
 
 Valid cookie attributes:
@@ -100,16 +99,16 @@ Rake tasks
 -------------
 `eeny-meeny` adds the following rake tasks to your project.
 
-* `eeny_meeny:cookies:experiment[experiment_id]`. Creates and outputs a valid cookie for the given experiment id.
-* `eeny_meeny:cookies:experiment_variation[experiment_id,variation_id]` creates and outputs a valid cookie for the given variation of the experiment with the given experiment_id.
-* `eeny_meeny:cookies:smoke_test[smoke_test_id,version]` Creates and outputs a valid smoke test cookie for a smoke test with the given id and version. `version` will default to `1` if not given.
+* `eeny_meeny:cookie:experiment[experiment_id]`. Creates and outputs a valid cookie for the given experiment id.
+* `eeny_meeny:cookie:experiment_variation[experiment_id,variation_id]` creates and outputs a valid cookie for the given variation of the experiment with the given experiment_id.
+* `eeny_meeny:cookie:smoke_test[smoke_test_id,version]` Creates and outputs a valid smoke test cookie for a smoke test with the given id and version. `version` will default to `1` if not given.
 
 You can execute the rake tasks like this:
 
-* `rake eeny_meeny:cookies:experimet[experiment_id]`
-* `rake eeny_meeny:cookies:experimet_variation[experiment_id, a]`
-* `rake eeny_meeny:cookies:smoke_test[shadow]`
-* `rake eeny_meeny:cookies:smoke_test[shadow,2]`
+* `rake eeny_meeny:cookie:experimet[experiment_id]`
+* `rake eeny_meeny:cookie:experimet_variation[experiment_id, a]`
+* `rake eeny_meeny:cookie:smoke_test[shadow]`
+* `rake eeny_meeny:cookie:smoke_test[shadow,2]`
 
 You can add the resulting cookie to your browser by copying the cookie string and use the following command in the JS console of your browser.
 
@@ -119,6 +118,18 @@ document.cookie = '<cookie string excluding httponly>';
 
 Please note that the `HttpOnly` attribute will prevent you from adding the cookie to your browser through JS. You will therefor have to remove the `HttpOnly` part of the cookie string before adding the cookie to your browser.
 
+Query parameters
+-------------
+By default it is possible to trigger smoke tests and experiment variations through query parameters.
+
+Executing a request to `/?smoke_test_id=my_secret` will trigger the `my_secret` smoke test.
+
+Executing a request to `/?eeny_meeny_my_page_v1=old` will trigger the `old` varition of the `my_page` experiment.
+
+For experiments the parameter needs to match the pattern `eeny_meeny_<experiment_id>_v<experiment_version>=<variation_id>`
+
+Please note that this behavior can be disabled through the `query_parameters` configuration.
+
 Setting up Experiments
 -------------
 It is easiest to define your experiments in YAML files and load them with as shown in the **Configuration** section.
@@ -137,7 +148,8 @@ A variation needs the following information:
 * `variation_id` This is the key that encapsulates the rest of your variation configuration in the YAML file (see `:a:` the **Configuration** section).
 * `name` The name/title of your varition.
 * `weight` The weight of the variation. Defaults to `1`. This can be a floating or integer number. The final weight of the variation will be `weight / sum_of_variation_weights`.
-* `options` (optional) a hash with variation specific information that you want stored want to use in your experiment. Notice that this information will be stored in the experiment cookie so avoid putting sensitive data in there - especially if you choose to disable the cookie encryption.
+
+You can define additional variation attributes as part of the experiment configuration. These attributes will be accessible as a `Hash` returned from the `options` method on variation objects.
 
 If you want to force all your users to get their experiment cookie updated, then you can change the `version` option on your experiment. This might for instance be useful if you want to remove an under-performing variation from your experiment. Or when gradually rolling a feature out to the public.
 

data/eeny-meeny.gemspec

@@ -3,7 +3,7 @@ require File.expand_path('../lib/eeny-meeny/version', __FILE__)
 Gem::Specification.new do |s|
   s.name        = 'eeny-meeny'
   s.version     = EenyMeeny::VERSION.dup
-  s.date        = '2016-09-11'
+  s.date        = '2016-10-02'
   s.summary     = "A simple split and smoke testing tool for Rails"
   s.authors     = ["Christian Orthmann"]
   s.email       = 'christian.orthmann@gmail.com'

data/lib/eeny-meeny.rb

@@ -5,16 +5,17 @@ require 'eeny-meeny/models/encryptor'
 module EenyMeeny
 
   class Config
-    attr_accessor :cookies, :experiments, :secret, :secure
+    attr_accessor :cookies, :experiments, :secret, :secure, :query_parameters
 
     attr_reader :encryptor
 
     def initialize
-      @cookies     = { http_only: true, path: '/', same_site: :strict }
-      @experiments = {}
-      @secret      = '9fc8b966eca7d03d55df40c01c10b8e02bf1f9d12d27b8968d53eb53e8c239902d00bf6afae5e726ce1111159eeb2f8f0e77233405db1d82dd71397f651a0a4f'
-      @secure      = true
-      @encryptor   = (@secure ? EenyMeeny::Encryptor.new(@secret) : nil)
+      @cookies             = { http_only: true, path: '/', same_site: :strict }
+      @experiments         = {}
+      @secret              = '9fc8b966eca7d03d55df40c01c10b8e02bf1f9d12d27b8968d53eb53e8c239902d00bf6afae5e726ce1111159eeb2f8f0e77233405db1d82dd71397f651a0a4f'
+      @secure              = true
+      @encryptor           = (@secure ? EenyMeeny::Encryptor.new(@secret) : nil)
+      @query_parameters    = { experiment: true, smoke_test: true }
     end
   end
   

data/lib/eeny-meeny/experiment_helper.rb

@@ -5,9 +5,10 @@ module EenyMeeny::ExperimentHelper
 
   def participates_in?(experiment_id, variation_id: nil)
     experiment = EenyMeeny::Experiment.find_by_id(experiment_id)
-    return unless experiment.active?
-    cookie = read_cookie(EenyMeeny::Cookie.cookie_name(experiment))
-    cookie[:variation] unless cookie.nil? || (variation_id.present? && variation_id != cookie[:variation].id)
+    return unless !experiment.nil? && experiment.active?
+    participant_variation_id = read_cookie(EenyMeeny::Cookie.cookie_name(experiment))
+    return if variation_id && variation_id != participant_variation_id
+    experiment.find_variation(participant_variation_id)
   end
 
   def smoke_test?(smoke_test_id, version: 1)

data/lib/eeny-meeny/middleware.rb

@@ -24,17 +24,28 @@ module EenyMeeny
       @experiments.each do |experiment|
         # Skip inactive experiments
         next unless experiment.active?(now)
+        # Trigger experiment through query parmeters
+        cookie_name = EenyMeeny::Cookie.cookie_name(experiment)
+        has_experiment_trigger = EenyMeeny.config.query_parameters[:experiment] && request.params.has_key?(cookie_name)
         # skip experiments that already have a cookie
-        unless cookies.has_key?(EenyMeeny::Cookie.cookie_name(experiment))
-          env['Set-Cookie'] = ''
-          cookie = EenyMeeny::Cookie.create_for_experiment(experiment, @cookie_config)
+        if has_experiment_trigger || !cookies.has_key?(cookie_name)
+          cookie = if has_experiment_trigger
+                     # Trigger experiment variation through query parameter.
+                     EenyMeeny::Cookie.create_for_experiment_variation(experiment, request.params[cookie_name].to_sym, @cookie_config)
+                   else
+                     EenyMeeny::Cookie.create_for_experiment(experiment, @cookie_config)
+                   end
           # Set HTTP_COOKIE header to enable experiment on first pageview
-          Rack::Utils.set_cookie_header!(env,
-                                         cookie.name,
-                                         cookie.to_h)
-          env['HTTP_COOKIE'] = '' if env['HTTP_COOKIE'].nil?
-          env['HTTP_COOKIE'] += '; ' unless env['HTTP_COOKIE'].empty?
-          env['HTTP_COOKIE'] += env['Set-Cookie']
+          env = add_http_cookie(env, cookie, precede: has_experiment_trigger)
+          new_cookies[cookie.name] = cookie
+        end
+      end
+      # Prepare smoke tests (if enabled through query parameters)
+      if EenyMeeny.config.query_parameters[:smoke_test]
+        if request.params.has_key?('smoke_test_id') && (request.params['smoke_test_id'] =~ /[A-Za-z_]+/)
+          # Set HTTP_COOKIE header to enable smoke test on first pageview
+          cookie = EenyMeeny::Cookie.create_for_smoke_test(request.params['smoke_test_id'])
+          env = add_http_cookie(env, cookie, precede: true)
           new_cookies[cookie.name] = cookie
         end
       end
@@ -53,5 +64,22 @@ module EenyMeeny
       end
       response.finish
     end
+
+    private
+    def add_http_cookie(env, cookie, precede: false)
+      env['Set-Cookie'] = ''
+      Rack::Utils.set_cookie_header!(env,
+                                     cookie.name,
+                                     cookie.to_h)
+      env['HTTP_COOKIE'] = '' if env['HTTP_COOKIE'].nil?
+      if precede
+        # Prepend cookie to the 'HTTP_COOKIE' header. This ensures it overwrites existing cookies when present.
+        env['HTTP_COOKIE'] = env['Set-Cookie'] + '; ' + env['HTTP_COOKIE']
+      else
+        env['HTTP_COOKIE'] += '; ' unless env['HTTP_COOKIE'].empty?
+        env['HTTP_COOKIE'] += env['Set-Cookie']
+      end
+      env
+    end
   end
 end

data/lib/eeny-meeny/models/cookie.rb

@@ -9,14 +9,11 @@ module EenyMeeny
     attr_reader :name, :expires, :httponly, :same_site, :path
 
     def self.create_for_experiment_variation(experiment, variation_id, config = {})
-      variation = experiment.variations.detect { |variation| variation.id == variation_id }
+      variation = experiment.find_variation(variation_id)
       raise "Variation '#{variation_id}' not found for Experiment '#{experiment.id}'" if variation.nil?
       options = {
           name: cookie_name(experiment),
-          value: Marshal.dump({
-                                  name: experiment.name,
-                                  variation: variation
-                              })
+          value: variation.id.to_s
       }
       options[:expires] = experiment.end_at if experiment.end_at
       if EenyMeeny.config.secure
@@ -28,10 +25,7 @@ module EenyMeeny
     def self.create_for_experiment(experiment, config = {})
       options = {
           name: cookie_name(experiment),
-          value: Marshal.dump({
-                                  name: experiment.name,
-                                  variation: experiment.pick_variation
-                              })
+          value: experiment.pick_variation.id.to_s
       }
       options[:expires] = experiment.end_at if experiment.end_at
       if EenyMeeny.config.secure
@@ -43,10 +37,7 @@ module EenyMeeny
     def self.create_for_smoke_test(smoke_test_id, version: 1, **config)
       options = {
           name: smoke_test_name(smoke_test_id, version: version),
-          value: Marshal.dump({
-                                  name: smoke_test_id,
-                                  version: version
-                              })
+          value: smoke_test_id.to_s
       }
       if EenyMeeny.config.secure
         options[:value] = EenyMeeny.config.encryptor.encrypt(options[:value])
@@ -67,8 +58,8 @@ module EenyMeeny
     def self.read(cookie_string)
       return if cookie_string.nil? || cookie_string.empty?
       begin
-        return Marshal.load(cookie_string) unless EenyMeeny.config.secure # Cookie encryption disabled.
-        Marshal.load(EenyMeeny.config.encryptor.decrypt(cookie_string))
+        return cookie_string unless EenyMeeny.config.secure # Cookie encryption disabled.
+        EenyMeeny.config.encryptor.decrypt(cookie_string)
       rescue
         nil # Return nil if cookie is invalid.
       end

data/lib/eeny-meeny/models/experiment.rb

@@ -36,6 +36,10 @@ module EenyMeeny
       !!((@start_at && (now > @start_at)) && (@end_at && (now < @end_at))) # specified start and end
     end
 
+    def find_variation(variation_id)
+      @variations.detect { |v| v.id.to_s == variation_id.to_s }
+    end
+
     def pick_variation
       Hash[
           @variations.map do |variation|

data/lib/eeny-meeny/models/variation.rb

@@ -8,13 +8,5 @@ module EenyMeeny
       @weight = weight
       @options = options
     end
-
-    def marshal_dump
-      [@id, { name: @name, weight: @weight, **@options }]
-    end
-
-    def marshal_load(array)
-      send :initialize, array[0], **array[1]
-    end
   end
 end

data/lib/eeny-meeny/railtie.rb

@@ -9,10 +9,11 @@ module EenyMeeny
     initializer 'eeny_meeny.configure' do |app|
       # Configrue EenyMeeny (defaults set in eeny_meeny.rb)
       EenyMeeny.configure do |config|
-        config.cookies     = app.config.eeny_meeny[:cookies]     if app.config.eeny_meeny.has_key?(:cookies)
-        config.experiments = app.config.eeny_meeny[:experiments] if app.config.eeny_meeny.has_key?(:experiments)
-        config.secret      = app.config.eeny_meeny[:secret]      if app.config.eeny_meeny.has_key?(:secret)
-        config.secure      = app.config.eeny_meeny[:secure]      if app.config.eeny_meeny.has_key?(:secure)
+        config.cookies               = app.config.eeny_meeny[:cookies]          if app.config.eeny_meeny.has_key?(:cookies)
+        config.experiments           = app.config.eeny_meeny[:experiments]      if app.config.eeny_meeny.has_key?(:experiments)
+        config.secret                = app.config.eeny_meeny[:secret]           if app.config.eeny_meeny.has_key?(:secret)
+        config.secure                = app.config.eeny_meeny[:secure]           if app.config.eeny_meeny.has_key?(:secure)
+        config.query_parameters      = app.config.eeny_meeny[:query_parameters] if app.config.eeny_meeny.has_key?(:query_parameters)
       end
       # Include Helpers in ActionController and ActionView
       ActionController::Base.send :include, EenyMeeny::ExperimentHelper

data/lib/eeny-meeny/routing/experiment_constraint.rb

@@ -10,10 +10,10 @@ module EenyMeeny
     end
 
     def matches?(request)
-      return false unless @experiment.active?
-      cookie = EenyMeeny::Cookie.read(request.cookie_jar[EenyMeeny::Cookie.cookie_name(@experiment)])
-      return false if cookie.nil? # Not participating in experiment
-      (@variation_id.nil? || @variation_id == cookie[:variation].id)
+      return false unless !@experiment.nil? && @experiment.active?
+      participant_variation_id = EenyMeeny::Cookie.read(request.cookie_jar[EenyMeeny::Cookie.cookie_name(@experiment)])
+      return false if participant_variation_id.nil? # Not participating in experiment
+      (@variation_id.nil? || @variation_id == participant_variation_id)
     end
   end
 end

data/lib/eeny-meeny/version.rb

@@ -1,3 +1,3 @@
 module EenyMeeny
-  VERSION = '2.0.0'
+  VERSION = '2.1.0'
 end

data/spec/eeny-meeny/experiment_helper_spec.rb

@@ -0,0 +1,88 @@
+require 'spec_helper'
+require 'eeny-meeny/middleware'
+require 'eeny-meeny/experiment_helper'
+require 'eeny-meeny/models/experiment'
+require 'eeny-meeny/models/variation'
+require 'eeny-meeny/models/cookie'
+require 'rack/test'
+
+describe EenyMeeny::ExperimentHelper, experiments: true do
+
+  subject do
+    Object.new.extend(EenyMeeny::ExperimentHelper)
+  end
+
+  let(:request) do
+    Rack::MockSession.new(EenyMeeny::Middleware.new(MockRackApp.new))
+  end
+
+  describe '#participates_in?' do
+    context 'given an experiment id' do
+      let(:request_with_cookie) do
+        request.set_cookie(EenyMeeny::Cookie.create_for_experiment(EenyMeeny::Experiment.find_by_id(:my_page)).to_s)
+        request
+      end
+
+      context 'of an active experiment' do
+        context 'with a valid experiment cookie' do
+          it "returns the user's experiment variation" do
+            allow(subject).to receive(:cookies).and_return(request_with_cookie.cookie_jar)
+            expect(subject.participates_in?(:my_page)).to be_a EenyMeeny::Variation
+          end
+        end
+
+        context 'without an experiment cookie' do
+          it 'returns nil' do
+            allow(subject).to receive(:cookies).and_return(request.cookie_jar)
+            expect(subject.participates_in?(:my_page)).to be_nil
+          end
+        end
+      end
+
+      context 'of an inactive experiment' do
+        context 'with a valid experiment cookie' do
+          let(:request_with_expired_cookie) do
+            request.set_cookie(EenyMeeny::Cookie.create_for_experiment(EenyMeeny::Experiment.find_by_id(:expired)).to_s)
+            request
+          end
+
+          it 'returns nil' do
+            allow(subject).to receive(:cookies).and_return(request_with_expired_cookie.cookie_jar)
+            expect(subject.participates_in?(:expired)).to be_nil
+          end
+        end
+      end
+
+      context 'that does not exist among the experiments' do
+        it 'returns nil' do
+          allow(subject).to receive(:cookies).and_return(request_with_cookie.cookie_jar)
+          expect(subject.participates_in?(:this_does_not_exist)).to be_nil
+        end
+      end
+    end
+  end
+
+  describe '#smoke_test?' do
+    context 'given a smoke test id' do
+      let(:request_with_smoke_test) do
+        request.set_cookie(EenyMeeny::Cookie.create_for_smoke_test(:my_smoke_test).to_s)
+        request
+      end
+
+      context 'and a request with a valid smoke test cookie' do
+        it 'returns the smoke test' do
+          allow(subject).to receive(:cookies).and_return(request_with_smoke_test.cookie_jar)
+          expect(subject.smoke_test?(:my_smoke_test)).to be
+        end
+      end
+
+      context 'and a request without a smoke test cookie' do
+        it 'returns nil' do
+          allow(subject).to receive(:cookies).and_return(request.cookie_jar)
+          expect(subject.smoke_test?(:my_smoke_test)).to be_nil
+        end
+      end
+    end
+  end
+
+end

data/spec/eeny-meeny/middleware_spec.rb

@@ -69,6 +69,47 @@ describe EenyMeeny::Middleware do
         expect(@response['Set-Cookie']).to be nil
       end
     end
+
+    context 'and given an experiment query parameter' do
+      let(:request) { Rack::MockRequest.new(subject) }
+
+      before(:example) do
+        @response = request.get('/test?eeny_meeny_my_page_v1=old', 'CONTENT_TYPE' => 'text/plain')
+      end
+
+      it 'selects the correct variation' do
+        modified_request = Rack::Request.new(app)
+        expect(EenyMeeny::Cookie.read(modified_request.cookies['eeny_meeny_my_page_v1'])).to eq('old')
+      end
+
+      it "sets the 'HTTP_COOKIE' header on the request" do
+        expect(app['HTTP_COOKIE']).to be
+        expect(app['HTTP_COOKIE']).to include('eeny_meeny_my_page_v1=')
+      end
+
+      it "sets the 'Set-Cookie' header on the response" do
+        expect(@response['Set-Cookie']).to be
+        expect(@response['Set-Cookie']).to include('eeny_meeny_my_page_v1=')
+      end
+    end
+
+    context 'and given a smoke test query parameter' do
+      let(:request) { Rack::MockRequest.new(subject) }
+
+      before(:example) do
+        @response = request.get('/test?smoke_test_id=my_smoke_test', 'CONTENT_TYPE' => 'text/plain')
+      end
+
+      it "sets the 'HTTP_COOKIE' header on the request" do
+        expect(app['HTTP_COOKIE']).to be
+        expect(app['HTTP_COOKIE']).to include('smoke_test_my_smoke_test_v1=')
+      end
+
+      it "sets the 'Set-Cookie' header on the response" do
+        expect(@response['Set-Cookie']).to be
+        expect(@response['Set-Cookie']).to include('smoke_test_my_smoke_test_v1=')
+      end
+    end
   end
 
 end

data/spec/eeny-meeny/models/cookie_spec.rb

@@ -64,7 +64,7 @@ describe EenyMeeny::Cookie do
         instance = described_class.create_for_experiment_variation(experiment, :new)
         expect(instance).to be_a EenyMeeny::Cookie
         expect(instance.name).to eq(described_class.cookie_name(experiment))
-        expect(described_class.read(instance.value)[:variation].id).to eq(:new)
+        expect(described_class.read(instance.value)).to eq('new')
       end
 
       context 'and given cookie options' do
@@ -74,7 +74,7 @@ describe EenyMeeny::Cookie do
           expect(instance).to be_a EenyMeeny::Cookie
           expect(instance.name).to eq(described_class.cookie_name(experiment))
           expect(instance.same_site).to eq(:fun_stuff)
-          expect(described_class.read(instance.value)[:variation].id).to eq(:new)
+          expect(described_class.read(instance.value)).to eq('new')
         end
       end
     end
@@ -108,8 +108,8 @@ describe EenyMeeny::Cookie do
     context 'when EenyMeeny.config.secure = true' do
       context 'and given a valid cookie string' do
         it 'decrypts the string and returns the cookie hash' do
-          valid_cookie_string = 'DhtZMLAtVpWiruuq6BdQ+YEeDTK4G1p0HQLeyKFZd2+fD8YyT004p56S03yXsE/kzCASnD9O1sk1tsIHDZ8W2gq+5zQD3fu2aqqLm461FOfy0En4/LqHCP0J0VYol3Py0BlhepjSGDuJrRU7TdKZWsG2/dCiMVLjMf0Pt00NZWooUvQfRz9SCzaFL0mywoVrY1ErKKQCNEPmLREaxavCng=='
-          expect(described_class.read(valid_cookie_string)).to be_a Hash
+          valid_cookie_string = 'x0bVgNAjEdiNUk9Zfr7IoVN51c8vj8Ah2yMmTbq1ANm8tF8/XpB0kLhViHmocuAgplaIkkTpdii55Gaq0rXgzw=='
+          expect(described_class.read(valid_cookie_string)).to eq('new')
         end
       end
 
@@ -129,7 +129,7 @@ describe EenyMeeny::Cookie do
           end
           experiment = EenyMeeny::Experiment.find_by_id(:my_page)
           valid_cookie_string = described_class.create_for_experiment(experiment).value
-          expect(described_class.read(valid_cookie_string)).to be_a Hash
+          expect(described_class.read(valid_cookie_string)).to match(/old|new/)
         end
       end
     end

data/spec/eeny-meeny/models/experiment_spec.rb

@@ -63,6 +63,22 @@ describe EenyMeeny::Experiment do
         expect(subject.total_weight).to eq(2)
       end
 
+      describe '#find_variation' do
+        context 'given an existing variation id' do
+          it 'returns the given variation' do
+            variation = subject.find_variation(:a)
+            expect(variation).to be_a EenyMeeny::Variation
+            expect(variation.id).to eq(:a)
+          end
+        end
+
+        context 'given a non-existing variation id' do
+          it 'returns nil' do
+            expect(subject.find_variation(:this_does_not_exist)).to be_nil
+          end
+        end
+      end
+
       describe '#pick_variation' do
         it 'picks a variation' do
           expect(subject.pick_variation).to be_a EenyMeeny::Variation

data/spec/mock_rack_app.rb

@@ -16,4 +16,7 @@ class MockRackApp
     @env[key]
   end
 
+  def []=(key,value)
+    @env[key] = value
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eeny-meeny
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Christian Orthmann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-11 00:00:00.000000000 Z
+date: 2016-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -158,6 +158,7 @@ files:
 - lib/eeny-meeny/routing/smoke_test_constraint.rb
 - lib/eeny-meeny/version.rb
 - lib/tasks/cookie.rake
+- spec/eeny-meeny/experiment_helper_spec.rb
 - spec/eeny-meeny/middleware_spec.rb
 - spec/eeny-meeny/models/cookie_spec.rb
 - spec/eeny-meeny/models/experiment_spec.rb