edouard-metric_fu 1.2.0 → 1.2.1

data/HISTORY

@@ -4,6 +4,7 @@
 * Add tooltips to graphs
 * Fix `activesupport` deprecation
 * Vendor Saikuro as a gem dependency
+* Merge back Rails Best Practice Results from Richard Huang
 
 === MetricFu 1.2.0 / 2010-01-09
 

data/README

@@ -1 +1 @@
-See http://metric-fu.rubyforge.org/ for documentation, or the HISTORY file for a change log.
+See http://metric-fu.rubyforge.org/ for documentation, or the HISTORY file for a change log.

data/Rakefile

@@ -2,7 +2,9 @@ require 'rake'
 require 'rake/rdoctask'
 require 'spec/rake/spectask'
 require 'lib/metric_fu'
-
+require 'mg'
+MG.new("metric_fu.gemspec")
+ 
 desc "Run all specs in spec directory"
 Spec::Rake::SpecTask.new(:spec) do |t|
   t.spec_files = FileList['spec/**/*_spec.rb']
@@ -10,9 +12,9 @@ Spec::Rake::SpecTask.new(:spec) do |t|
    t.rcov_opts = ['--exclude', 'spec,config,Library,usr/lib/ruby']
    t.rcov_dir = File.join(File.dirname(__FILE__), "tmp")
 end
-
+ 
 MetricFu::Configuration.run do |config|
   config.template_class = AwesomeTemplate
 end
-
+ 
 task :default => [:"metrics:all"]

data/lib/base/configuration.rb

@@ -8,7 +8,7 @@ module MetricFu
   AVAILABLE_METRICS = [:churn, :flog, :flay, :reek, 
                        :roodi, :saikuro, :rcov]
 
-  AVAILABLE_GRAPHS = [:flog, :flay, :reek, :roodi, :rcov]
+  AVAILABLE_GRAPHS = [:flog, :flay, :reek, :roodi, :rcov, :rails_best_practices]
   AVAILABLE_GRAPH_ENGINES = [:gchart, :bluff]
 
   # The @@configuration class variable holds a global type configuration
@@ -109,7 +109,8 @@ module MetricFu
       set_metrics
       set_graphs
       set_code_dirs
-      @flay     = { :dirs_to_flay => @code_dirs  } 
+      @flay     = { :dirs_to_flay => @code_dirs,
+                    :minimum_score => 100 } 
       @flog     = { :dirs_to_flog => @code_dirs  }
       @reek     = { :dirs_to_reek => @code_dirs  }
       @roodi    = { :dirs_to_roodi => @code_dirs }
@@ -122,7 +123,8 @@ module MetricFu
                     :formater => "text"}
       @churn    = {}
       @stats    = {}
-      @rcov     = { :test_files => ['test/**/*_test.rb', 
+      @rcov     = { :environment => 'test',
+                    :test_files => ['test/**/*_test.rb', 
                                     'spec/**/*_spec.rb'],
                     :rcov_opts => ["--sort coverage", 
                                    "--no-html", 
@@ -131,6 +133,7 @@ module MetricFu
                                    "--profile",
                                    "--rails",
                                    "--exclude /gems/,/Library/,/usr/,spec"]}
+      @rails_best_practices = {}
 
       @file_globs_to_ignore = []
                                    
@@ -149,7 +152,7 @@ module MetricFu
     # running within rails.
     def set_metrics
       if rails?
-        @metrics = MetricFu::AVAILABLE_METRICS + [:stats]
+        @metrics = MetricFu::AVAILABLE_METRICS + [:stats, :rails_best_practices]
       else
         @metrics = MetricFu::AVAILABLE_METRICS
       end 

data/lib/base/graph.rb

@@ -13,7 +13,7 @@ module MetricFu
     end
     
     def add(graph_type, graph_engine)
-      grapher_name = graph_type.to_s.capitalize + graph_engine.to_s.capitalize + "Grapher"
+      grapher_name = graph_type.to_s.gsub(/\/(.?)/) { "::#{$1.upcase}" }.gsub(/(?:^|_)(.)/) { $1.upcase } + graph_engine.to_s.capitalize + "Grapher"
       self.clazz.push MetricFu.const_get(grapher_name).new
     end
     

data/lib/base/report.rb

@@ -50,7 +50,7 @@ module MetricFu
     # @param report_type Hash
     #   The hash to add to the aggregate report_hash
     def add(report_type)
-      clazz = MetricFu.const_get(report_type.to_s.capitalize)
+      clazz = MetricFu.const_get(report_type.to_s.gsub(/\/(.?)/) { "::#{$1.upcase}" }.gsub(/(?:^|_)(.)/) { $1.upcase })
       report_hash.merge!(clazz.generate_report)
     end
 

data/lib/generators/churn.rb

@@ -1,90 +1,34 @@
-require 'chronic'
 module MetricFu
-  
+
   class Churn < Generator
 
-    
     def initialize(options={})
       super
-      if self.class.git?
-        @source_control = Git.new(MetricFu.churn[:start_date])
-      elsif File.exist?(".svn")
-        @source_control = Svn.new(MetricFu.churn[:start_date])
-      else
-        raise "Churning requires a subversion or git repo"
-      end
-      @minimum_churn_count = MetricFu.churn[:minimum_churn_count] || 5
     end
 
-    def self.git?
-      system("git branch")
+    def self.verify_dependencies!
+      result = `churn --help`
+      raise 'sudo gem install churn # if you want the churn tasks' unless result.match(/churn/)
     end
+
     
     def emit
-      @changes = parse_log_for_changes.reject {|file, change_count| change_count < @minimum_churn_count}
+      @output = `churn --yaml`
+      yaml_start = @output.index("---")
+      @output = @output[yaml_start...@output.length] if yaml_start
     end
 
     def analyze
-      @changes = @changes.to_a.sort {|x,y| y[1] <=> x[1]}
-      @changes = @changes.map {|change| {:file_path => change[0], :times_changed => change[1] }}
-    end
-
-    def to_h
-      {:churn => {:changes => @changes}}
-    end
-
-    private
-
-    def parse_log_for_changes
-      changes = {}
-
-      logs = @source_control.get_logs
-      logs.each do |line|
-        changes[line] ? changes[line] += 1 : changes[line] = 1
-      end
-      changes
-    end
-
-
-    class SourceControl
-      def initialize(start_date=nil)
-        @start_date = start_date
-      end
-    end
-
-    class Git < SourceControl
-      def get_logs
-        `git log #{date_range} --name-only --pretty=format:`.split(/\n/).reject{|line| line == ""}
-      end
-
-      private
-      def date_range
-        if @start_date
-          date = Chronic.parse(@start_date)
-          "--after=#{date.strftime('%Y-%m-%d')}"
-        end
+      if @output.match(/fatal: Not a git repository/)
+        @churn = [:churn => {}]
+      else
+        @churn = YAML::load(@output)
       end
-
     end
 
-    class Svn < SourceControl
-      def get_logs
-        `svn log #{date_range} --verbose`.split(/\n/).map { |line| clean_up_svn_line(line) }.compact
-      end
-
-      private
-      def date_range
-        if @start_date
-          date = Chronic.parse(@start_date)
-          "--revision {#{date.strftime('%Y-%m-%d')}}:{#{Time.now.strftime('%Y-%m-%d')}}"
-        end
-      end
-
-      def clean_up_svn_line(line)
-        m = line.match(/\W*[A,M]\W+(\/.*)\b/)
-        m ? m[1] : nil
-      end
+    def to_h
+      {:churn => @churn[:churn]}
     end
-
   end
+
 end

data/lib/generators/flay.rb

@@ -10,7 +10,8 @@ module MetricFu
     def emit
       files_to_flay = MetricFu.flay[:dirs_to_flay].map{|dir| Dir[File.join(dir, "**/*.rb")] }
       files = remove_excluded_files(files_to_flay.flatten)
-      @output = `flay #{files.join(" ")}`
+      mimimum_score_parameter = MetricFu.flay[:minimum_score] ? "--mass #{MetricFu.flay[:minimum_score]} " : ""
+      @output = `flay #{mimimum_score_parameter}#{files.join(" ")}`
     end
 
     def analyze

data/lib/generators/rails_best_practices.rb

@@ -0,0 +1,31 @@
+module MetricFu
+  class RailsBestPractices < Generator
+
+    def self.verify_dependencies!
+      `rails_best_practices --help`
+      raise 'sudo gem install rails_best_practices # if you want the rails_best_practices tasks' unless $?.success?
+    end
+
+    
+    def emit
+      @output = `rails_best_practices .`
+    end
+
+    def analyze
+      @matches = @output.chomp.split("\n").map{|m| m.split(" - ") }
+      total = @matches.pop
+      2.times { @matches.pop } # ignore wiki link
+      @matches.reject! {|array| array.empty? }
+      @matches.map! do |match|
+        file, line = match[0].split(':')
+        problem = match[1]
+        {:file => file, :line => line, :problem => problem}
+      end
+      @rails_best_practices_results = {:total => total, :problems => @matches}
+    end
+
+    def to_h
+      {:rails_best_practices => @rails_best_practices_results}
+    end
+  end
+end

data/lib/generators/rcov.rb

@@ -36,6 +36,8 @@ module MetricFu
         test_files = FileList[*MetricFu.rcov[:test_files]].join(' ')
         rcov_opts = MetricFu.rcov[:rcov_opts].join(' ')
         output = ">> #{MetricFu::Rcov.metric_directory}/rcov.txt"
+        puts "** Running the specs/tests in the [#{MetricFu.rcov[:environment]}] environment"
+        puts "RAILS_ENV=#{MetricFu.rcov[:environment]} rcov #{test_files} #{rcov_opts} #{output}"
         `rcov #{test_files} #{rcov_opts} #{output}`
       rescue LoadError
         if RUBY_PLATFORM =~ /java/

data/lib/graphs/engines/bluff.rb

@@ -83,4 +83,17 @@ module MetricFu
       File.open(File.join(MetricFu.output_directory, 'roodi.js'), 'w') {|f| f << content }
     end
   end
+
+  class RailsBestPracticesBluffGrapher < RailsBestPracticesGrapher
+    def graph!
+      content = <<-EOS
+        #{BLUFF_DEFAULT_OPTIONS}
+        g.title = 'Rails Best Practices: design problems';
+        g.data('rails_best_practices', [#{@rails_best_practices_count.join(',')}]);
+        g.labels = #{@labels.to_json};
+        g.draw();
+      EOS
+      File.open(File.join(MetricFu.output_directory, 'rails_best_practices.js'), 'w') {|f| f << content }
+    end
+  end
 end

data/lib/graphs/rails_best_practices_grapher.rb

@@ -0,0 +1,22 @@
+module MetricFu
+  
+  class RailsBestPracticesGrapher < Grapher
+    
+    attr_accessor :rails_best_practices_count, :labels
+    
+    def initialize
+      super
+      @rails_best_practices_count = []
+      @labels = {}
+    end
+    
+    def get_metrics(metrics, date)
+      if metrics[:rails_best_practices]
+        @rails_best_practices_count.push(metrics[:rails_best_practices][:problems].size)
+        @labels.update( { @labels.size => date })
+      end
+    end
+    
+  end
+  
+end

data/lib/templates/awesome/churn.html.erb

@@ -16,4 +16,43 @@
     <% count += 1 %>
   <% end %>
 </table>
+
+<% if @churn[:class_churn] %>
+<p>Classes that change a lot in your project may be bad a sign.</p>
+<table>
+  <tr>
+    <th>File Path</th>
+    <th>Times Changed</th>
+  </tr>
+  <% count = 0 %>
+  <% @churn[:class_churn].each do |change| %>
+    <tr>
+      <td><%= link_to_filename(change['klass']['file']) %> <%= change['klass']['klass'] %></td>
+      <td><%= change['times_changed'] %></td>
+    </tr>
+    <% count += 1 %>
+  <% end %>
+</table>
+<% end %>
+
+<% if @churn[:method_churn] %>
+<p>Methods that change a lot in your project may be bad a sign.</p>
+<table>
+  <tr>
+    <th>File Path</th>
+    <th>Times Changed</th>
+  </tr>
+  <% count = 0 %>
+  <% @churn[:method_churn].each do |change| %>
+    <tr>
+      <td><%= link_to_filename(change['method']['file']) %> <%= change['method']['method'] %></td>
+      <td><%= change['times_changed'] %></td>
+    </tr>
+    <% count += 1 %>
+  <% end %>
+</table>
+<% end %>
+
+
+
 <p>Generated on <%= Time.now.localtime %></p>	

data/lib/templates/awesome/flay.html.erb

@@ -11,6 +11,7 @@
 <% end %>
 
 <h4>Total Score (lower is better): <%= @flay[:total_score] %></h4>
+<h5>Scores less than <%= MetricFu.flay[:minimum_score] %> are not shown or part of the total</h5>
 
 <table>
   <tr>

data/lib/templates/awesome/index.html.erb

@@ -23,6 +23,9 @@
 <% end %>
 <% if @stats %>
   <li class='even failure'><a href="stats.html">Stats</a></li>
+<% end %>  
+<% if @rails_best_practices %>
+  <li class='even failure'><a href="rails_best_practices.html">Rails Best Practices</a></li>
 <% end %>
 </ul>
 <p>Generated on <%= Time.now.localtime %></p>	

data/lib/templates/awesome/rails_best_practices.html.erb

@@ -0,0 +1,27 @@
+<h3>Rails Best Practices Results</h3>
+
+<p><a href="http://github.com/flyerhzm/rails_best_practices">rails_best_practices</a> checks quality of rails app files according to ihower’s presentation from Kungfu RailsConf in Shanghai China.</p>
+
+<% graph_name = 'rails_best_practices' %>
+<% if MetricFu.configuration.graph_engine == :gchart %>
+<img src="<%= graph_name %>.png?<%= Time.now.to_i %>" />
+<% else %>
+<canvas id="graph"></canvas>
+<script language="javascript" src="<%= graph_name %>.js?<%= Time.now.to_i %>" type="text/javascript"></script>
+<% end %>
+
+<table>
+  <tr>
+    <th>File Path</th>
+    <th>Warning</th>
+  </tr>
+  <% count = 0 %>
+  <% @rails_best_practices[:problems].each do |problem| %>
+    <tr class='<%= cycle("light", "dark", count) %>'>
+      <td><%= link_to_filename(problem[:file], problem[:line]) %></td>
+      <td><%= problem[:problem] %></td>
+    </tr>
+    <% count += 1 %>
+  <% end %>
+</table>
+<p>Generated on <%= Time.now.localtime %></p>	

data/lib/templates/standard/index.html.erb

@@ -32,6 +32,9 @@
   <% if @stats %>
     <p><a href="stats.html">Stats report</a></p>
   <% end %>
+  <% if @rails_best_practices %>
+    <p><a href="rails_best_practices.html">Rails Best Practices report</a></p>
+  <% end %>
   <p>Generated on <%= Time.now.localtime %></p>	
 </body>
 </html>

data/lib/templates/standard/rails_best_practices.html.erb

@@ -0,0 +1,29 @@
+<html>
+<head>
+	<title>Rails Best Practices Results</title>
+	<style>
+	<%= inline_css("default.css") %>	
+	</style>
+</head>
+
+<body>
+	<h1>Rails Best Practices Results</h1>
+  <a href="index.html">back to menu</a>
+  <p><a href="http://github.com/flyerhzm/rails_best_practices">rails_best_practices</a> checks quality of rails app files according to ihower’s presentation from Kungfu RailsConf in Shanghai China.</p>
+	<table>
+		<tr>
+		  <th>File Path</th>
+		  <th>Warning</th>
+    </tr>
+    <% count = 0 %>
+    <% @rails_best_practices[:problems].each do |problem| %>
+      <tr class='<%= cycle("light", "dark", count) %>'>
+        <td><%= problem[:file] %>:<%= problem[:line] %></td>
+        <td><%= problem[:problem] %></td>
+      </tr>
+      <% count += 1 %>
+  	<% end %>
+	</table>
+	<p>Generated on <%= Time.now.localtime %></p>	
+</body>
+</html>

data/spec/base/configuration_spec.rb

@@ -87,7 +87,7 @@ describe MetricFu::Configuration do
 
     it 'should set @flay to {:dirs_to_flay => @code_dirs}' do
       @config.instance_variable_get(:@flay).
-              should == {:dirs_to_flay => ['lib']}
+              should == {:dirs_to_flay => ['lib'], :minimum_score => 100}
     end
     
     it 'should set @flog to {:dirs_to_flog => @code_dirs}' do
@@ -125,7 +125,8 @@ describe MetricFu::Configuration do
                                               "--rails",           
                                               "--exclude /gems/,/Library/,/usr/,spec"]}' do
       @config.instance_variable_get(:@rcov).
-              should ==  { :test_files => ['test/**/*_test.rb', 
+              should ==  { :environment => 'test',
+                           :test_files => ['test/**/*_test.rb', 
                                            'spec/**/*_spec.rb'],
                            :rcov_opts => ["--sort coverage", 
                                          "--no-html", 

data/spec/base/generator_spec.rb

@@ -1,6 +1,9 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe MetricFu::Generator do
+
+  include Construct::Helpers
+
   MetricFu::Configuration.run do |config|
   end
 

data/spec/generators/churn_spec.rb

@@ -1,151 +1,42 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe Churn do
-  describe "initialize" do
-    before :each do
-      MetricFu::Configuration.run {}
-      File.stub!(:directory?).and_return(true)
-    end
-    
-    it "should setup git if .git exits" do
-      MetricFu::Churn.should_receive(:system).and_return(true)
-      Churn::Git.should_receive(:new)
-      MetricFu::Churn.new
-    end
-    
-    it "should setup git if .svn exits" do
-      MetricFu::Churn.should_receive(:system).and_return(false)
-      File.should_receive(:exist?).with(".svn").and_return(true)
-      Churn::Svn.should_receive(:new)
-      MetricFu::Churn.new()
-    end
-    
-    it "should raise an error if not .svn or .git" do
-      MetricFu::Churn.should_receive(:system).and_return(false)
-      lambda{MetricFu::Churn.new()}.should raise_error(Exception)
-    end
-  end
-  
-  describe "emit method with git" do
-    before :each do
-      MetricFu::Configuration.run {|config| config.churn = {:minimum_churn_count => 2} }
-      File.stub!(:directory?).and_return(true)
-      MetricFu::Churn.should_receive(:system).and_return(true)
-      @git = Churn::Git.new
-      Churn::Git.should_receive(:new).and_return(@git)
-      @lines = <<-HERE.gsub(/^\s*/, "")
-      
-      lib/generators/flog.rb
-      spec/generators/flog_spec.rb
-
-
-      lib/generators/flog.rb
-      spec/generators/flay_spec.rb
-
-
-      lib/metric_fu.rb
-
-
-      lib/generators/saikuro.rb
-      lib/metric_fu.rb
-      tasks/metric_fu.rake
-
-
-      spec/churn_spec.rb
-      spec/config_spec.rb
-      spec/flay_spec.rb
-      spec/flog_spec.rb
-      lib/metric_fu.rb
-      spec/reek_spec.rb
-      HERE
-    end
-    
-    it "should read the logs" do
-      churn = MetricFu::Churn.new
-      @git.should_receive(:`).with("git log  --name-only --pretty=format:").and_return(@lines)
-      changes = churn.emit
-      changes["lib/generators/flog.rb"].should == 2
-      changes["lib/metric_fu.rb"].should == 3
-    end
-  end
-  
-  describe "emit method with svn" do
-    before :each do
-      MetricFu::Configuration.run{|config| config.churn = {:minimum_churn_count => 2} }
-      File.stub!(:directory?).and_return(true)
-      MetricFu::Churn.should_receive(:system).and_return(false)
-      File.should_receive(:exist?).with(".svn").and_return(true)
-      @svn = Churn::Svn.new
-      Churn::Svn.should_receive(:new).and_return(@svn)
-      @lines = <<-HERE.gsub(/^\s*/, "")
-      ------------------------------------------------------------------------
-      r3183 | dave | 2009-04-28 07:23:37 -0500 (Tue, 28 Apr 2009) | 1 line
-      Changed paths:
-         M /trunk/app/views/promotions/index.erb
-         M /trunk/app/models/email_personalizer.rb
-
-      making custom macros case-insensitive
-      ------------------------------------------------------------------------
-      r3182 | marc | 2009-04-28 03:59:32 -0500 (Tue, 28 Apr 2009) | 1 line
-      Changed paths:
-         M /trunk/app/models/file_extraction.rb
-         M /trunk/app/views/promotions/index.erb
-         M /trunk/config/environment.rb
-
-      Demo of the drop out effect for uploading promotions.
-      ------------------------------------------------------------------------
-      r3181 | dave | 2009-04-27 21:40:04 -0500 (Mon, 27 Apr 2009) | 1 line
-      Changed paths:
-         M /trunk/app/views/promotions/index.erb
-         A /trunk/app/models/file_extraction.rb
-         A /trunk/app/models/url_file_extraction.rb
-         M /trunk/app/models/zip_file_extraction.rb
-         M /trunk/test/data/zip_test.zip
-         M /trunk/test/unit/zip_file_extraction_test.rb
-
-      URL imports
-      HERE
-    end
-    
-    it "should read the logs" do
-      churn = MetricFu::Churn.new
-      @svn.should_receive(:`).with("svn log  --verbose").and_return(@lines)
-      changes = churn.emit
-      changes["/trunk/app/views/promotions/index.erb"].should == 3
-      changes["/trunk/app/models/file_extraction.rb"].should == 2
-    end
-  end
   
   describe "analyze method" do
     before :each do
       MetricFu::Configuration.run {}
       File.stub!(:directory?).and_return(true)
-      MetricFu::Churn.should_receive(:system).and_return(true)
+      MetricFu::Churn.should_receive(:verify_dependencies!).and_return(true)
       @changes = {"lib/generators/flog.rb"=>2, "lib/metric_fu.rb"=>3}
     end
     
-    it "should organize and format" do
+    it "should be empty on error" do
       churn = MetricFu::Churn.new
-      churn.instance_variable_set(:@changes, @changes)
-      changes = churn.analyze
-      changes.first[:file_path].should == "lib/metric_fu.rb"
-      changes.first[:times_changed].should == 3
-      changes[1][:file_path].should == "lib/generators/flog.rb"
-      changes[1][:times_changed].should == 2
+      churn.instance_variable_set(:@output, "fatal: Not a git repository")
+      result = churn.analyze
+      result.should == [:churn => {}]
     end
+
+    it "should return yaml results" do
+      churn = MetricFu::Churn.new
+      churn.instance_variable_set(:@output, "--- \n:churn: \n  :changed_files: \n  - spec/graphs/flog_grapher_spec.rb\n  - spec/base/graph_spec.rb\n  - lib/templates/awesome/layout.html.erb\n  - lib/graphs/rcov_grapher.rb\n  - lib/base/base_template.rb\n  - spec/graphs/grapher_spec.rb\n  - lib/templates/awesome/flog.html.erb\n  - lib/templates/awesome/flay.html.erb\n  - lib/graphs/roodi_grapher.rb\n  - lib/graphs/reek_grapher.rb\n  - HISTORY\n  - spec/graphs/roodi_grapher_spec.rb\n  - lib/generators/rcov.rb\n  - spec/graphs/engines/gchart_spec.rb\n  - spec/graphs/rcov_grapher_spec.rb\n  - lib/templates/javascripts/excanvas.js\n  - lib/templates/javascripts/bluff-min.js\n  - spec/graphs/reek_grapher_spec.rb\n")
+      result = churn.analyze
+      result.should == {:churn=>{:changed_files=>["spec/graphs/flog_grapher_spec.rb", "spec/base/graph_spec.rb", "lib/templates/awesome/layout.html.erb", "lib/graphs/rcov_grapher.rb", "lib/base/base_template.rb", "spec/graphs/grapher_spec.rb", "lib/templates/awesome/flog.html.erb", "lib/templates/awesome/flay.html.erb", "lib/graphs/roodi_grapher.rb", "lib/graphs/reek_grapher.rb", "HISTORY", "spec/graphs/roodi_grapher_spec.rb", "lib/generators/rcov.rb", "spec/graphs/engines/gchart_spec.rb", "spec/graphs/rcov_grapher_spec.rb", "lib/templates/javascripts/excanvas.js", "lib/templates/javascripts/bluff-min.js", "spec/graphs/reek_grapher_spec.rb"]}}
+    end
+
   end
   
   describe "to_h method" do
     before :each do
       MetricFu::Configuration.run {}
       File.stub!(:directory?).and_return(true)
-      MetricFu::Churn.should_receive(:system).and_return(true)
+      MetricFu::Churn.should_receive(:verify_dependencies!).and_return(true)
     end
     
     it "should put the changes into a hash" do
       churn = MetricFu::Churn.new
-      churn.instance_variable_set(:@changes, "churn_info")
-      churn.to_h[:churn][:changes].should == "churn_info"
+      churn.instance_variable_set(:@churn, {:churn => 'results'})
+      churn.to_h[:churn].should == "results"
     end
   end
 end

data/spec/generators/flay_spec.rb

@@ -5,19 +5,25 @@ describe Flay do
     MetricFu::Flay.stub!(:verify_dependencies!).and_return(true)
   end
   describe "emit method" do
-    before :each do
+    it "should look at the dirs" do
       MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => ['app', 'lib']  } }
       File.stub!(:directory?).and_return(true)
-      @flay = MetricFu::Flay.new('base_dir')
-      
-    end
+      @flay = MetricFu::Flay.new('base_dir')    
     
-    it "should look at the dirs" do
       Dir.should_receive(:[]).with(File.join("app", "**/*.rb")).and_return("path/to/app")
       Dir.should_receive(:[]).with(File.join("lib", "**/*.rb")).and_return("path/to/lib")
       @flay.should_receive(:`).with("flay path/to/app path/to/lib")
       output = @flay.emit
     end
+    
+    it "should limit flay scores by the minimum_score" do
+      MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => [], :minimum_score => 99 } }
+      File.stub!(:directory?).and_return(true)
+      @flay = MetricFu::Flay.new('base_dir')
+
+      @flay.should_receive(:`).with("flay --mass 99 ")
+      output = @flay.emit
+    end
   end
   
   describe "analyze method" do

data/spec/graphs/engines/gchart_spec.rb

@@ -4,7 +4,6 @@ describe "Gchart graphers responding to #graph!" do
   MetricFu::AVAILABLE_GRAPHS.each do |metric|
     it "should write chart file for #{metric}" do
       MetricFu.configuration
-      puts "#{metric.to_s.capitalize}GchartGrapher"
       grapher = MetricFu.const_get("#{metric.to_s.capitalize}GchartGrapher").new
       grapher.flog_average, grapher.top_five_percent_average = [7.0],[20.0] if metric == :flog #googlecharts gem has problems with [[],[]] as data
       grapher.graph!

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 require 'rubygems'
 require 'spec/autorun'
 require 'date'
+require 'construct'
 
 require File.join(File.dirname(__FILE__), '/../lib/metric_fu.rb')
 include MetricFu

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: edouard-metric_fu
 version: !ruby/object:Gem::Version 
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors: 
 - Jake Scruggs
@@ -12,11 +12,12 @@ authors:
 - Nick Quaranto
 - "\xC3\x89douard Bri\xC3\xA8re"
 - Carl Youngblood
+- Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2010-01-15 00:00:00 +01:00
+date: 2010-01-22 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -49,6 +50,36 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: 0.9.7.1
     version: 
+- !ruby/object:Gem::Dependency 
+  name: reek
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.2.6
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: roodi
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 2.1.0
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: rails_best_practices
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 0.3.16
+    version: 
 - !ruby/object:Gem::Dependency 
   name: chronic
   type: :runtime
@@ -59,6 +90,16 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: 0.2.3
     version: 
+- !ruby/object:Gem::Dependency 
+  name: churn
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 0.0.10
+    version: 
 - !ruby/object:Gem::Dependency 
   name: Saikuro
   type: :runtime
@@ -69,7 +110,47 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: 1.1.0
     version: 
-description: Code metrics from Flog, Flay, RCov, Saikuro, Churn, Reek, Roodi and Rails' stats task
+- !ruby/object:Gem::Dependency 
+  name: activesupport
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 2.2.3
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: rspec
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.2.0
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: devver-construct
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.1.0
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: mg
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 0.0.6
+    version: 
+description: Code metrics from Flog, Flay, RCov, Saikuro, Churn, Reek, Roodi and Rails' stats task and Rails Best Practices
 email: jake.scruggs@gmail.com
 executables: []
 
@@ -99,6 +180,7 @@ files:
 - lib/generators/roodi.rb
 - lib/generators/saikuro.rb
 - lib/generators/stats.rb
+- lib/generators/rails_best_practices.rb
 - lib/graphs/engines/bluff.rb
 - lib/graphs/engines/gchart.rb
 - lib/graphs/flay_grapher.rb
@@ -107,6 +189,7 @@ files:
 - lib/graphs/rcov_grapher.rb
 - lib/graphs/reek_grapher.rb
 - lib/graphs/roodi_grapher.rb
+- lib/graphs/rails_best_practices_grapher.rb
 - lib/metric_fu.rb
 - lib/templates/awesome/awesome_template.rb
 - lib/templates/awesome/churn.html.erb
@@ -123,6 +206,7 @@ files:
 - lib/templates/awesome/roodi.html.erb
 - lib/templates/awesome/saikuro.html.erb
 - lib/templates/awesome/stats.html.erb
+- lib/templates/awesome/rails_best_practices.html.erb
 - lib/templates/javascripts/bluff-min.js
 - lib/templates/javascripts/excanvas.js
 - lib/templates/javascripts/js-class.js
@@ -137,6 +221,7 @@ files:
 - lib/templates/standard/saikuro.html.erb
 - lib/templates/standard/standard_template.rb
 - lib/templates/standard/stats.html.erb
+- lib/templates/standard/rails_best_practices.html.erb
 - tasks/metric_fu.rake
 - Manifest.txt
 has_rdoc: true
@@ -146,7 +231,7 @@ licenses: []
 post_install_message: 
 rdoc_options: 
 - --main
-- README
+- README.textile
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement