editmode 1.2.7 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aac6adb5e24a89664dc5939ddb97606ac0003f33fb329b7d00b507c98a8ebc98
-  data.tar.gz: ae22fe6ff1b9cf07ea3a1d7761c298f856482b051a080111fa9e29a7965633ee
+  metadata.gz: fe9965c96f8c7fb66afae65725f82fbb536fae3981924b090643e9899735627c
+  data.tar.gz: 75bc30d9f5bb9575780e43a3f2f8776fc35ad55f328c7fd5c7134c9685487727
 SHA512:
-  metadata.gz: 1264161505c4cb1ded693b68231825962f686420817244d427510e76ac71950b78ba5a4da5ab85bb02c8a163f724e012f4232b397bdaa7fcef74bedea9ea8e03
-  data.tar.gz: 3a5afb3beac64da0120e296b3bd41747031b6a1d662aa24df1b56f82eb3e29e1f44665df76ce29a6cd87848a4ebd3e9b61df79ad6112feb7747a30bca3816b84
+  metadata.gz: 8ffb62bd7347c80679acdcc57fa50d3ce1c266557f3f88f27d08d0cc646b5297e8a4dceb36f6f36cb229a58888230cc9be8220f80832346607c49dfda5475c39
+  data.tar.gz: 0375dc9c6098596aead8445fc4d57b8f53ee57d820ccd1db2c61cf3c214171472cbee29e2f7b39b019e212c0968077702b50d99e261ef82e4722080f46d0d82b

data/Gemfile

@@ -1,4 +1,6 @@
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in chunks.gemspec
+  gem 'pry-rails'
+  gem 'rails', '~> 5.2.0'
 gemspec

data/Rakefile

@@ -1,2 +1,10 @@
-require "bundler/gem_tasks"
+require 'bundler'
+Bundler::GemHelper.install_tasks
 
+task :test do
+  Dir['test/*_test.rb'].each do |testfile|
+    load testfile
+  end
+end
+
+task :default => :test

data/lib/editmode/action_view_extensions/editmode_helper.rb

@@ -1,15 +1,25 @@
 require 'editmode/helper'
+require 'action_view'
+require 'httparty'
 
 module Editmode
   module ActionViewExtensions
     module EditmodeHelper
-      require 'httparty'
+      include ::ActionView::Helpers::TagHelper
+      include ::ActionView::Helpers::TextHelper
+      include ::ActionView::Helpers::AssetTagHelper
+      include ::ActionView::Context
       include Editmode::Helper
 
+
       def api_version
         # Todo Add Header Version
       end
 
+      def allowed_tag_attributes
+        [:style, :href, :title, :src, :alt, :width, :height]
+      end
+
       def api_root_url
         ENV["EDITMODE_OVERRIDE_API_URL"] || "https://api.editmode.com"
       end
@@ -104,7 +114,7 @@ module Editmode
         end
       end
 
-      def render_chunk_content(chunk_identifier, chunk_content, chunk_type,options = {})
+      def render_chunk_content(chunk_identifier, chunk_content, chunk_type, options = {})
         begin 
           css_class = options[:class]
           cache_id = options[:cache_identifier]
@@ -126,17 +136,17 @@ module Editmode
           case display_type
           when "span"
             if chunk_type == "rich_text"
-              content = content_tag("em-span", :class => "editmode-richtext-editor #{css_class}", :data => chunk_data.merge!({:chunk_editable => true}) ) do
+              content = content_tag("em-span", :class => "editmode-richtext-editor #{css_class}", :data => chunk_data.merge!({:chunk_editable => true}), **options.slice(*allowed_tag_attributes) ) do
                 chunk_content.html_safe
               end
             else
-              content_tag("em-span", :class => css_class, :data => chunk_data.merge!({:chunk_editable => true}) ) do
+              content_tag("em-span", :class => css_class, :data => chunk_data.merge!({:chunk_editable => true}), **options.slice(*allowed_tag_attributes) ) do
                 chunk_content.html_safe
               end
             end
           when "image"
             chunk_content = chunk_content.blank? || chunk_content == "/images/original/missing.png" ? 'https://www.editmode.com/upload.png' : chunk_content
-            image_tag(chunk_content, :data => chunk_data, :class => css_class) 
+            image_tag(chunk_content, :data => chunk_data, :class => css_class, **options.slice(*allowed_tag_attributes)) 
           end
         rescue => errors
           puts errors
@@ -153,7 +163,7 @@ module Editmode
         # prevent the page from loading.
         begin
           field = options[:field].presence || ""          
-
+          options[:referrer] = request.url
           chunk_value = Editmode::ChunkValue.new(identifier, options)
           
           if field.present? && chunk_value.chunk_type == 'collection_item'

data/lib/editmode/chunk_value.rb

@@ -1,3 +1,6 @@
+require 'action_view'
+require 'active_support'
+
 module Editmode
   class ChunkValue
     include ActionView::Helpers::TagHelper
@@ -14,6 +17,7 @@ module Editmode
       @identifier = identifier
       @branch_id = options[:branch_id].presence
       @project_id = project_id
+      @referrer = options[:referrer].presence || ""
       @variable_values = options[:variables].presence || {}
       @raw = options[:raw].present?
       @skip_sanitize = options[:dangerously_skip_sanitization]
@@ -63,7 +67,15 @@ module Editmode
       result.try(:html_safe)
     end
 
+    def cached?
+      return false if @skip_cache
+      Rails.cache.exist?(cache_identifier)
+    end
+
     private
+    def allowed_tag_attributes
+      %w(style href title src alt width height class target)
+    end
 
     # Todo: Transfer to helper utils
     def api_root_url
@@ -99,15 +111,10 @@ module Editmode
         end
       end
 
-      content = ActionController::Base.helpers.sanitize(content) unless skip_sanitize
+      content = ActionController::Base.helpers.sanitize(content, attributes: allowed_tag_attributes) unless skip_sanitize
       return content
     end
 
-    def cached?
-      return false if @skip_cache
-      Rails.cache.exist?(cache_identifier)
-    end
-
     def query_params
       the_params = { 'project_id' => project_id }
       the_params['branch_id'] = branch_id if branch_id.present?
@@ -116,14 +123,15 @@ module Editmode
     end
 
     def get_content
-
       if !cached?
-        http_response = HTTParty.get(url, query: query_params)
+        http_response = HTTParty.get(url, query: query_params, headers: {referrer: @referrer})
         response_received = true if http_response.code == 200
       end
 
       if !cached? && !response_received
-        raise no_response_received(identifier)
+        message = http_response.try(:[], 'message') || no_response_received(identifier)
+
+        raise message
       else
         Rails.cache.write(cache_identifier, http_response.to_json) if http_response.present?
         cached_response = Rails.cache.fetch(cache_identifier)
@@ -141,5 +149,8 @@ module Editmode
       @branch_id = response['branch_id']
     end
 
+    def no_response_received(id = "")
+      "Sorry, we can't find a chunk using this identifier: \"#{id}\". This can happen if you've deleted a chunk on editmode.com or if your local cache is out of date. If it persists, try running Rails.cache clear."
+    end
   end
 end

data/lib/editmode/engine.rb

@@ -1,4 +1,5 @@
-require 'editmode/chunk_value'
+require 'rails/engine'
+require 'action_controller'
 require 'editmode/helper'
 
 module Editmode

data/lib/editmode/helper.rb

@@ -5,34 +5,17 @@ module Editmode
       field, options = parse_arguments(args)
       begin
         chunk = Editmode::ChunkValue.new(identifier, options.merge({raw: true}))
-        render_noneditable_chunk(chunk, field, options)
+
+        if chunk.chunk_type == 'collection_item'
+          chunk.field(field)
+        else
+          chunk.content
+        end 
       rescue => er
-        puts er
+        Rails.logger.info "#{er}: We can't render content for #{identifier}"
       end
     end
 
-    def render_noneditable_chunk(chunk, field=nil, options=nil)
-      return render_collection_item(chunk, field, options) if chunk.chunk_type == 'collection_item'
-
-      render_content(chunk, options)
-    end
-
-    def render_collection_item(chunk, field=nil, options=nil)
-      return render_image(chunk.field(field), options[:class]) if chunk.field_chunk(field)['chunk_type'] == 'image'
-
-      chunk.field(field)
-    end
-
-    def render_content(chunk, options=nil)
-      return render_image(chunk.content, options[:class]) if chunk.chunk_type == 'image'
-
-      chunk.content
-    end
-
-    def render_image(content, css_class=nil)
-      image_tag(content, class: css_class)
-    end
-
     def render_custom_field_raw(label, options={})
       e(@custom_field_chunk["identifier"], label, options.merge({response: @custom_field_chunk}))
     end
@@ -50,4 +33,4 @@ module Editmode
       return field, options
     end
   end
-end
+end

data/lib/editmode/railtie.rb

@@ -1,3 +1,4 @@
+require 'rails/railtie'
 module Editmode
   class Railtie < Rails::Railtie
     initializer "editmode" do |app|

data/lib/editmode/version.rb

@@ -1,3 +1,3 @@
 module Editmode
-  VERSION = "1.2.7"
+  VERSION = "1.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: editmode
 version: !ruby/object:Gem::Version
-  version: 1.2.7
+  version: 1.3.2
 platform: ruby
 authors:
 - Tony Ennis
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-22 00:00:00.000000000 Z
+date: 2021-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -109,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.2.4
 signing_key:
 specification_version: 4
 summary: Editmode allows you to turn plain text in your rails app into easily inline-editable