eddy 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90e30433d3481cfb057ca31480ae6ee1e30ba06df8a58439fc20f28e9bf231b3
-  data.tar.gz: 8f5e0429739292acc29f9a4135f945cee429e409d08321b6cffc3efdff841f2d
+  metadata.gz: 43d73af4c067917ea23cc7ecb506d84f33bd4da411b3150add1de0d4c6990844
+  data.tar.gz: 165e1541760111c49ed4f7ad17ee1017f805f2e7a2a36de6c7205b6ed1f34db3
 SHA512:
-  metadata.gz: 26e9c3a97fba8c9e680ba924462f9cc9546616332808912bb2050901b7c6de07fe88664bd579dd5510b44f9e3a7e0f89482f86eb5386be90cf2530e7f1f34e68
-  data.tar.gz: eed5bc960e5c8c7cdbe6deef40a194219dbe9ea98222113342fa4ed237f0a5c1eeeafa30637583e2526d27142ad93f0bc9841923d289a7be4a7560f3aba39a23
+  metadata.gz: 77dbed194e567cb50d41db9dc08f7fdf83b85ad64941d09691ddac435dea64f97460d03342d30c7ba377c946e7abfa8fe3faa59b3aeab2bc579d5c230df70a40
+  data.tar.gz: d236567a50af7d4542897496bc79f1a315079d41b6ca7594f9264a781308ae465289557ab8f1937a3362729edc68137a1c1b117553f9974ac205c4bd628730f9

data/CHANGELOG.md

@@ -13,6 +13,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## master (unreleased)
 
+## 0.8.2 (2020-01-09)
+
+### Fixed
+
+- Account for skipped segments when calculating `SE.NumberOfIncludedSegments`.
+
+### Changed
+
+- Improve messages for `NotImplementedError` exceptions raised  from `R` elements.
+
 ## 0.8.1 (2020-01-08)
 
 ### Changed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    eddy (0.8.1)
+    eddy (0.8.2)
       ginny (~> 0.6.3)
       json_schemer (~> 0.2.8)
       thor (~> 1.0.1)

data/README.md

@@ -10,7 +10,7 @@
 [travis-ci]: https://travis-ci.org/tcd/eddy
 [coveralls]: https://coveralls.io/github/tcd/eddy?branch=master
 [license]: https://github.com/tcd/eddy/blob/master/LICENSE.txt
-[docs]: https://www.rubydoc.info/gems/eddy/0.8.1
+[docs]: https://www.rubydoc.info/gems/eddy/0.8.2
 
 ## Installation
 

data/lib/eddy/models/element/r.rb

@@ -73,13 +73,14 @@ module Eddy
             return val.to_s.slice(0..(max + 1))
           when Complex
             # TODO: Handle case
-            raise NotImplementedError
+            raise NotImplementedError, "eddy: support for Complex types in R data elements has not been implemented."
           when Rational
             # TODO: Handle case
-            raise NotImplementedError
+            raise NotImplementedError, "eddy: support for Rational types in R data elements has not been implemented."
           when BigDecimal
             # TODO: Handle case
-            raise NotImplementedError
+            raise NotImplementedError, "eddy: support for BigDecimal types in R data elements has not been implemented."
+            # return val.to_f.to_s.slice(0..(max + 1))
           end
         end
 

data/lib/eddy/models/transaction_set.rb

@@ -68,7 +68,7 @@ module Eddy
         st.TransactionSetControlNumber  = self.control_number
 
         se = Eddy::Segments::SE.new(self.store)
-        se.NumberOfIncludedSegments    = self.all_components.length + 2
+        se.NumberOfIncludedSegments    = self.number_of_included_segments()
         se.TransactionSetControlNumber = self.control_number
 
         self.components.unshift(st)
@@ -85,6 +85,14 @@ module Eddy
         return self.all_components.map { |s| s.render(self.store.element_separator) }.compact.join(s_sep)
       end
 
+      # Return the count of Segments in the Transaction Set where `skip` is false,
+      # plus 2 for `ST` and `SE`.
+      #
+      # @return [Integer]
+      def number_of_included_segments()
+        return (self.all_components.reject(&:skip).length + 2)
+      end
+
       # Return all contained Segments in a single, flattened array.
       #
       # @return [Array<Eddy::Models::Segment>]

data/lib/eddy/version.rb

@@ -1,3 +1,3 @@
 module Eddy
-  VERSION = "0.8.1".freeze
+  VERSION = "0.8.2".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eddy
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Clay Dunston
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-08 00:00:00.000000000 Z
+date: 2020-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -1569,7 +1569,7 @@ metadata:
   homepage_uri: https://github.com/tcd/eddy
   source_code_uri: https://github.com/tcd/eddy
   changelog_uri: https://github.com/tcd/eddy/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/eddy/0.8.1
+  documentation_uri: https://www.rubydoc.info/gems/eddy/0.8.2
   yard.run: yri
 post_install_message: 
 rdoc_options: []