ecoportal-api-v2 3.3.2 → 3.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fcf0d1bcb9682c389d37e23c34f5e8b358fec8867dcc42da783279e9d7b3de85
-  data.tar.gz: 62f6710a5f91ad24960ccd6cd03b83703de067e6cbcd7f49f2814ed792e5b287
+  metadata.gz: c89de46bf0ec5496e672a071c0c402f5b7c4c4e227b01639e48c46affa0d9bf8
+  data.tar.gz: dbf0124f2f65d2701aefe6ed338a873a759577e206b20021d88475237799a594
 SHA512:
-  metadata.gz: f398d701389d9a3f705385a86ed7f14bf055b77e244fef3f735fe5d63d85974d305520a77bb142506c8ede0d7ab2436fe520098c859fba950f7c18ed65594c8e
-  data.tar.gz: b01280b46c5168ab31d510680ee8d46b650c0c25dc4540784fff591a2160fe848f7e6d7a365259ddaea53199f4e1381eca6aa8d0a391d89e134bddf2206bb9d0
+  metadata.gz: a0216dc9983b1889b8d512e1b5b3c2868a28907b4b00b3a22f2f72482bf0cf174586627e287d93e18776af64853047148de47349c5f86440afbf75b3cb0bdc9f
+  data.tar.gz: 220919e3926f1d9cd1b06d93828ef5e1485f699eb5aa7caa882b9b6b4210e7ed8b87495c88497c7a725ef290a91b7debd6f590d93f3e6ce73512d5399ef565cd

data/CHANGELOG.md

@@ -2,14 +2,29 @@
 
 All notable changes to this project will be documented in this file.
 
-## [3.3.3] - 2026-06-xx
+## [3.3.4] - 2026-08-13
 
-### Added
+### Fixed
 
-### Changed
+- Packaging-only republish with the allowlisted gemspec. `3.3.3` shipped internal repository
+  content (`.ai-assistance/` tooling and notes, `.claude/settings.json`) to rubygems.org via the
+  old denylist `spec.files`. `3.3.4` is the identical `lib/` code packaged clean; `3.3.3` will
+  be yanked.
+
+## [3.3.3] - 2026-07-05
 
 ### Fixed
 
+- **`_cascaded_attributes_trace` — Ruby 3.x block-param order (TypeError crash).** In
+  `DoubleModel::Attributable::Nesting::CascadedCallback`, `_cascaded_attributes.each.with_object(out_trace)`
+  yields `(element, memo)`, but the block read them swapped (`|out, (attribute, obj_k)|`), so
+  `(attribute, obj_k)` destructured the **accumulator hash** and `attribute` became the trace `Hash` →
+  `send(<hash>)` raised `"… is not a symbol nor a string" (TypeError)` on **any** cascaded operation
+  (e.g. `Diffable#as_update` / `DiffService`) over a model with nested attributes. Latent because
+  Ruby 2.x tolerated the arg order; fatal under Ruby 3.x (crashed the live act-gov TOOCS integration
+  via the `ecoportal-api-graphql` consumer). Swapped to `|(attribute, obj_k), out|` (commit `6a2b1b5`).
+  **Regression spec added** (`spec/…/double_model_spec.rb`).
+
 ## [3.3.2] - 2026-06-05
 
 ### Added

data/lib/ecoportal/api/common/content/double_model/attributable/nesting/cascaded_callback.rb

@@ -178,7 +178,7 @@ module Ecoportal::API::Common::Content::DoubleModel::Attributable::Nesting
           nested_attrs: _cascaded_attributes.keys,
           attributes:   {}
         }.merge(trace || {}).tap do |out_trace|
-          _cascaded_attributes.each.with_object(out_trace) do |out, (attribute, obj_k)|
+          _cascaded_attributes.each.with_object(out_trace) do |(attribute, obj_k), out|
             next unless (obj = send(attribute))
 
             obj_k_path = key_path.dup.push(obj_k)

data/lib/ecoportal/api/v2_version.rb

@@ -1,5 +1,5 @@
 module Ecoportal
   module API
-    GEM2_VERSION = '3.3.2'.freeze
+    GEM2_VERSION = '3.3.4'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ecoportal-api-v2
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.3.4
 platform: ruby
 authors:
 - Oscar Segura
@@ -171,21 +171,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".markdownlint.json"
-- ".rspec"
-- ".rubocop.yml"
-- ".ruby-version"
-- ".yardopts"
 - CHANGELOG.md
-- CLAUDE.md
-- Gemfile
 - LICENSE
 - README.md
-- Rakefile
-- bin/console
-- bin/setup
-- ecoportal-api-v2.gemspec
 - lib/ecoportal/api-v2.rb
 - lib/ecoportal/api/common.v2.rb
 - lib/ecoportal/api/common/concerns.rb

data/.gitignore

@@ -1,23 +0,0 @@
-# it's a gem, ignore the lockfile
-Gemfile.lock
-
-# build artifacts
-*.gem
-/.bundle/
-/vendor/bundle
-/spec/reports/
-/tmp/
-/pkg/
-
-/.vscode
-.solargraph.yml
-
-# docs
-/.yardoc
-/_yardoc/
-/coverage/
-/doc/
-
-# rspec failure tracking
-.rspec_status
-scratch.rb

data/.markdownlint.json

@@ -1,4 +0,0 @@
-{
-  "MD013": false,
-  "MD024": false
-}

data/.rspec

@@ -1,3 +0,0 @@
---format documentation
---color
---require spec_helper

data/.rubocop.yml

@@ -1,101 +0,0 @@
-AllCops:
-  TargetRubyVersion: 3.2
-  Exclude:
-    - 'config/routes.rb'
-  NewCops: enable
-
-Metrics/ClassLength:
-  Max: 500
-Metrics/ModuleLength:
-  Max: 300
-Metrics/MethodLength:
-  Max: 50
-Metrics/AbcSize:
-  Max: 30
-Metrics/ParameterLists:
-  Max: 5
-  CountKeywordArgs: false
-Metrics/BlockLength:
-  CountAsOne: ['array', 'heredoc', 'method_call']
-  Max: 50
-Metrics/CyclomaticComplexity:
-  Max: 30
-Metrics/PerceivedComplexity:
-  Max: 30
-
-Style/AccessorGrouping:
-  Enabled: false
-Style/ConditionalAssignment:
-  Enabled: false
-Style/BlockDelimiters:
-  BracesRequiredMethods: ['log']
-Style/HashSyntax:
-  EnforcedShorthandSyntax: either
-  EnforcedStyle: no_mixed_keys
-Style/ArgumentsForwarding:
-  UseAnonymousForwarding: false
-Style/ClassAndModuleChildren:
-  Enabled: false
-Style/FrozenStringLiteralComment:
-  Enabled: false
-Style/StringLiterals:
-  Enabled: false
-Style/StringLiteralsInInterpolation:
-  Enabled: false
-Style/Documentation:
-  Enabled: false
-Style/CommentedKeyword:
-  Enabled: false
-Style/MultilineBlockChain:
-  Enabled: false
-Style/AndOr:
-  Enabled: false
-Style/Alias:
-  EnforcedStyle: prefer_alias_method
-Style/FetchEnvVar:
-  Enabled: false
-Style/RegexpLiteral:
-  EnforcedStyle: mixed
-  AllowInnerSlashes: true
-
-Layout/HashAlignment:
-  EnforcedColonStyle: table
-  EnforcedHashRocketStyle: table
-Layout/LeadingCommentSpace:
-  Enabled: false
-  AllowGemfileRubyComment: true
-Layout/ParameterAlignment:
-  Enabled: false
-Layout/MultilineMethodDefinitionBraceLayout:
-  EnforcedStyle: symmetrical
-Layout/LineLength:
-  Enabled: true
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: false
-Layout/SpaceInsideBlockBraces:
-  Enabled: false
-Layout/SpaceAroundOperators:
-  Enabled: false
-Layout/ExtraSpacing:
-  AllowForAlignment: true
-  AllowBeforeTrailingComments: true
-Layout/AccessModifierIndentation:
-  EnforcedStyle: indent
-Layout/DotPosition:
-  EnforcedStyle: trailing
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-Layout/FirstHashElementIndentation:
-  Enabled: false
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
-
-Naming/VariableNumber:
-  EnforcedStyle: snake_case
-  CheckSymbols: false
-Naming/MethodParameterName:
-  AllowedNames: ['x', 'y', 'i', 'j', 'id', 'io']
-Naming/RescuedExceptionsVariableName:
-  Enabled: false
-Naming/BlockForwarding:
-  Enabled: false

data/.ruby-version

@@ -1 +0,0 @@
-3.2.2

data/.yardopts

@@ -1,10 +0,0 @@
---readme README.md
---charset utf-8
---markup-provider=redcarpet
---markup=markdown
---no-private
---output-dir ./doc
-'lib/**/*.rb'
--
-CHANGELOG.md
-LICENSE

data/CLAUDE.md

@@ -1,82 +0,0 @@
-# CLAUDE.md — ecoportal-api-v2
-
-AI agent instructions for this repository.
-
-**Cross-cutting architecture context lives in `ecoportal-api-graphql` — see its `CLAUDE.md` and `.claude/` folder for the full dependency map, project history, and shared skills.**
-
----
-
-## Repository Role
-
-`ecoportal-api-v2` is the **REST API v2 gem**, extending `ecoportal-api` with a rich content model layer (pages, registers, people, S3 file handling). It provides the `Ecoportal::API::V2` and `Ecoportal::API::Common::Content` namespaces.
-
-**Position in chain:**
-```
-ecoportal-api
-      ↓
-ecoportal-api-v2       ← THIS REPO
-      ↓
-ecoportal-api-graphql
-      ↓
-eco-helpers
-```
-
-**Remote:** https://gitlab.ecoportal.co.nz/oscar/ecoportal-api-v2.git
-
----
-
-## Key Folder Layout
-
-```
-lib/ecoportal/api/
-  common/
-    concerns/          Benchmarkable, Threadable mixins
-    content/           Core model infrastructure (see below)
-  v2/
-    page/              Page model — sections, stages, components, forces, permissions
-    page/component/    All field types (text, number, date, selection, files, geo, etc.)
-    pages/             Pages collection, stage results, tasks
-    registers/         Register models — search results, stage/page results
-    people/            V2 people endpoint
-    s3/                S3 file upload/download infrastructure
-```
-
-### `Common::Content` — the model engine
-
-The most complex part of this gem. Key classes:
-
-- `DoubleModel` — two-layer model (a "live" doc and a "patch" doc) with attribute DSL, diffing, nesting, and change tracking. Almost all V2 models inherit from this.
-- `CollectionModel` — ordered collection with upsert/delete/mutation support.
-- `ClassHelpers` — `class_resolver` macro for injectable class references (pattern shared with `ecoportal-api-graphql`).
-- `DocHelpers`, `ModelHelpers`, `IncluderHelpers` — utility mixins for model construction.
-
----
-
-## Namespace
-
-- `Ecoportal::API::V2` — v2 REST resources
-- `Ecoportal::API::Common::Content` — shared model infrastructure (consumed downstream)
-- `Ecoportal::API::Common::Concerns` — threading and benchmarking mixins
-
----
-
-## Key Concerns
-
-- `DoubleModel` is the foundational abstraction — understand it before modifying any V2 model.
-- `Common::Content::ClassHelpers` mirrors the `ClassHelpers` in `ecoportal-api-graphql` — changes to one may need mirroring in the other.
-- S3 upload is async with polling (`s3/files/poll.rb`) — timing-sensitive code.
-
----
-
-## Backwards Compatibility
-
-`eco-helpers` and `ecoportal-api-graphql` both depend on this gem. Changes to `Common::Content::*` or `V2::Page::*` interfaces must be checked against usage in both downstream gems before committing.
-
----
-
-## Running Tests
-
-```bash
-bundle install
-bundle exec rspec
-```

data/Gemfile

@@ -1,6 +0,0 @@
-source "https://rubygems.org"
-
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
-
-# Specify your gem's dependencies in ecoportal-api.gemspec
-gemspec

data/Rakefile

@@ -1,36 +0,0 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-require 'rubocop/rake_task'
-require "yard"
-require "redcarpet"
-
-desc "run the specs"
-RSpec::Core::RakeTask.new(:spec)
-
-desc "run rspec showing backtrace"
-RSpec::Core::RakeTask.new(:spec_trace) do |task|
-  task.rspec_opts = ['--backtrace']
-end
-
-desc "run rspec stopping on first fail, and show backtrace"
-RSpec::Core::RakeTask.new(:spec_fast) do |task|
-  task.rspec_opts = ['--fail-fast', '--backtrace']
-end
-
-desc "run rubocop diaplying cop names"
-RuboCop::RakeTask.new(:rubocop) do |t|
-  t.options = ['--display-cop-names']
-end
-
-# default task name is yard
-desc "Yard: generate all the documentation"
-YARD::Rake::YardocTask.new(:doc) do |t|
-  #t.files = ['lib/**/*.rb']
-end
-
-desc "default task: runs rubocop and rspec"
-task :default do
-  Rake::Task[:rubocop].invoke
-ensure
-  Rake::Task[:spec].invoke
-end

data/bin/console

@@ -1,14 +0,0 @@
-#!/usr/bin/env ruby
-
-require "bundler/setup"
-require "ecoportal/api-v2"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "pry"
-Pry.start(__FILE__)

data/bin/setup

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
-set -vx
-
-bundle install
-
-# Do any other automated setup that you need to do here

data/ecoportal-api-v2.gemspec

@@ -1,40 +0,0 @@
-# rubocop:disable Gemspec/DevelopmentDependencies
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-
-require 'ecoportal/api/v2_version'
-
-Gem::Specification.new do |spec|
-  spec.name          = 'ecoportal-api-v2'
-  spec.version       = Ecoportal::API::GEM2_VERSION
-  spec.authors       = ['Oscar Segura']
-  spec.email         = ['oscar@ecoportal.co.nz']
-
-  spec.summary       = "A collection of helpers for interacting with the ecoPortal MS's V2 API"
-  spec.homepage      = "https://www.ecoportal.com"
-  spec.licenses      = %w[MIT]
-
-  spec.metadata['rubygems_mfa_required'] = 'true'
-
-  spec.required_ruby_version = '>= 3.2.2'
-
-  spec.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(test|spec|features)/})
-  end
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ['lib']
-
-  spec.add_development_dependency 'pry',       '~> 0.14'
-  spec.add_development_dependency 'rake',      '>= 13.0.3', '< 14'
-  spec.add_development_dependency 'redcarpet', '>= 3.6.0',  '< 4'
-  spec.add_development_dependency 'rspec',     '>= 3.12.0', '< 4'
-  spec.add_development_dependency 'rubocop',   '~> 1'
-  spec.add_development_dependency 'rubocop-rake', '~> 0'
-  spec.add_development_dependency 'yard',         '~> 0.9'
-
-  spec.add_dependency 'ecoportal-api', '~> 0.10', '>= 0.10.16'
-  spec.add_dependency 'mime-types',    '~> 3.5',  '>= 3.5.2'
-end
-
-# rubocop:enable Gemspec/DevelopmentDependencies