ecoportal-api-graphql 1.3.14 → 1.3.15

data/lib/ecoportal/api/graphql/mutation/smart_fill/submit_feedback.rb

@@ -1,40 +1,40 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Mutation
-        module SmartFill
-          # Submit a rating on a SmartFill generation.
-          # value: "THUMBS_UP" | "THUMBS_DOWN" (BinaryRatingEnum)
-          class SubmitFeedback < Logic::Mutation
-            field_name :smartFillSubmitFeedback
-
-            class_resolver :payload_class, 'Ecoportal::API::GraphQL::Payload::OkPayload'
-
-            private
-
-            def basic_block(&block)
-              payload_block = block || default_payload_block
-              proc {
-                mutation(pageId: :id!, dataFieldId: :id!, value: :BinaryRatingEnum!) {
-                  smartFillSubmitFeedback(
-                    pageId:      :pageId,
-                    dataFieldId: :dataFieldId,
-                    value:       :value,
-                    &payload_block
-                  )
-                }
-              }
-            end
-
-            def default_payload_block
-              proc {
-                ok
-                errors { details fullMessages }
-              }
-            end
-          end
-        end
-      end
-    end
-  end
-end
+module Ecoportal
+  module API
+    class GraphQL
+      module Mutation
+        module SmartFill
+          # Submit a rating on a SmartFill generation.
+          # value: "THUMBS_UP" | "THUMBS_DOWN" (BinaryRatingEnum)
+          class SubmitFeedback < Logic::Mutation
+            field_name :smartFillSubmitFeedback
+
+            class_resolver :payload_class, 'Ecoportal::API::GraphQL::Payload::OkPayload'
+
+            private
+
+            def basic_block(&block)
+              payload_block = block || default_payload_block
+              proc {
+                mutation(pageId: :id!, dataFieldId: :id!, value: :BinaryRatingEnum!) {
+                  smartFillSubmitFeedback(
+                    pageId:      :pageId,
+                    dataFieldId: :dataFieldId,
+                    value:       :value,
+                    &payload_block
+                  )
+                }
+              }
+            end
+
+            def default_payload_block
+              proc {
+                ok
+                errors { details fullMessages }
+              }
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ecoportal/api/graphql/mutation/smart_fill.rb

@@ -1,13 +1,13 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Mutation
-        module SmartFill
-        end
-      end
-    end
-  end
-end
-
-require_relative 'smart_fill/generate'
-require_relative 'smart_fill/submit_feedback'
+module Ecoportal
+  module API
+    class GraphQL
+      module Mutation
+        module SmartFill
+        end
+      end
+    end
+  end
+end
+
+require_relative 'smart_fill/generate'
+require_relative 'smart_fill/submit_feedback'

data/lib/ecoportal/api/graphql/mutation/template/create_related_page.rb

@@ -1,46 +1,46 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Mutation
-        module Template
-          class CreateRelatedPage < Logic::Mutation
-            SCHEMA_VERSION = '20260605'.freeze
-
-            field_name :createTemplateRelatedPage
-
-            class_resolver :payload_class, 'Ecoportal::API::GraphQL::Payload::Template::CreateRelatedPage'
-
-            def query(template_id:, title:, register_id:, patch_ver:, filters: nil, **kargs, &block)
-              input = {
-                templateId: template_id,
-                title:      title,
-                registerId: register_id,
-                patchVer:   patch_ver
-              }
-              input[:filters] = filters if filters
-              super(input: input, **kargs, &block)
-            end
-
-            private
-
-            def basic_block(&block)
-              payload_block = block || default_payload_block
-              proc {
-                mutation(input: :CreateTemplateRelatedPageInput!) {
-                  createTemplateRelatedPage(input: :input, &payload_block)
-                }
-              }
-            end
-
-            def default_payload_block
-              proc {
-                item { spread :PageFields }
-                errors { details fullMessages }
-              }
-            end
-          end
-        end
-      end
-    end
-  end
-end
+module Ecoportal
+  module API
+    class GraphQL
+      module Mutation
+        module Template
+          class CreateRelatedPage < Logic::Mutation
+            SCHEMA_VERSION = '20260605'.freeze
+
+            field_name :createTemplateRelatedPage
+
+            class_resolver :payload_class, 'Ecoportal::API::GraphQL::Payload::Template::CreateRelatedPage'
+
+            def query(template_id:, title:, register_id:, patch_ver:, filters: nil, **kargs, &block)
+              input = {
+                templateId: template_id,
+                title:      title,
+                registerId: register_id,
+                patchVer:   patch_ver
+              }
+              input[:filters] = filters if filters
+              super(input: input, **kargs, &block)
+            end
+
+            private
+
+            def basic_block(&block)
+              payload_block = block || default_payload_block
+              proc {
+                mutation(input: :CreateTemplateRelatedPageInput!) {
+                  createTemplateRelatedPage(input: :input, &payload_block)
+                }
+              }
+            end
+
+            def default_payload_block
+              proc {
+                item { spread :TemplateRelatedPages }
+                errors { details fullMessages }
+              }
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ecoportal/api/graphql/mutation/template/destroy_related_page.rb

@@ -31,7 +31,7 @@ module Ecoportal
 
             def default_payload_block
               proc {
-                item { spread :PageFields }
+                item { spread :TemplateRelatedPages }
                 errors { details fullMessages }
               }
             end

data/lib/ecoportal/api/graphql/mutation/template/update_information.rb

@@ -31,7 +31,7 @@ module Ecoportal
 
             def default_payload_block
               proc {
-                item { spread :PageFields }
+                item { spread :TemplateInformation }
                 errors { details fullMessages }
               }
             end

data/lib/ecoportal/api/graphql/mutation.rb

@@ -1,20 +1,20 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Mutation
-      end
-    end
-  end
-end
-
-require_relative 'mutation/location_structure'
-require_relative 'mutation/contractor_entity'
-require_relative 'mutation/action'
-require_relative 'mutation/page'
-require_relative 'mutation/register'
-require_relative 'mutation/preset_view'
-
-require_relative 'mutation/ai_summary'
-require_relative 'mutation/smart_fill'
-require_relative 'mutation/kickstand'
-require_relative 'mutation/template'
+module Ecoportal
+  module API
+    class GraphQL
+      module Mutation
+      end
+    end
+  end
+end
+
+require_relative 'mutation/location_structure'
+require_relative 'mutation/contractor_entity'
+require_relative 'mutation/action'
+require_relative 'mutation/page'
+require_relative 'mutation/register'
+require_relative 'mutation/preset_view'
+
+require_relative 'mutation/ai_summary'
+require_relative 'mutation/smart_fill'
+require_relative 'mutation/kickstand'
+require_relative 'mutation/template'

data/lib/ecoportal/api/graphql/payload/ok_payload.rb

@@ -1,21 +1,36 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Payload
-        # Payload for mutations that return { ok: Boolean, errors } instead of an item.
-        # Used by: submitAiSummaryFeedback, smartFillGenerate, smartFillSubmitFeedback.
-        class OkPayload < Logic::BaseModel
-          passboolean :ok
-
-          def success?
-            !!ok
-          end
-
-          def error?
-            !success?
-          end
-        end
-      end
-    end
-  end
-end
+module Ecoportal
+  module API
+    class GraphQL
+      module Payload
+        # Payload for mutations that return `{ ok: Boolean, errors }` instead of an item.
+        # Used by `submitPageAiSummaryFeedback` (`SubmitFeedbackPayload`).
+        #
+        # The `smartFillGenerate` / `smartFillSubmitFeedback` users named here before 2026-07-30
+        # never existed in the schema — see the CHANGELOG entry that removed them.
+        class OkPayload < Logic::BaseModel
+          passboolean :ok
+
+          # The mutations select `errors`, so model it: without this the response contract
+          # (`success?`/`error?`/`error_doc`) reported success on a payload that carried errors.
+          embeds_one :errors, klass: Error::ValidationErrors, nullable: true
+
+          def success?
+            !!ok && !error?
+          end
+
+          def error?
+            return false if errors.nil?
+
+            !errors.empty?
+          end
+
+          def error_doc
+            return unless (err_doc = errors&.doc)
+
+            { errors: err_doc }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ecoportal/api/graphql/payload/page/draft.rb

@@ -1,13 +1,26 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Payload
-        module Page
-          class Draft < Logic::Payload
-            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PageUnion'
-          end
-        end
-      end
-    end
-  end
-end
+module Ecoportal
+  module API
+    class GraphQL
+      module Payload
+        module Page
+          # Payload of the three draft mutations. ★ None of their schema payload types has an
+          # `item` (verified against the live schema 2026-07-30) — they return scalars:
+          #   createPageDraft  -> CreatePageDraftPayload  { id }   the new draft's page id
+          #   deleteDraftPage  -> DeleteDraftPagePayload  { ok }
+          #   publishDraftPage -> PublishDraftPagePayload { ok }
+          # All three used to select `item { ...PageFields }`, which made them invalid documents.
+          #
+          # `item` stays inherited from `Logic::Payload` for interface compatibility, but with no
+          # `item` in the response it materialises a HOLLOW model (all fields nil) rather than
+          # returning nil — read `id` / `ok` instead.
+          class Draft < Logic::Payload
+            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PageUnion'
+
+            passkey     :id
+            passboolean :ok
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ecoportal/api/graphql/payload/page/review_task.rb

@@ -1,13 +1,13 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Payload
-        module Page
-          class ReviewTask < Logic::Payload
-            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PageUnion'
-          end
-        end
-      end
-    end
-  end
-end
+module Ecoportal
+  module API
+    class GraphQL
+      module Payload
+        module Page
+          class ReviewTask < Logic::Payload
+            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::Page::Task'
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ecoportal/api/graphql/payload/page/review_task_batch.rb

@@ -0,0 +1,23 @@
+module Ecoportal
+  module API
+    class GraphQL
+      module Payload
+        module Page
+          # Payload of `batchUpdateReviewPageTask`. ★ Distinct from `Payload::Page::ReviewTask`:
+          # `BatchUpdateReviewPageTaskPayload` has NO `item` — it returns `count` (how many tasks
+          # were updated), verified against the live schema 2026-07-30. The mutation previously
+          # shared `Payload::Page::ReviewTask` and selected `item { ...PageFields }`, which made
+          # the document invalid.
+          class ReviewTaskBatch < Logic::Payload
+            # UNUSED: this payload has no `item`. A class must still be resolvable because
+            # `Logic::Payload`'s inherited `embeds_one :item` materialises a hollow model, and
+            # the default `GenericItem` raises by design.
+            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PageUnion'
+
+            passthrough :count
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ecoportal/api/graphql/payload/page.rb

@@ -1,19 +1,20 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Payload
-        module Page
-        end
-      end
-    end
-  end
-end
-
-require_relative 'page/update'
-require_relative 'page/archive'
-require_relative 'page/unarchive'
-require_relative 'page/build_from_template'
-require_relative 'page/create_from_template'
-require_relative 'page/draft'
-require_relative 'page/review_task'
-require_relative 'page/update_variable_bindings'
+module Ecoportal
+  module API
+    class GraphQL
+      module Payload
+        module Page
+        end
+      end
+    end
+  end
+end
+
+require_relative 'page/update'
+require_relative 'page/archive'
+require_relative 'page/unarchive'
+require_relative 'page/build_from_template'
+require_relative 'page/create_from_template'
+require_relative 'page/draft'
+require_relative 'page/review_task'
+require_relative 'page/review_task_batch'
+require_relative 'page/update_variable_bindings'

data/lib/ecoportal/api/graphql/payload/preset_view.rb

@@ -1,11 +1,15 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Payload
-        class PresetView < Logic::Payload
-          class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PresetView'
-        end
-      end
-    end
-  end
-end
+module Ecoportal
+  module API
+    class GraphQL
+      module Payload
+        class PresetView < Logic::Payload
+          class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PresetView'
+
+          # `destroyPresetView` returns DestroyPresetViewPayload { clientMutationId errors }
+          # only — no `item`, not even `ok` (verified against the live schema 2026-07-30).
+          # create/update DO return `item: PresetView`.
+        end
+      end
+    end
+  end
+end

data/lib/ecoportal/api/graphql/payload/register.rb

@@ -1,11 +1,15 @@
-module Ecoportal
-  module API
-    class GraphQL
-      module Payload
-        class Register < Logic::Payload
-          class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::Register'
-        end
-      end
-    end
-  end
-end
+module Ecoportal
+  module API
+    class GraphQL
+      module Payload
+        class Register < Logic::Payload
+          class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::Register'
+
+          # `destroyRegister` returns DestroyRegisterPayload { ok } — no `item` (verified
+          # against the live schema 2026-07-30). create/update DO return `item: Register`.
+          passboolean :ok
+        end
+      end
+    end
+  end
+end

data/lib/ecoportal/api/graphql/payload/template/create_related_page.rb

@@ -4,7 +4,7 @@ module Ecoportal
       module Payload
         module Template
           class CreateRelatedPage < Logic::Payload
-            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PageUnion'
+            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::Template::RelatedPages'
           end
         end
       end

data/lib/ecoportal/api/graphql/payload/template/destroy_related_page.rb

@@ -4,7 +4,7 @@ module Ecoportal
       module Payload
         module Template
           class DestroyRelatedPage < Logic::Payload
-            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PageUnion'
+            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::Template::RelatedPages'
           end
         end
       end

data/lib/ecoportal/api/graphql/payload/template/update_information.rb

@@ -4,7 +4,7 @@ module Ecoportal
       module Payload
         module Template
           class UpdateInformation < Logic::Payload
-            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::PageUnion'
+            class_resolver :item_class, 'Ecoportal::API::GraphQL::Model::Template::Information'
           end
         end
       end

data/lib/ecoportal/api/graphql/query/page_with_forces.rb

@@ -28,12 +28,18 @@ module Ecoportal
             }
           end
 
+          # `currentOrganization.page(id:)` returns a PageUnion — selecting `forces` on it
+          # directly is invalid GraphQL ("Selections can't be made directly on unions").
+          # `forces` lives on BasePageInterface (which every union member implements), so it
+          # goes through an inline type condition, same as `PageFields` does.
           def default_block
             proc {
               spread :PageFields
-              forces {
-                spread :ForceFields
-              }
+              spread on: :BasePageInterface do
+                forces {
+                  spread :ForceFields
+                }
+              end
             }
           end
         end

data/lib/ecoportal/api/graphql/query/pages_workflow_commands.rb

@@ -25,15 +25,21 @@ module Ecoportal
 
           private
 
+          # `page(id:)` returns a PageUnion — selecting `workflow` on it directly is invalid
+          # GraphQL ("Selections can't be made directly on unions"). `workflow` lives on
+          # BasePageInterface, so it goes through an inline type condition. The response shape
+          # is unchanged by the type condition, so `#path` still resolves the connection.
           def basic_block(&block)
             connection_block = block || default_connection_block
             proc {
               query(id: :id!, after: :string, before: :string, first: :int, last: :int) {
                 currentOrganization {
                   page(id: :id) {
-                    workflow {
-                      commands(after: :after, before: :before, first: :first, last: :last, &connection_block)
-                    }
+                    spread on: :BasePageInterface do
+                      workflow {
+                        commands(after: :after, before: :before, first: :first, last: :last, &connection_block)
+                      }
+                    end
                   }
                 }
               }