ecom_core 1.3.3 → 1.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f471cd5b5bddb2156f3edbd091a53fff200ac09e374d465201dd4fa930bbc384
-  data.tar.gz: 5b8bb54ba78c861e284f85bcd9c183e5213559005669245483aea63b4ddf64c3
+  metadata.gz: 94e3027df94f50f9f3c06ccd90f7db0656503d24548f9ba4f13a5e08f64d4bfa
+  data.tar.gz: f322acc0c157ceb5b7e2e39a80bde80cf8b94c6fb6cee08fb3fedf60b918e01d
 SHA512:
-  metadata.gz: ed6a04e00cf9c858ee3a9366c297f5e989bdf3bb9e0d18e6ca0c905945995a03c6312f2549b4ab7f2f5cbaefd6994933d7c05d27462e2efece7a5a922ed66c74
-  data.tar.gz: c6e0dc807e852c9ee55ab645422c2f51bf17340c7196e1665dbc24cc3081771ad2791d14cc08de64fe226561da70d934b1177fc2ea38c30ccb523264f3e1d325
+  metadata.gz: 6c722a056f2070704bac09ffc3fe964d38216de5d172609898697a25f6be90f98a280dbaa53a80d29c7457d81318849b8b05dbc997425c9addd169fa48b9b6b2
+  data.tar.gz: 44603efa47b064f655e000080a954df972ddc3125389b143343f95f3c9127588130b1de450978d39530b886a18ac37598072e7c3f946667cbb9bcd457852e662

data/app/models/ecom/core/attendance_sheet_entry.rb

@@ -4,6 +4,8 @@ module Ecom
       belongs_to :attendance_sheet
       belongs_to :crew
       has_many :crew_times
+
+      validates :total_hours, presence: true, numericality: { greater_than_or_equal_to: 0 }
     end
   end
 end

data/app/models/ecom/core/crew_overtime.rb

@@ -10,6 +10,10 @@ module Ecom
 
       validates :hours, :raw_hours, presence: true
       validate :validate_overtime_by_type
+      validates :hours, presence: true, numericality: { greater_than_or_equal_to: 0 }
+      validates :overtime_type_id,
+                uniqueness: { scope: :overtime_sheet_entry_id,
+                              message: 'There exists a crew overtime for the given overtime sheet and overtime type' }
 
       scope :by_overtime, lambda { |id|
         joins(:overtime_sheet_entry).where(ecom_core_overtime_sheet_entries: { overtime_sheet_id: id })
@@ -23,8 +27,11 @@ module Ecom
 
         start = Time.zone.parse(overtime_type.from)
         finish = Time.zone.parse(overtime_type.to)
-        diff = ((finish - start) / 3600).round
-
+        diff = if finish >= start
+                 ((finish - start) / 3600).round
+               else
+                 ((start - finish) / 3600).round
+               end
         return unless raw_hours > diff
 
         errors.add(:crew_overtime, 'The selected overtime type does not allow the specified amount of hours.')

data/app/models/ecom/core/crew_time.rb

@@ -13,6 +13,7 @@ module Ecom
 
       validates :checkin_time, presence: true, if: :checkout_time
       validate :time_range_validation, :total_time_validation
+      validates :hours, presence: true, numericality: { greater_than_or_equal_to: 0 }
 
       scope :by_attendance, lambda { |id|
         joins(:attendance_sheet_entry).where(ecom_core_attendance_sheet_entries: { attendance_sheet_id: id })
@@ -31,9 +32,13 @@ module Ecom
       def total_time_validation
         return if checkout_time.nil? || checkin_time.nil?
 
-        return unless attendance_sheet_entry.total_hours + compute_hours > 8
-
-        errors.add(:attendance_sheet_entry, 'has more than 8 hours')
+        if new_record? & !persisted?
+          if attendance_sheet_entry.total_hours + compute_hours > 8
+            errors.add(:attendance_sheet_entry, 'has more than 8 hours')
+          end
+        elsif attendance_sheet_entry.total_hours + compute_hours - computed_hour > 8
+          errors.add(:attendance_sheet_entry, 'has more than 8 hours')
+        end
       end
 
       def calculate_hours
@@ -109,6 +114,21 @@ module Ecom
         time -= 1 if day_part == FULL_DAY
         time
       end
+
+      # A similar method as `compute_hours` but this one computes hours for
+      # the the currently presisted checkin_time and checkout_time
+      def computed_hour
+        # Reparse time to avoid errors caused by date differences
+        range = define_range
+        start = Time.zone.parse(checkin_time_was.strftime('%I:%M%p'))
+        finish = Time.zone.parse(checkout_time_was.strftime('%I:%M%p'))
+        day_part = find_range(start, finish)
+        left = start.before?(range[day_part][:start]) ? range[day_part][:start] : start
+        right = finish.after?(range[day_part][:finish]) ? range[day_part][:finish] : finish
+        time = (right - left) / 1.hour
+        time -= 1 if day_part == FULL_DAY
+        time
+      end
     end
   end
 end

data/app/models/ecom/core/maintenance_service_order.rb

@@ -10,9 +10,9 @@ module Ecom
       belongs_to :equipment_item
       belongs_to :maintenance_type
       belongs_to :prepared_by, class_name: 'Ecom::Core::User'
-      belongs_to :approved_by, class_name: 'Ecom::Core::User'
+      belongs_to :approved_by, class_name: 'Ecom::Core::User', optional: true
 
-      validates :title, :status, :current_reading, presence: true
+      validates :title, :status, presence: true
       validates :status, inclusion: STATUSES
     end
   end

data/app/models/ecom/core/overtime_sheet_entry.rb

@@ -4,6 +4,8 @@ module Ecom
       belongs_to :overtime_sheet
       belongs_to :crew
       has_many :crew_overtimes
+
+      validates :total_overtime, presence: true, numericality: { greater_than_or_equal_to: 0 }
     end
   end
 end

data/app/models/ecom/core/payment_detail.rb

@@ -5,7 +5,7 @@ module Ecom
       belongs_to :payment
 
       validates :hours, :ot_hours, :base_salary, :overtime, :gross_salary, :tax, :pension, :net_salary, :net_pay,
-                :advance, presence: true
+                :advance, presence: true, numericality: { greater_than_or_equal_to: 0 }
     end
   end
 end

data/app/models/ecom/core/task_template.rb

@@ -11,7 +11,7 @@ module Ecom
       has_many :work_product_templates, through: :project_work_item_templates
       has_and_belongs_to_many :resource_types, join_table: 'ecom_core_task_templates_resource_types'
 
-      validates :name, :code, :takeoff_fields, :task_completion_detail, presence: true
+      validates :name, :code, presence: true
       validates :code, uniqueness: true
       validates :percentage_contribution,
                 numericality: {

data/app/services/ecom/core/filter_service.rb

@@ -0,0 +1,19 @@
+module Ecom
+  module Core
+    class FilterService
+      def get_filtered_data(type, filters)
+        positive = {}
+        negative = {}
+        obj = type.constantize
+        filters.each { |f|
+          if f[:cond] == 'P'
+            positive[f[:key]] = f[:value]
+          else
+            negative[f[:key]] = f[:value]
+          end
+        }
+        obj.where(positive).where.not(negative)
+      end
+    end
+  end
+end

data/db/migrate/20191119012030_create_ecom_core_task_templates.rb

@@ -9,13 +9,13 @@ class CreateEcomCoreTaskTemplates < ActiveRecord::Migration[6.0]
                    index: { name: 'tt_on_ttt_indx' },
                    foreign_key: { to_table: :ecom_core_task_template_types }
       t.string :ancestry, index: true
-      t.boolean :has_takeoff_fields, null:false, default: false
-      t.jsonb :takeoff_fields, null: false, default: {}
+      t.boolean :has_takeoff_fields, null: false, default: false
+      t.jsonb :takeoff_fields, null: true
       t.integer :percentage_contribution
       t.integer :task_sequence
       t.boolean :has_inspection, null: false, default: false
       t.boolean :discipline, null: false, default: false
-      t.jsonb :task_completion_detail, null: false, default: {}
+      t.jsonb :task_completion_detail, null: true
 
       t.timestamps
     end

data/db/migrate/20200410111827_create_ecom_core_crew_overtimes.rb

@@ -23,5 +23,6 @@ class CreateEcomCoreCrewOvertimes < ActiveRecord::Migration[6.0]
 
       t.timestamps
     end
+    add_index :ecom_core_crew_overtimes, [:overtime_type_id, :overtime_sheet_entry_id],unique: true, name: 'ot_on_ose_name_indx'
   end
 end

data/db/migrate/20200919081338_create_ecom_core_maintenance_service_orders.rb

@@ -8,7 +8,7 @@ class CreateEcomCoreMaintenanceServiceOrders < ActiveRecord::Migration[6.0]
       t.boolean :approved, default: false
       t.string :status, null: false, default: 'New'
       t.string :remark
-      t.float :current_reading, null: false
+      t.float :current_reading, null: true
       t.references :equipment_item,
                    null: false,
                    index: { name: 'mso_on_ei_indx' },
@@ -22,7 +22,7 @@ class CreateEcomCoreMaintenanceServiceOrders < ActiveRecord::Migration[6.0]
                    index: { name: 'mso_on_pb_indx' },
                    foreign_key: { to_table: :ecom_core_users }
       t.references :approved_by,
-                   null: false,
+                   null: true,
                    index: { name: 'mso_on_ab_indx' },
                    foreign_key: { to_table: :ecom_core_users }
 

data/db/migrate/20201013094100_create_ecom_core_crew_id_cards.rb

@@ -8,7 +8,7 @@ class CreateEcomCoreCrewIdCards < ActiveRecord::Migration[6.0]
 
       t.datetime :issued_on, null: false
       t.datetime :valid_until, null: false
-      t.string :status, null: false, default: 'Active'
+      t.string :status, null: false, default: 'Valid'
 
       t.timestamps
     end

data/lib/ecom/core/version.rb

@@ -1,5 +1,5 @@
 module Ecom
   module Core
-    VERSION = '1.3.3'.freeze
+    VERSION = '1.3.8'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ecom_core
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.8
 platform: ruby
 authors:
 - Henock L.
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-26 00:00:00.000000000 Z
+date: 2021-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aasm
@@ -134,14 +134,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.3
+        version: 6.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.3
+        version: 6.1.1
 - !ruby/object:Gem::Dependency
   name: json-schema
   requirement: !ruby/object:Gem::Requirement
@@ -375,6 +375,7 @@ files:
 - app/serializers/ecom/core/user_role_serializer.rb
 - app/serializers/ecom/core/user_serializer.rb
 - app/services/ecom/core/crew_contract_transaction_service.rb
+- app/services/ecom/core/filter_service.rb
 - app/services/ecom/core/menu_service.rb
 - app/services/ecom/core/site_crew_service.rb
 - app/services/ecom/core/token_auth_service.rb
@@ -556,7 +557,7 @@ homepage: http://www.mks.com.et
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -572,7 +573,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.4
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Core engine for construction management application.
 test_files: []