eco-helpers 3.2.6 → 3.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8bb545e3154c1a65a993a24b6eeab4eebbe125e95492bc2b6961fee0a708a80f
-  data.tar.gz: dc6bd380cd757b5218fadf264c64ef8a61b767916514aebac63fae0739c5153c
+  metadata.gz: bfe97cd5583e8650f73c0f7cb2557fde896d3b59b7e729703fdb01f9323d6fbb
+  data.tar.gz: e40c8fdeae21780ca957c043aa7a637d06d9e85088fdbca6eb7c488448c74ab5
 SHA512:
-  metadata.gz: b9852caf3f9f2dcdcbcbe4d17e325c566e63b3724b92349668e35fb4839aea5b7879b3b080b031868495b40c5bb09a9fc9d43c0b5cd4e9dbc298ec0f25d867d8
-  data.tar.gz: 5941ec298de1bff8205be578bcefaed0602dfea76ceee47a00497b28ff973a293553927d1ce96f0617abe0886c5fa4f5810678e69c3fab2673fd35c6df88dac3
+  metadata.gz: c1f28e77164e7f8c439b09dba5d952594c34721457842963cfb9e037c90658de8049545c1029e25e6aa2aadda2a729a4fc103fb04335adcfb6359b1fe946ad60
+  data.tar.gz: '090c4c12745401c0191aec263bb3970bd92e5244c6b57f4d5ef6dd157acab37ab868ed239972d133bd52a4eb11ddcac0e4857a8e760e10321b7236f50a7d3c76'

data/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file.
 
-## [3.2.7] - 2025-09-xx
+## [3.2.8] - 2025-09-xx
 
 ### Added
 
@@ -10,6 +10,16 @@ All notable changes to this project will be documented in this file.
 
 ### Fixed
 
+## [3.2.7] - 2025-09-09
+
+### Added
+
+- `NodeBase` (and subclasses): **added** missed case `#self_parented?`
+
+### Fixed
+
+- **Added** early detection of `self-parented` nodes (from the input file).
+
 ## [3.2.6] - 2025-09-05
 
 ### Added
@@ -24,14 +34,6 @@ All notable changes to this project will be documented in this file.
   - This was a working around due to not using `as_nodes_json` as a **common** converter between `live_tree` and `file_tree` (which was fixed in a previous release).
   - `as_nodes_json` already does the call to `node_parser_block`, which does the conversion of the **classifications**
 
-## [3.2.6] - 2025-09-xx
-
-### Added
-
-### Changed
-
-### Fixed
-
 ## [3.2.5] - 2025-09-04
 
 ### Changed

data/lib/eco/data/locations/node_base/builder.rb

@@ -11,15 +11,19 @@ module Eco::Data::Locations::NodeBase
       case data
       when ::CSV::Table
         return Eco::Data::Locations::NodePlain if Eco::Data::Locations::NodePlain.csv_matches_format?(csv)
-        return Eco::Data::Locations::NodeLevel if Eco::Data::Locations::NodeLevel.csv_matches_format?(csv)
+
+        Eco::Data::Locations::NodeLevel        if Eco::Data::Locations::NodeLevel.csv_matches_format?(csv)
       when Array
-        return nil unless sample = data.first
+        return unless (sample = data.first)
+
         node_class(sample)
       when Eco::Data::Locations::NodeBase
-        return nil unless data.class < Eco::Data::Locations::NodeBase
+        return unless data.class < Eco::Data::Locations::NodeBase
+
         data.class
       else
-        raise ArgumentError, "Expecting CSV::Table. Given: #{csv.class}" unless csv.is_a?(::CSV::Table)
+        msg ="Expecting CSV::Table. Given: #{csv.class}"
+        raise ArgumentError, msg unless csv.is_a?(::CSV::Table)
       end
     end
   end

data/lib/eco/data/locations/node_base/parsing.rb

@@ -6,10 +6,19 @@ module Eco::Data::Locations::NodeBase
     # @param csv [CSV::Table]
     # @return [Array<NodePlain>, Array<NodeLevel>] with integrity issues resolved.
     def nodes_from_csv(csv)
-      raise ArgumentError, "Expecting CSV::Table. Given: #{csv.class}" unless csv.is_a?(::CSV::Table)
-      return Eco::Data::Locations::NodePlain.nodes_from_csv(csv) if Eco::Data::Locations::NodePlain.csv_matches_format?(csv)
-      return Eco::Data::Locations::NodeLevel.nodes_from_csv(csv) if Eco::Data::Locations::NodeLevel.csv_matches_format?(csv)
-      raise ArgumentError, "The input csv does not have the required format to read a locations structure."
+      msg = "Expecting CSV::Table. Given: #{csv.class}"
+      raise ArgumentError, msg unless csv.is_a?(::CSV::Table)
+
+      if Eco::Data::Locations::NodePlain.csv_matches_format?(csv)
+        return Eco::Data::Locations::NodePlain.nodes_from_csv(csv)
+      end
+
+      if Eco::Data::Locations::NodeLevel.csv_matches_format?(csv)
+        return Eco::Data::Locations::NodeLevel.nodes_from_csv(csv)
+      end
+
+      msg = "The input csv does not have the required format to read a locations structure."
+      raise ArgumentError, msg
     end
 
     # @yield [node, json] optional custom serializer
@@ -18,7 +27,9 @@ module Eco::Data::Locations::NodeBase
     # @yieldreturn [Hash] the serialized Node
     # @return [Array<Hash>] a hierarchical tree of nested Hashes via `nodes` key.
     def hash_tree_from_csv(csv, &block)
-      raise ArgumentError, "Expecting CSV::Table. Given: #{csv.class}" unless csv.is_a?(::CSV::Table)
+      msg = "Expecting CSV::Table. Given: #{csv.class}"
+      raise ArgumentError, msg unless csv.is_a?(::CSV::Table)
+
       treeify(nodes_from_csv(csv), &block)
     end
 

data/lib/eco/data/locations/node_base/treeify.rb

@@ -55,8 +55,25 @@ module Eco::Data::Locations::NodeBase
     # @return [Hash] where `key`s are all the `parentId` of the nodes
     #   and `value` and `Array` of those nodes that have that `parentId`
     def parents_hash(nodes)
+      self_parented = []
+
       nodes.each_with_object({}) do |node, parents|
+        next self_parented.push(node) if node.self_parented?
+
         (parents[node.parentId] ||= []).push(node)
+      end.tap do
+        next if self_parented.empty?
+
+        log(:error) {
+          msg = "#{self_parented.count} nodes are self-parented: "
+          msg << self_parented.map(&:id).map do |node_id|
+            "'#{node_id}'"
+          end.join(', ')
+          msg << "\nPlease amend the data."
+          msg
+        }
+
+        exit 1
       end
     end
 
@@ -138,7 +155,6 @@ module Eco::Data::Locations::NodeBase
       # skipped keys is inherent, as they were excluded because of id clash with done_ids
       unlinked_parent_ids = (parents.keys - done_ids.keys).compact
 
-
       # The reason of missing nodes in the output tree is unknown!
       if skipped.empty? && unlinked_parent_ids.empty?
         msg  = []

data/lib/eco/data/locations/node_base.rb

@@ -14,6 +14,10 @@ module Eco::Data::Locations
 
     attr_accessor :tracked_level, :parent
 
+    def self_parented?
+      raise 'You should implement this method in child classes'
+    end
+
     def copy
       self.class.new.set_attrs(**to_h)
     end

data/lib/eco/data/locations/node_level.rb

@@ -50,6 +50,10 @@ module Eco::Data::Locations
     alias_method :node_id, :id
     alias_method :nodeId,  :id # rubocop:disable Naming/MethodName
 
+    def self_parented?
+      id == parent_id
+    end
+
     def name
       tag
     end

data/lib/eco/data/locations/node_plain.rb

@@ -30,10 +30,6 @@ module Eco::Data::Locations
     # backwards compatibility
     alias_method :tag, :id
 
-    def name
-      super || id
-    end
-
     def parent_id
       clean_id(
         super,
@@ -43,6 +39,14 @@ module Eco::Data::Locations
     end
     alias_method :parentId, :parent_id # rubocop:disable Naming/MethodName
 
+    def self_parented?
+      id == parent_id
+    end
+
+    def name
+      super || id
+    end
+
     def archived
       value = super
       return false if value.nil? || value == false

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = '3.2.6'.freeze
+  VERSION = '3.2.7'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 3.2.6
+  version: 3.2.7
 platform: ruby
 authors:
 - Oscar Segura
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-05 00:00:00.000000000 Z
+date: 2025-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug