eco-helpers 3.0.7 → 3.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b0fea8f72b2d0037d801b6150661827607326151c71b93df924d1f1271c17166
-  data.tar.gz: d0059328bb938ace9e481a8023a4e5574f1e37e034220418e752c4647de4e382
+  metadata.gz: c5f99b7ad6dad2fcd262a6269bbe2c7a2acae695b077712ce745c9f0746e2580
+  data.tar.gz: de2217f416b703f1cc0ae06f6c42bddbebedef906013b128b5efcdc552df40af
 SHA512:
-  metadata.gz: 01eb1d82295aa464cad0b5898e1fa3a295a7f01953f77b1591a2c1e96a96704f1bf82beb0b41b0ce6b6e0ed6eeea07568e029f2797b62d162dd541d93b37b9ed
-  data.tar.gz: 21258ac597601cad5559f847f26defc78a564733b0e4ed4610d4f70b404cbf6977292a462040374f36706eb69cffabafa52179aa24531c23e29e10a53d9c539b
+  metadata.gz: 6149a32bf28606ac1051a127deabefd66fbab577700035f36ba01b9268438b1223423a30e399c1efaed92858586722a0dfa6d7d1a180a4ff0870c894ac730fde
+  data.tar.gz: 1799bbf948a1725f99b567b0934c29eb53f3361db5c22c660e616e876cc857c15c85330db3d2e60df4a6d5f1c0c9697722e1ded6b114897cbe8b5a257fd06511

data/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file.
 
-## [3.0.8] - 2024-08-xx
+## [3.0.9] - 2024-08-xx
 
 ### Added
 
@@ -10,6 +10,22 @@ All notable changes to this project will be documented in this file.
 
 ### Fixed
 
+## [3.0.8] - 2024-08-30
+
+### Added
+
+- options to choose `-batch-mode` [`:batch`|`:job`]
+
+### Changed
+
+- When `-skip-api-policies`
+  - Default policy: to skip non generic logic when api policies are skept
+  - Still run default policies
+
+### Fixed
+
+- unknown option `suggestions`
+
 ## [3.0.7] - 2024-08-27
 
 ### Added

data/Rakefile

@@ -19,6 +19,11 @@ RSpec::Core::RakeTask.new(:spec_fast) do |task|
 end
 task(rspec_fast: :spec_fast)
 
+desc "run rubocop diaplying cop names"
+RuboCop::RakeTask.new(:rubocop) do |t|
+  t.options = ['--display-cop-names']
+end
+
 # default task name is yard
 desc "Yard: generate all the documentation"
 YARD::Rake::YardocTask.new(:doc) do |t|

data/eco-helpers.gemspec

@@ -1,3 +1,4 @@
+# rubocop:disable Gemspec/DevelopmentDependencies
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
@@ -54,3 +55,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'roo-xls',       '>= 1.2.0',  '< 1.3'
   spec.add_dependency 'rubyzip',       '>= 2.3.2',  '< 2.4'
 end
+
+# rubocop:enable Gemspec/DevelopmentDependencies

data/lib/eco/api/policies/default_policies/99_user_access_policy.rb

@@ -14,8 +14,10 @@ class Eco::API::Policies::DefaultPolicies::UserAccess < Eco::API::Common::Loader
     self.account_removed_count = 0
 
     people.each do |person|
-      remove_account_when_no_email!(person) if person.email.to_s.empty?
-      next unless account = person.account
+      remove_account_when_no_email!(person)
+
+      next if options.dig(:skip, :api_policies)
+      next unless (account = person.account)
       next if options.dig(:exclude, :account)
 
       add_def_policy_group_if_applicable!(account)
@@ -35,6 +37,7 @@ class Eco::API::Policies::DefaultPolicies::UserAccess < Eco::API::Common::Loader
   end
 
   def remove_account_when_no_email!(person)
+    return unless person.email.to_s.empty?
     return unless person.account
 
     self.account_removed_count += 1 if had_account?(person)

data/lib/eco/api/policies.rb

@@ -15,8 +15,10 @@ module Eco
       end
 
       def add(policy)
-        raise "Expected Eco::API::Policies::Policy object. Given: #{policy}" unless policy.is_a?(Eco::API::Policies::Policy)
-        super(policy)
+        msg = "Expected Eco::API::Policies::Policy object. Given: #{policy}"
+        raise ArgumentError, msg unless policy.is_a?(Eco::API::Policies::Policy)
+
+        super
       end
 
       def launch(people:, session:, job:, options: {})

data/lib/eco/api/session/batch/job.rb

@@ -350,9 +350,12 @@ module Eco
           # Applies the changes introduced by api policies
           def apply_policies(pre_queue)
             people(pre_queue).tap do |entries|
-              next if options.dig(:skip, :api_policies)
+              if options.dig(:skip, :api_policies)
+                policies = session.default_policies
+              else
+                policies = session.policies
+              end
 
-              policies = session.policies
               next if policies.empty?
 
               policies.launch(

data/lib/eco/api/session/batch.rb

@@ -12,6 +12,16 @@ module Eco
           end
         end
 
+        # @return [Symbol] the batch mode to run
+        def batch_mode(opts = self.options)
+          opts.dig(:workflow, :batch, :mode) || :batch
+        end
+
+        # @return [Boolean] are we running in `:job` mode?
+        def job_mode?(opts = self.options)
+          batch_mode(opts) == :job
+        end
+
         # Gets the _people_ of the organization according `params`.
         #   If `people` is not `nil`, scopes to only the people specified.
         # @note
@@ -113,6 +123,11 @@ module Eco
           )
         end
 
+        # Default way to retrieve options (unless provided)
+        def options
+          ASSETS.cli.options
+        end
+
         def launch_batch( # rubocop:disable Metrics/AbcSize
           data,
           method:,
@@ -120,7 +135,8 @@ module Eco
           job_mode:   true, # rubocop:disable Lint/UnusedMethodArgument
           per_page:   DEFAULT_BATCH_BLOCK,
           people_api: api&.people,
-          silent:     false
+          silent:     false,
+          options:    self.options
         )
           iteration  = 1
           done       = 0
@@ -145,7 +161,7 @@ module Eco
 
               start_slice = Time.now
               offer_retry_on(Ecoportal::API::Errors::TimeOut) do
-                people_api.batch(job_mode: false) do |batch|
+                people_api.batch(job_mode: job_mode?(options)) do |batch|
                   slice.each do |person|
                     batch.public_send(method, person) do |response|
                       faltal("Request with no response") unless response

data/lib/eco/api/session/config.rb

@@ -365,6 +365,7 @@ module Eco
         # @return [Eco::API::Policies]
         def policies
           @policies = self["policies"] ||= Eco::API::Policies.new
+
           if block_given?
             yield(@policies)
             self

data/lib/eco/api/session.rb

@@ -252,11 +252,15 @@ module Eco
       # @return [Eco::API::Policies]
       def policies
         @policies ||= config.policies.dup.tap do |policies|
-          default_policies = Eco::API::Policies::DefaultPolicies.new
           policies.merge(default_policies)
         end
       end
 
+      # The native policies
+      def default_policies
+        @default_policies ||= Eco::API::Policies::DefaultPolicies.new
+      end
+
       # Set of helpers to simplify your code
       # @see Eco::API::MicroCases
       # @return [Eco::API::MicroCases]

data/lib/eco/assets.rb

@@ -1,6 +1,5 @@
 module Eco
   class Assets
-
     attr_reader :active_config
 
     def initialize
@@ -17,10 +16,12 @@ module Eco
 
     def config(key: active_config, update_active: true)
       configs[:default] ||= Eco::API::Session::Config.new(key)
+
       unless configs.key?(key)
-        @active_config = key unless !update_active
+        @active_config = key if update_active
         configs[key]   = configs[:default].clone(key)
       end
+
       configs[key].tap do |config|
         config.active_api(key) if config.apis.defined?(key)
         yield(config) if block_given?
@@ -36,6 +37,7 @@ module Eco
         @cli_init = true
         require_relative('cli_default')
       end
+
       @cli.tap { yield(@cli) if block_given? }
     end
   end

data/lib/eco/cli/scripting/args_helpers.rb

@@ -2,6 +2,8 @@ module Eco
   class CLI
     class Scripting
       module ArgsHelpers
+        class UnknownArgument < ArgumentError; end
+
         # @return [Array<String] the command line arguments.
         def argv
           @argv || ARGV
@@ -31,7 +33,8 @@ module Eco
           }
           unknown = arguments.unknown(**args) do |key, correct|
             next suggestions[key] = correct unless correct.empty?
-            suggstions[key] = '-- not known similar options! --'
+
+            suggestions[key] = ['-- not known similar options! --']
           end
           unknown = unknown.select {|arg| is_modifier?(arg)} if only_options
 
@@ -49,7 +52,7 @@ module Eco
           msg << "\nUse 'ruby main.rb -org [-usecase] --help -options' for more information"
           msg << "\n  - Please, remember that use case specific options "
           msg << "should come after the use case in the command line.\n"
-          raise msg
+          raise UnknownArgument, msg
         end
 
         # @return [Boolean] if `key` is in the command line.

data/lib/eco/cli_default/options.rb

@@ -27,7 +27,7 @@ ASSETS.cli.config do |cnf| # rubocop:disable Metrics/BlockLength
         puts conf.usecases.help(refine: huc)
       end
 
-      puts [
+      help_str = [
         "Please specify one of the below:",
         "  -filters       to display available filters on people",
         "  -input-filters to display available filters on input data",
@@ -36,7 +36,9 @@ ASSETS.cli.config do |cnf| # rubocop:disable Metrics/BlockLength
         "TIPS:",
         "  * You may specify the usecase to know its specific options by:    -usecase_name --help -options",
         "  * You may specify a refinement to show specific information only: --help -usecases tags"
-      ].join("\n") unless hpf || hif || ho || huc
+      ].join("\n")
+
+      puts help_str unless hpf || hif || ho || huc
       exit
     end
 
@@ -151,6 +153,26 @@ ASSETS.cli.config do |cnf| # rubocop:disable Metrics/BlockLength
       session.config.dry_run!
     end
 
+    desc = "It specifies the type of batch to be used (default: ':batch')"
+    options_set.add("-batch-mode", desc) do |options, session|
+      mode_in  = SCR.get_arg("-batch-mode", with_param: true)
+      mode_str = mode_in.to_s.downcase
+      mode_sym = %i[batch job].find do |md|
+        next true if md.to_s == mode_str
+
+        md.to_s == mode_str.gsub(':', '')
+      end
+
+      unless mode_sym
+        session.log(:warn) {
+          "Unknown job_mode: #{mode_in}. Switching to default: ':batch'"
+        }
+        mode_sym = :batch
+      end
+
+      options.deep_merge!(workflow: {batch: {mode: mode_sym}})
+    end
+
     desc = "Runs runs post_launch cases even if in dry-run"
     options_set.add("-run-postlaunch", desc) do |options, session|
       options.deep_merge!(post_launch: {run: true})

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = '3.0.7'.freeze
+  VERSION = '3.0.8'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 3.0.7
+  version: 3.0.8
 platform: ruby
 authors:
 - Oscar Segura
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-26 00:00:00.000000000 Z
+date: 2024-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -922,7 +922,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
+rubygems_version: 3.5.18
 signing_key:
 specification_version: 4
 summary: eco-helpers to manage people api cases