eco-helpers 3.0.4 → 3.0.7

data/lib/eco/api/usecases/graphql/helpers/base/error_handling.rb

@@ -0,0 +1,52 @@
+module Eco::API::UseCases::GraphQL::Helpers::Base
+  # Basic stuff you would need in any use case
+  module ErrorHandling
+    include Eco::Language::AuxiliarLogger
+
+    attr_reader :exception
+
+    private
+
+    def interrupted?(err = exception)
+      interrupt_errors.any? {|klass| err.is_a?(klass)}
+    end
+
+    def error_raised?
+      exception && !interrupted?
+    end
+
+    def rescued
+      yield
+    rescue StandardError => err
+      self.exception ||= err
+      log(:error) { err.patch_full_message }
+    end
+
+    def with_error_handling
+      @exception = nil
+      yield
+    rescue SystemExit => sext
+      @exception = sext
+      exit sext.status
+    rescue *interrupt_errors => int
+      @exception = int
+      raise
+    rescue SystemStackError
+      puts $! # rubocop:disable Style/SpecialGlobalVars
+      puts caller[0..100]
+      raise
+    rescue StandardError, SignalException => err
+      @exception = err
+      raise
+    end
+
+    def interrupt_errors
+      return @interrupt_errors if @interrupt_errors
+
+      errs = [Interrupt]
+      errs << IRB::Abort if Object.const_defined?(:IRB) && IRB.const_defined?(:Abort)
+
+      @interrupt_errors = errs
+    end
+  end
+end

data/lib/eco/api/usecases/graphql/helpers/base.rb

@@ -1,5 +1,6 @@
 module Eco::API::UseCases::GraphQL::Helpers
   module Base
+    require_relative 'base/error_handling'
     require_relative 'base/case_env'
     require_relative 'base/graphql_env'
 

data/lib/eco/api/usecases/graphql/helpers/location/base/classifications_parser.rb

@@ -10,7 +10,9 @@ module Eco::API::UseCases::GraphQL::Helpers::Location
       #   2. If the value is wrong, it warns and returns `nil`
       def to_classification(value)
         return nil unless node_classifications?
+
         raise ArgumentError, "Expecting a single element. Given: #{value.class}" if value.is_a?(Enumerator)
+
         return nil unless value.is_a?(String)
 
         node_classifications.to_id(value).tap do |type|
@@ -28,7 +30,9 @@ module Eco::API::UseCases::GraphQL::Helpers::Location
       #   2. If the value is wrong, it warns and returns `nil`
       def to_classification_name(value)
         return nil unless node_classifications?
+
         raise ArgumentError, "Expecting a single element. Given: #{value.class}" if value.is_a?(Enumerator)
+
         return nil unless value.is_a?(String)
 
         node_classifications.to_name(value) do |name|
@@ -46,6 +50,7 @@ module Eco::API::UseCases::GraphQL::Helpers::Location
 
       def unknown_clasification!(value)
         return if unknown_classifications.include?(value)
+
         unknown_classifications << value
         log(:warn) {
           "Unknown location node classification '#{value}'"

data/lib/eco/api/usecases/graphql/helpers/location/command/diffs/stages/commandable.rb

@@ -12,6 +12,7 @@ class Eco::API::UseCases::GraphQL::Helpers::Location::Command::Diffs
       module ClassMethods
         def stage_command(stage)
           return :update if stage == :id_name
+
           stage
         end
       end
@@ -37,6 +38,7 @@ class Eco::API::UseCases::GraphQL::Helpers::Location::Command::Diffs
 
       def stage_diffs(stage)
         raise "There is NO support for stage '#{stage}'. Please review" unless respond_to?(stage)
+
         sort_diffs(stage) do
           send(stage)
         end

data/lib/eco/api/usecases/graphql/helpers/location/command/diffs/stages/diff_sortable.rb

@@ -20,6 +20,7 @@ class Eco::API::UseCases::GraphQL::Helpers::Location::Command::Diffs
       # @yieldreturn [Array<Diff>] the raw diffs of `stage`
       def sort_diffs(stage)
         raise ArgumentError, "Expecting block but not given" unless block_given?
+
         raw_diffs = yield
 
         case stage
@@ -41,6 +42,7 @@ class Eco::API::UseCases::GraphQL::Helpers::Location::Command::Diffs
       def uniq_archive_token(raw_diffs, stage)
         raw_diffs.group_by(&:archived_token_prev).each_with_object([]) do |(token, token_diffs), out|
           next out.concat(token_diffs) unless token
+
           out << sort_top_to_bottom(token_diffs, stage).first
         end
       end

data/lib/eco/api/usecases/graphql/helpers/location/command/result.rb

@@ -58,7 +58,8 @@ module Eco::API::UseCases::GraphQL::Helpers::Location::Command
     end
 
     def command_id
-      return nil unless result
+      return unless result
+
       command_result["id"]
     end
 

data/lib/eco/api/usecases/graphql/helpers/location/command/results.rb

@@ -124,14 +124,17 @@ module Eco::API::UseCases::GraphQL::Helpers::Location::Command
     # First error is relevant only if request was NOT forced to continue.
     def first_err_str
       return '' if force?
+
       pre_str = 'stopped on node'
       pre_str = 'first error' unless force?
+
       "(#{pre_str}: '#{first_errored&.node_id}' - idx: #{first_errored_idx})"
     end
 
     # Last successfully applied is relevant only if request was NOT forced to continue.
     def last_okay_str
       return '' if force?
+
       "(last node done: '#{last_applied&.node_id}' - idx: #{last_applied_idx})"
     end
   end

data/lib/eco/api/usecases/graphql/helpers/location/command.rb

@@ -36,6 +36,7 @@ module Eco::API::UseCases::GraphQL::Helpers::Location
         msg  = "#{dry_run_msg}No commands for '#{desc}'."
         msg << " Skipping batch..." unless simulate?
         log(:info) { msg }
+
         return
       end
 

data/lib/eco/api/usecases/graphql/helpers/location/tags_remap.rb

@@ -21,6 +21,7 @@ module Eco::API::UseCases::GraphQL::Helpers::Location
     def to_csv(filename)
       CSV.open(filename, "w") do |fd|
         fd << %w[src_tags dst_tags]
+
         each do |tags_map|
           fd << tags_map.to_csv_row
         end
@@ -64,12 +65,14 @@ module Eco::API::UseCases::GraphQL::Helpers::Location
 
     def <<(pair)
       raise ArgumentError, "Expecting pair of Array in Array. Given: #{pair}" unless self.class.correct_pair?(pair)
+
       add(*pair)
     end
 
     def add(from, to)
       raise ArgumentError, "Expecting Array. Given: #{from.class}" unless from.is_a?(Array)
       raise ArgumentError, "Expecting Array. Given: #{to.class}"   unless to.is_a?(Array)
+
       new_src TagsMap.new(from, to)
     end
 

data/lib/eco/api/usecases/graphql/samples/location/command/dsl.rb

@@ -24,38 +24,39 @@ class Eco::API::UseCases::GraphQL::Samples::Location
 
     # Main processor
     def process # rubocop:disable Metrics/AbcSize
-      self.error     = false
-      self.exception = nil
+      self.error = false
 
-      super if defined?(super)
+      with_error_handling do
+        super if defined?(super)
 
-      # this may trigger a backup of the tagtree
-      self.current_tree ||= live_tree
+        # this may trigger a backup of the tagtree
+        self.current_tree ||= live_tree
 
-      inputs(force_continue: force_continue?) do |input, stage|
-        results[stage] ||= []
+        inputs(force_continue: force_continue?) do |input, stage|
+          results[stage] ||= []
 
-        track_mode = batch_tree_track_mode(stage)
+          track_mode = batch_tree_track_mode(stage)
 
-        # yields the result of each batch
-        sliced_batches(input, desc: stage, track_tree_mode: track_mode) do |sliced_input, response, page, pages, done, total| # rubocop:disable Metrics/ParameterLists, Layout/LineLength
-          track_current_tree(response&.structure)
+          # yields the result of each batch
+          sliced_batches(input, desc: stage, track_tree_mode: track_mode) do |sliced_input, response, page, pages, done, total| # rubocop:disable Metrics/ParameterLists, Layout/LineLength
+            track_current_tree(response&.structure)
 
-          results[stage] << (page_results = request_results_class.new(sliced_input, response))
-          update_tags_remap_table(page_results, stage, current_tree)
+            results[stage] << (page_results = request_results_class.new(sliced_input, response))
+            update_tags_remap_table(page_results, stage, current_tree)
+
+            self.error = page_errors?(page_results, page, pages, done, total, stage: stage)
+            break if error
+          end
 
-          self.error = page_errors?(page_results, page, pages, done, total, stage: stage)
           break if error
         end
-
-        break if error
       end
     rescue SystemStackError
       puts $! # rubocop:disable Style/SpecialGlobalVars
       puts caller[0..100]
       raise
-    rescue StandardError => e
-      log(:error) { self.exception ||= e.patch_full_message }
+    rescue StandardError => err
+      log(:error) { err.patch_full_message }
       raise
     ensure
       rescued { self.tags_remap_csv_file = generate_tags_remap_csv }

data/lib/eco/api/usecases/graphql/samples/location/command/results.rb

@@ -3,13 +3,7 @@ class Eco::API::UseCases::GraphQL::Samples::Location
   module Command::Results
     include Eco::API::UseCases::GraphQL::Helpers::Base::CaseEnv
 
-    attr_accessor :error, :exception
-
-    def rescued
-      yield
-    rescue StandardError => e
-      log(:error) { self.exception ||= e.patch_full_message }
-    end
+    attr_accessor :error
 
     def request_results_class
       Eco::API::UseCases::GraphQL::Helpers::Location::Command::Results

data/lib/eco/api/usecases/graphql/samples/location/command/service/tree_update.rb

@@ -7,7 +7,7 @@ class Eco::API::UseCases::GraphQL::Samples::Location
 
       class << self
         def included(base)
-          super(base)
+          super
           base.send :include, Eco::API::UseCases::GraphQL::Samples::Location::Service::TreeDiff
           base.send :include, Eco::API::UseCases::GraphQL::Samples::Location::Command::DSL
           base.send :include, Eco::API::UseCases::GraphQL::Utils::Sftp
@@ -17,9 +17,11 @@ class Eco::API::UseCases::GraphQL::Samples::Location
 
       module InstanceMethods
         def process
-          super
+          with_error_handling do
+            super
+          end
         ensure
-          rescued { re_archive }
+          rescued { re_archive } unless error_raised?
           rescued { email_digest('TagTree Update') }
         end
 
@@ -28,6 +30,8 @@ class Eco::API::UseCases::GraphQL::Samples::Location
         # @note this is an additional necessary step
         def re_archive
           return if simulate?
+          return if error_raised?
+
           stage = :rearchive
 
           nodes_diff_class.new(
@@ -75,6 +79,7 @@ class Eco::API::UseCases::GraphQL::Samples::Location
         #   2. `REMOTE_FOLDER` const
         def close_handling_tags_remap_csv
           return false unless super
+
           upload(tags_remap_csv_file) unless remote_subfolder.nil?
           true
         end
@@ -83,9 +88,9 @@ class Eco::API::UseCases::GraphQL::Samples::Location
           return if simulate?
           return if options.dig(:workflow, :no_email)
 
-          digest_msgs = logger.cache.logs(level: %i[info error warn])
-          exception   = exception ? " - Exception!" : ''
-          subject     = "#{config.active_enviro} - #{title}#{exception}"
+          digest_msgs   = logger.cache.logs(level: %i[info error warn])
+          str_exception = exception ? " - Exception!" : ''
+          subject       = "#{config.active_enviro} - #{title}#{str_exception}"
           session.mail(subject: subject, body: digest_msgs.join)
         end
 

data/lib/eco/api/usecases/graphql/samples/location/command/track_changed_ids.rb

@@ -58,22 +58,17 @@ class Eco::API::UseCases::GraphQL::Samples::Location
         next if prev_id == new_id
 
         tags_remap_table << [[prev_id], [new_id]]
-
-        # next unless ref_tree.is_a?(Eco::API::Organization::TagTree)
-        # next unless ref_tree.tag?(new_id)
-
-        # msg  = "Node '#{prev_id}' was updated to '#{new_id}', "
-        # msg << "but in current structure '#{new_id}' is not present"
-        # log(:warn) { msg }
       end
     end
 
     # Generates the final tags remap file
     def generate_tags_remap_csv(filename = tags_remap_csv_full_filename)
-      return nil if tags_remap_table.empty?
+      return if tags_remap_table.empty?
+
       timestamp_file(filename).tap do |file|
         CSV.open(file, 'w') do |csv|
           csv << %w[prev_node_ids new_node_ids]
+
           tags_remap_table.each do |tags_remap|
             csv << tags_remap.to_csv_row
           end

data/lib/eco/api/usecases/graphql/samples/location/service/tree_diff/convertible/parsing/classifications.rb

@@ -13,6 +13,7 @@ module Eco::API::UseCases::GraphQL::Samples::Location::Service
 
           def transform_classifications(row)
             return row if node_classifications_maping.empty?
+
             row['classifications'] = into_a(row['classifications']).map do |type|
               node_classifications_map(type)
             end.join('|')
@@ -21,6 +22,7 @@ module Eco::API::UseCases::GraphQL::Samples::Location::Service
           # Helper to map classifications
           def node_classifications_map(value)
             return value unless node_classifications_maping.key?(value)
+
             node_classifications_maping[value]
           end
 

data/lib/eco/api/usecases/graphql/samples/location/service/tree_diff/convertible.rb

@@ -8,7 +8,7 @@ module Eco::API::UseCases::GraphQL::Samples::Location::Service
     module Convertible
       class << self
         def included(base)
-          super(base)
+          super
           base.send :include, Inputable
         end
       end
@@ -24,12 +24,15 @@ module Eco::API::UseCases::GraphQL::Samples::Location::Service
 
           csv.transform_headers do |name|
             next name unless header_maps.key?(name)
+
             header_maps[name]
           end
         end.then do |csv|
           transform_input_csv(csv).tap do |res|
             next if res.is_a?(Eco::CSV::Table)
-            raise ArgumentError, "Expecting and Eco::CSV::Table. Given: #{res.class}"
+
+            msg = "Expecting and Eco::CSV::Table. Given: #{res.class}"
+            raise ArgumentError, msg
           end
         end
       end

data/lib/eco/api/usecases/graphql/samples/location/service/tree_diff.rb

@@ -46,13 +46,15 @@ module Eco::API::UseCases::GraphQL::Samples
 
       class << self
         def included(base)
-          super(base)
+          super
           base.send :include, Convertible
         end
       end
 
       def process
-        compare
+        with_error_handling do
+          compare
+        end
       end
 
       def compare
@@ -92,7 +94,9 @@ module Eco::API::UseCases::GraphQL::Samples
 
       def live_nodes_list
         @live_nodes_list ||= as_nodes_json(input_tagtree).tap do |list|
-          log(:info) { "Converted live tree to list of #{list.count} hash-nodes" }
+          log(:info) {
+            "Converted live tree to list of #{list.count} hash-nodes"
+          }
         end
       end
 
@@ -103,7 +107,9 @@ module Eco::API::UseCases::GraphQL::Samples
       #   2. `org_tree` is native from `Eco::Data::Locations::NodeBase::CsvConvert`
       def file_nodes_list
         @file_nodes_list ||= as_nodes_json(file_tree).tap do |list|
-          log(:info) { "Converted input csv file to list of #{list.count} hash-nodes" }
+          log(:info) {
+            "Converted input csv file to list of #{list.count} hash-nodes"
+          }
         end
       end
 

data/lib/eco/api/usecases/graphql/samples/location/service/tree_to_list/converter/parser.rb

@@ -12,8 +12,10 @@ module Eco::API::UseCases::GraphQL::Samples::Location::Service
 
         def node_parser_block
           return @node_parser_block if instance_variable_defined?(:@node_parser_block)
+
           custom_before = custom_node_parser_before_block
           custom_after  = custom_node_parser_block
+
           @node_parser_block = proc do |node_hash, node|
             node_hash.tap do
               custom_before&.call(node_hash, node)
@@ -25,12 +27,14 @@ module Eco::API::UseCases::GraphQL::Samples::Location::Service
 
         # Grabs the custom node parser that runs after the generic one
         def custom_node_parser_block
-          return nil unless respond_to?(:custom_node_parser, true)
+          return unless respond_to?(:custom_node_parser, true)
+
           method(:custom_node_parser)
         end
 
         def custom_node_parser_before_block
-          return nil unless respond_to?(:custom_node_parser_before, true)
+          return unless respond_to?(:custom_node_parser_before, true)
+
           method(:custom_node_parser_before)
         end
 

data/lib/eco/api/usecases/graphql/samples/location/service/tree_to_list/converter.rb

@@ -22,9 +22,11 @@ module Eco::API::UseCases::GraphQL::Samples::Location::Service
         end.each_with_object([]) do |node, list|
           list << node.as_json(include_children: false).transform_keys do |key|
             next key unless node_attr_maps.key?(key)
+
             node_attr_maps[key]
           end.tap do |node_hash|
             node_parser_block&.call(node_hash, node)
+
             yield(node_hash, node) if block_given?
           end
         end.compact.reject(&:empty?)

data/lib/eco/api/usecases/graphql/samples/location/service/tree_to_list.rb

@@ -31,10 +31,12 @@ module Eco::API::UseCases::GraphQL::Samples
       include Converter
 
       def process
-        as_nodes_json(input_tagtree).tap do |list|
-          next generate_live_nodes_file(list) unless list.empty?
+        with_error_handling do
+          as_nodes_json(input_tagtree).tap do |list|
+            next generate_live_nodes_file(list) unless list.empty?
 
-          log(:error) { "There are no location nodes!" }
+            log(:error) { "There are no location nodes!" }
+          end
         end
       end
     end

data/lib/eco/api/usecases/ooze_cases/export_register_case.rb

@@ -41,6 +41,7 @@ class Eco::API::UseCases::OozeCases::ExportRegisterCase < Eco::API::UseCases::Oo
   def build_tags_filter(mode = :any)
     tags = option_tags(mode)
     return nil if !tags || tags.empty?
+
     tags_filter(tags, any: mode == :any)
   end
 

data/lib/eco/api/usecases/ooze_samples/helpers_migration/copying.rb

@@ -1,16 +1,21 @@
+# rubocop:disable Lint/DuplicateBranch
 class Eco::API::UseCases::OozeSamples
   module HelpersMigration
     module Copying
+      include Eco::Language::AuxiliarLogger
+
       def session
         defined?(super)? super : @session
       end
 
-      def logger
-        session.logger
-      end
-
       def copy_generic_paired_fields(src, dst, src_excluded: [], dst_excluded: [], exclude_ximport: false)
-        HelpersMigration::TypedFieldsPairing.new(src, dst, src_excluded: src_excluded, dst_excluded: dst_excluded, exclude_ximport: false).tap do |pairing|
+        HelpersMigration::TypedFieldsPairing.new(
+          src,
+          dst,
+          src_excluded:    src_excluded,
+          dst_excluded:    dst_excluded,
+          exclude_ximport: exclude_ximport
+        ).tap do |pairing|
           pairing.each_pair do |src_fld, dst_fld|
             copy_field_content(src_fld, dst_fld)
             yield(src_fld, dst_fld, pairing) if block_given?
@@ -21,18 +26,35 @@ class Eco::API::UseCases::OozeSamples
       def copy_hooked_fields(src, dst, hook:, type:, fields_tracker: nil, src_excluded: [], dst_excluded: [])
         case hook
         when String
-          with_src_dst_field_pair(src, dst, label: to_regex(hook), type: type, src_excluded: src_excluded, dst_excluded: dst_excluded) do |src_fld, dst_fld|
-            copy_field_content(src_fld, dst_fld).tap do |result|
-              fields_tracker.resolve(src_fld, dst_fld) if fields_tracker
+          with_src_dst_field_pair(
+            src,
+            dst,
+            label:        to_regex(hook),
+            type:         type,
+            src_excluded: src_excluded,
+            dst_excluded: dst_excluded
+          ) do |src_fld, dst_fld|
+            copy_field_content(src_fld, dst_fld).tap do
+              fields_tracker&.resolve(src_fld, dst_fld)
               yield(src_fld, dst_fld, fields_tracker) if block_given?
             end
           end
         when Hash
           hook.each do |hook_src, hook_dst|
-            src_lab, dst_lab = to_regex(hook_src), to_regex(hook_dst)
-            with_src_dst_field_pair(src, dst, label: src_lab, label_dst: dst_lab, type: type, src_excluded: src_excluded, dst_excluded: dst_excluded) do |src_fld, dst_fld|
-              copy_field_content(src_fld, dst_fld).tap do |result|
-                fields_tracker.resolve(src_fld, dst_fld) if fields_tracker
+            src_lab = to_regex(hook_src)
+            dst_lab = to_regex(hook_dst)
+
+            with_src_dst_field_pair(
+              src,
+              dst,
+              label:        src_lab,
+              label_dst:    dst_lab,
+              type:         type,
+              src_excluded: src_excluded,
+              dst_excluded: dst_excluded
+            ) do |src_fld, dst_fld|
+              copy_field_content(src_fld, dst_fld).tap do
+                fields_tracker&.resolve(src_fld, dst_fld)
                 yield(src_fld, dst_fld, fields_tracker) if block_given?
               end
             end
@@ -46,60 +68,72 @@ class Eco::API::UseCases::OozeSamples
 
       # @note
       #   - When used with `type: nil` it may pair fields of different type. There isn't refinement for this yet.
-      def with_src_dst_field_pair(src, dst, label: nil, label_dst: label, type: nil, src_excluded: [], dst_excluded: [])
-        unless respond_to?(:with_fields, true)
-          raise "These helpers are to be included in class cases inheriting from Eco::API::UseCases::OozeSamples::RegisterUpdateCase"
-        end
+      def with_src_dst_field_pair(src, dst, label: nil, label_dst: label, type: nil, src_excluded: [], dst_excluded: []) # rubocop:disable Metrics/AbcSize
+        msg = "These helpers are to be included in class cases inheriting from Eco::API::UseCases::OozeSamples::RegisterUpdateCase"
+        raise msg unless respond_to?(:with_fields, true)
+
         src_flds = with_fields(src, label: label, type: type)
         dst_flds = with_fields(dst, label: label_dst, type: type)
-        src_fld, dst_fld = src_flds.first, dst_flds.first
+        src_fld  = src_flds.first
+        dst_fld  = dst_flds.first
 
         # Not found
         if dst_flds.empty? || src_flds.empty?
-          msg = "There isn't a '#{type}'"
+          msg     = "There isn't a '#{type}'"
           dst_msg = dst_flds.empty?? "destination field named '#{label_dst}'" : nil
           src_msg = src_flds.empty?? "source field named '#{label}'" : nil
-          msg << " #{[dst_msg, src_msg].join(" or ")} (source: '#{src.id}')"
-          logger.warn(msg)
+          msg    << " #{[dst_msg, src_msg].join(" or ")} (source: '#{src.id}')"
+
+          log(:warn) { msg }
           return nil, nil
         end
 
         # Fields exclusion
         dst_flds -= dst_excluded unless dst_excluded.empty?
         src_flds -= src_excluded unless src_excluded.empty?
-        src_fld, dst_fld = src_flds.first, dst_flds.first
+
+        src_fld = src_flds.first
+        dst_fld = dst_flds.first
+
         return src_fld, dst_fld if dst_flds.empty? || src_flds.empty?
 
         if dst_flds.count > 1
-          logger.warn("There are #{dst_flds.count} destination '#{type}' fields named '#{label_dst}' (source: '#{dst.id}'). Using first...")
+          log(:warn) {
+            msg  = "There are #{dst_flds.count} destination '#{type}' fields "
+            msg << "named '#{label_dst}' (source: '#{dst.id}'). Using first..."
+            msg
+          }
         end
 
         if src_flds.count > 1
-          msg = "There are #{src_flds.count} source '#{type}' fields named '#{label}' (source: '#{src.id}'). "
+          msg         = "There are #{src_flds.count} source '#{type}' fields named '#{label}' (source: '#{src.id}'). "
           src_content = src_flds.reject(&:empty?)
+
           if src_content.empty?
             msg << "None with content. Using first..."
           else
             src_fld = src_content.first
+
             if src_content.count == 1
               msg << "Using the only one with content (idx: #{src_flds.index(src_fld)})..."
             else
               msg << "#{src_content.count} have content. Using first..."
             end
           end
-          logger.warn(msg)
+
+          log(:warn) { msg }
         end
 
-        [src_fld, dst_fld].tap do |(src_fld, dst_fld)|
+        [src_fld, dst_fld].tap do
           yield(src_fld, dst_fld) if block_given?
         end
       end
 
-      def copy_field_content(src, dst)
+      def copy_field_content(src, dst) # rubocop:disable Metrics/AbcSize
         type = src.type
         case type
         when "select"
-          src.values.each {|val| dst.select(val)}
+          src.values.each {|val| dst.select(val)} # rubocop:disable Style/HashEachMethods
           dst.other_desc = src.other_desc if src.other && src.other_desc && dst.other
         when "plain_text", "date", "number", "gauge"
           dst.value = src.value
@@ -110,8 +144,9 @@ class Eco::API::UseCases::OozeSamples
         when "people"
           dst.people_ids << src.people_ids.to_a
         when "geo"
-          src_coo, dst_coo = src.coordinates, dst.coordinates
-          dst_coo.lat, dst_coo.lon = src_coo.lat, src_coo.lon
+          src_coo = src.coordinates
+          dst_coo = dst.coordinates
+          dst_coo.lat, dst_coo.lon = src_coo.lat, src_coo.lon # rubocop:disable Style/ParallelAssignment
         when "file"
           src.items.each do |src_item|
             dst.add_file(src_item.file_container_id) do |dst_item|
@@ -149,3 +184,5 @@ class Eco::API::UseCases::OozeSamples
     end
   end
 end
+
+# rubocop:enable Lint/DuplicateBranch