eco-helpers 3.0.4 → 3.0.6

data/lib/eco/api/session/batch/errors.rb

@@ -4,6 +4,8 @@ module Eco
       class Batch
         # Helper object linked to a `Batch::Status`. Its aim is to manage the errors of the batch status.
         class Errors
+          include Eco::Language::AuxiliarLogger
+
           # @attr_reader status [Eco::API::Session::Batch::Status] `batch status` this `Errors` object is associated to.
           attr_reader :status
 
@@ -41,7 +43,7 @@ module Eco
           end
 
           def logger
-            status.logger
+            status.logger || super
           end
           # @!endgroup
 
@@ -84,6 +86,7 @@ module Eco
               next unless (body = response.body)
 
               errs = []
+
               case body
               when Hash
                 body_errs = body["errors"] || body["error"]
@@ -111,6 +114,7 @@ module Eco
 
           def message
             msgs = strs
+
             if msgs.empty?
               "There were no errors for the current batch '#{method}'!! ;)"
             else
@@ -120,10 +124,15 @@ module Eco
 
           def print
             msgs = strs
+
             if msgs.empty?
-              logger.info("There were no errors for the current batch '#{method}'!! ;)")
+              log(:info) {
+                "There were no errors for the current batch '#{method}'!! ;)"
+              }
             else
-              logger.error("There were #{msgs.length} errors:\n" + msgs.join("\n"))
+              msg  = "There were #{msgs.length} errors:\n"
+              msg << msgs.join("\n")
+              log(:error) { msg }
             end
           end
           # @!endgroup
@@ -140,20 +149,29 @@ module Eco
           #   - please, observe that this can only happen if there were repeated entries in the `source_queue`
           # @return [Array<Hash>, Array<Ecoportal::API::V1::Person>, Array<Ecoportal::API::Internal::Person>]
           def entries
-            queue.select.with_index do |query, i|
-              unless (response = status[i])
-                msg  = "Error: query with no response. You might have duplicated entries in your queue.\n"
-                msg += "Queue length: #{queue.length}; Queue elements class: #{queue.first.class}\n"
-                msg += "Query with no response. Person: #{person_ref(query)}\n"
-                queue.map do |entry|
-                  if %i[id external_id email].any? {|attr| (v = get_attr(entry, attr)) && v == get_attr(query, attr)}
-                    msg += "It could be this peson entry (idx: #{to_index(entry)}): #{person_ref(entry)}\n"
-                  end
+            queue.reject.with_index do |query, i|
+              response = status[i]
+
+              next response.success? if response
+
+              msg  = "Error: query with no response. You might have duplicated entries in your queue.\n"
+              msg << "Queue length: #{queue.length}; Queue elements class: #{queue.first.class}\n"
+              msg << "Query with no response. Person: #{person_ref(query)}\n"
+
+              queue.map do |entry|
+                identifiable = %i[id external_id email].any? do |attr|
+                  next false unless (val = get_attr(entry, attr))
+
+                  val == get_attr(query, attr)
                 end
-                raise msg
+
+                next unless identifiable
+
+                msg << "It could be this peson entry (idx: #{to_index(entry)}): "
+                msg << "#{person_ref(entry)}\n"
               end
 
-              !response.success?
+              raise msg
             end
           end
 
@@ -177,21 +195,21 @@ module Eco
           # @param key [Integer, Ecoportal::API::V1::Person]
           # @return [String] the error description.
           def str(key)
-            msg = ""
-            unless status.success?(key)
+            "".tap do |msg|
+              next if status.success?(key)
+
               i        = to_index(key)
               entry    = queue.to_a[i]
               response = status[i]
-              msg      = "Error #{response.status}: #{response.body}\n"
-              msg     += "-- Failed to #{method}. Person: #{person_ref(entry)}"
+              msg     << "Error #{response.status}: #{response.body}\n"
+              msg     << "-- Failed to #{method}. Person: #{person_ref(entry)}"
             end
-            msg
           end
 
           def print_one(key)
             return if status.success?(key)
 
-            logger.error(str(key))
+            log(:error) { str(key) }
           end
         end
       end