eco-helpers 2.0.22 → 2.0.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba43099c7902b3e2623640a196abd86f39215403d28e7a614da78b2422629323
-  data.tar.gz: 7e3701cbeb7b3a0a65453dc002d6f4c5cb6e6ec4103e6cd0178c1af333d29d7d
+  metadata.gz: 2fb1adac01fbf3e34dfc80ca54c8254f660fc12deb3be3b20b395e3fc84fb8a7
+  data.tar.gz: b6d8d61a28333eb7446654589e32725b22c875741df08f9a2401315b6ef6b1b5
 SHA512:
-  metadata.gz: f14ab296c2cff2dc694ef9182593329ca1bc86cf08ca32ba879cd5e74d658d1d123add425bc62a981182b9e4da06b33d225d613cd1a9d9cbfd7284e6b6d24ea5
-  data.tar.gz: f020822ad4ae2e18f1f0424bb3a47417ff9a6bc78a439517cee3cd9212548efe4c89256579d73ccde27709dc5d2ea3d3e74bd072de23d4c089ccf3c7a107fc07
+  metadata.gz: c45a670a64f0e2a725542aa47776800b1a013dbc222a676b1ed813c5cb6aad425b8e0d0b906a06a8fce37fc89de2b329998a0c5ec9861bf2b3de42d10b560b47
+  data.tar.gz: df2f0fc1e776bbdc8dbf8de622944444b84b8b1cf9446002299fbd60d4f062b73e42d1828403996be0f42251d21db27c6bdb227a1d3b9dd979cde4799148915e

data/CHANGELOG.md

@@ -1,6 +1,17 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [2.0.23] - 2021-06-xx
+
+### Added
+  - `Eco::API::Session::Batch::Job` **new** option (`-save-requests`) to save requests even if in `dry-run` (`-simulate`)
+### Changed
+  - `Eco::API::Session::Batch::Job` new people won't create updates unless they have either details or account
+    * because that entry is not supposed to be created unless has account or details
+
+### Fixed
+
+
 ## [2.0.22] - 2021-06-18
 
 ### Added
@@ -25,8 +36,6 @@ All notable changes to this project will be documented in this file.
   - custom `Error` classes now all inherit from `StandardError` (rather than `Exception`)
 
 
-### Fixed
-
 
 ## [2.0.21] - 2021-06-04
 

data/lib/eco/api/session/batch/job.rb

@@ -164,12 +164,17 @@ module Eco
           # @return [Eco::API::Session::Batch::Status]
           def launch(simulate: false)
             pqueue    = processed_queue
-            @requests = pqueue.map {|e| as_update(e)}
+            @requests = as_update(pqueue)
             pre_checks(requests, simulate: simulate)
 
-            unless simulate
+            if simulate
+              if options.dig(:requests, :backup)
+                req_backup = as_update(pqueue, add_feedback: false)
+                backup_update(req_backup, simulate: simulate)
+              end
+            else
               if pqueue.length > 0
-                req_backup = pqueue.map {|e| as_update(e, add_feedback: false)}
+                req_backup = as_update(pqueue, add_feedback: false)
                 backup_update(req_backup)
                 session.batch.launch(pqueue, method: type).tap do |job_status|
                   @status     = job_status
@@ -220,13 +225,26 @@ module Eco
             end.join("\n")
           end
 
-          def as_update(*args)
-            feedback.as_update(*args)
+          def as_update(data, *args)
+            if data.is_a?(Array)
+              data.map do |e|
+                feedback.as_update(e, *args)
+              end.compact.select {|e| e && !e.empty?}
+            else
+              feedback.as_update(data, *args)
+            end
           end
 
           def processed_queue
             @queue.each {|e| @callbacks[e].call(e) if @callbacks.key?(e) }
-            apply_policies(api_included(@queue)).select {|e| !as_update(e).empty?}
+            apply_policies(api_included(@queue)).select do |e|
+              !as_update(e).empty?
+            end.select do |e|
+              next true unless e.is_a?(Ecoportal::API::V1::Person)
+              next true unless e.new?
+              # new people should either have account or details
+              e.account || e.details
+            end
           end
 
           # if there is a config definition to exclude entries
@@ -307,9 +325,10 @@ module Eco
           end
 
           # Keep a copy of the requests for future reference
-          def backup_update(requests)
+          def backup_update(requests, simulate: false)
+            dry_run   = simulate ? "_dry_run" : ""
             dir       = config.people.requests_folder
-            file      = File.join(dir, "#{type}_data.json")
+            file      = File.join(dir, "#{type}_data#{dry_run}.json")
             file_manager.save_json(requests, file, :timestamp)
           end
 

data/lib/eco/cli/config/default/options.rb

@@ -66,6 +66,11 @@ ASSETS.cli.config do |cnf|
       })
     end
 
+    desc = "Saves the requests's body even though running in dry-run (-simulate)"
+    options_set.add("-save-requests", desc) do |options, session|
+      options.deep_merge!(requests: {backup: true})
+    end
+
     desc  = "Used to specify the cache file of people to be used. "
     desc += "It is useful to use as people reference those stored in cached file diffrent to the last one."
     options_set.add("-people-from-backup", desc) do |options, session|

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = "2.0.22"
+  VERSION = "2.0.23"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 2.0.22
+  version: 2.0.23
 platform: ruby
 authors:
 - Oscar Segura