eco-helpers 2.0.10 → 2.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8ca1a088cf60b7608e9f92da680a631c73228ae92fed33484b5669c480350fb
-  data.tar.gz: 6733d55fbdcf24c2766529c275f86f3132f1c3232b4c8d31f34880f9253dbc82
+  metadata.gz: 61ef9270db24cf1582814423b75bc1f3a74bf88cd14281862658c972d1f94f05
+  data.tar.gz: 30ac39b330426fcb8840b7e7456d240e6e7324030aea00b6950328708bbeb53b
 SHA512:
-  metadata.gz: d1cdc2aacd52c590230fe606b079d91e6f3dea01ddbd8857d48170467bbfd089ffa7081c8630aac93ebae4c6e3b8125a446cd7ddc8a6b290c174e906661b2474
-  data.tar.gz: 356ccf7e50d3f0e12f9ad1dde6f1fe7ad4fd13205334f9319cecd45736f110684eb404113512aca4b1d2c49070fe61eb48b1e69c3ae13f423ae8895288ea0d2d
+  metadata.gz: 4dcfa4714c6b245c017194eb6b3fb623702472c260f5717b5485141fb9765fd7e10f891938e65978b7bc13142cc45e06efbc430db9cb63270355f6341e0991d3
+  data.tar.gz: 7cd4382209bef6d5b0db07b2adb90237500050b4ac9340ec39457f7f23d1131bc6562367bc5cf005fdcc4f3af1553dafd446aa02e551549b1bbb90c08e51e15d

data/CHANGELOG.md

@@ -1,7 +1,16 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
-## [2.0.10] - 2021-03-xx
+## [2.0.11] - 2021-03-xx
+
+### Added
+
+### Changed
+
+### Fixed
+  - `Eco::API::Session::Batch:Errors#errors` changed `Array#filter` call to `Array#select` call
+
+## [2.0.10] - 2021-03-26
 
 ### Added
   - `Eco::API::Common::People::PersonParser`

data/lib/eco/api/session/batch/errors.rb

@@ -124,7 +124,7 @@ module Eco
           #   - please, observe that this can only happen if there were repeated entries in the `source_queue`
           # @return [Array<Hash>, Array<Ecoportal::API::V1::Person>, Array<Ecoportal::API::Internal::Person>]
           def entries
-            queue.filter.with_index do |query, i|
+            queue.select.with_index do |query, i|
               unless response = status[i]
                 msg  = "Error: query with no response. You might have duplicated entries in your queue.\n"
                 msg += "Queue length: #{queue.length}; Queue elements class: #{queue.first.class}\n"

data/lib/eco/api/session/batch/feedback.rb

@@ -45,25 +45,22 @@ module Eco
           # @!group Pure feedback methods
 
           # Slightly modifies the behaviour of `Ecoportal::API::Common::BaseModel#as_update`, so schema details fields show the `alt_id`
+          # It also fixes possible patch updates that are incomplete or unnecessary.
           # @note for better feedback
           # @param entry [Hash, Ecoportal::API::V1::Person, Ecoportal::API::Internal::Person]
-          def as_update(entry)
+          # @param add_feedback [Boolean] if `true` it tweak the hash update with additional data.
+          def as_update(entry, add_feedback: true)
             case
             when entry.is_a?(Hash)
               hash = entry
             else #entry.is_a?(Ecoportal::API::V1::Person)
               if only_ids?
-                hash = {
-                  "id"          => entry.id,
-                  "external_id" => entry.external_id,
-                  "email"       => entry.email
-                }
                 hash = entry.as_json.slice("id", "external_id", "email")
               else
                 hash = entry.as_update
-                #if entry.details
-                if hash["details"]
-                  if hfields = hash.dig("details", "fields")
+
+                if add_feedback && details = hash["details"]
+                  if hfields = details["fields"]
                     hfields.each do |fld|
                       fld.merge!("alt_id" => entry.details.get_field(fld["id"]).alt_id)
                     end

data/lib/eco/api/session/batch/job.rb

@@ -169,7 +169,8 @@ module Eco
 
             unless simulate
               if pqueue.length > 0
-                backup_update(requests)
+                req_backup = pqueue.map {|e| as_update(e, add_feedback: false)}
+                backup_update(req_backup)
                 session.batch.launch(pqueue, method: type).tap do |job_status|
                   @status     = job_status
                   status.root = self
@@ -217,7 +218,7 @@ module Eco
             [].tap do |msg|
               subjobs.map {|subjob| msg << subjob.summary}
             end.join("\n")
-          end          
+          end
 
           def as_update(*args)
             feedback.as_update(*args)

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = "2.0.10"
+  VERSION = "2.0.11"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 2.0.10
+  version: 2.0.11
 platform: ruby
 authors:
 - Oscar Segura