eco-helpers 1.3.9 → 1.3.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98e16aec9c1f34feae08b633ec05831ec6435a91b20a8d69afe9ddaedac18480
-  data.tar.gz: 4a843f9036fdebb5468f0129f2c9c1d335f64372883a99d740e3b5ab48298601
+  metadata.gz: 01ec2727fdeee5bc360e417faefdafdb8bf69078cecc17ead881047e8df17cd2
+  data.tar.gz: 67e46501f166224248d6d92e6607cddcbce3806dbd05f41e485d0ca2139f1105
 SHA512:
-  metadata.gz: 247f9baee2ff73214afab58a892b0f56eef831306f52a088b7499083a97ca1e5c6b1d2ec3316e3cc428e97a8797a79f24f9ce7bb355d7093170792e60682c9fc
-  data.tar.gz: 74e2bbe2a950d760cbac18dd88631980b03e6d43406c4abf112f5adc4e6b74d8f3053717851866d1d9868a629d15f59c0768e1dfd923d1e26dcacebbd757c1fb
+  metadata.gz: cd26851249e2c8557f9da3399f72292cb46a2c12db530f12e3da2a88120dc08a6e0a6ee053527b91685cd60e532d2bbd76e156f1fc803dc6bf2c1246a21fac27
+  data.tar.gz: 4f199963c86259bb5a210dca09aa1af2b83c9489308afd200986d6d5c13f32d3479fb2eeaad19c397882359dd3ef16892dc7449860879e2a71fdbf8f73e34943

data/CHANGELOG.md

@@ -1,6 +1,51 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [1.3.14] - 2020-06-10
+
+### Added
+  - `Eco::API::Common::People::SupervisorHelpers` now has its methods as class methods
+### Changed
+  - upgraded `ecoportal-api` gem dependency to minimum version `0.5.6`
+### Fixed
+
+
+## [1.3.13] - 2020-05-29
+
+### Added
+### Changed
+### Fixed
+  - `Eco::API::Organization::TagTree#tag?` to accept `nil` by returning `false`
+  - `Eco::API::Common::People::DefaultParsers::DateParser` will parse to `Date` class
+    * it was parsing to `Time` class, while the native gem `ecoportal-api` parses as `Date` ([reference](https://gitlab.com/ecoPortal/ecoportal-api/-/blob/master/lib/ecoportal/api/v1/schema_field.rb))
+## [1.3.11] - 2020-05-19
+
+### Added
+### Changed
+  - stop using `email` as `external_id` on `People#person` & `People#find`
+    * this should result in more accurate searches when using `:strict` options
+### Fixed
+
+
+## [1.3.11] - 2020-05-12
+
+### Added
+### Changed
+  - remove popping up comments on `Eco::API::Organization::PolicyGroups#`
+### Fixed
+
+
+## [1.3.10] - 2020-05-12
+
+### Added
+  - `Eco::API::Organization::PolicyGroups#to_name` added support for `Array` input
+  - `config.people.default_usergroup`, when defined, will have effect on usecases: `update` (this case was missing the change)
+    * on account creation, if the input file did not specify `policy_group_ids`
+
+### Changed
+### Fixed
+  - `upsert`, `hris` and `create` usecases: fixed condition for use of default_usergroup
+
 ## [1.3.9] - 2020-05-12
 
 ### Added
@@ -8,7 +53,7 @@ All notable changes to this project will be documented in this file.
 ### Fixed
 
 - `usecase` callback was not receiving `usecase` paramater
-  * as a consequence `Batch:Job` created were missing the `usecase`
+  * as a consequence `Batch::Job` created were missing the `usecase`
 
 ## [1.3.8] - 2020-05-07
 

data/eco-helpers.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "yard",      "~> 0.9", ">= 0.9.18"
   s.add_development_dependency "redcarpet", "~> 3.5", ">= 3.5.0"
 
-  s.add_dependency 'ecoportal-api', '~> 0.5',  '>= 0.5.5'
+  s.add_dependency 'ecoportal-api', '~> 0.5',  '>= 0.5.6'
   s.add_dependency 'aws-sdk-s3',    '~> 1.30', '>= 1.30.1'
   s.add_dependency 'aws-sdk-ses',   '~> 1.14', '>= 1.14.0'
   s.add_dependency 'dotenv',        '~> 2.6',  '>= 2.6.0'

data/lib/eco/api/common/people/default_parsers/date_parser.rb

@@ -19,7 +19,7 @@ module Eco
 
             def parse_date(value)
               begin
-                (value.to_s.empty?) ? nil : Time.parse(value)
+                (value.to_s.empty?) ? nil : Date.parse(value)
               rescue
                 nil
               end

data/lib/eco/api/common/people/supervisor_helpers.rb

@@ -7,134 +7,144 @@ module Eco
         #   * `external_id`
         #   * `id`
         module SupervisorHelpers
+          def self.included(base)
+            base.send(:include, ClassMethods)
+          end
 
-          # Reorders as follows:
-          #   1. supervisors, people with no supervisor or where their supervisor not present
-          #   2. subordinates
-          def sort_by_supervisors(values, supervisors_first: true)
-            raise "Expected non hash Enumerable. Given: #{values.class}" if values.is_a?(Hash)
-            return [] unless values && values.is_a?(Enumerable)
-            roam = Proc.new do |tree|
-              [].tap do |out|
-                sub_outs = tree.empty?? [] : tree.map {|sup, subtree| roam.call(subtree)}
-                tree.each do |sup, subtree|
-                  sout = subtree.empty?? [] :roam.call(subtree)
-                  supervisors_first ? sout.unshift(sup) : sout.push(sup)
-                  out.concat(sout)
+          module ClassMethods
+            # Reorders as follows:
+            #   1. supervisors, people with no supervisor or where their supervisor not present
+            #   2. subordinates
+            def sort_by_supervisors(values, supervisors_first: true)
+              raise "Expected non hash Enumerable. Given: #{values.class}" if values.is_a?(Hash)
+              return [] unless values && values.is_a?(Enumerable)
+              roam = Proc.new do |tree|
+                [].tap do |out|
+                  sub_outs = tree.empty?? [] : tree.map {|sup, subtree| roam.call(subtree)}
+                  tree.each do |sup, subtree|
+                    sout = subtree.empty?? [] :roam.call(subtree)
+                    supervisors_first ? sout.unshift(sup) : sout.push(sup)
+                    out.concat(sout)
+                  end
                 end
               end
-            end
 
-            roam.call(supervisors_tree(values))
-          end
+              roam.call(supervisors_tree(values))
+            end
 
-          def tree_to_str(tree, lev: 0)
-            raise "Required Hash tree structure. Given: #{tree.class}" unless tree.is_a?(Hash)
-            "".tap do |str|
-              tree.each do |entry, subtree|
-                str << "#{"  " * lev}+-- #{entry.id || entry.external_id}\n"
-                str << tree_to_str(subtree, lev: lev + 1) unless !subtree || subtree.empty?
+            def tree_to_str(tree, lev: 0)
+              raise "Required Hash tree structure. Given: #{tree.class}" unless tree.is_a?(Hash)
+              "".tap do |str|
+                tree.each do |entry, subtree|
+                  str << "#{"  " * lev}+-- #{entry.id || entry.external_id}\n"
+                  str << tree_to_str(subtree, lev: lev + 1) unless !subtree || subtree.empty?
+                end
               end
             end
-          end
 
-          def print_tree(tree, lev: 0)
-            puts tree_to_str(tree)
-          end
+            def print_tree(tree, lev: 0)
+              puts tree_to_str(tree)
+            end
 
-          # Generates a `Hash` tree structure, where:
-          #   * **keys** are nodes
-          #   * **values** are `Hash` subtree structures of `key` subordinates
-          # @note it is resilient to cyclic supervisors (it will just add the last at the top)
-          # @param values [Enumerable<Object>] of objects with methods:
-          #  `id`, `external_id` and `supervisor_id`
-          # @return [Hash] the tree structure
-          def supervisors_tree(values)
-            raise "Expected non hash Enumerable. Given: #{values.class}" if values.is_a?(Hash)
-            return {} unless values && values.is_a?(Enumerable)
-            idx = get_super_indexes(values)
-
-            processed = []
-            subtree = Proc.new do |entry, level, toptree|
-              if processed.include?(entry)
-                next {} unless toptree.key?(entry) && level > 0
-                # needs to be moved as a child
-                subnodes = toptree.delete(entry)
-                processed.delete(entry)
-              end
+            # Generates a `Hash` tree structure, where:
+            #   * **keys** are nodes
+            #   * **values** are `Hash` subtree structures of `key` subordinates
+            # @note it is resilient to cyclic supervisors (it will just add the last at the top)
+            # @param values [Enumerable<Object>] of objects with methods:
+            #  `id`, `external_id` and `supervisor_id`
+            # @return [Hash] the tree structure
+            def supervisors_tree(values)
+              raise "Expected non hash Enumerable. Given: #{values.class}" if values.is_a?(Hash)
+              return {} unless values && values.is_a?(Enumerable)
+              idx = get_super_indexes(values)
+
+              processed = []
+              subtree = Proc.new do |entry, level, toptree|
+                if processed.include?(entry)
+                  next {} unless toptree.key?(entry) && level > 0
+                  # needs to be moved as a child
+                  subnodes = toptree.delete(entry)
+                  processed.delete(entry)
+                end
 
-              subnodes ||= {}.tap do |tree|
-                subs = idx[:subordinates].call(entry)
-                processed.push(entry)
-                next nil unless subs && !subs.empty?
-                subs.each do |sub|
-                  sub_tree = subtree.call(sub, level + 1, toptree)
-                  tree.merge!(sub_tree)
+                subnodes ||= {}.tap do |tree|
+                  subs = idx[:subordinates].call(entry)
+                  processed.push(entry)
+                  next nil unless subs && !subs.empty?
+                  subs.each do |sub|
+                    sub_tree = subtree.call(sub, level + 1, toptree)
+                    tree.merge!(sub_tree)
+                  end
                 end
-              end
 
-              {entry => subnodes}
-            end
+                {entry => subnodes}
+              end
 
-            {}.tap do |tree|
-              idx[:by_sup].keys.each do |sup_id|
-                if sup = idx[:supers][sup_id]
-                  tree.merge!(subtree.call(sup, 0, tree))
-                else
-                  idx[:by_sup][sup_id].each do |sub|
-                    tree.merge!(subtree.call(sub, 0, tree))
+              {}.tap do |tree|
+                idx[:by_sup].keys.each do |sup_id|
+                  if sup = idx[:supers][sup_id]
+                    tree.merge!(subtree.call(sup, 0, tree))
+                  else
+                    idx[:by_sup][sup_id].each do |sub|
+                      tree.merge!(subtree.call(sub, 0, tree))
+                    end
                   end
                 end
               end
             end
-          end
 
-          private
-
-          def get_super_indexes(values)
-            raise "Expected non hash Enumerable. Given: #{values.class}" if values.is_a?(Hash)
-            {}.tap do |indexes|
-              indexes[:by_id]  = values.map do |e|
-                e.id && [e.id, e]
-              end.compact.to_h
-              indexes[:by_ext] = values.map do |e|
-                e.external_id && [e.external_id, e]
-              end.compact.to_h
-
-              indexes[:by_sup] = {}.tap do |by_s|
-                values.group_by do |e|
-                  e.supervisor_id
-                end.tap do |by_sup|
-                  by_s[nil] = by_sup.delete(nil) if by_sup.key?(nil)
-                  by_s.merge!(by_sup)
+            private
+
+            def get_super_indexes(values)
+              raise "Expected non hash Enumerable. Given: #{values.class}" if values.is_a?(Hash)
+              {}.tap do |indexes|
+                indexes[:by_id]  = values.map do |e|
+                  e.id && [e.id, e]
+                end.compact.to_h
+                indexes[:by_ext] = values.map do |e|
+                  e.external_id && [e.external_id, e]
+                end.compact.to_h
+
+                indexes[:by_sup] = {}.tap do |by_s|
+                  values.group_by do |e|
+                    e.supervisor_id
+                  end.tap do |by_sup|
+                    by_s[nil] = by_sup.delete(nil) if by_sup.key?(nil)
+                    by_s.merge!(by_sup)
+                  end
                 end
-              end
 
-              indexes[:supers] = {}.tap do |sups|
-                indexes[:by_ext].select do |ext, e|
-                  ext && indexes[:by_sup].key?(ext)
-                end.tap {|found| sups.merge!(found)}
-                indexes[:by_id].select do |id, e|
-                  id && indexes[:by_sup].key?(id)
-                end.tap {|found| sups.merge!(found)}
-              end
+                indexes[:supers] = {}.tap do |sups|
+                  indexes[:by_ext].select do |ext, e|
+                    ext && indexes[:by_sup].key?(ext)
+                  end.tap {|found| sups.merge!(found)}
+                  indexes[:by_id].select do |id, e|
+                    id && indexes[:by_sup].key?(id)
+                  end.tap {|found| sups.merge!(found)}
+                end
 
-              indexes[:is_super]     = Proc.new do |entry|
-                !!(indexes[:supers][entry.id] || indexes[:supers][entry.external_id])
-              end
+                indexes[:is_super]     = Proc.new do |entry|
+                  !!(indexes[:supers][entry.id] || indexes[:supers][entry.external_id])
+                end
 
-              indexes[:subordinates] = Proc.new do |entry|
-                subs = nil
-                if sup = indexes[:supers][entry.id] || indexes[:supers][entry.external_id]
-                  subs ||= indexes[:by_sup][sup.id]          unless !sup.id
-                  subs ||= indexes[:by_sup][sup.external_id] unless !sup.external_id
+                indexes[:subordinates] = Proc.new do |entry|
+                  subs = nil
+                  if sup = indexes[:supers][entry.id] || indexes[:supers][entry.external_id]
+                    subs ||= indexes[:by_sup][sup.id]          unless !sup.id
+                    subs ||= indexes[:by_sup][sup.external_id] unless !sup.external_id
+                  end
+                  subs
                 end
-                subs
               end
+
             end
 
           end
 
+          class << self
+            include SupervisorHelpers::ClassMethods
+          end
+
         end
       end
     end

data/lib/eco/api/organization/people.rb

@@ -65,8 +65,8 @@ module Eco
               pers = candidates.first
             end
 
+            pers = @by_external_id[email&.downcase.strip]&.first    if !pers && !email.to_s.strip.empty?
           end
-          pers = @by_external_id[email&.downcase.strip]&.first    if !pers && !email.to_s.strip.empty?
 
           pers
         end

data/lib/eco/api/organization/policy_groups.rb

@@ -19,7 +19,7 @@ module Eco
         def names
           @by_name.keys
         end
-        
+
         def to_id(name)
           case name
           when Enumerable
@@ -32,7 +32,15 @@ module Eco
         end
 
         def to_name(id)
-          policy_group(id)&.name
+          case id
+          when Enumerable
+            id.map do |n|
+              policy_group(n)&.name
+            end.compact
+          else
+            policy_group(id)&.name
+          end
+
         end
 
         def policy_group(id_name)

data/lib/eco/api/organization/tag_tree.rb

@@ -62,7 +62,7 @@ module Eco
         # @param key [String] tag to verify.
         # @return [Boolean]
         def tag?(key)
-          @hash_tags.key?(key.upcase)
+          @hash_tags.key?(key&.upcase)
         end
 
         # Finds a subtree node.

data/lib/eco/api/usecases/default_cases/create_case.rb

@@ -51,7 +51,7 @@ module Eco
                     unless options.dig(:exclude, :policy_groups) && !create
                       end_pg_ids = person.account.policy_group_ids || []
 
-                      unless entry.policy_group_ids? && !add_account && !def_id
+                      if add_account && def_id && !entry.policy_group_ids?
                         # on account creation, if missing policy_group_ids column in the input
                         # use default_usergroup, if it's defined
                         end_pg_ids = [def_id]

data/lib/eco/api/usecases/default_cases/hris_case.rb

@@ -65,7 +65,7 @@ module Eco
                   unless options.dig(:exclude, :policy_groups) && !create
                     end_pg_ids = person.account.policy_group_ids || []
 
-                    unless entry.policy_group_ids? && !add_account && !def_id
+                    if add_account && def_id && !entry.policy_group_ids?
                       # on account creation, if missing policy_group_ids column in the input
                       # use default_usergroup, if it's defined
                       end_pg_ids = [def_id]

data/lib/eco/api/usecases/default_cases/update_case.rb

@@ -46,11 +46,19 @@ module Eco
 
                     person.account.send_invites = options[:send_invites] if options.key?(:send_invites)
 
-                    unless options.dig(:exclude, :policy_groups)
+                    unless options.dig(:exclude, :policy_groups) && !create
+                      end_pg_ids = person.account.policy_group_ids || []
+
+                      if add_account && def_id && !entry.policy_group_ids?
+                        # on account creation, if missing policy_group_ids column in the input
+                        # use default_usergroup, if it's defined
+                        end_pg_ids = [def_id]
+                      end
+
                       # avoid false updates by preserving the original order
                       person.account.policy_group_ids   = pgs.user_pg_ids(
                         initial:         ini_pg_ids,
-                        final:           person.account.policy_group_ids
+                        final:           end_pg_ids
                       )
                     end
 

data/lib/eco/api/usecases/default_cases/upsert_case.rb

@@ -58,7 +58,7 @@ module Eco
                   unless options.dig(:exclude, :policy_groups) && !create
                     end_pg_ids = person.account.policy_group_ids || []
 
-                    unless entry.policy_group_ids? && !add_account && !def_id
+                    if add_account && def_id && !entry.policy_group_ids?
                       # on account creation, if missing policy_group_ids column in the input
                       # use default_usergroup, if it's defined
                       end_pg_ids = [def_id]

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = "1.3.9"
+  VERSION = "1.3.14"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 1.3.9
+  version: 1.3.14
 platform: ruby
 authors:
 - Oscar Segura
@@ -107,7 +107,7 @@ dependencies:
         version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.5
+        version: 0.5.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -117,7 +117,7 @@ dependencies:
         version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.5
+        version: 0.5.6
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
   requirement: !ruby/object:Gem::Requirement