eco-helpers 1.3.8 → 1.3.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4eb9a6d4fc09ab97362ab384856a32562c1f61321277e2537f1cc6859a5a4d54
-  data.tar.gz: 550fd9ce9a7510dca05bbcd80c153d7c114a25798e5d5af89059351db13f4b7d
+  metadata.gz: 5b59fa190429f792010af645ab28370ef0132ad17fafca035a363722736ab01e
+  data.tar.gz: c35a11ee4935356f1a93a008b63b520bd0809ef3a3d12d2b71e5329eb9f721f8
 SHA512:
-  metadata.gz: ef1c26368f22e5b06ead30ab4aeb042d337fbfb5cd2b68369aa1407350993e38109e7cfde86295e046fcbcc5295a87a97da3cefd91873460cd7a3e535471afb1
-  data.tar.gz: 84f36840162ec228b41a923476aae26917ab1254c4c4e86e848b9b276ea84f0e1a33a69f9c0e8c15497262cebfd99151b91a6dd7a2b7779105096ee97593285d
+  metadata.gz: e9d7f407038348bfb98bc8c1cf127d73108f3e90b92d3cd267f8c1868a1fad5810226506e4112f7c87d9deb6775af2d7ad94bb27dfd4c6c2ea2885b28f7b6c76
+  data.tar.gz: 90c6d245f2eb3fbfa1729765cf7629792eadbd33b84c58333aaac6a7e6a81d395fa150c4ff9c240c24403976c25d471d510441b849159aeaf67a593c19258db1

data/.yardopts

@@ -6,5 +6,4 @@
 --output-dir ./doc
 'lib/**/*.rb'
 -
-CHANGELOG.md
 LICENSE

data/CHANGELOG.md

@@ -1,7 +1,52 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
-## [1.3.8] - 2020-05-DD (Unreleased)
+## [1.3.13] - 2020-05-29
+
+### Added
+### Changed
+### Fixed
+  - `Eco::API::Organization::TagTree#tag?` to accept `nil` by returning `false`
+  - `Eco::API::Common::People::DefaultParsers::DateParser` will parse to `Date` class
+    * it was parsing to `Time` class, while the native gem `ecoportal-api` parses as `Date` ([reference](https://gitlab.com/ecoPortal/ecoportal-api/-/blob/master/lib/ecoportal/api/v1/schema_field.rb))
+## [1.3.11] - 2020-05-19
+
+### Added
+### Changed
+  - stop using `email` as `external_id` on `People#person` & `People#find`
+    * this should result in more accurate searches when using `:strict` options
+### Fixed
+
+
+## [1.3.11] - 2020-05-12
+
+### Added
+### Changed
+  - remove popping up comments on `Eco::API::Organization::PolicyGroups#`
+### Fixed
+
+
+## [1.3.10] - 2020-05-12
+
+### Added
+  - `Eco::API::Organization::PolicyGroups#to_name` added support for `Array` input
+  - `config.people.default_usergroup`, when defined, will have effect on usecases: `update` (this case was missing the change)
+    * on account creation, if the input file did not specify `policy_group_ids`
+
+### Changed
+### Fixed
+  - `upsert`, `hris` and `create` usecases: fixed condition for use of default_usergroup
+
+## [1.3.9] - 2020-05-12
+
+### Added
+### Changed
+### Fixed
+
+- `usecase` callback was not receiving `usecase` paramater
+  * as a consequence `Batch::Job` created were missing the `usecase`
+
+## [1.3.8] - 2020-05-07
 
 ### Added
 

data/lib/eco/api/common/people/default_parsers/date_parser.rb

@@ -19,7 +19,7 @@ module Eco
 
             def parse_date(value)
               begin
-                (value.to_s.empty?) ? nil : Time.parse(value)
+                (value.to_s.empty?) ? nil : Date.parse(value)
               rescue
                 nil
               end

data/lib/eco/api/organization/people.rb

@@ -65,8 +65,8 @@ module Eco
               pers = candidates.first
             end
 
+            pers = @by_external_id[email&.downcase.strip]&.first    if !pers && !email.to_s.strip.empty?
           end
-          pers = @by_external_id[email&.downcase.strip]&.first    if !pers && !email.to_s.strip.empty?
 
           pers
         end

data/lib/eco/api/organization/policy_groups.rb

@@ -19,7 +19,7 @@ module Eco
         def names
           @by_name.keys
         end
-        
+
         def to_id(name)
           case name
           when Enumerable
@@ -32,7 +32,15 @@ module Eco
         end
 
         def to_name(id)
-          policy_group(id)&.name
+          case id
+          when Enumerable
+            id.map do |n|
+              policy_group(n)&.name
+            end.compact
+          else
+            policy_group(id)&.name
+          end
+
         end
 
         def policy_group(id_name)

data/lib/eco/api/organization/tag_tree.rb

@@ -62,7 +62,7 @@ module Eco
         # @param key [String] tag to verify.
         # @return [Boolean]
         def tag?(key)
-          @hash_tags.key?(key.upcase)
+          @hash_tags.key?(key&.upcase)
         end
 
         # Finds a subtree node.

data/lib/eco/api/usecases/default_cases/create_case.rb

@@ -51,7 +51,7 @@ module Eco
                     unless options.dig(:exclude, :policy_groups) && !create
                       end_pg_ids = person.account.policy_group_ids || []
 
-                      unless entry.policy_group_ids? && !add_account && !def_id
+                      if add_account && def_id && !entry.policy_group_ids?
                         # on account creation, if missing policy_group_ids column in the input
                         # use default_usergroup, if it's defined
                         end_pg_ids = [def_id]

data/lib/eco/api/usecases/default_cases/hris_case.rb

@@ -65,7 +65,7 @@ module Eco
                   unless options.dig(:exclude, :policy_groups) && !create
                     end_pg_ids = person.account.policy_group_ids || []
 
-                    unless entry.policy_group_ids? && !add_account && !def_id
+                    if add_account && def_id && !entry.policy_group_ids?
                       # on account creation, if missing policy_group_ids column in the input
                       # use default_usergroup, if it's defined
                       end_pg_ids = [def_id]

data/lib/eco/api/usecases/default_cases/update_case.rb

@@ -46,11 +46,19 @@ module Eco
 
                     person.account.send_invites = options[:send_invites] if options.key?(:send_invites)
 
-                    unless options.dig(:exclude, :policy_groups)
+                    unless options.dig(:exclude, :policy_groups) && !create
+                      end_pg_ids = person.account.policy_group_ids || []
+
+                      if add_account && def_id && !entry.policy_group_ids?
+                        # on account creation, if missing policy_group_ids column in the input
+                        # use default_usergroup, if it's defined
+                        end_pg_ids = [def_id]
+                      end
+
                       # avoid false updates by preserving the original order
                       person.account.policy_group_ids   = pgs.user_pg_ids(
                         initial:         ini_pg_ids,
-                        final:           person.account.policy_group_ids
+                        final:           end_pg_ids
                       )
                     end
 

data/lib/eco/api/usecases/default_cases/upsert_case.rb

@@ -58,7 +58,7 @@ module Eco
                   unless options.dig(:exclude, :policy_groups) && !create
                     end_pg_ids = person.account.policy_group_ids || []
 
-                    unless entry.policy_group_ids? && !add_account && !def_id
+                    if add_account && def_id && !entry.policy_group_ids?
                       # on account creation, if missing policy_group_ids column in the input
                       # use default_usergroup, if it's defined
                       end_pg_ids = [def_id]

data/lib/eco/api/usecases/use_case_io.rb

@@ -54,7 +54,8 @@ module Eco
               res.merge!(usecase: usecase)
               res.merge!(job: @job) if @job
             else
-              res.push(usecase).push(@job) if @job
+              res.push(usecase)
+              res.push(@job) if @job
             end
           end
         end

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = "1.3.8"
+  VERSION = "1.3.13"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 1.3.8
+  version: 1.3.13
 platform: ruby
 authors:
 - Oscar Segura