eco-helpers 1.3.15 → 1.3.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1527493b64563ca009c0338bc5e3b5311371a4c59947526ad60fa453d577abfd
-  data.tar.gz: cabc02e6a45958ff8cfa46fc7ff76e451074d492f42a3091f28e6633c131b64b
+  metadata.gz: a43bda1c38e889ae1d7035b4cb6864ff4db692c26d709bcb99d58373404b179f
+  data.tar.gz: cb2d7d559e115b214adbfa0951e7d7487c0197e63bff2d9243a4d9308f62b8a4
 SHA512:
-  metadata.gz: 6c8eaa3f1a56daaee787c26dd5c2681aea73e689fa55636c946a46441e8b894adb63922584d69f292176ffe35f05da3878dd0a410e0fd3bbf0d906937bca774b
-  data.tar.gz: 345b6faa4aa18aaf0db1930eddcf45bf228a1ed2f6246efe7f839c86f8af396d81513209fa2a6e04e36734da28842b6b193d2269d7aee5be1b2c7be23e120eaf
+  metadata.gz: d6d489186d306df34befcbe4fe898bac6482c773f79e71824ac331f1869f3e75356acc6a9b1d40b2aeca994244d22c78d19483bc6342feee78dbae5c85e14417
+  data.tar.gz: 9558cc316de54b61a119da8ce27a235032ea6dd4c200b4deb2d646a45dd4b76c4a2724c9ba93ff1620e610d778e300a192c3969ff3a94af0706bcaf8cfd0d870

data/CHANGELOG.md

@@ -1,6 +1,17 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [1.3.16] - 2020-06-xx
+
+### Added
+  - `Eco::API::Common::People::Entries`, `#entry` & `#find` should allow for `strict` search (added parameter)
+### Changed
+  - upgraded `ecoportal-api` gem dependency to minimum version `0.5.7`
+    - this includes the removal of some patches
+  - some gems update
+### Fixed
+  - patched preferences (`kiosk` preferences should default to `nil`)
+
 ## [1.3.15] - 2020-06-11
 
 ### Added

data/eco-helpers.gemspec

@@ -22,16 +22,16 @@ Gem::Specification.new do |s|
   #s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_development_dependency "bundler",   "~> 2.0.1"
-  s.add_development_dependency "rspec",     "~> 3",   ">= 3.8"
+  s.add_development_dependency "bundler",   "~> 2.1", ">= 2.1.3"
+  s.add_development_dependency "rspec",     "~> 3",   ">= 3.9"
   s.add_development_dependency "rake",      "~> 12.3.0"
   s.add_development_dependency "yard",      "~> 0.9", ">= 0.9.18"
   s.add_development_dependency "redcarpet", "~> 3.5", ">= 3.5.0"
 
-  s.add_dependency 'ecoportal-api', '~> 0.5',  '>= 0.5.6'
-  s.add_dependency 'aws-sdk-s3',    '~> 1.30', '>= 1.30.1'
-  s.add_dependency 'aws-sdk-ses',   '~> 1.14', '>= 1.14.0'
-  s.add_dependency 'dotenv',        '~> 2.6',  '>= 2.6.0'
+  s.add_dependency 'ecoportal-api', '~> 0.5',  '>= 0.5.8'
+  s.add_dependency 'aws-sdk-s3',    '~> 1',    '>= 1.64.0'
+  s.add_dependency 'aws-sdk-ses',   '~> 1',    '>= 1.29.0'
+  s.add_dependency 'dotenv',        '~> 2.7',  '>= 2.7.0'
   s.add_dependency 'net-sftp',      '~> 2.1',  '>= 2.1.2'
 
 end

data/lib/eco/api/common/people/entries.rb

@@ -50,23 +50,28 @@ module Eco
           end
 
           # Search function to find an `entry` based on one of different options
-          def entry(id: nil, external_id: nil, email: nil)
+          def entry(id: nil, external_id: nil, email: nil, strict: false)
             init_caches
             pers = nil
             pers = @by_id[id]&.first if id
             pers = @by_external_id[external_id&.strip]&.first    if !pers && !external_id.to_s.strip.empty?
-            pers = @by_email[email&.downcase.strip]&.first       if !pers && !email.to_s.strip.empty?
-            pers = @by_external_id[email&.downcase.strip]&.first if !pers && !email.to_s.strip.empty?
+
+            # strict prevents taking existing user for searched person with same email
+            # specially useful if the organisation ensures all have external id (no need for email search)
+            if !pers && (!strict || external_id.to_s.strip.empty?)
+              pers = @by_email[email&.downcase.strip]&.first       if !pers && !email.to_s.strip.empty?
+              pers = @by_external_id[email&.downcase.strip]&.first if !pers && !email.to_s.strip.empty?
+            end
             pers
           end
 
           # Search function to find an `entry` based on one of different options
           # see Eco::API::Common::People::Entries#entry
-          def find(object)
+          def find(object, strict: false)
             id          = object.respond_to?("id")?          object.send("id") : nil
             external_id = object.respond_to?("external_id")? object.send("external_id") : nil
             email       = object.respond_to?("email")?       object.send("email") : nil
-            entry(id: id, external_id: external_id, email: email)
+            entry(id: id, external_id: external_id, email: email, strict: strict)
           end
 
           def exclude(object)

data/lib/eco/api/common/version_patches/ecoportal_api.rb

@@ -1,6 +1,4 @@
-require 'ecoportal/api'
 require_relative 'ecoportal_api/base_model'
-require_relative 'ecoportal_api/external_people'
 require_relative 'ecoportal_api/external_person'
 require_relative 'ecoportal_api/internal_person'
 require_relative 'ecoportal_api/account_preferences'

data/lib/eco/api/common/version_patches/ecoportal_api/account_preferences.rb

@@ -1,47 +1,28 @@
 module Ecoportal
   module API
     class Internal
-      class Preferences
+      class Preferences < Common::BaseModel
+        passthrough  :kiosk_enabled, :kiosk_workflow_message, :kiosk_create_button_label,
+            :kiosk_create_button_help, :kiosk_return_button_label, :kiosk_return_button_help,
+            :kiosk_dashboard_button_label, :kiosk_dashboard_button_help
+
         [
           :show_sidebar,
           :show_shortcuts,
           :show_coming_soon,
           :show_recently_visited_forms,
           :show_tasks,
-        ].each do |field|
-          key = field.to_s
+          :show_task_bubbles
+        ].map(&:to_s).each do |field|
           define_method(field) do
-            if doc.key?(key)
-              doc[key]
+            if doc.key?(field)
+              doc[field]
             else
               true
             end
           end
           define_method("#{field}=") do |value|
-            doc[key] = !!value
-          end
-        end
-
-        [
-          :kiosk_enabled,
-          :kiosk_workflow_message,
-          :kiosk_create_button_label,
-          :kiosk_create_button_help,
-          :kiosk_return_button_label,
-          :kiosk_return_button_help,
-          :kiosk_dashboard_button_label,
-          :kiosk_dashboard_button_help
-        ].each do |field|
-          key = field.to_s
-          define_method(field) do
-            if doc.key?(key)
-              doc[key]
-            else
-              nil
-            end
-          end
-          define_method("#{field}=") do |value|
-            doc[key] = !!value
+            doc[field] = !!value
           end
         end
 

data/lib/eco/api/usecases/default_cases/create_case.rb

@@ -69,7 +69,7 @@ module Eco
                     if session.tagtree
                       person.account.default_tag = session.tagtree.default_tag(*person.filter_tags)
                     else
-                      tags = person.filter_tags
+                      tags = person.filter_tags || []
                       person.account.default_tag = tags.first unless tags.length > 1
                     end
                   end

data/lib/eco/api/usecases/default_cases/hris_case.rb

@@ -11,8 +11,11 @@ module Eco
               supers   = session.job_group("post").new("supers", usecase: usecase, type: :update, sets: :core)
               leavers  = session.job_group("post").new("leavers", usecase: usecase, type: :update, sets: :account)
 
+              strict_search = session.config.people.strict_search? && (!options[:search]&.key?(:strict) || options.dig(:search, :strict))
+              pgs           = session.policy_groups
+
               people.users.each_with_index  do |person, i|
-                if !entries.find(person)
+                if !entries.find(person, strict: strict_search)
                   leavers.add(person) do |person|
                     person.supervisor_id = nil
                     person.account       = nil
@@ -20,8 +23,6 @@ module Eco
                 end
               end
 
-              strict_search = session.config.people.strict_search? && (!options[:search]&.key?(:strict) || options.dig(:search, :strict))
-              pgs           = session.policy_groups
 
               if session.config.people.default_usergroup?
                 def_id  = pgs.to_id(session.config.people.default_usergroup)
@@ -84,7 +85,7 @@ module Eco
                     if session.tagtree
                       person.account.default_tag = session.tagtree.default_tag(*person.filter_tags)
                     else
-                      tags = person.filter_tags
+                      tags = person.filter_tags || []
                       person.account.default_tag = tags.first unless tags.length > 1
                     end
                   end

data/lib/eco/api/usecases/default_cases/set_default_tag_case.rb

@@ -30,8 +30,12 @@ module Eco
               update   = session.job_group("main").new("update", usecase: usecase, type: :update, sets: :account)
 
               people.each_with_index  do |person, i|
-                #next unless person.id == "5c527ba63f7690001243f5b2"
-                person.account.default_tag = session.tagtree.default_tag(*person.filter_tags)
+                if session.tagtree
+                  person.account.default_tag = session.tagtree.default_tag(*person.filter_tags)
+                else
+                  tags = person.filter_tags || []
+                  person.account.default_tag = tags.first unless tags.length > 1
+                end
                 update.add(person)
               end
 

data/lib/eco/api/usecases/default_cases/to_csv_case.rb

@@ -42,7 +42,7 @@ module Eco
                   csv << session.new_entry(person, dependencies: deps).to_hash.values
                 end
               end
-              true
+              exit(0)
             end
           end
 

data/lib/eco/api/usecases/default_cases/to_csv_detailed_case.rb

@@ -57,7 +57,7 @@ module Eco
                   csv << data
                 end
               end
-              true
+              exit(0)
             end
           end
 

data/lib/eco/api/usecases/default_cases/update_case.rb

@@ -68,7 +68,7 @@ module Eco
                       if session.tagtree
                         person.account.default_tag = session.tagtree.default_tag(*person.filter_tags)
                       else
-                        tags = person.filter_tags
+                        tags = person.filter_tags || []
                         person.account.default_tag = tags.first unless tags.length > 1
                       end
                     end

data/lib/eco/api/usecases/default_cases/upsert_case.rb

@@ -77,7 +77,7 @@ module Eco
                     if session.tagtree
                       person.account.default_tag = session.tagtree.default_tag(*person.filter_tags)
                     else
-                      tags = person.filter_tags
+                      tags = person.filter_tags || []
                       person.account.default_tag = tags.first unless tags.length > 1
                     end
                   end

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = "1.3.15"
+  VERSION = "1.3.16"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 1.3.15
+  version: 1.3.16
 platform: ruby
 authors:
 - Oscar Segura
@@ -16,14 +16,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: '2.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: '2.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.1.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -33,7 +39,7 @@ dependencies:
         version: '3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,7 +49,7 @@ dependencies:
         version: '3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -107,7 +113,7 @@ dependencies:
         version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.6
+        version: 0.5.8
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -117,67 +123,67 @@ dependencies:
         version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.6
+        version: 0.5.8
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.30'
+        version: '1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.30.1
+        version: 1.64.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.30'
+        version: '1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.30.1
+        version: 1.64.0
 - !ruby/object:Gem::Dependency
   name: aws-sdk-ses
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.14.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.29.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.14.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.29.0
 - !ruby/object:Gem::Dependency
   name: dotenv
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.7.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '2.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.7.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '2.7'
 - !ruby/object:Gem::Dependency
   name: net-sftp
   requirement: !ruby/object:Gem::Requirement
@@ -249,7 +255,6 @@ files:
 - lib/eco/api/common/version_patches/ecoportal_api.rb
 - lib/eco/api/common/version_patches/ecoportal_api/account_preferences.rb
 - lib/eco/api/common/version_patches/ecoportal_api/base_model.rb
-- lib/eco/api/common/version_patches/ecoportal_api/external_people.rb
 - lib/eco/api/common/version_patches/ecoportal_api/external_person.rb
 - lib/eco/api/common/version_patches/ecoportal_api/internal_person.rb
 - lib/eco/api/common/version_patches/exception.rb

data/lib/eco/api/common/version_patches/ecoportal_api/external_people.rb

@@ -1,38 +0,0 @@
-module Ecoportal
-  module API
-    class V1
-      class People
-
-        def job
-          operation = Common::BatchOperation.new("/people", person_class, logger: client.logger)
-          yield operation
-          # The batch operation is responsible for logging the output
-          job_id = create_job(operation)
-          status = wait_for_job_completion(job_id)
-
-          if status&.complete?
-            operation.process_response job_result(job_id, operation)
-          else
-            raise "Job `#{job_id}` not complete. Probably timeout after #{JOB_TIMEOUT + 120} seconds. Current status: #{status}"
-          end
-        end
-
-        private
-
-        def wait_for_job_completion(job_id)
-          # timeout library is evil. So we make poor-man timeout.
-          # https://jvns.ca/blog/2015/11/27/why-rubys-timeout-is-dangerous-and-thread-dot-raise-is-terrifying/
-          before = Time.now
-          while true
-            status = job_status(job_id)
-            break status if status.complete?
-            break status if Time.now >= before + (JOB_TIMEOUT + 120)
-            sleep(DELAY_STATUS_CHECK)
-            status
-          end
-        end
-
-      end
-    end
-  end
-end